Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Reviews
Search
Janos Gyerik
October 14, 2015
Programming
0
130
Code Reviews
Just Do It!
Janos Gyerik
October 14, 2015
Tweet
Share
More Decks by Janos Gyerik
See All by Janos Gyerik
Capture The Flag at SonarSource 2019
janosgyerik
1
29
Keyboard shortcuts
janosgyerik
0
120
Analyze your changeset in a branch before git push using SonarLint + Git hooks; Round #2
janosgyerik
0
590
Analyze your changeset in a branch before git push using SonarLint + Git hooks
janosgyerik
0
300
Unwatch GitHub repos
janosgyerik
0
280
Playing with Yahoo! Pipes
janosgyerik
0
220
Cool features of GitHub
janosgyerik
0
1.2k
Time-saving tricks on the command line
janosgyerik
1
3.9k
Other Decks in Programming
See All in Programming
Elm 0.19.0 Changes
bkuhlmann
0
510
Domain-Driven Transformation
hschwentner
2
1.5k
#phpcon_odawara オープン・クローズドなテストフィクスチャを求めて / open closed test fixtures
77web
3
240
見た目から始める生産性向上
ikumatadokoro
10
1.4k
業務ツールとして使うPostman
msys75
0
100
AWS CDKコントリビュートTIPS / aws-cdk-contribution-tips
gotok365
4
390
Three ways to use AI on Android: The Good, the Bad and the Ugly
marxallski
0
110
雑に思考を整理する技術と効能
konifar
63
30k
Ruby GitHub Packages
bkuhlmann
0
640
Compose-View Interop in Practice (mDevCamp 2024)
stewemetal
0
170
効率化に挑戦してみたらモバイル開発が少し快適になった話
ryunakayama
0
140
CREってこういうこと? 体験入社 - 提案資料 - / what-is-cre-trial-employment
shinden
1
520
Featured
See All Featured
Learning to Love Humans: Emotional Interface Design
aarron
267
39k
Building a Modern Day E-commerce SEO Strategy
aleyda
21
6.4k
Let's Do A Bunch of Simple Stuff to Make Websites Faster
chriscoyier
501
140k
Building an army of robots
kneath
300
41k
Practical Orchestrator
shlominoach
183
9.7k
Gamification - CAS2011
davidbonilla
77
4.6k
KATA
mclloyd
16
12k
Become a Pro
speakerdeck
PRO
13
4.6k
BBQ
matthewcrist
80
8.8k
Docker and Python
trallard
35
2.7k
A Tale of Four Properties
chriscoyier
152
22k
ParisWeb 2013: Learning to Love: Crash Course in Emotional UX Design
dotmariusz
104
6.6k
Transcript
code.reviews Janos Gyerik correct clean efficient tested efficient efficient clean
clean tested tested correct correct correct tested correc orrect correc tested efficient clean
2 what is it?
3 commit commit commit review commit commit review commit accept
commit commit commit NOT code reviewed code reviewed
4 why do it?
5 UCXGVKOG catch early catch early catch early bugs bad
patterns ugliness
6
7 peer review peer pressure
8 anything that gets reviewed gets better
9 quality time savings cost savings FACT
10 correct readable efficient tested buggy messy crappy untested NOT
code reviewed code reviewed
11 information sharing NO MORE bottleneck developers
12
13 why/when NOT do it?
14 big bang development too hard to control should be
the exception, not the norm! code reviews are not practical when…
15 without supporting tools tools help doing code reviews efficiently
don’t waste your time, get them and use them! code reviews are not practical…
16 what’s required? disciplined commits
17 incremental changes small and stable logical steps at all
levels
18 one feature one purpose one branch feature
19 short-lived max 3 days feature
20 (example good branch)
21 (example bad branch)
22 one commit one logical change
23 one good commit == stable build; related changes; no
garbage; small; good comment
24
25 (example good commit)
26 example bad commit with many changes)
27 (example bad commit with garbage)
28 how to do it?
29 git fetch origin master git checkout -b feature-x origin/ma
# work work work git commit git commit git push origin feature-x # create merge request
30 Create Merge Request create; don’t assign! self-review: any WTFs?
ready? assign!
31 peer review peer pressure
32 what to review?
33 readable is it clear? easy to read? easy to
understand? FACT Code is read far more often than written!
34 correct is the logic sane? does it work? bug
suspects? -> ask!
35 efficient any performance concerns? -> ask!
36 tested unit tests included? unit test opportunities?
37 good practices Code Complete Effective Java Sonar/Findbugs/… codereview.stackexchange.com
38 how bad can it be?
39 how in-depth? •not too much •not too little •just
right •DO IT FAST
40 attitude?
41 a code review is… NOT about the developer it
is about the code
42 don’t just say something is “wrong” suggest a better
way
43 the focus is.. NOT on problems it is on
solutions
44 perfect code? don’t seek perfect seek good enough better
is good enough don’t be a pain in the ass be flexible be constructive
45
46 mistakes… it’s OK to make mistakes it’s NOT OK
to not learn from them
47