Slide 1

Slide 1 text

Taming Chaotic Specs RSpec Design Patterns

Slide 2

Slide 2 text

http://rspec.info/

Slide 3

Slide 3 text

Problem

Slide 4

Slide 4 text

Not what to test, But…

Slide 5

Slide 5 text

Patterns to follow when structuring the test(s)

Slide 6

Slide 6 text

1. Communicate expectations 2. Encourage consistency 3. Reduce the mental load Design Patterns…

Slide 7

Slide 7 text

Minimum Valid Object

Slide 8

Slide 8 text

class User < ActiveRecord::Base has_secure_password validates :firstname, presence: true, length: 4..20 validates :middlename, length: 4..20, allow_blank: true validates :lastname, presence: true, length: 4..20 validates :email, format: { with: /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i } validates :password, presence: true, confirmation: true, length: { minimum: 8 } # ... end

Slide 9

Slide 9 text

# spec/models/user_spec.rb describe User do it "should be invalid" do user = User.new(firstname: "really really ... super long firstname") expect(user.valid?).to_not eq true user = User.new(firstname: "sht") expect(user.valid?).to_not eq true end end

Slide 10

Slide 10 text

# spec/models/user_spec.rb describe User do it "should be invalid" do user = User.new(firstname: "really really ... super long firstname") expect(user.valid?).to_not eq true user = User.new(firstname: "sht") expect(user.valid?).to_not eq true end end

Slide 11

Slide 11 text

# spec/models/user_spec.rb describe User do it "should be invalid" do user = User.new(firstname: "really really ... super long firstname") expect(user.valid?).to_not eq true user = User.new(firstname: "sht") expect(user.valid?).to_not eq true end end

Slide 12

Slide 12 text

# spec/models/user_spec.rb describe User do it "should be invalid" do user = User.new(firstname: "really really ... super long firstname") expect(user.valid?).to_not eq true user = User.new(firstname: "sht") expect(user.valid?).to_not eq true end end

Slide 13

Slide 13 text

class User < ActiveRecord::Base has_secure_password validates :firstname, presence: true, length: 4..20 validates :middlename, length: 4..20, allow_blank: true validates :lastname, presence: true, length: 4..20 validates :email, format: { with: /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i } validates :password, presence: true, confirmation: true, length: { minimum: 8 } # ... end

Slide 14

Slide 14 text

class User < ActiveRecord::Base has_secure_password validates :firstname, presence: true, length: 4..20 validates :middlename, length: 4..20, allow_blank: true validates :lastname, presence: true, length: 4..20 validates :email, format: { with: /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i } validates :password, presence: true, confirmation: true, length: { minimum: 8 } # ... end

Slide 15

Slide 15 text

class User < ActiveRecord::Base has_secure_password validates :firstname, presence: true, length: 4..20 validates :middlename, length: 4..20, allow_blank: true validates :lastname, presence: true, length: 4..20 validates :email, format: { with: /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i } validates :password, presence: true, confirmation: true, length: { minimum: 8 } # ... end Other validations failing!!

Slide 16

Slide 16 text

# spec/models/user_spec.rb describe User do it "should be invalid" do user = User.new(firstname: "really really ... super long firstname") expect(user.valid?).to_not eq true user = User.new(firstname: "sht") expect(user.valid?).to_not eq true end end

Slide 17

Slide 17 text

# spec/models/user_spec.rb describe User do it "should be invalid" do user = User.new(firstname: "really really ... super long firstname") expect(user.valid?).to_not eq true user = User.new(firstname: "sht") expect(user.valid?).to_not eq true end end

Slide 18

Slide 18 text

describe User do subject(:user) { described_class.new } # ... end

Slide 19

Slide 19 text

# spec/models/user_spec.rb describe User do it "should be invalid" do user = User.new(firstname: "really really ... super long firstname") expect(user.valid?).to_not eq true user = User.new(firstname: "sht") expect(user.valid?).to_not eq true end end

Slide 20

Slide 20 text

describe User do subject(:user) { described_class.new } context 'with a firstname that is over 20 chars' do # ... end context 'with a firstname that is under 4 chars' do # ... end end

Slide 21

Slide 21 text

describe User do subject(:user) { described_class.new firstname: firstname } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } # ... end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } # ... end end

Slide 22

Slide 22 text

# spec/models/user_spec.rb describe User do it "should be invalid" do user = User.new(firstname: "really really ... super long firstname") expect(user.valid?).to_not eq true user = User.new(firstname: "sht") expect(user.valid?).to_not eq true end end

Slide 23

Slide 23 text

# spec/models/user_spec.rb describe User do it "should be invalid" do user = User.new(firstname: "really really ... super long firstname") expect(user.valid?).to_not eq true user = User.new(firstname: "sht") expect(user.valid?).to_not eq true end end

Slide 24

Slide 24 text

expect(user.valid?).to_not eq true (true, not false?)

Slide 25

Slide 25 text

expect(user.valid?).to_not eq true (true, not false?)

Slide 26

Slide 26 text

expect(user.valid?).to_not be true (true, be false?)

Slide 27

Slide 27 text

expect(user.valid?).to_not be true (true, be false?)

Slide 28

Slide 28 text

(true?) expect(user).to be_invalid

Slide 29

Slide 29 text

(true?) expect(user).to be_invalid

Slide 30

Slide 30 text

describe User do subject(:user) { described_class.new firstname: firstname } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } # ... end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } # ... end end

Slide 31

Slide 31 text

describe User do subject(:user) { described_class.new firstname: firstname } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end Fix false positive ???

Slide 32

Slide 32 text

describe User do subject(:user) { described_class.new firstname: firstname } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end

Slide 33

Slide 33 text

describe User do subject(:user) { described_class.new firstname: firstname } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end

Slide 34

Slide 34 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } specify { expect(user).to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end

Slide 35

Slide 35 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } specify { expect(user).to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end

Slide 36

Slide 36 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } specify { expect(user).to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end ??

Slide 37

Slide 37 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } specify { expect(user).to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end

Slide 38

Slide 38 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } specify { expect(user).to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end ?? ??

Slide 39

Slide 39 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } specify { expect(user).to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end

Slide 40

Slide 40 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } specify { expect(user).to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end Fix false positive ???

Slide 41

Slide 41 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } specify { expect(user).to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end

Slide 42

Slide 42 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } specify { expect(user).to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } specify { expect(user).to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } specify { expect(user).to be_invalid } end end

Slide 43

Slide 43 text

describe User do subject(:user) { described_class.new firstname: firstname } let(:firstname) { 'Adam' } it { is_expected.to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } it { is_expected.to be_invalid } end context 'with a firstname that is under 4 chars' do let(:firstname) { 'srt' } it { is_expected.to be_invalid } end end

Slide 44

Slide 44 text

describe User do subject(:user) { described_class.new firstname: firstname, middlename: middlename, lastname: lastname, email: email, password: password } let(:firstname) { 'Adam' } let(:middlename) { nil } let(:lastname) { 'Cuppy' } let(:email) { '[email protected]' } let(:password) { 'Passw0rd!' } it { is_expected.to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } it { is_expected.to be_invalid } end # ... end

Slide 45

Slide 45 text

describe User do subject(:user) { described_class.new firstname: firstname, middlename: middlename, lastname: lastname, email: email, password: password } let(:firstname) { 'Adam' } let(:middlename) { nil } let(:lastname) { 'Cuppy' } let(:email) { '[email protected]' } let(:password) { 'Passw0rd!' } it { is_expected.to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } it { is_expected.to be_invalid } end # ... end #1: Build the subject

Slide 46

Slide 46 text

describe User do subject(:user) { described_class.new firstname: firstname, middlename: middlename, lastname: lastname, email: email, password: password } let(:firstname) { 'Adam' } let(:middlename) { nil } let(:lastname) { 'Cuppy' } let(:email) { '[email protected]' } let(:password) { 'Passw0rd!' } it { is_expected.to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } it { is_expected.to be_invalid } end # ... end #1: Build the subject #2: Set the config values

Slide 47

Slide 47 text

describe User do subject(:user) { described_class.new firstname: firstname, middlename: middlename, lastname: lastname, email: email, password: password } let(:firstname) { 'Adam' } let(:middlename) { nil } let(:lastname) { 'Cuppy' } let(:email) { '[email protected]' } let(:password) { 'Passw0rd!' } it { is_expected.to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } it { is_expected.to be_invalid } end # ... end #3 Assert a Valid state

Slide 48

Slide 48 text

describe User do subject(:user) { described_class.new firstname: firstname, middlename: middlename, lastname: lastname, email: email, password: password } let(:firstname) { 'Adam' } let(:middlename) { nil } let(:lastname) { 'Cuppy' } let(:email) { '[email protected]' } let(:password) { 'Passw0rd!' } it { is_expected.to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } it { is_expected.to be_invalid } end # ... end #4 Mutate

Slide 49

Slide 49 text

describe User do subject(:user) { described_class.new firstname: firstname, middlename: middlename, lastname: lastname, email: email, password: password } let(:firstname) { 'Adam' } let(:middlename) { nil } let(:lastname) { 'Cuppy' } let(:email) { '[email protected]' } let(:password) { 'Passw0rd!' } it { is_expected.to be_valid } context 'with a firstname that is over 20 chars' do let(:firstname) { 'really really ... super long firstname' } it { is_expected.to be_invalid } end # ... end

Slide 50

Slide 50 text

Permutation Tables

Slide 51

Slide 51 text

class User < ActiveRecord::Base # ... def fullname [firstname, middlename, lastname].compact.join ' ' end end

Slide 52

Slide 52 text

class User < ActiveRecord::Base # ... def fullname [firstname, middlename, lastname].compact.join ' ' end end

Slide 53

Slide 53 text

class User < ActiveRecord::Base # ... def fullname [firstname, middlename, lastname].compact.join ' ' end end

Slide 54

Slide 54 text

class User < ActiveRecord::Base # ... def fullname [firstname, middlename, lastname].compact.join ' ' end end

Slide 55

Slide 55 text

describe User do subject(:user) { described_class.new firstname: firstname, middlename: middlename, lastname: lastname, email: email, password: password } let(:firstname) { 'Adam' } let(:middlename) { nil } let(:lastname) { 'Cuppy' } # ... end

Slide 56

Slide 56 text

describe User do # ... describe 'retrieving a fullname' do subject(:fullname) { user.fullname } context 'when firstname is blank' do let(:firstname) { nil } it { is_expected.to eq lastname } end context 'when lastname is blank' do let(:lastname) { nil } it { is_expected.to eq firstname } end context 'when first and lastname are blank' do let(:firstname) { nil } let(:lastname) { nil } it { is_expected.to be_blank } end context 'when there are all three names' do let(:middlename) { 'Jimmy' } it { is_expected.to eq "#{firstname} #{middlename} #{lastname}" } end end # ... end

Slide 57

Slide 57 text

describe User do # ... describe 'retrieving a fullname' do subject(:fullname) { user.fullname } context 'when firstname is blank' do let(:firstname) { nil } it { is_expected.to eq lastname } end context 'when lastname is blank' do let(:lastname) { nil } it { is_expected.to eq firstname } end context 'when first and lastname are blank' do let(:firstname) { nil } let(:lastname) { nil } it { is_expected.to be_blank } end context 'when there are all three names' do let(:middlename) { 'Jimmy' } it { is_expected.to eq "#{firstname} #{middlename} #{lastname}" } end end # ... end

Slide 58

Slide 58 text

describe User do # ... describe 'retrieving a fullname' do subject(:fullname) { user.fullname } context 'when firstname is blank' do let(:firstname) { nil } it { is_expected.to eq lastname } end context 'when lastname is blank' do let(:lastname) { nil } it { is_expected.to eq firstname } end context 'when first and lastname are blank' do let(:firstname) { nil } let(:lastname) { nil } it { is_expected.to be_blank } end context 'when there are all three names' do let(:middlename) { 'Jimmy' } it { is_expected.to eq "#{firstname} #{middlename} #{lastname}" } end end # ... end

Slide 59

Slide 59 text

describe User do # ... describe 'retrieving a fullname' do subject(:fullname) { user.fullname } context 'when firstname is blank' do let(:firstname) { nil } it { is_expected.to eq lastname } end context 'when lastname is blank' do let(:lastname) { nil } it { is_expected.to eq firstname } end context 'when first and lastname are blank' do let(:firstname) { nil } let(:lastname) { nil } it { is_expected.to be_blank } end context 'when there are all three names' do let(:middlename) { 'Jimmy' } it { is_expected.to eq "#{firstname} #{middlename} #{lastname}" } end end # ... end

Slide 60

Slide 60 text

describe User do # ... describe 'retrieving a fullname' do subject(:fullname) { user.fullname } context 'when firstname is blank' do let(:firstname) { nil } it { is_expected.to eq lastname } end context 'when lastname is blank' do let(:lastname) { nil } it { is_expected.to eq firstname } end context 'when first and lastname are blank' do let(:firstname) { nil } let(:lastname) { nil } it { is_expected.to be_blank } end context 'when there are all three names' do let(:middlename) { 'Jimmy' } it { is_expected.to eq "#{firstname} #{middlename} #{lastname}" } end end # ... end Anything missing ??

Slide 61

Slide 61 text

describe User do # ... describe 'retrieving a fullname' do subject(:fullname) { user.fullname } context 'when firstname is blank' do let(:firstname) { nil } it { is_expected.to eq lastname } end context 'when lastname is blank' do let(:lastname) { nil } it { is_expected.to eq firstname } end context 'when first and lastname are blank' do let(:firstname) { nil } let(:lastname) { nil } it { is_expected.to be_blank } end context 'when there are all three names' do let(:middlename) { 'Jimmy' } it { is_expected.to eq "#{firstname} #{middlename} #{lastname}" } end end # ... end

Slide 62

Slide 62 text

describe 'retrieving a fullname' do subject(:fullname) { user.fullname } context 'when firstname is blank' do let(:firstname) { nil } it { is_expected.to eq lastname } end #... end

Slide 63

Slide 63 text

describe 'retrieving a fullname' do subject(:fullname) { user.fullname } context 'when firstname is blank' do let(:firstname) { nil } it { is_expected.to eq lastname } end #... end

Slide 64

Slide 64 text

describe 'retrieving a fullname' do subject(:fullname) { user.fullname } context 'when firstname is blank' do let(:firstname) { nil } it { is_expected.to eq lastname } end #... end

Slide 65

Slide 65 text

describe 'retrieving a fullname' do # context 'when firstname is blank' do # let(:firstname) { nil } # it { is_expected.to eq lastname } # end { [nil, 'James', 'Johnson'] => 'James Johnson', }.each do |name_set, output| # ... end end

Slide 66

Slide 66 text

describe 'retrieving a fullname' do # ... { [nil, 'James', 'Johnson'] => 'James Johnson', [nil, 'James', nil] => 'James', ['Jimmy', 'James', nil] => 'Jimmy James', ['Jimmy', 'James', 'Johnson'] => 'Jimmy James Johnson' }.each do |name_set, output| # ... end end Anything missing ??

Slide 67

Slide 67 text

describe 'retrieving a fullname' do # ... { [nil, 'James', 'Johnson'] => 'James Johnson', [nil, 'James', nil] => 'James', ['Jimmy', 'James', nil] => 'Jimmy James', ['Jimmy', 'James', 'Johnson'] => 'Jimmy James Johnson' ['Jimmy', nil, nil] => 'Jimmy', [nil, nil, 'Johnson'] => 'Johnson', ['Jimmy', nil, 'Johnson'] => 'Jimmy Johnson' }.each do |name_set, output| # ... end end

Slide 68

Slide 68 text

describe 'retrieving a fullname' do shared_examples_for 'a fullname' do |(first, middle, last), output| subject(:fullname) { user.fullname } let(:firstname) { first } let(:middlename) { middle } let(:lastname) { last } it { is_expected.to eq output } end { [nil, 'James', 'Johnson'] => 'James Johnson', [nil, 'James', nil] => 'James', ['Jimmy', 'James', nil] => 'Jimmy James', ['Jimmy', 'James', 'Johnson'] => 'Jimmy James Johnson' ['Jimmy', nil, nil] => 'Jimmy', [nil, nil, 'Johnson'] => 'Johnson', ['Jimmy', nil, 'Johnson'] => 'Jimmy Johnson' }.each do |name_set, output| it_behaves_like 'a fullname', name_set, output end end

Slide 69

Slide 69 text

describe 'retrieving a fullname' do shared_examples_for 'a fullname' do |(first, middle, last), output| subject(:fullname) { user.fullname } let(:firstname) { first } let(:middlename) { middle } let(:lastname) { last } it { is_expected.to eq output } end { [nil, 'James', 'Johnson'] => 'James Johnson', [nil, 'James', nil] => 'James', ['Jimmy', 'James', nil] => 'Jimmy James', ['Jimmy', 'James', 'Johnson'] => 'Jimmy James Johnson' ['Jimmy', nil, nil] => 'Jimmy', [nil, nil, 'Johnson'] => 'Johnson', ['Jimmy', nil, 'Johnson'] => 'Jimmy Johnson' }.each do |name_set, output| it_behaves_like 'a fullname', name_set, output end end

Slide 70

Slide 70 text

describe 'retrieving a fullname' do shared_examples_for 'a fullname' do |(first, middle, last), output| subject(:fullname) { user.fullname } let(:firstname) { first } let(:middlename) { middle } let(:lastname) { last } it { is_expected.to eq output } end { [nil, 'James', 'Johnson'] => 'James Johnson', [nil, 'James', nil] => 'James', ['Jimmy', 'James', nil] => 'Jimmy James', ['Jimmy', 'James', 'Johnson'] => 'Jimmy James Johnson' ['Jimmy', nil, nil] => 'Jimmy', [nil, nil, 'Johnson'] => 'Johnson', ['Jimmy', nil, 'Johnson'] => 'Jimmy Johnson' }.each do |name_set, output| it_behaves_like 'a fullname', name_set, output end end

Slide 71

Slide 71 text

Golden Master

Slide 72

Slide 72 text

1. Backfilling untested legacy code 2. Uncertain expectations require visual confirmation 3. Code complexity significantly exceeds current domain knowledge Golden Master Testing

Slide 73

Slide 73 text

require 'rails_helper' RSpec.describe User, type: :model do pending "add some examples to (or delete) #{__FILE__}" end

Slide 74

Slide 74 text

1. Take a snapshot of an object (to a file) 2. Verify the snapshot (manually) 3. Compare future versions to the verified “master” Golden Master Testing

Slide 75

Slide 75 text

https://github.com/kytrinyx/approvals

Slide 76

Slide 76 text

# spec/spec_helper.rb require ‘approvals/rspec' # path/to/spec.rb it 'works' do verify format: :html do "

ZOMG

" end end # Manually verify snapshots $ cd /path/to/app $ approvals verify https://github.com/kytrinyx/approvals

Slide 77

Slide 77 text

# spec/spec_helper.rb require ‘approvals/rspec' # path/to/spec.rb it 'works' do verify format: :html do "

ZOMG

" end end # Manually verify snapshots $ cd /path/to/app $ approvals verify https://github.com/kytrinyx/approvals

Slide 78

Slide 78 text

# spec/spec_helper.rb require ‘approvals/rspec' # path/to/spec.rb it 'works' do verify format: :html do "

ZOMG

" end end # Manually verify snapshots $ cd /path/to/app $ approvals verify https://github.com/kytrinyx/approvals

Slide 79

Slide 79 text

Best Practices

Slide 80

Slide 80 text

let

Slide 81

Slide 81 text

@fullname = 'Adam Cuppy' specify { expect(@fullnmae).to eq 'Adam Cuppy' } # => expected: "Adam Cuppy", got: nil

Slide 82

Slide 82 text

let(:fullname) { 'Adam Cuppy' } specify { expect(fullnmae).to eq 'Adam Cuppy' } # => NameError: undefined local variable or method `fullnmae'

Slide 83

Slide 83 text

Descriptive Naming

Slide 84

Slide 84 text

it { expect(user1).to be_valid } it { expect(user2).to be_valid }

Slide 85

Slide 85 text

it { expect(guest_user).to have_access } it { expect(admin_user).to have_access }

Slide 86

Slide 86 text

describe 'secure zones' do context 'as a guest user' do let(:user) { User.new } # ... end context 'as an admin user' do let(:user) { User.new admin: true } # ... end end

Slide 87

Slide 87 text

Extract Common Expectations

Slide 88

Slide 88 text

Custom Matchers

Slide 89

Slide 89 text

require 'rspec/expectations' RSpec::Matchers.define :be_a_multiple_of do |expected| match do |actual| actual % expected == 0 end end RSpec.describe 9 do it { is_expected.to be_a_multiple_of(3) } end https://www.relishapp.com/rspec/rspec-expectations/v/3-3/docs/custom-matchers/define-matcher

Slide 90

Slide 90 text

require 'rspec/expectations' RSpec::Matchers.define :be_a_multiple_of do |expected| match do |actual| actual % expected == 0 end end RSpec.describe 9 do it { is_expected.to be_a_multiple_of(3) } end https://www.relishapp.com/rspec/rspec-expectations/v/3-3/docs/custom-matchers/define-matcher

Slide 91

Slide 91 text

Shoulda-Matchers https://github.com/thoughtbot/shoulda-matchers

Slide 92

Slide 92 text

describe User do # ... context 'when a new user matches an existing user' do let!(:existing_user) { described_class.create! firstname: firstname, middlename: middlename lastname: lastname, email: email, password: password } let(:new_user) { described_class.new firstname: firstname, middlename: middlename lastname: lastname, email: email, password: password } it { expect(new_user).to be_invalid } end # ... end WHat’s invalid ??

Slide 93

Slide 93 text

describe User do # ... context 'when a new user matches an existing user' do let!(:existing_user) { described_class.create! firstname: firstname, middlename: middlename lastname: lastname, email: email, password: password } let(:new_user) { described_class.new firstname: firstname, middlename: middlename lastname: lastname, email: email, password: password } it { expect(new_user).to be_invalid } end # ... end

Slide 94

Slide 94 text

describe User do subject(:user) { ... } # ... describe 'validations' do it { is_expected.to validate_uniqueness_of(:email) } end end https://github.com/thoughtbot/shoulda-matchers

Slide 95

Slide 95 text

describe User do subject(:user) { ... } # ... describe 'validations' do it { is_expected.to validate_uniqueness_of(:email) } end end https://github.com/thoughtbot/shoulda-matchers

Slide 96

Slide 96 text

describe User do subject(:user) { ... } # ... describe 'validations' do it { is_expected.to validate_uniqueness_of(:email) } end end https://github.com/thoughtbot/shoulda-matchers

Slide 97

Slide 97 text

Factories over Fixtures

Slide 98

Slide 98 text

https://github.com/thoughtbot/factory_girl

Slide 99

Slide 99 text

describe User do subject(:user) { FactoryGirl.build :user } # ... context 'validations' do it { is_expected.to validate_uniqueness_of(:email) } end end

Slide 100

Slide 100 text

describe User do subject(:user) { FactoryGirl.build :user } # ... context 'validations' do it { is_expected.to validate_uniqueness_of(:email) } end end

Slide 101

Slide 101 text

FactoryGirl.lint!

Slide 102

Slide 102 text

https://github.com/thoughtbot/factory_girl

Slide 103

Slide 103 text

Readables

Slide 104

Slide 104 text

http://betterspecs.org/

Slide 105

Slide 105 text

Randy Coulman - http://randycoulman.com/blog/categories/getting-testy/

Slide 106

Slide 106 text

Randy Coulman - http://randycoulman.com/blog/categories/getting-testy/

Slide 107

Slide 107 text

Sandi Metz - http://www.poodr.com

Slide 108

Slide 108 text

https://codingzeal.com/

Slide 109

Slide 109 text

www.codingzeal.com @adamcuppy Adam Cuppy