Link
Embed
Share
Beginning
This slide
Copy link URL
Copy link URL
Copy iframe embed code
Copy iframe embed code
Copy javascript embed code
Copy javascript embed code
Share
Tweet
Share
Tweet
Slide 1
Slide 1 text
#CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017 REVIEW
Slide 2
Slide 2 text
Sébastien Charrier scharrier
Slide 3
Slide 3 text
No content
Slide 4
Slide 4 text
BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.
Slide 5
Slide 5 text
CODING WAS FAST
Slide 6
Slide 6 text
No content
Slide 7
Slide 7 text
GIT, Then, we got GITHUB, GITLAB, BITBUCKET…
Slide 8
Slide 8 text
SOME GOOD TOOLS TOGETHER TO WORK AND CODE
Slide 9
Slide 9 text
PULL* REQUEST * or merge
Slide 10
Slide 10 text
CODE REVIEW Yea. We could do before merging.
Slide 11
Slide 11 text
Ask a peer to read and validate our code before merging it into the product.
Slide 12
Slide 12 text
Fuck, it takes too much time. Your boss
Slide 13
Slide 13 text
AT LEAST 30% OF MY TIME * personal estimation
Slide 14
Slide 14 text
No content
Slide 15
Slide 15 text
COSTS Yep, it but…
Slide 16
Slide 16 text
QUALITY,
Slide 17
Slide 17 text
CONSISTENCY,
Slide 18
Slide 18 text
LEARNING.
Slide 19
Slide 19 text
IT’S AN INVESTMENT. Finally,
Slide 20
Slide 20 text
There are two important things.
Slide 21
Slide 21 text
STATE OF MIND
Slide 22
Slide 22 text
No content
Slide 23
Slide 23 text
We work together to create the best product we can.
Slide 24
Slide 24 text
GUIDELINES
Slide 25
Slide 25 text
No content
Slide 26
Slide 26 text
Write code style rules and review rules.
Slide 27
Slide 27 text
In order to not repeat yourself, and avoid conflicts.
Slide 28
Slide 28 text
SOME OF MY RULES
Slide 29
Slide 29 text
FOR EVERYBODY
Slide 30
Slide 30 text
EMPATHY
Slide 31
Slide 31 text
STAY HUMBLE EMPATHY
Slide 32
Slide 32 text
STAY HUMBLE NO IRONY EMPATHY
Slide 33
Slide 33 text
STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true story. EMPATHY
Slide 34
Slide 34 text
No content
Slide 35
Slide 35 text
I AM THE REVIEWER
Slide 36
Slide 36 text
QUESTIONS, NO ORDERS
Slide 37
Slide 37 text
QUESTIONS, NO ORDERS BE EXPLICIT
Slide 38
Slide 38 text
QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF
Slide 39
Slide 39 text
QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE
Slide 40
Slide 40 text
No content
Slide 41
Slide 41 text
I AM REVIEWED
Slide 42
Slide 42 text
KEEP PRS SMALL
Slide 43
Slide 43 text
BE GRATEFUL KEEP PRS SMALL
Slide 44
Slide 44 text
BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL
Slide 45
Slide 45 text
BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS SMALL
Slide 46
Slide 46 text
BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT GIVE UP KEEP PRS SMALL
Slide 47
Slide 47 text
STILL DISAGREE ?
Slide 48
Slide 48 text
No content
Slide 49
Slide 49 text
CLOSE COMPUTERS AND DISCUSS IRL
Slide 50
Slide 50 text
OR ASK SOMEBODY ELSE’S POINT OF VIEW.
Slide 51
Slide 51 text
No content
Slide 52
Slide 52 text
THE FINAL DECISION Finally, let the maintainer take (but do another PR later.)
Slide 53
Slide 53 text
THANKS. http://bump.sh Psssst !