Reviewing Code Reviews - Speaker Deck

Slide 1

Slide 1 text

Reviewing Code Reviews

Slide 2

Slide 2 text

Gio iOS Lead at @mokagio gio.codes

Slide 3

Slide 3 text

What & Why

Slide 4

Slide 4 text

Code Reviews are… Discussion on the code

Slide 5

Slide 5 text

Code Reviews are… Learning opportunity

Slide 6

Slide 6 text

Code Reviews are… ✍ share new things they learnt " teach what they know

Slide 7

Slide 7 text

Code Reviews are… Growth opportunity for the team

Slide 8

Slide 8 text

Invest in Code Reviews because… If code reviews make the team better, then better code reviews will make the team even better

Slide 9

Slide 9 text

“Indeed, the ratio of time spent reading versus writing is well over 10 to 1. We are constantly reading old code as part of the effort to write new code. Robert C. Martin (Uncle Bob) - Clean Code

Slide 10

Slide 10 text

"" "" "" "" "" ✍

Slide 11

Slide 11 text

Invest in Code Reviews because… Less back and forth

Slide 12

Slide 12 text

1. As an author ✍ 2. As a reviewer " 3. As a robot #

Slide 13

Slide 13 text

As an author ✍

Slide 14

Slide 14 text

As an author ✍ Write a great PR description - What AND Why - Context - Graphs, Images, GIFs, Links

Slide 15

Slide 15 text

No content

Slide 16

Slide 16 text

No content

Slide 17

Slide 17 text

No content

Slide 18

Slide 18 text

As an author ✍ Review your PRs yourself first

Slide 19

Slide 19 text

As an author ✍ Keep your PRs small and focused

Slide 20

Slide 20 text

https://twitter.com/iamdevloper/status/397664295875805184

Slide 21

Slide 21 text

As a reviewer "

Slide 22

Slide 22 text

As a reviewer " Watch your language

Slide 23

Slide 23 text

No content

Slide 24

Slide 24 text

As a reviewer " $ “How would I feel if someone left this comment to me?”

Slide 25

Slide 25 text

As a reviewer " Ask questions

Slide 26

Slide 26 text

As a reviewer " Constructive Criticism

Slide 27

Slide 27 text

As a reviewer " Strong rationales (and links to back them up)

Slide 28

Slide 28 text

No content

Slide 29

Slide 29 text

As a reviewer " Review what the code DOES not how it LOOKS

Slide 30

Slide 30 text

As a reviewer " Use a style guide

Slide 31

Slide 31 text

https://github.com/iflix-letsplay/swift-style-guide

Slide 32

Slide 32 text

As a reviewer " You can code review your style guide %

Slide 33

Slide 33 text

As a robot #

Slide 34

Slide 34 text

As a robot # Automate your style guide Linters Formatters

Slide 35

Slide 35 text

https://github.com/realm/SwiftLint

Slide 36

Slide 36 text

https://houndci.com/

Slide 37

Slide 37 text

https://prettier.io/

Slide 38

Slide 38 text

As a robot # Check for mistakes easy to make

Slide 39

Slide 39 text

https://danger.systems

Slide 40

Slide 40 text

https://danger.systems

Slide 41

Slide 41 text

https://danger.systems

Slide 42

Slide 42 text

As a robot # Use a PR template

Slide 43

Slide 43 text

https://blog.github.com/2016-02-17-issue-and-pull-request-templates/

Slide 44

Slide 44 text

https://blog.github.com/2016-02-17-issue-and-pull-request-templates/

Slide 45

Slide 45 text

https://twitter.com/mokagio/status/1019709696872087557

Slide 46

Slide 46 text

Recap ☝ Code Reviews are first and foremost a growth opportunity for the team ' A good Code Review starts with the author ✍ As a reviewers, be inquisitive and constructive " Use automation to remove friction and take care of mundane checks #