$ git anti-patterns
how to mess up with git
and love it again
LEMi ORHAN ERGiN
Agile Software Craftsman, iyzico
/lemiorhan
@lemiorhan
lemiorhanergin.com
bit.ly/lemiorhan
Slide 2
Slide 2 text
/lemiorhan
lemiorhanergin.com
@lemiorhan
LEMi ORHAN ERGiN
agile software craftsman @ iyzico
ex-Sony, ex-eBay
founder of Turkish Software Craftsmanship Community
Slide 3
Slide 3 text
git is powerful
but you have to know using it properly
because of its internal structure
Slide 4
Slide 4 text
Are you using git
if all you do is commit-push-pull
use dropbox instead
ANTIPATTERN DANGER
as if it is dropbox ?
1
DROPBOX-ISH GIT ANTI-PATTERN
Slide 5
Slide 5 text
learn
no worries, I will cover how git behaves in 5 minutes
git works
how
Slide 6
Slide 6 text
the way it keeps
FILES & FOLDERS
.git folder, aka repository
working copy
staging area
objects database
the way it keeps
REFERENCES
directed acyclic graph
keeping snapshots
traversing graph
branches, tags, heads
git has 2 mechanisms
Slide 7
Slide 7 text
Source Code
Working Copy
you want to version changes
Slide 8
Slide 8 text
Source Code
Working Copy
$ git init
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
initializing repo
Slide 9
Slide 9 text
Source Code
Working Copy
$ git init --bare
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
initializing bare repo
Slide 10
Slide 10 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git add .
preparing commits
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git add .
preparing commits
Slide 13
Slide 13 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git commit -m “initial commit”
commi!ing
Slide 14
Slide 14 text
$ git commit -m “initial commit”
commi!ing
folder
folder
folder
file
file
file
commit
branch
HEAD
For more details, refer to book
Git Internals by Scott Chacon
Slide 15
Slide 15 text
folder
folder
folder
file
file
file
commit
$ git commit -m “second commit”
commi!ing
folder
commit
branch
HEAD
folder
file
folder
For more details, refer to book
Git Internals by Scott Chacon
Slide 16
Slide 16 text
folder
folder
folder
file
file
file
commit
$ git commit -m “third commit”
commi!ing
folder
commit
folder
file
folder
folder
commit
branch
HEAD
file
For more details, refer to book
Git Internals by Scott Chacon
Slide 17
Slide 17 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git commit -m “initial commit”
commi!ing
Slide 18
Slide 18 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git remote add origin http://upstream.repo
$ git push -u origin master
pushing to remote
Slide 19
Slide 19 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
new changes from others are pushed
Slide 20
Slide 20 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git fetch
fetching changes
Slide 21
Slide 21 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git merge FETCHED_HEAD
updating working copy
Slide 22
Slide 22 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git pull
git fetch + git merge
ge!ing changes to source code
Slide 23
Slide 23 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
want to update last commit
Slide 24
Slide 24 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git reset --soft $ git commit --amend
/ so" reseting
cannot be reached
Only the cache for
the commit you reseted
is removed from staging area
for your current branch
Slide 25
Slide 25 text
folder
folder
folder
file
file
file
commit
folder
commit
folder
file
folder
folder
commit
branch
HEAD
file
For more details, refer to book
Git Internals by Scott Chacon
$ git reset --soft $ git commit --amend
/ so" reseting
Slide 26
Slide 26 text
folder
folder
folder
file
file
file
commit
folder
commit
folder
file
folder
folder
commit
branch
HEAD
file
For more details, refer to book
Git Internals by Scott Chacon
$ git reset --soft $ git commit --amend
/ so" reseting
Slide 27
Slide 27 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
want to squash or change last commits
Slide 28
Slide 28 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git reset --mixed mixed reseting
cannot be reached
entries for commits, files
and folders are removed
from staging area
Slide 29
Slide 29 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
want to get rid of last commits
Slide 30
Slide 30 text
Object Database
.git Folder / Object Database
Cache
Staging Area / The Index
Remote
Upstream Repo / Remote Repo
Server
Source Code
Working Copy
$ git reset --hard hard reseting
cannot be reached
removed from staging area
removed from working copy
Slide 31
Slide 31 text
are you brave enough to
jump to any commit ?
jump to a branch
create a branch from a commit
create a branch from a tag
ANTIPATTERN DANGER
$ git checkout feature/PA-121
$ git checkout -b fix/missing-sign-parameter 2449be8
$ git checkout -b hotfix/v1.1 tags/v1
2
BROKEN TIME MACHINE ANTI-PATTERN
Slide 32
Slide 32 text
are you sure?
are you brave enough to
jump to any commit ?
Slide 33
Slide 33 text
do you have
loooooong living
topic branches ?
ANTIPATTERN DANGER
3
LONG LIVING BRANCHES ANTI-PATTERN
Slide 34
Slide 34 text
do you have
loooooong living
topic branches ?
welcome to
merge hell
Slide 35
Slide 35 text
before merging
do you validate commits
back to source ?
ANTIPATTERN DANGER
code review, continuous integration, automated testing…
4
TOO LATE TO VALIDATE ANTI-PATTERN
Slide 36
Slide 36 text
before merging
do you validate commits
back to source ? are you
sure?
Slide 37
Slide 37 text
merge and unmerge
do you o!en need to
just before releases ?
ANTIPATTERN DANGER
5
CHERRY-PICK OBSSESSION ANTI-PATTERN
Slide 38
Slide 38 text
merge and unmerge
do you o!en need to
just before releases ?
master
HEAD
TAG/v13
version 14
$ git cherry-pick Every-Single-Commit-We-Want-To-Deploy
Slide 39
Slide 39 text
the commit graph ?
do you fully understand
ANTIPATTERN DANGER
6
DEATH ON COMMIT GRAPH ANTI-PATTERN
Slide 40
Slide 40 text
the commit graph ?
do you fully understand
topic and shared branches, tracking branches, tags, HEADs, merge commits, reverted commits…
Slide 41
Slide 41 text
Cure?
Slide 42
Slide 42 text
Commit Early, Commit O"en
Perfect Later, Publish Once
Slide 43
Slide 43 text
STEP 0
split your big feature into
mini shippable tasks
master
HEAD
TOPIC
ORIGIN/master
refactorings
tasks, like rest endpoints
red-green-refactor
each task will have a
branch, not a feature
Slide 44
Slide 44 text
STEP 1
commit early
commit o!en
no need to compile
no need for CI
it’s only for versioning
do not push
master
HEAD
TOPIC
ORIGIN/master
Slide 45
Slide 45 text
always pull with rebase
$ git pull --rebase origin master
to get forced pushes securely
to rebase your commits
master
HEAD
TOPIC
STEP 2
ORIGIN/master
and do it o!en!
Slide 46
Slide 46 text
$ git pull --rebase origin master
master
HEAD
TOPIC
STEP 2
ORIGIN/master
always pull with rebase
to get forced pushes securely
to rebase your commits
and do it o!en!
Slide 47
Slide 47 text
$ git pull --rebase origin master
master
HEAD
TOPIC
STEP 2
ORIGIN/master
if you branch is pushed already
$ git push -f
always pull with rebase
to get forced pushes securely
to rebase your commits
and do it o!en!
Slide 48
Slide 48 text
$ git pull --rebase origin master
master
HEAD
TOPIC
STEP 2
ORIGIN/master
if you branch is pushed already
$ git push -f
Sync source branch a!erwards
$ git fetch origin master:master
always pull with rebase
to get forced pushes securely
to rebase your commits
and do it o!en!
Slide 49
Slide 49 text
perfect later
make it single commit
$ git reset HEAD~3
$ git rebase -i HEAD~3
$ git merge --squash
HEAD
TOPIC
STEP 3
ORIGIN/master
tests are passing
app is working
code is reviewed (*)
master
Slide 50
Slide 50 text
HEAD
TOPIC
STEP 3
ORIGIN/master
perfect later
make it single commit
tests are passing
app is working
code is reviewed (*)
master
$ git reset HEAD~3
$ git rebase -i HEAD~3
$ git merge --squash
Slide 51
Slide 51 text
Use feature flags/toggles
HEAD
TOPIC
STEP 4
ORIGIN/master
if feature should be disabled
merge back to source
$ git checkout master
$ git merge topic
master
Slide 52
Slide 52 text
Use feature flags/toggles
master
HEAD
TOPIC
STEP 4
ORIGIN/master
if feature should be disabled
merge back to source
$ git checkout master
$ git merge topic
Slide 53
Slide 53 text
Continuous Integration
validates master branch
continuously
master
HEAD
TOPIC
ORIGIN/master
Pull requests can be
used to review code
and to validate before
merging back to master
Scrum tasks are
mapped to commits,
not stories
Github Flow can be
used to govern overall
TRUNK-BASED
DEVELOPMENT
let's make git great again
Feature flags should be
used whenever possible
Commit early & o"en
perfect later, publish
once philosophy
Deliver frequently
be prepared to send
every single commit
Deleting branches a"er
merge will make your
commit graph readable
Slide 54
Slide 54 text
use terminal
GUIs are prison balls of developers
it’s ok to use GUIs while checking diffs,
resolving conflicts and viewing commit graph
BUTTON ADDICT ANTI-PATTERN
7
ANTIPATTERN DANGER
Slide 55
Slide 55 text
stop adding
prevent commits from being big ball of muds
every change
OMNIBUS BILL ANTI-PATTERN
8
ANTIPATTERN DANGER
Slide 56
Slide 56 text
stop adding
prevent commits from being big ball of muds
every change
local change sets at JetBrains IDEs
Slide 57
Slide 57 text
stop adding every change
partial add
Slide 58
Slide 58 text
messages
are
read!
# WHAT
# (this commit will...)
# WHY and HOW
# Explain why this change is being made
# RELATED
# Provide links or keys to any relevant issues or other resources
# REMEMBER
# use lower case in the subject line
# start with a verb in imperative tone in the subject line
# do not end the subject line with a period
# separate subject from body with a blank line
# use the body to explain what and why vs. how
# can use multiple lines with "-" for bullet points in body
$ git config --global commit.template ~/.git-commit-template.txt
$ git config --global commit.cleanup strip
use git commit
templates to
create be"er
commit messages
com
t
m
i
F*CKING COMMIT MESSAGES ANTI-PATTERN
9
ANTIPATTERN DANGER
Slide 59
Slide 59 text
messages
are
read!
use git commit
templates to
create be"er
commit messages
com
t
m
i
Slide 60
Slide 60 text
ANTIPATTERN DANGER
10
ZOMBIE REBASE ANTI-PATTERN
Rebase Conflicts
Death by
master
HEAD
TOPIC
Slide 61
Slide 61 text
TOPIC
master
c1 c2 c3 c4 c7
HEAD
c5 c6
c5 c6
git:(topic) $ git rebase master
rebase
how
really works
command
Slide 62
Slide 62 text
TOPIC
master
c1 c2 c3 c4 c7
HEAD
c5 c6
c5 c6
git:(topic) $ git rebase master
rebase
how
really works
command
Slide 63
Slide 63 text
TOPIC
master
c1 c2 c3 c4 c7
HEAD
c5 c6
c5 c6
git:(topic) $ git rebase master
rebase
how
really works
command
Slide 64
Slide 64 text
TOPIC
master
c1 c2 c3 c4 c7
HEAD
c5 c6
c5 c6 c5'
REPLAY #1
git:(topic) $ git rebase master
orig_HEAD
rebase
how
really works
command
Slide 65
Slide 65 text
TOPIC
master
c1 c2 c3 c4 c7
c5 c6
c5 c6 c5' c6
c6'
git:(topic) $ git rebase master
HEAD
REPLAY #2
orig_HEAD
rebase
how
really works
command
Slide 66
Slide 66 text
TOPIC
master
c1 c2 c3 c4 c7
HEAD
c5 c6
c5 c6 c5' c6
c6'
git:(topic) $ git rebase master
REWIND
orig_HEAD
rebase
how
really works
command
Slide 67
Slide 67 text
master
c1 c2 c3 c4 c7
c5' c6
c6'
git:(topic) $ git rebase master
TOPIC
HEAD
REWIND
rebase
how
really works
command
Slide 68
Slide 68 text
master
HEAD
TOPIC
YOU STILL WANT TO REBASE, RIGHT?
Slide 69
Slide 69 text
master
HEAD
TOPIC
$ git merge topic
merge to branches:
merge with squash:
squash and rebase:
$ git merge topic --squash
$ git reset HEAD~8
$ git commit
$ git rebase master
Slide 70
Slide 70 text
1. DROPBOX-ISH GIT
2. BROKEN TIME MACHINE
3. LONG LIVING BRANCHES
4. TOO LATE TO VALIDATE
5. CHERRY-PICK OBSSESSION
6. DEATH ON COMMIT GRAPH
7. BUTTON ADDICT
8. TRASH HOUSE
9. OMNIBUS BILL
10. F*CKING COMMIT MESSAGES
11. ZOMBIE REBASE
12. CODE LOSING SYNDROME
13. MESS UP WITH THE ROLLBACK
14. CENTRALIZED GIT
15. MERGE FANATIC
16. BRANCH CEMETERY
17. UNCONTROLLED POWER
18. WEB OF REPOSITORIES
19. ORACLE SYNDROME
20. WAITING FOR HACKERS
21. EVIL MERGE
22. BRANCH OVERDOSE
23. CHUCKY THE COMMAND
24. NO HERO TO SAVE LIVES
25. DUPLICATE COMMITS
26. BIG FAT COMMIT
27. CONFLICT-FOBIA
28. LIVING AT DETACHED HEAD STATE
Slide 71
Slide 71 text
RECAP
what was really
happened at that time?
LET’S
Slide 72
Slide 72 text
master
TAG/v1.1
login
HEAD
DETACHED HEAD STATE
$ git checkout cecd95914
Note: checking out 'cecd95914'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
LIVING AT DETACHED HEAD STATE ANTI-PATTERN
11
ANTIPATTERN DANGER
Slide 73
Slide 73 text
master
TAG/v1.1
login
DETACHED HEAD STATE
$ git rebase (and conflicts happen)
$ git checkout HEAD~2
$ git checkout 43e3ab01
$ git checkout tags/v1.1
WHEN IT HAPPENS
HEAD
Slide 74
Slide 74 text
master
TAG/v1.1
login
HEAD
poor little developer...
Slide 75
Slide 75 text
master
TAG/v1.1
login
HEAD
$ git checkout master
Slide 76
Slide 76 text
master
TAG/v1.1
login
HEAD
$ git reflog
aa67e3a2c HEAD@{0}: rebase finished: returning to refs/heads/fix/java-sql-Date-violates-LSR
aa67e3a2c HEAD@{1}: rebase: fixes UnsupportedOperationException while calling toIstant() method of java.sql.Date
a45f3c4e5 HEAD@{2}: rebase: checkout develop
630ddad6e HEAD@{3}: checkout: moving from develop to fix/java-sql-Date-violates-LSR
b26cf7a1a HEAD@{4}: rebase: checkout develop
630ddad6e HEAD@{5}: checkout: moving from develop to fix/java-sql-Date-violates-LSR
b26cf7a1a HEAD@{6}: pull: Fast-forward
8b59f8f50 HEAD@{7}: checkout: moving from fix/java-sql-Date-violates-LSR to develop
Slide 77
Slide 77 text
$ git reflog
630ddad6e
the one we are
searching for
master
TAG/v1.1
login
HEAD
aa67e3a2c HEAD@{0}: rebase finished: returning to refs/heads/fix/java-sql-Date-violates-LSR
aa67e3a2c HEAD@{1}: rebase: fixes UnsupportedOperationException while calling toIstant() method of java.sql.Date
a45f3c4e5 HEAD@{2}: rebase: checkout develop
630ddad6e HEAD@{3}: checkout: moving from develop to fix/java-sql-Date-violates-LSR
b26cf7a1a HEAD@{4}: rebase: checkout develop
630ddad6e HEAD@{5}: checkout: moving from develop to fix/java-sql-Date-violates-LSR
b26cf7a1a HEAD@{6}: pull: Fast-forward
8b59f8f50 HEAD@{7}: checkout: moving from fix/java-sql-Date-violates-LSR to develop
Slide 78
Slide 78 text
master
typofix
TAG/v1.1
login
HEAD
$ git branch typofix 630ddad6e
Slide 79
Slide 79 text
master
typofix
TAG/v1.1
login
HEAD
$ git branch typofix 630ddad6e
KEEP CALM, NOTHING WILL BE LOST
Slide 80
Slide 80 text
LEMi ORHAN ERGiN
agile software craftsman @ iyzico
/lemiorhan
lemiorhanergin.com
@lemiorhan
ANTIPATTERN DANGER
thank you all!
Feedback: bit.ly/lemiorhan