Slide 1

Slide 1 text

Review all the things! Maciej Piotrowski

Slide 2

Slide 2 text

swifting.io

Slide 3

Slide 3 text

swifting.io

Slide 4

Slide 4 text

importance of review

Slide 5

Slide 5 text

I’ve done 100s of reviews

Slide 6

Slide 6 text

it’s important

Slide 7

Slide 7 text

I’ve learnt from an expert

Slide 8

Slide 8 text

real-life example

Slide 9

Slide 9 text

No content

Slide 10

Slide 10 text

No content

Slide 11

Slide 11 text

No content

Slide 12

Slide 12 text

review code

Slide 13

Slide 13 text

No content

Slide 14

Slide 14 text

2 important aspects

Slide 15

Slide 15 text

ego effect

Slide 16

Slide 16 text

good culture

Slide 17

Slide 17 text

how to introduce it at work?

Slide 18

Slide 18 text

unit testing code review

Slide 19

Slide 19 text

not taught

Slide 20

Slide 20 text

No content

Slide 21

Slide 21 text

No content

Slide 22

Slide 22 text

coding task

Slide 23

Slide 23 text

pull-what?

Slide 24

Slide 24 text

pull-request

Slide 25

Slide 25 text

git flow

Slide 26

Slide 26 text

No content

Slide 27

Slide 27 text

No content

Slide 28

Slide 28 text

No content

Slide 29

Slide 29 text

No content

Slide 30

Slide 30 text

No content

Slide 31

Slide 31 text

No content

Slide 32

Slide 32 text

No content

Slide 33

Slide 33 text

unit testing + code review = ♥

Slide 34

Slide 34 text

obstacles

Slide 35

Slide 35 text

3 months, 3 developers usual estimate

Slide 36

Slide 36 text

30 min, not 3 days for a bug search for a review

Slide 37

Slide 37 text

fire andforget projects

Slide 38

Slide 38 text

review andlearn projects

Slide 39

Slide 39 text

there is no time

Slide 40

Slide 40 text

there is no try just do it do or do not

Slide 41

Slide 41 text

but it takes too much time

Slide 42

Slide 42 text

how much time to deliver a drug?

Slide 43

Slide 43 text

how much time to deliver a drug? 1 year ?

Slide 44

Slide 44 text

how much time to deliver a drug? 3 years ?

Slide 45

Slide 45 text

on average 10 years

Slide 46

Slide 46 text

Is 30 min for a code review too long?

Slide 47

Slide 47 text

clinical trial

Slide 48

Slide 48 text

software validation

Slide 49

Slide 49 text

No content

Slide 50

Slide 50 text

peer reviewed academic journals

Slide 51

Slide 51 text

No content

Slide 52

Slide 52 text

not everyone do it

Slide 53

Slide 53 text

should we review?

Slide 54

Slide 54 text

No content

Slide 55

Slide 55 text

No content

Slide 56

Slide 56 text

No content

Slide 57

Slide 57 text

why should we?

Slide 58

Slide 58 text

review andlearn improve teach

Slide 59

Slide 59 text

good habits stay

Slide 60

Slide 60 text

No content

Slide 61

Slide 61 text

Review all the things!

Slide 62

Slide 62 text

swifting.io

Slide 63

Slide 63 text

• code review @ swifting.io • Confusion String Quartet • The Drug Approval Process - Medscape • Mobile Academy • NASA images • Pixabay