Surviving Code Reviews & Tech Interviews

Slide 1

Slide 1 text

Surviving Code Reviews & Tech Interviews Cecy Correa // @cecycorrea // The Lead Dev Austin Meetup November 2019 1 Surviving Code Reviews & Tech Interviews {vulnerability: true}

Slide 2

Slide 2 text

Hi, I’m Cecy!   @cecycorrea Surviving Code Reviews & Tech Interviews 2

Slide 3

Slide 3 text

I want to talk about vulnerability & failure 3 Surviving Code Reviews & Tech Interviews

Slide 4

Slide 4 text

code reviews & tech interviews Surviving Code Reviews & Tech Interviews 4

Slide 5

Slide 5 text

Code Reviews Building bullet proof PRs 5 Surviving Code Reviews & Tech Interviews

Slide 6

Slide 6 text

6 Surviving Code Reviews & Tech Interviews

Slide 7

Slide 7 text

Why does this happen?

Slide 8

Slide 8 text

How does it make you feel? 8 Surviving Code Reviews & Tech Interviews

Slide 9

Slide 9 text

Find a way to get control back 9 Surviving Code Reviews & Tech Interviews

Slide 10

Slide 10 text

Create a bullet-proof pull request 10 Surviving Code Reviews & Tech Interviews

Slide 11

Slide 11 text

DISTRACTIONS 11 Surviving Code Reviews & Tech Interviews

Slide 12

Slide 12 text

Presentation theme goes here Bullet-proof PRs • Make your PR as small as possible • Provide context • Provide visuals  (where applicable) 12 Surviving Code Reviews & Tech Interviews

Slide 13

Slide 13 text

Small PRs aka Extreme Slicing EXTREME SLICING is the practice of breaking down a task into its smallest possible sub-tasks 13 Surviving Code Reviews & Tech Interviews SMOL BOI

Slide 14

Slide 14 text

Presentation theme goes here Put your PR in Context • Context is king • JIRA / Trello / ticket • Problem you’re solving • Solution 14 Surviving Code Reviews & Tech Interviews THE CONTEXT KING

Slide 15

Slide 15 text

Surviving Code Reviews & Tech Interviews 15

Slide 16

Slide 16 text

Bullet-proof PRs •Are small •Provide context 16 Surviving Code Reviews & Tech Interviews

Slide 17

Slide 17 text

Presentation theme goes here What if that still doesn’t work? 17 Surviving Code Reviews & Tech Interviews

Slide 18

Slide 18 text

It’s part of a larger systemic issue Surviving Code Reviews & Tech Interviews 18

Slide 19

Slide 19 text

Surviving Code Reviews & Tech Interviews 19

Slide 20

Slide 20 text

How do we collectively improve? Surviving Code Reviews & Tech Interviews

Slide 21

Slide 21 text

Presentation theme goes here Deﬁne success as a team 21 Surviving Code Reviews & Tech Interviews

Slide 22

Slide 22 text

Establish a team Operating System Surviving Code Reviews & Tech Interviews 22

Slide 23

Slide 23 text

“The ultimate goal is to improve the quality of the code and the product, and any unpleasant tones of one-upmanship should be avoided. Remember that the code is not the author and the author is not the code. Do not take or make things personal.” 23 Surviving Code Reviews & Tech Interviews

Slide 24

Slide 24 text

Codify as a team how to provide feedback Surviving Code Reviews & Tech Interviews 24

Slide 25

Slide 25 text

Feedback should be actionable Surviving Code Reviews & Tech Interviews 25

Slide 26

Slide 26 text

Feedback should be in context Surviving Code Reviews & Tech Interviews 26

Slide 27

Slide 27 text

Feedback should not do the work for someone Surviving Code Reviews & Tech Interviews 27

Slide 28

Slide 28 text

A note on “assume positive intent”

Slide 29

Slide 29 text

assume positive intent == burden on the receiver

Slide 30

Slide 30 text

assume people are   smart competent  here for a reason

Slide 31

Slide 31 text

Bullet-proof PRs •Are small •Provide context 31 Surviving Code Reviews & Tech Interviews

Slide 32

Slide 32 text

Good feedback •Actionable •In context •Sets people on the right path 32 Surviving Code Reviews & Tech Interviews

Slide 33

Slide 33 text

Slide 34

Slide 34 text

Tech interviews Surviving Code Reviews & Tech Interviews 34

Slide 35

Slide 35 text

The rule about technical interview club is… Surviving Code Reviews & Tech Interviews 35

Slide 36

Slide 36 text

Surviving Code Reviews & Tech Interviews 36

Slide 37

Slide 37 text

Surviving Code Reviews & Tech Interviews 37

Slide 38

Slide 38 text

Surviving Code Reviews & Tech Interviews

Slide 39

Slide 39 text

People perform inconsistently Surviving Code Reviews & Tech Interviews 39

Slide 40

Slide 40 text

Surviving Code Reviews & Tech Interviews 40

Slide 41

Slide 41 text

People suck at gauging their own performance Surviving Code Reviews & Tech Interviews 41

Slide 42

Slide 42 text

Surviving Code Reviews & Tech Interviews

Slide 43

Slide 43 text

"When people think they did poorly, even if they actually didn’t, they may be a lot less likely to want to work with you.” Surviving Code Reviews & Tech Interviews 43

Slide 44

Slide 44 text

Improving the tech interview experience

Slide 45

Slide 45 text

Hiring at Thinkful •Take home code challenge •Talk through solution •Add a feature •Open ended architecture