Review is DEAD - Speaker Deck

Slide 1

Slide 1 text

Review is DEAD Tatsuya “Botcher” Sato

Slide 2

Slide 2 text

Who I am • Tatsuya “Botcher” Sato • @sato_ryu • Rubyist & Scrum Master

Slide 3

Slide 3 text

Botcher? ʲ໊ʳ ʪӳʫ΁΅৬ਓɺमཧͷԼखͳਓ

Slide 4

Slide 4 text

Slide 5

Slide 5 text

ʲ໊ʳ΅ͬͪͳਓ

Slide 6

Slide 6 text

Review is Evil ϨϏϡʔ͸ѱ

Slide 7

Slide 7 text

Evil Reviews

Slide 8

Slide 8 text

Evil Reviews Code Review Specification Review Design Review

Slide 9

Slide 9 text

Review as a Gate

Slide 10

Slide 10 text

When the evils appear Specification Design Code

Slide 11

Slide 11 text

When the evils appear Specification Design Code Review Review Review

Slide 12

Slide 12 text

When the evils appear Speciﬁcation Design Code Review Review Review • Each Review stops the progress. • Each Review makes us go back to the beginning.

Slide 13

Slide 13 text

“The GateKeeper” Reviewer

Slide 14

Slide 14 text

“The GateKeeper” Reviewer • “Reviewer” vs “Reviewee” • Reviewer believes s/he SHOULD point out anything as possible. • Review makes UNWISHED WARS.

Slide 15

Slide 15 text

Diversity of Background

Slide 16

Slide 16 text

Diversity of Background • Pros • Diversity of view points • Cons • Need communications for CONSENSUS.

Slide 17

Slide 17 text

All Reviews Should be Passed

Slide 18

Slide 18 text

Wastes much time…

Slide 19

Slide 19 text

–Wikipedia http://en.wikipedia.org/wiki/Development_hell “development hell is a state during which a ﬁlm or other project remains in development without progressing to production.”

Slide 20

Slide 20 text

Review is Evil ϨϏϡʔ͸ѱ

Slide 21

Slide 21 text

ॾ܅ɺ ඞཁͳ͜ͱ͸ Կ͔ʁ

Slide 22

Slide 22 text

Consensus

Slide 23

Slide 23 text

Consensus • σϓϩΠͯ͠΋ྑ͍ͱ͍͏߹ҙ • ίʔυʹࣗ৴Λ࣋ͯΔͱ͍͏߹ҙ

Slide 24

Slide 24 text

Review is DEAD?

Slide 25

Slide 25 text

Review is still Alive ϨϏϡʔ͸ੜ͖͍ͯΔɻ

Slide 26

Slide 26 text

Code Review is alive

Slide 27

Slide 27 text

Discovery increases over phases Specification Design Code Discovery

Slide 28

Slide 28 text

Code Review is still alive • Two passback do NOT make sense. • But pass back from Code Review has emergency but valuable Speciﬁcation Design Code Review Review Review

Slide 29

Slide 29 text

How? Ͳ͏΍Δͷ͔ʁ

Slide 30

Slide 30 text

Backlog Refinement

Slide 31

Slide 31 text

Backlog Refinement • The process through which product backlog items are reviewed by the Scrum team and revised, providing more detail and ensuring that there is greater clarity in the requirements for that item.