Slide 1

Slide 1 text

Dispelling The ‘Genius Programmer’ Myth 
 (Through Code Review) Ashwini Oruganti twitter.com/@_ashfall_ DjangoCon US 2016

Slide 2

Slide 2 text

✦ Software Engineer, Eventbrite ✦ (ex) Director, Python Software Foundation ✦ PyCA/TLS ✦ Twisted, HippyVM

Slide 3

Slide 3 text

Slide 4

Slide 4 text

No content

Slide 5

Slide 5 text

Genius!

Slide 6

Slide 6 text

No content

Slide 7

Slide 7 text

Open Source Contributions!

Slide 8

Slide 8 text

Slide 9

Slide 9 text

Fears of a new programmer

Slide 10

Slide 10 text

Clever people don’t make mistakes, right?

Slide 11

Slide 11 text

Leaders exist. Heroes don’t.

Slide 12

Slide 12 text

Why won’t you “just merge it”?

Slide 13

Slide 13 text

“I hope that’s not my project” -Every maintainer in the room

Slide 14

Slide 14 text

Contributing Basics

Slide 15

Slide 15 text

contributing.txt

Slide 16

Slide 16 text

Respect the process

Slide 17

Slide 17 text

Split reviews into smaller diffs.

Slide 18

Slide 18 text

Work with your reviewer.

Slide 19

Slide 19 text

Criticism is not evil.

Slide 20

Slide 20 text

No content

Slide 21

Slide 21 text

Iterate failures quickly.

Slide 22

Slide 22 text

Document every effort.

Slide 23

Slide 23 text

Hi Maintainers!

Slide 24

Slide 24 text

Social problems cannot be solved with technical solutions.

Slide 25

Slide 25 text

If you care deeply about a style, document it *visibly*.

Slide 26

Slide 26 text

It’s OK to not like things, be nice about it.

Slide 27

Slide 27 text

“Nope. Nope. Nope. Nope. Nope. Never.”

Slide 28

Slide 28 text

1. Mention the change. 2. Provide a self-contained example. 3. Describe the effects of the change.

Slide 29

Slide 29 text

Respect the volunteer’s time. “Thanks! This looks really good. IPv6 has a number of subtleties, so I have quite a few review comments, but I want to emphasize that the code does look good and you’re definitely going in the right direction. :)”

Slide 30

Slide 30 text

Contributor Maintainer

Slide 31

Slide 31 text

There’s no such thing as “not qualified enough”.

Slide 32

Slide 32 text

It’s alright to miss things.

Slide 33

Slide 33 text

twitter.com/@_ashfall_ Thank You!