Slide 1
Slide 1 text
#SFBLJOH$IBOHF
<ഁյతมߋ>
$MPTJOH,FZOPUF
גࣜձࣾ%3&$0.
!LPJD&4.
*OD
4BU
ฏ3VCZձٞ
Slide 2
Slide 2 text
!LPJD,PJDIJ*50
w 3VCP$PQ$PNNJUUFS
w "30SBDMFFOIBODFE
BEBQUFS$PNNJUUFS
w $PNNVOJUZ.BOBHFS
BU&4.
*OD
Slide 3
Slide 3 text
8SJUF 3FWJFX
$PEF&WFSZ%BZ
Slide 4
Slide 4 text
No content
Slide 5
Slide 5 text
No content
Slide 6
Slide 6 text
#VOEMFS
1SZ
34QFD
3VCP$PQ
CZFCVH
3VCZ,BJHJ
%3&$0.͞Μϒʔεʹͯ
Slide 7
Slide 7 text
No content
Slide 8
Slide 8 text
044ίϛϡχςΟͱͷڞੜΛࢧԉ
Support coexistence with OSS community
Slide 9
Slide 9 text
͋ͱ͔Γ·͢Ͷʁ
࠾༻
Ҏ্ͷ3BJMTΞϓϦ։ൃͷ࣮&4.
l3BJMT044Λ௨͍ͨ͡͠ϓϩάϥϚʔz
@koicまでどうぞ
Slide 10
Slide 10 text
IUUQTIFJTFJSCHJUIVCJPLBJHJ
Slide 11
Slide 11 text
IUUQTIFJTFJSCHJUIVCJPLBJHJ
Slide 12
Slide 12 text
#SFBLJOH$IBOHF
<ഁյతมߋ>
$MPTJOH,FZOPUF
גࣜձࣾ%3&$0.
,PJDIJ*50&4.
*OD
4BU
ฏ3VCZձٞ
Slide 13
Slide 13 text
͜ͷߨԋͰಘΒΕΔ͔͠Εͳ͍͜ͱ
w ςετͱCVOEMFVQEBUFͷॏཁ
ੑͷ࠶ೝࣝ
w 3VCP$PQͷࣼΊ্ͷ͍ํ
w ࢲ͔Βݟͨ044ͷੈք؍
w ഁյతมߋͷͨΊʹ͋ͳ͕ͨͰ͖Δ
͔͠Εͳ͍͜ͱ
Slide 14
Slide 14 text
w ഁյతมߋͱԿ͔ʁ
w ެࡁΈΠϯλϑΣʔεΛ͏
w ඇਪܯࠂόʔδϣϯΛܦ༝͢Δ
w ഁյతมߋΛΓӽ͑Δ
w ΦʔϓϯιʔείϛϡχςΟ
ΞδΣϯμ
Slide 15
Slide 15 text
ഁյతมߋ
ͱԿ͔ʁ
Slide 16
Slide 16 text
CVHTSVCZMBOHPSHJTTVFT
3FBMLFZXPSEBSHVNFOU
Slide 17
Slide 17 text
IUUQTXXXSVCZMBOHPSHKBOFXTSVCZQSFWJFXSFMFBTFE
Slide 18
Slide 18 text
No content
Slide 19
Slide 19 text
To be continued…
Slide 20
Slide 20 text
CVHTSVCZMBOHPSHJTTVFT
3FHFYQ\NBUDI
NBUDI ^XJUIBOJMBSHVNFOUBSF
EFQSFDBUFEBOEXJMMSBJTFB5ZQF&SSPSJO3VCZ
Slide 21
Slide 21 text
҆ఆ൛ͷ3VCZ[
% rbenv shell 2.6.5 && ruby -e 'p /re/.match?(nil)'
false
Slide 22
Slide 22 text
։ൃ൛ͷ3VCZ
% rbenv shell 2.6.5 && ruby -e 'p /re/.match?(nil)'
false
% rbenv shell 2.7.0-preview2 && ruby -e 'p /re/.match?
(nil)'
Traceback (most recent call last):
1: from -e:1:in `'
-e:1:in `match?': no implicit conversion of nil into
String (TypeError)
QSFWJFX
Slide 23
Slide 23 text
։ൃ൛ͷ3VCZ
% rbenv shell 2.6.5 && ruby -e 'p /re/.match?(nil)'
false
% rbenv shell 2.7.0-preview2 && ruby -e 'p /re/.match?
(nil)'
Traceback (most recent call last):
1: from -e:1:in `'
-e:1:in `match?': no implicit conversion of nil into
String (TypeError)
% rbenv shell 2.7.0-preview3 && ruby -e 'p /re/.match?
(nil)'
-e:1: warning: given argument is nil; this will raise a
TypeError in the next release
false QSFWJFX
Slide 24
Slide 24 text
IUUQTCMPHBHJMFFTNDPKQFOUSZSBJMTPTTQBUDINFFUVQ
ύονձͰʹ
Slide 25
Slide 25 text
IUUQTUXJUUFSDPNLBNJQPTUBUVT
Slide 26
Slide 26 text
IUUQTUXJUUFSDPNLBNJQPTUBUVT
Slide 27
Slide 27 text
IUUQTUXJUUFSDPNOBMTITUBUVT
Slide 28
Slide 28 text
IUUQTUXJUUFSDPNZVLJIJSP@NBU[TUBUVT
Slide 29
Slide 29 text
IUUQTCVHTSVCZMBOHPSHJTTVFT
3FWFSU
Slide 30
Slide 30 text
ഁյతมߋ
ͱԿ͔ʁ
Slide 31
Slide 31 text
w CVOEMFVQEBUFޙ
w 3VCZͷόʔδϣϯΛ͋͛ͨޙ
w ͦͷ΄͔ϛυϧΣΞΛߋ৽ͨ͠ޙ
ར༻ίʔυͷޙํޓΛͳ͘͢มߋ
ҎલͱҟͳΔ݁ՌΛҾ͖ى͜͠͏Δมߋ
‑
Slide 32
Slide 32 text
w ެ։͞Εͨ"1*ͷ໊લ͕มΘΔ
w ެ։͞Εͨ"1*ͷҾ͕มΘΔ
w ެ։͞Εͨ"1*ͷΓ͕มΘΔ
w ެ։͞Εͨ"1*ͷৼΔ͍͕มΘΔ
w όάpYͱඇޓมߋظͷҧ͍
ͲΜͳഁյతมߋ͕͋Δͷ͔ʁ
Slide 33
Slide 33 text
ެ։"1*
ඇެ։"1*
Slide 34
Slide 34 text
%FQFOEPO
1VCMJTIFE"1*
公開APIへの依存
Slide 35
Slide 35 text
IUUQTCMJLJKBHJUIVCJP1VCMJTIFE*OUFSGBDF
Slide 36
Slide 36 text
0CKFDU0SJFOUFE
1SPHSBNJOH
Slide 37
Slide 37 text
҆ఆʹґଘͤΑ
SDP: Stable Dependency Principle
Slide 38
Slide 38 text
w ιϑτΣΞมԽ͠ଓ͚Δ
w ҆ఆͨ͠"1*ͱෆ҆ఆͳ"1*͕͋Δ
w ઃܭશʹݻఆͰ͖ͳ͍ͨΊɺෆ
҆ఆΛڐ͢Έ͕ඞཁ
w ෆ҆ఆͳ"1*͕ѱ͍ͷͰͳ͘ɺෆ
҆ఆͳ"1*ʹґଘ͢Δͷ͕ѱ͍͜ͱ
4%1҆ఆґଘͷ๏ଇ
Slide 39
Slide 39 text
w ෦తͳ"1*ͱ໌ࣔ͞Ε͍ͯΔ"1*
Θͳ͍
w 3BJMTʹ͓͍ͯϝιουίϝϯτ
͕͋ΔEPDʹө͞ΕΔϝιου͕
ެ։"1*ͱͳΔ
w ඇެ։"1*ʹґଘ͢ΔͱͲ͏ͳΔʁ
3VCZ3VCZPO3BJMT
Slide 40
Slide 40 text
%FQFOEPO
*OUFSOBM"1*
⾮公開APIへの依存
Slide 41
Slide 41 text
8JUIHSFBUQPXFS
DPNFTHSFBU
SFTQPOTJCJMJUZ
⼤いなる⼒には⼤いなる責任が伴う
Slide 42
Slide 42 text
MTFHBMZBSE
SVCZ@QBSTFSSCBEEWPJE@TUNUUPJOTFSU@DPNNFOUT
MPPQ
Slide 43
Slide 43 text
SVCZSVCZ!FGCDB
Slide 44
Slide 44 text
3FNPWFBOJOUFSOBM"1*
෦"1*
શআ
Slide 45
Slide 45 text
SFRVJSFFSSPS
෦"1*
Slide 46
Slide 46 text
෦"1*ͷґଘΛճආ͢Δ
Slide 47
Slide 47 text
SBJMTSBJMT
3FNPWFVTFMFTT
A.JHSBUPSTDIFNB@NJHSBUJPOT@UBCMF@OBNFA
Slide 48
Slide 48 text
෦"1*
Slide 49
Slide 49 text
෦"1*
3BJMTͰϝιουίϝϯτ͕ه͞Ε͍ͯͳ͍ͷඇެ։
"1*ͱ͍͏ѻ͍ͱͳ͍ͬͯΔ
Slide 50
Slide 50 text
আࡁ"1*
ͷஔ
Slide 51
Slide 51 text
% ag 'Migrator\.schema_migrations_table_name' `ghq root`
HIRཧͷMPDBMSFQPΛ۲͠ݕࡧ
Ͳ͏ͩΖ͏ʁ
Slide 52
Slide 52 text
% ag 'Migrator\.schema_migrations_table_name' `ghq root`
HIRཧͷMPDBMSFQPΛ۲͠ݕࡧ
݁Ռͱ͍͔ͯͭ͘͠ώοτͨ͠
‑
Slide 53
Slide 53 text
෦"1*ͷґଘͷ࣮ྫ
IUUQTHJUIVCDPNFTNJODBEIPRQVMM
Slide 54
Slide 54 text
෦"1*ͷґଘͷ࣮ྫ
IUUQTHJUIVCDPNBNBUTVEBEBUBCBTF@SFXJOEFSQVMM
Slide 55
Slide 55 text
w ෦"1*ϥΠϒϥϦఏڙऀ͕࣮
ʹԠͯ͡มߋ͠͏Δ
w ͭ·Γಥવͦͷ"1*͕ͳ͘ͳͬͯ
/P.FUIPE&SSPS͕ى͖ΔͳͲ
w ྫ͑3BJMTΛΞοϓσʔτͨ͠Β
ະରԠґଘ(FNͰΤϥʔ͕ى͖Δ
%PO`UEFQFOEPOJOUFSOBM"1*
Slide 56
Slide 56 text
ඇਪܯࠂͷఏҊ͕͞ΕΔ
削除の前に⾮推奨警告しませんか。 バックリ
ンクに⽰された多くのGemが使⽤してる。
Slide 57
Slide 57 text
w ຊདྷ෦"1*ʹґଘ͢Δͷ͕ྑ͘
ͳ͍͕ɺใࠂ͕݅ͦΕͳΓʹ͋ͬ
ͨͱϝϯςφʔʹײ͡ΒΕ༷ͨ
w ͓ͦΒ͔͘ͳΓಛघέʔε
w ҰํͰެ։"1*ͷมߋϢʔβʔ
ӨڹΛߟྀ͖͢
ඇਪܯࠂ
Slide 58
Slide 58 text
ඇਪܯࠂͷՃ
IUUQTHJUIVCDPNSBJMTSBJMTQVMM
Slide 59
Slide 59 text
ඇਪܯࠂʹΑΔઆ໌
IUUQTHJUIVCDPNKSVCZBDUJWFSFDPSEKECDBEBQUFSQVMM
Slide 60
Slide 60 text
w ॲཧܥϥΠϒϥϦ͕ܯࠂΛग़͍ͯ
ΔόʔδϣϯΛܦ༝ͯ͠ɺܯࠂΛ௵
͔ͯ͠Β࣍ͷόʔδϣϯʹ্͛Δ
w ͳΔ͘ϋΠδϟϯϓΛආ͚Δ
w ࠒ͔ΒCVOEMFVQEBUFΛ͠
ͯɺςετΛ࣮ߦ͢Δ
ΞϓϦέʔγϣϯ։ൃऀͷᅂΈ
Slide 61
Slide 61 text
ഁյతมߋ
ͱԿ͔ʁ
͔Γ·
͔ͨ͠ʁ
Slide 62
Slide 62 text
w ͦͦιϑτΣΞ։ൃ͍͠
w ͬͱ͍͍ͩ͢Ζ͏ઃܭ͕͋Ε
ɺͰ͖Εͦ͏͍ͨ͠ ᷤ౻
w ιϑτΣΞਓ͕࡞͍ͬͯΔ
w ͭ·Γެ։"1*Ͱᷤ౻ͷɺഁյ
͞ΕΔ ͢Δ
͜ͱ͕͋Δ
ެ։"1*Λ͑ى͖ͳ͍ʁ
Slide 63
Slide 63 text
'BLFS
#SFBLJOH$IBOHF
#Z&YBNQMF
Slide 64
Slide 64 text
No content
Slide 65
Slide 65 text
w ͋Δɺ3BJMTΞϓϦέʔγϣϯΛ
CVOEMFVQEBUFͯ͠ςετΛ࣮
ߦͨ͠ΒಥવͷΤϥʔ͕ى͖Δ
'BLFSͰى͖ͨഁյతมߋ
Slide 66
Slide 66 text
'BLFSZ[
Faker::Address.zip_code('NY') # => "25771"
Slide 67
Slide 67 text
'BLFS[
Faker::Address.zip_code('NY')
% bundle exec ruby example.rb
Traceback (most recent call last):
1: from example.rb:3:in `'
/Users/koic/.rbenv/versions/2.6.3/lib/ruby/gems/
2.6.0/gems/faker-2.1.2/lib/faker/default/
address.rb:32:in
`zip_code': wrong number of arguments (given 1,
expected 0) (ArgumentError)
Slide 68
Slide 68 text
'BLFS[ ղܾ൛
-Faker::Address.zip_code('NY')
+Faker::Address.zip_code(state_abbreviation: 'NY')
LXBSHT
ʹ͢Δ
Slide 69
Slide 69 text
w ࣗͷ߹ॳखʹHFNEJGGΛͬ
ͯࠩΛ֬ೝͨ͠Γɺίϛοτϝοηʔ
δʹͨ͠Γ͍ͯ͠ΔͷͰͦͷϦϯΫ
ΛݟΔ
VQTUSFBNͷࠩΛݟΔ
% gemdiff
(snip)
faker: 2.8.1 > 2.8.0
https://github.com/faker-ruby/faker/compare/
v2.8.0...v2.8.1
Slide 70
Slide 70 text
มߋཤྺͱ
͍͏ཏ൫
IUUQKBXJLJQFEJBPSHXJLJ&""&""&##&&##"NFEJB'JMF$BOUJOP1MBOJTQIFSFQOH
IUUQTHJUIVCDPNGBLFSSVCZGBLFSCMPC
W$)"/(&-0(NEJNQPSUBOUOPUF
Slide 71
Slide 71 text
No content
Slide 72
Slide 72 text
"1*
Slide 73
Slide 73 text
w "SHVNFOU&SSPSݪҼͱ͔ͯ͠
Γ͍͕͢ɺͲͷΑ͏ͳҾ͕ਖ਼͍͠
͔͔Βͳ͔ͬͨ
w QPTJUJPOBMҾ͔ΒΩʔϫʔυҾ
ͷมߋͰΩʔϫʔυ͕͙͢ʹ͔Βͳ
͔ͬͨ
w "1*ͷҾ
Slide 74
Slide 74 text
w ͕ࣗ౿Μͩ໘ͳ͜ͱɺଞͷਓ
ʹͱͬͯ໘͔͠Εͳ͍
w (FNͷଟ͘3VCZͰॻ͔Ε͍ͯ
Δ
w ύονΛૹΔͷʹࢧোͷ͋ΔϥΠη
ϯεʹग़ձͬͨ͜ͱ͕ͳ͍
ෆศͩͱࢥͬͨΒఏҊ͢Εྑ͍
Slide 75
Slide 75 text
w ΞοϓάϨʔυޙͷ࣮ߦ࣌Ͱ͙͢ʹ
Τϥʔʹ͢ΔͷͰͳ͘ɺઌʹͲͷ
Α͏ͳΠϯλϑΣʔεʹมΘΔͷ͔
ܯࠂΛग़͢
ղܾҊͱͯ͠ߟ͑ͨ͜ͱ
Slide 76
Slide 76 text
GBLFSSVCZGBLFS
"EEXBSOGPSQPTJUJPOBMBSHVNFOUTXIFOVTJOH
'BLFS
Slide 77
Slide 77 text
$POUFYU
Կނඞཁ͔
Slide 78
Slide 78 text
)PX
࣮ϙΠϯτ
Slide 79
Slide 79 text
.FSJU
ͲΜͳಘ͕
Slide 80
Slide 80 text
&YBNQMF
࣮ྫ
Slide 81
Slide 81 text
ίʔυEJGG جຊతͳมߋ
ޓ*'ͷఏڙ
Slide 82
Slide 82 text
ίʔυEJGG جຊతͳมߋ
چ"1*ͷܯࠂ
Slide 83
Slide 83 text
ίʔυEJGG جຊతͳมߋ
w legacy_sourceͱͯ͠ݩͷҾͰ
ड͚ೖΕΔΑ͏ʹ͢Δ
w legacy_source͕͞Εͨ߹ܯ
ࠂΛදࣔͯ͠ɺͦͷΛ༏ઌͯ͠͏
Slide 84
Slide 84 text
ͦΕΛ"1*
Slide 85
Slide 85 text
def saying(legacy_source = NOT_GIVEN, source: nil)
if legacy_source != NOT_GIVEN
warn_with_uplevel 'Passing `source` with the \
1st argument of `Dune.saying` is deprecated. \
Use keyword argument like \
`Dune.saying(source: ...)` instead.',
uplevel: 1
source = legacy_source
end
end
"1*ͷରԠͱ
Slide 86
Slide 86 text
def saying(legacy_source = NOT_GIVEN, source: nil)
if legacy_source != NOT_GIVEN
warn_with_uplevel 'Passing `source` with the \
1st argument of `Dune.saying` is deprecated. \
Use keyword argument like \
`Dune.saying(source: ...)` instead.',
uplevel: 1
source = legacy_source
end
end
ϝιου໊
"1*ͷରԠͱ
Slide 87
Slide 87 text
def saying(legacy_source = NOT_GIVEN, source: nil)
if legacy_source != NOT_GIVEN
warn_with_uplevel 'Passing `source` with the \
1st argument of `Dune.saying` is deprecated. \
Use keyword argument like \
`Dune.saying(source: ...)` instead.',
uplevel: 1
source = legacy_source
end
end
Ҿ໊
"1*ͷରԠͱ
Slide 88
Slide 88 text
def saying(legacy_source = NOT_GIVEN, source: nil)
if legacy_source != NOT_GIVEN
warn_with_uplevel 'Passing `source` with the \
1st argument of `Dune.saying` is deprecated. \
Use keyword argument like \
`Dune.saying(source: ...)` instead.',
uplevel: 1
source = legacy_source
end
end
Ҿͷ
"1*ͷରԠͱ
Slide 89
Slide 89 text
def saying(legacy_source = NOT_GIVEN, source: nil)
if legacy_source != NOT_GIVEN
warn_with_uplevel 'Passing `source` with the \
1st argument of `Dune.saying` is deprecated. \
Use keyword argument like \
`Dune.saying(source: ...)` instead.',
uplevel: 1
source = legacy_source
end
end
σϑΥϧτ
"1*ͷରԠͱ
Slide 90
Slide 90 text
def saying(legacy_source = NOT_GIVEN, source: nil)
if legacy_source != NOT_GIVEN
warn_with_uplevel 'Passing `source` with the \
1st argument of `Dune.saying` is deprecated. \
Use keyword argument like \
`Dune.saying(source: ...)` instead.',
uplevel: 1
source = legacy_source
end
end
ܯࠂจ
"1*ͷରԠͱ
Slide 91
Slide 91 text
"1*
ख࡞ۀ
ͭΒ͍
Slide 92
Slide 92 text
ୡਓϓϩάϥϚʔͷجૅٕज़
ςεςΟϯά
%FWFMPQFS5FTUJOH
ࣗಈԽ
1SPKFDU"VUPNBUJPO
όʔδϣϯཧ
7FSTJPO$POUSPM
Slide 93
Slide 93 text
No content
Slide 94
Slide 94 text
w LXBSHTʹมΘΔલͷ'BLFSͷίϛο
τϋογϡΛखʹೖΕΔ
w खݩͷ'BLFSϦϙδτϦΛͦͷόʔδϣ
ϯʹ͢
w 'BLFSελΠϧͷҠߦΠϯλϑΣʔ
εʹBVUPDPSSFDU͢Δ$PQΛ࡞Δ
w 'BLFSʹ$PQΛద༻ͨ͠ύονΛૹΔ
͜ͷඇਪܯࠂΛ࡞ΔͨΊߦͬͨ͜ͱ
Slide 95
Slide 95 text
w LXBSHTʹมΘΔલͷ'BLFSͷίϛο
τϋογϡΛखʹೖΕΔ
w खݩͷ'BLFSϦϙδτϦΛͦͷόʔδϣ
ϯʹ͢
w 'BLFSελΠϧͷҠߦΠϯλϑΣʔ
εʹBVUPDPSSFDU͢Δ$PQΛ࡞Δ
w 'BLFSʹ$PQΛద༻ͨ͠ύονΛૹΔ
͜ͷඇਪܯࠂΛ࡞ΔͨΊߦͬͨ͜ͱ
Slide 96
Slide 96 text
w 3VCP$PQظ͍ͯ͠ͳ͍ελΠ
ϧͷίʔυΛظ͍ͯ͠Δίʔυʹ
ࣗಈमਖ਼͢ΔػೳΛඋ͍͑ͯΔ
w 3VCP$PQ͕ఏڙ͍ͯ͠Δ$PQΫ
ϥεΛܧঝ͢Δ͜ͱͰΦϦδφϧͷ
$PQΛ࡞Δ͜ͱ͕Ͱ͖Δ
3VCP$PQ͓͞Β͍
Slide 97
Slide 97 text
w ϩʔΧϧϦϙδτϦͷΈͷϒϥϯν
Ͱॻ͖ͳ͙ͬͨͷΛൃ۷͠·ͨ͠
w ͲΜͳҠߦεΫϦϓτΛॻ͍͍ͯͨ
ͷ͔ൈਮͯ͠งғؾΛ͑·͢
w ϝϯςφϯεΛ΄΅ߟ͍͑ͯͳ͍ɺ
γϣοτͷίʔυʹͯޚ༰ࣻئ
ΦϒδΣΫτࢦlεΫϦϓτzݴޠ
Slide 98
Slide 98 text
ԶDPQ͕ظ͢Δ༷
# bad
# def email(
# name: nil,
# separators: nil
# )
#
# good
# def email(
# legacy_name = NOT_GIVEN,
# legacy_separators = NOT_GIVEN,
# name: nil,
# separators: nil
# )
ΩʔϫʔυҾͷΈ
Ͱߏ͞Ε͍ͯΔ
Slide 99
Slide 99 text
CBEέʔεΛଊ͑Δ࣮ྫ
class BreakingChangeArguments < Cop
def on_def(node)
return unless node.arguments.all? {|argument|
argument.kwarg_type? ||
argument.kwoptarg_type?
}
node.arguments.reverse_each do |argument|
message = format(
MSG, name: argument.children.first
)
add_offense(argument, message: message)
end
end
end
Slide 100
Slide 100 text
CBEέʔεΛଊ͑Δ࣮ྫ
class BreakingChangeArguments < Cop
def on_def(node)
return unless node.arguments.all? {|argument|
argument.kwarg_type? ||
argument.kwoptarg_type?
}
node.arguments.reverse_each do |argument|
message = format(
MSG, name: argument.children.first
)
add_offense(argument, message: message)
end
end
end
EFGϊʔυͷॲཧ
Slide 101
Slide 101 text
CBEέʔεΛଊ͑Δ࣮ྫ
class BreakingChangeArguments < Cop
def on_def(node)
return unless node.arguments.all? {|argument|
argument.kwarg_type? ||
argument.kwoptarg_type?
}
node.arguments.reverse_each do |argument|
message = format(
MSG, name: argument.children.first
)
add_offense(argument, message: message)
end
end
end
ܯࠂΛग़͢"1*
Slide 102
Slide 102 text
CBEέʔεΛଊ͑Δ࣮ྫ
class BreakingChangeArguments < Cop
def on_def(node)
return unless node.arguments.all? {|argument|
argument.kwarg_type? ||
argument.kwoptarg_type?
}
node.arguments.reverse_each do |argument|
message = format(
MSG, name: argument.children.first
)
add_offense(argument, message: message)
end
end
end
ܯࠂ͠ͳ͍݅
Slide 103
Slide 103 text
CBEέʔεΛଊ͑Δ࣮ྫ
class BreakingChangeArguments < Cop
def on_def(node)
return unless node.arguments.all? {|argument|
argument.kwarg_type? ||
argument.kwoptarg_type?
}
node.arguments.reverse_each do |argument|
message = format(
MSG, name: argument.children.first
)
add_offense(argument, message: message)
end
end
end
ܯࠂ͠ͳ͍݅
ϊʔυͷλΠϓ
% ruby-parse -e 'def do_something(foo:, bar: 1);
end'
(def :do_something
(args
(kwarg :foo)
(kwoptarg :bar
(int 1))) nil)
Slide 104
Slide 104 text
class BreakingChangeArguments < Cop
def on_def(node)
return unless node.arguments.all? {|argument|
argument.kwarg_type? ||
argument.kwoptarg_type?
}
node.arguments.reverse_each do |argument|
message = format(
MSG, name: argument.children.first
)
add_offense(argument, message: message)
end
end
end
ܯࠂ͠ͳ͍݅
% ruby-parse -e 'def do_something(foo:, bar: 1);
end'
(def :do_something
(args
(kwarg :foo)
(kwoptarg :bar
(int 1))) nil)
CBEέʔεΛଊ͑Δ࣮ྫ
ϊʔυͷλΠϓ
Slide 105
Slide 105 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
def autocorrect(node)
kwarg = node.children.first
argument_index =
node.parent.parent.arguments.map {|argument|
argument.children.first
}.index(kwarg) + 1
index = case argument_index
when 1; '1st'
when 2; '2nd'
when 3; '3rd'
else
"#{argument_index}th"
end
Slide 106
Slide 106 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
def autocorrect(node)
kwarg = node.children.first
argument_index =
node.parent.parent.arguments.map {|argument|
argument.children.first
}.index(kwarg) + 1
index = case argument_index
when 1; '1st'
when 2; '2nd'
when 3; '3rd'
else
"#{argument_index}th"
end
ࣗಈमਖ਼
ͷίʔϧόοΫ
ఆٛ
Slide 107
Slide 107 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
def autocorrect(node)
kwarg = node.children.first
argument_index =
node.parent.parent.arguments.map {|argument|
argument.children.first
}.index(kwarg) + 1
index = case argument_index
when 1; '1st'
when 2; '2nd'
when 3; '3rd'
else
"#{argument_index}th"
end
LXBSHͷ
ϊʔυ
Slide 108
Slide 108 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
def autocorrect(node)
kwarg = node.children.first
argument_index =
node.parent.parent.arguments.map {|argument|
argument.children.first
}.index(kwarg) + 1
index = case argument_index
when 1; '1st'
when 2; '2nd'
when 3; '3rd'
else
"#{argument_index}th"
end
LXBSHͷ
ҾҐஔ
Slide 109
Slide 109 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
legacy_argument = "legacy_#{kwarg}"
class_name = find_class_name(node)
method_name = node.parent.parent.method_name
condition += <<-RUBY
if #{legacy_argument} != NOT_GIVEN
warn_with_uplevel 'Passing `#{kwarg}` with
the #{index} argument of
`#{class_name}.#{method_name}` is deprecated. Use
keyword argument like `#{class_name}.#{method_name}
(#{kwarg}: ...)` instead.', uplevel: 1
#{kwarg} = #{legacy_argument}
end
RUBY
Slide 110
Slide 110 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
legacy_argument = "legacy_#{kwarg}"
class_name = find_class_name(node)
method_name = node.parent.parent.method_name
condition += <<-RUBY
if #{legacy_argument} != NOT_GIVEN
warn_with_uplevel 'Passing `#{kwarg}` with
the #{index} argument of
`#{class_name}.#{method_name}` is deprecated. Use
keyword argument like `#{class_name}.#{method_name}
(#{kwarg}: ...)` instead.', uplevel: 1
#{kwarg} = #{legacy_argument}
end
RUBY
ޓมͷ࡞
Slide 111
Slide 111 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
legacy_argument = "legacy_#{kwarg}"
class_name = find_class_name(node)
method_name = node.parent.parent.method_name
condition += <<-RUBY
if #{legacy_argument} != NOT_GIVEN
warn_with_uplevel 'Passing `#{kwarg}` with
the #{index} argument of
`#{class_name}.#{method_name}` is deprecated. Use
keyword argument like `#{class_name}.#{method_name}
(#{kwarg}: ...)` instead.', uplevel: 1
#{kwarg} = #{legacy_argument}
end
RUBY
private
def find_class_name(node)
if node.class_type?
return node.identifier.source
end
find_class_name(node.parent)
end
Slide 112
Slide 112 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
legacy_argument = "legacy_#{kwarg}"
class_name = find_class_name(node)
method_name = node.parent.parent.method_name
condition += <<-RUBY
if #{legacy_argument} != NOT_GIVEN
warn_with_uplevel 'Passing `#{kwarg}` with
the #{index} argument of
`#{class_name}.#{method_name}` is deprecated. Use
keyword argument like `#{class_name}.#{method_name}
(#{kwarg}: ...)` instead.', uplevel: 1
#{kwarg} = #{legacy_argument}
end
RUBY
ࣗಈमਖ਼ίʔυͷ
ஔจࣈྻ
Slide 113
Slide 113 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
lambda do |corrector|
corrector.insert_before(
arguments_range(node),
"#{legacy_argument} = NOT_GIVEN, "
)
corrector.insert_before(
node.parent.parent.children.last.source_range,
condition
)
end
Slide 114
Slide 114 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
lambda do |corrector|
corrector.insert_before(
arguments_range(node),
"#{legacy_argument} = NOT_GIVEN, "
)
corrector.insert_before(
node.parent.parent.children.last.source_range,
condition
)
end
मਖ਼ίʔυ
ͷஔ
Slide 115
Slide 115 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
lambda do |corrector|
corrector.insert_before(
arguments_range(node),
"#{legacy_argument} = NOT_GIVEN, "
)
corrector.insert_before(
node.parent.parent.children.last.source_range,
condition
)
end
ޓҾͷૠೖ
Slide 116
Slide 116 text
CBEέʔεΛࣗಈमਖ਼͢Δ࣮ྫ
lambda do |corrector|
corrector.insert_before(
arguments_range(node),
"#{legacy_argument} = NOT_GIVEN, "
)
corrector.insert_before(
node.parent.parent.children.last.source_range,
condition
)
end
ܯࠂ݅ͷૠೖ
Slide 117
Slide 117 text
No content
Slide 118
Slide 118 text
͓Ϛʔδ
Slide 119
Slide 119 text
ϢʔβʔͷԠ
Feedback
Slide 120
Slide 120 text
GBLFSSVCZGBLFS
USJHHFSTEFQSFDBUJPOXBSOJOHTGSPNJOTJEFUIF
HFN
Slide 121
Slide 121 text
⾮推奨警告の量が半端なくて⼤変だったよ
Slide 122
Slide 122 text
w ,ಥવͷΤϥʔΛճආ͢Δඇਪ
ܯࠂ͕׆༻͞ΕͨΑ͏Ͱ͋Δ
w 1ͷഁյతมߋΛܸ͢Δ
ͱͭΒͦ͏Ͱ͋Δ
w 5ࣗಈमਖ਼ՄೳͳπʔϧΛఏڙ͠
ͯΞοϓάϨʔυͷ௧ΈΛݮΒ͢
ϑΟʔυόοΫʹରͯ͠ߟ͑ͨ͜ͱ
Slide 123
Slide 123 text
LPJDSVCPDPQGBLFS
"3VCP$PQFYUFOTJPOGPS'BLFS
Slide 124
Slide 124 text
w ͔ͭͯ34QFD͔Β34QFD
ͷҠߦͰͬͨ5SBOTQFDʹӨڹ
Λड͚ͯ࡞ͬͨ(FN
w 'BLFSʹඇਪܯࠂΛೖΕΔ13Λ
࡞ΔաఔͰ͍ͭͰʹฒߦͯ͠࡞Ζ͏
ͱ͍ͯͨ͠Α͏ͳ ͏Ζ֮͑
Ұܳ։ൃΛՃ͢Δ
Slide 125
Slide 125 text
No content
Slide 126
Slide 126 text
No content
Slide 127
Slide 127 text
ઌͷ࣮ͱࣅͨ
Α͏ͳͷͳͷ
Ͱ࣮ղઆׂѪ
Slide 128
Slide 128 text
l
(FN࡞͚ͬͨͩͰউख
ʹ·ΔΘ͚Ͱͳ͘Θ
ΕΔͨΊͷͻͱॏཁ
!BNBUTVEB
Slide 129
Slide 129 text
Slide 130
Slide 130 text
IUUQTXXXNPVOUBJOHPBUTPGUXBSFDPNCMPHBSFPGGFBUVSFTSFBMMZSBSFMZPSOFWFSVTFE
Slide 131
Slide 131 text
ࢲ͕ࢥ͍͍ͭͨ
͜ͷ՝ʹର͠
࠷ڧͷએํ๏
Slide 132
Slide 132 text
VQTUSFBN
ʹऔΓࠐΜ
ͰΒ͏
Slide 133
Slide 133 text
GBLFSSVCZGBLFS
*ODMVEFSVCPDPQGBLFSBVUPDPSSFDUJOEFQSFDBUJPO
Slide 134
Slide 134 text
No content
Slide 135
Slide 135 text
$POUFYU
લྫΛग़͢
Slide 136
Slide 136 text
)PX
ղܾࡦ
Slide 137
Slide 137 text
&YBNQMF
࣮ྫ
Slide 138
Slide 138 text
.FSJU
ͲΜͳಘ͕
Slide 139
Slide 139 text
৺ͩͬͨ
Slide 140
Slide 140 text
No content
Slide 141
Slide 141 text
͓Ϛʔδ
Slide 142
Slide 142 text
ͦͷޙ
Afterwards
Slide 143
Slide 143 text
GBLFSSVCZGBLFS
6TJOHLXBSHTGPSNFUIPETUIBUBDDFQUPOMZPOF
BSHVNFOUJTJOF⒏DJFOU
Slide 144
Slide 144 text
引数ひとつにkwargsはやりすぎじゃね？
Slide 145
Slide 145 text
8*1GPS'BLFS
Slide 146
Slide 146 text
8*1GPS'BLFS
To be continued…
Slide 147
Slide 147 text
w ࠷ॳ͔Βऑͷͳ͍ઃܭΛ͢Δͷ͍͠
w ιϑτΣΞΛΑΓྑ͍ܗʹ͢ΔͨΊʹɺࢭΉΛ
ಘͣޙํޓΛؾʹ͔͚ͭͭఘΊΔ߹͕͋Δ
w CVOEMFVQEBUFͰখ͞ͳϦϓϨʔεΛ܁Γฦ
͢͜ͱͰେ͖ͳϦϓϨʔεΛ͙
w มߋൣғ͕ڱ͍ํ͕ݪҼͷಛఆ͕༰қ
w ͋ͳͨͱ·ΘΓݹ͍όʔδϣϯ͔৽͍͠όʔδϣ
ϯͲͪΒΛ͏ͷ͕ΈͰ͔͢ʁ
ഁյతมߋΛӽ͑Δ
Slide 148
Slide 148 text
όʔδϣϯӽ͑
lޙੈʹ͢ͷz
ະདྷ
Slide 149
Slide 149 text
w ͋ͳͨʹΑͬͯෆඞཁ͔ͩͬͨ͠Εͳ͍
ഁյతͳมߋΛࢭΊΔ͜ͱ͕Ͱ͖Δ͔͠
Εͳ͍
w ͋ͳͨʹΑͬͯഁյతͳมߋͷμϝʔδ
Λ؇Ͱ͖Δ͔͠Εͳ͍
w ·ͣखݩͷඇਪܯࠂΛݟͯΈΑ͏
w ΈΜͳͰ3VCZͷΞοϓ
άϨʔυࣗຫΛ͍͖ͯ͠·͠ΐ͏
͋ͳ͕ͨίϛϡχςΟ
Slide 150
Slide 150 text
l
ίϛϡχςΟͱ୭͔ɻͪΖ
Μɺ͋ͳͨͷ͜ͱͩɻ͋ͳ͕ͨ
ίϛϡχςΟͰ͋ΓɺͦΕҎ֎
ʹίϛϡχςΟ͍ͳ͍ɻ͋ͳ
ͨͷΑ͏ͳਓʑͷू·ΓΛɺί
ϛϡχςΟͱݺͿͷͩɻ
IUUQTNBHB[JOFSVCZJTUOFUBSUJDMFT'PSF8PSEIUNM
Community is yourself
Slide 151
Slide 151 text
No content