Slide 1

Slide 1 text

Refactoring to the rescue @gurgelrenan

Slide 2

Slide 2 text

Renan Gurgel

Slide 3

Slide 3 text

No content

Slide 4

Slide 4 text

No content

Slide 5

Slide 5 text

Views

Slide 6

Slide 6 text

Models

Slide 7

Slide 7 text

Controllers

Slide 8

Slide 8 text

No content

Slide 9

Slide 9 text

200 ms to 20 ms

Slide 10

Slide 10 text

No content

Slide 11

Slide 11 text

Dicas para melhorar a qualidade de código

Slide 12

Slide 12 text

Atualize as dependências

Slide 13

Slide 13 text

No content

Slide 14

Slide 14 text

Atualize o Ruby

Slide 15

Slide 15 text

No content

Slide 16

Slide 16 text

Use uma ferramenta de análise de código

Slide 17

Slide 17 text

No content

Slide 18

Slide 18 text

No content

Slide 19

Slide 19 text

No content

Slide 20

Slide 20 text

Use uma ferramenta de CI

Slide 21

Slide 21 text

No content

Slide 22

Slide 22 text

No content

Slide 23

Slide 23 text

#1 N + 1

Slide 24

Slide 24 text

Source: http://guides.rubyonrails.org/active_record_querying.html#eager-loading- associations

Slide 25

Slide 25 text

Source: http://guides.rubyonrails.org/active_record_querying.html#eager-loading- associations

Slide 26

Slide 26 text

1 load client Source: http://guides.rubyonrails.org/active_record_querying.html#eager-loading- associations

Slide 27

Slide 27 text

1 load client Source: http://guides.rubyonrails.org/active_record_querying.html#eager-loading- associations

Slide 28

Slide 28 text

Source: http://guides.rubyonrails.org/active_record_querying.html#eager-loading- associations

Slide 29

Slide 29 text

1 load client N load address Source: http://guides.rubyonrails.org/active_record_querying.html#eager-loading- associations

Slide 30

Slide 30 text

Source: http://guides.rubyonrails.org/active_record_querying.html#eager-loading- associations

Slide 31

Slide 31 text

Source: http://guides.rubyonrails.org/active_record_querying.html#eager-loading- associations

Slide 32

Slide 32 text

#2 Null Object

Slide 33

Slide 33 text

NoMethodError: undefined method user_type for nil:NilClass

Slide 34

Slide 34 text

Source: https://robots.thoughtbot.com/rails-refactoring-example-introduce-null-object

Slide 35

Slide 35 text

Source: https://medium.com/@franzejr/null-object-pattern-in-ruby-12a809bc75cc

Slide 36

Slide 36 text

Source: https://medium.com/@franzejr/null-object-pattern-in-ruby-12a809bc75cc

Slide 37

Slide 37 text

No content

Slide 38

Slide 38 text

No content

Slide 39

Slide 39 text

#3 Tell don’t ask

Slide 40

Slide 40 text

Dizer o que um objeto deve fazer Ao invés de perguntar

Slide 41

Slide 41 text

No content

Slide 42

Slide 42 text

No content

Slide 43

Slide 43 text

No content

Slide 44

Slide 44 text

No content

Slide 45

Slide 45 text

#4 Service Objects

Slide 46

Slide 46 text

Actions Complexas

Slide 47

Slide 47 text

Actions envolvendo múltiplos models

Slide 48

Slide 48 text

Interagindo com serviços externos

Slide 49

Slide 49 text

No content

Slide 50

Slide 50 text

No content

Slide 51

Slide 51 text

#5 Decorator

Slide 52

Slide 52 text

Remover lógica das views

Slide 53

Slide 53 text

https://github.com/drapergem/draper

Slide 54

Slide 54 text

app/views/articles/show.html.erb

Slide 55

Slide 55 text

app/views/articles/show.html.erb

Slide 56

Slide 56 text

No content

Slide 57

Slide 57 text

app/decorators/article_decorator.rb

Slide 58

Slide 58 text

app/views/articles/show.html.erb

Slide 59

Slide 59 text

Material de estudo

Slide 60

Slide 60 text

No content

Slide 61

Slide 61 text

No content

Slide 62

Slide 62 text

https://refactoringrails.io

Slide 63

Slide 63 text

No content

Slide 64

Slide 64 text

Finalizando…

Slide 65

Slide 65 text

Cuide bem do seu código

Slide 66

Slide 66 text

Microservices >>> Monolítico

Slide 67

Slide 67 text

Depende do seu contexto

Slide 68

Slide 68 text

Alto acoplamento

Slide 69

Slide 69 text

Design ruim

Slide 70

Slide 70 text

@nandovieira

Slide 71

Slide 71 text

Não adianta extrair código, se ele continua ruim

Slide 72

Slide 72 text

Obrigado :)