動作するきれいなコード / Clean code that works - SeleniumConf Tokyo 2019

Slide 1

Slide 1 text

ςετۦಈ։ൃ ͷ 5BLVUP8BEB !U@XBEB "QS !4FMFOJVN$POG5PLZP $MFBODPEFUIBUXPSLT )PXDBOXFHPUIFSF

Slide 2

Slide 2 text

#SeConfTokyo $BNFSBTBMMPXFE .BUFSJBMTBSFUPCFQVCMJTIFE 5XFFUJOHXFMDPNFE )FMMP

Slide 3

Slide 3 text

UXBEB U@XBEB UXBEB 5BLVUP8BEB

Slide 4

Slide 4 text

5BLVUP8BEB - Consultant - Programmer guided by tests - Loves FLOSS - Creator of power-assert-js

Slide 5

Slide 5 text

5IF#PPLT*XPSLFEPO

Slide 6

Slide 6 text

l5IF8JME4BWBOOBI-JPOz.FNF

Slide 7

Slide 7 text

No content

Slide 8

Slide 8 text

assert(typeof item.id === 'strong') | | | | | | | false | | "foo" | Item{id:"foo",name:"bar"} "string" --- [string] 'strong' +++ [string] typeof item.id @@ -1,6 +1,6 @@ str -o +i ng Representative work: power-assert-js IUUQTHJUIVCDPNQPXFSBTTFSUKTQPXFSBTTFSU

Slide 9

Slide 9 text

-FUTHFUTUBSUFE

Slide 10

Slide 10 text

No content

Slide 11

Slide 11 text

l$MFBODPEFUIBUXPSLT JO3PO+F⒎SJFT QJUIZQISBTF JTUIFHPBMPG5FTU%SJWFO %FWFMPQNFOU 5%% $MFBODPEFUIBU XPSLTJTBXPSUIXIJMFHPBMGPSBXIPMF CVODIPGSFBTPOTz ᴷ,FOU#FDL 5FTU%SJWFO%FWFMPQNFOUCZ&YBNQMF

Slide 12

Slide 12 text

l$MFBODPEFUIBUXPSLTJTPVUPGUIF SFBDIPGFWFOUIFCFTUQSPHSBNNFST TPNFPGUIFUJNF BOEPVUPGUIFSFBDI PGNPTUQSPHSBNNFST MJLFNF NPTUPG UIFUJNF%JWJEFBOEDPORVFS CBCZz ᴷ,FOU#FDL 5FTU%SJWFO%FWFMPQNFOUCZ&YBNQMF

Slide 13

Slide 13 text

$MFBODPEFUIBUXPSLT $MFBODPEFUIBUXPSLT $MFBODPEFUIBUXPSLT

Slide 14

Slide 14 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT

Slide 15

Slide 15 text

Clean Dirty Doesn’t work Works Two Ways $MFBODPEFUIBUXPSLT

Slide 16

Slide 16 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT

Slide 17

Slide 17 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT

Slide 18

Slide 18 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT Bog

Slide 19

Slide 19 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT Bog Shame

Slide 20

Slide 20 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT Bog Vanity Shame

Slide 21

Slide 21 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT Bog Vanity Shame Perfectionism

Slide 22

Slide 22 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT Bog Vanity Shame Perfectionism Analysis Paralysis

Slide 23

Slide 23 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT

Slide 24

Slide 24 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT

Slide 25

Slide 25 text

l%JWJEFBOEDPORVFS CBCZ 'JSTUXFMMTPMWFUIFlUIBUXPSLTzQBSUPG UIFQSPCMFN 5IFOXFMMTPMWFUIFlDMFBODPEFzQBSUz ᴷ,FOU#FDL 5FTU%SJWFO%FWFMPQNFOUCZ&YBNQMF

Slide 26

Slide 26 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT

Slide 27

Slide 27 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT Bog

Slide 28

Slide 28 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT Bog Laziness

Slide 29

Slide 29 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT Bog Laziness Impatience

Slide 30

Slide 30 text

Clean Dirty Doesn’t work Works $MFBODPEFUIBUXPSLT Bog Laziness Impatience Fear

Slide 31

Slide 31 text

l*GJUJTXPSLJOH EPO`UDIBOHFz IUUQTXXXqJDLSDPNQIPUPT!/

Slide 32

Slide 32 text

&EJUBOE1SBZ

Slide 33

Slide 33 text

$PWFSBOE.PEJGZ

Slide 34

Slide 34 text

7FSTJPO $POUSPM 5FTUJOH "VUPNBUJPO 5IF5ISFF1JMMBST

Slide 35

Slide 35 text

7FSTJPO$POUSPM

Slide 36

Slide 36 text

7FSTJPO$POUSPM

Slide 37

Slide 37 text

5FTUJOH

Slide 38

Slide 38 text

$POUJOVPVT *OUFHSBUJPO 9'% "VUPNBUJPO ࣗಈԽ "VUPOPNBUJPO ࣗಇԽ

Slide 39

Slide 39 text

5ISFFMFHHFETUPPM NFUBQIPS ©Artek ( http://www.artek.fi/ )

Slide 40

Slide 40 text

Clean Dirty Doesn’t work Works The way we work $MFBODPEFUIBUXPSLT

Slide 41

Slide 41 text

3FGBDUPSJOH Refactoring (noun): a change made to the internal structure of software to make it easier to understand and cheaper to modify without changing its observable behavior.

Slide 42

Slide 42 text

5IF&OE

Slide 43

Slide 43 text

Clean Dirty Doesn’t work Works l$ZDMFzNBUUFSTNPTU The way we work

Slide 44

Slide 44 text

Red. Write a little test that doesn't work, and perhaps doesn't even compile at first. Green. Make the test work quickly, committing whatever sins necessary in the process. Refactor. Eliminate all of the duplication created in merely getting the test to work.

Slide 45

Slide 45 text

Clean Dirty Doesn’t work Works 5IF(PMEFODZDMFPG5%% Red Green Refactoring

Slide 46

Slide 46 text

Clean Dirty Doesn’t work Works 5IF(PMEFODZDMFPG5%% Red Green Refactoring Impatience

Slide 47

Slide 47 text

"DVSTFPOUIFXPSElSFGBDUPSJOHz

Slide 48

Slide 48 text

#JH3FGBDUPSJOH"DDPVOUBCJMJUZ

Slide 49

Slide 49 text

Clean Dirty Doesn’t work Works %FWXJUIPVU3FGBDUPSJOH %FWXJUIPVU$MFBO$PEF Red Green

Slide 50

Slide 50 text

Clean Dirty Doesn’t work Works %PO`UMFUSFGBDUPSJOHBMPOF Red Green Refactoring

Slide 51

Slide 51 text

"HBJO$ZDMFNBUUFSTNPTU

Slide 52

Slide 52 text

No content

Slide 53

Slide 53 text

No content

Slide 54

Slide 54 text

8IZ 8IBU 8IP 8IBUTIPVME JUCF )PXUPNBLF BOELFFQ UIFNDMFBO $POUJOVPVT %FMJWFSZ "DDFQUBODF 5FTU 6OJU5FTU #Z&JKJ*FOBHB

Slide 55

Slide 55 text

8IZ 6OJU5FTUT

Slide 56

Slide 56 text

Unit Integration E2E Scale Amount of Feedback Internal Quality External Quality

Slide 57

Slide 57 text

External Quality: Correctness, Usability, Efficiency, Reliability, Integrity, Adaptability, Accuracy, Robustness Internal Quality: Maintainability, Flexibility, Portability, Re-usability, Readability, Testability, Understandability

Slide 58

Slide 58 text

l"VUPNBUFE5FTU1ZSBNJEzCZ.JLF$PIO

Slide 59

Slide 59 text

l5FTU4J[FTzBU(PPHMF IUUQTUFTUJOHHPPHMFCMPHDPNUFTUTJ[FTIUNM

Slide 60

Slide 60 text

medium small large Define SML on your own

Slide 61

Slide 61 text

l'*345z 'JWFSVMFTPGDMFBOUFTUT

Slide 62

Slide 62 text

'BTU *OEFQFOEFOU 3FQFBUBCMF 4FMG7BMJEBUJOH 5JNFMZ

Slide 63

Slide 63 text

l"53*1z 1SPQFSUJFTPG(PPE5FTUT

Slide 64

Slide 64 text

"VUPNBUFE 5IPSPVHI 3FQFBUBCMF *OEFQFOEFOU 1SPGFTTJPOBM

Slide 65

Slide 65 text

*OUFSTFDUJPOPG '*345 BOE "53*1

Slide 66

Slide 66 text

'BTU *OEFQFOEFOU 3FQFBUBCMF 4FMG7BMJEBUJOH 5JNFMZ "VUPNBUFE 5IPSPVHI 3FQFBUBCMF *OEFQFOEFOU 1SPGFTTJPOBM

Slide 67

Slide 67 text

'BTU *OEFQFOEFOU 3FQFBUBCMF 4FMG7BMJEBUJOH 5JNFMZ "VUPNBUFE 5IPSPVHI 3FQFBUBCMF *OEFQFOEFOU 1SPGFTTJPOBM

Slide 68

Slide 68 text

ʰY6OJU5FTU1BUUFSOTʱ .BJOUFOBODF$PTU PG5FTUDPEF *EFBM 3FBMJUZ

Slide 69

Slide 69 text

The code you write for a unit test is real; some may argue it's even more real than the code you ship to customers. This means that it must be written and maintained to the same professional standards as your production code. Test code is real code.

Slide 70

Slide 70 text

Clean Dirty Doesn’t work Works 3FDBQ5IF(PMEFODZDMFPG5%% Red Green Refactoring

Slide 71

Slide 71 text

TDD can't guarantee that we will have flashes of insight at the right moment. However, confidence-giving tests and carefully factored code give us preparation for insight, and preparation for applying that insight when it comes. ─ Kent Beck

Slide 72

Slide 72 text

5IBOLZPV BDUT@BT@QSPGFTTJPOBM