Tweet
Tweet

Slide 1

Slide 1 text

Code Reviews FTW! Prague, 6th February 2013 Josef Reidinger David Majda &

Slide 2

Slide 2 text

Why? 1

Slide 3

Slide 3 text

better code better design bus factor learning feel for quality social pressure

Slide 4

Slide 4 text

How? 2

Slide 5

Slide 5 text

Code Change Pull Request Review Merge Accept Reject

Slide 6

Slide 6 text

Checklist 3

Slide 7

Slide 7 text

1. Is it easy to read? 2. Do I understand what it does? 3. Boy scout rule 4. Can I make it better?

Slide 8

Slide 8 text

Code Quality 4

Slide 9

Slide 9 text

Have I Already Seen This?

Slide 10

Slide 10 text

Easy to Extend?

Slide 11

Slide 11 text

Covered by Tests?

Slide 12

Slide 12 text

Are Errors Handled?

Slide 13

Slide 13 text

Follows Coding Style?

Slide 14

Slide 14 text

Has Proper Level of Abstraction?

Slide 15

Slide 15 text

Is The Change Isolated?

Slide 16

Slide 16 text

Bugs Are Social!

Slide 17

Slide 17 text

Overengineering!

Slide 18

Slide 18 text

Social Aspects 5

Slide 19

Slide 19 text

No content

Slide 20

Slide 20 text

No content

Slide 21

Slide 21 text

No content

Slide 22

Slide 22 text

No content

Slide 23

Slide 23 text

Challenges 6

Slide 24

Slide 24 text

Big Branches

Slide 25

Slide 25 text

The Never Ending Story

Slide 26

Slide 26 text

Act like you start maintaining it tomorrow!