These classes are no where to be found:
!
.avatar-upload-label
.billing-extra-yolo
.login-form-fixed
Stale selectors and partials
Slide 30
Slide 30 text
These selectors are too damn complicated:
!
#adv_code_search .enterprise .site-search .search-page-label:
body.page-profile .profilecols .tabnav .pagehead-actions li.t
.discussion-hidden .timeline-comment-content .timeline-commen
.prose-diff > .markdown-body li .wraps-task-list-item-checkbo
Deep selectors
Slide 31
Slide 31 text
Stylesheets should not contain js- prefixed classes:
!
.js-avatar-uploader
.js-prorated-for-days
.js-branch-name-suggestion
Special prefixed classes
Slide 32
Slide 32 text
Stylesheets should not contain js- prefixed classes:
!
.js-avatar-uploader
.js-prorated-for-days
.js-branch-name-suggestion
Special prefixed classes
git grep -n '[#.]js-' -- app/assets/stylesheets
Slide 33
Slide 33 text
Accessibility
Slide 34
Slide 34 text
Limited resources ➡️ Reactive
Slide 35
Slide 35 text
No content
Slide 36
Slide 36 text
No content
Slide 37
Slide 37 text
The ALT attribute
if(!img.hasAttribute('alt')) {
console.warn(“Missing alt attribute on", img)
}
if(!img.hasAttribute('alt')) {
console.warn(“Missing alt attribute on", img)
}