ϞςΔίʔυͷॻ͖ํ 2022/7/30 Grow fi t TechLTձ Ώ͏͖ΌΜ

ࣗݾ঺հ • גࣜձࣾROLO • ΤϯδχΞྺ͸13೥ • ૊ΈࠐΈܥ͔Βឯ༨ۂં͋ͬͯWebܥʹస޲ • PHP/Laravel͕޷͖ • झຯ͸HADO

ϞςΔίʔυ͔ɺ ϞςΔίʔυҎ֎͔ɻ ੈͷதʹ͸2छྨͷίʔυ͕͋Δ

ඇϞςίʔυΛॻ͘ͱ あの⼈のコードちょっと臭う... さわりたくない... ⼀緒に仕事したくない>< 控えめに⾔ってうんコード

ඇϞςίʔυͱϞςίʔυ 4બ

ඇϞςίʔυᶃ

class Hoge { public function foo($arg): string { if ($arg === 'bar') { return 'bar'; } return 'piyo'; } } ඇϞςίʔυ💩

ݟͨ໨͕Ԛ͍🙅 • ΠϯσϯτͷཚΕ͸৺ͷཚΕ • Πϯσϯτ่͕Ε͍ͯΔͱݏΘΕΔ

class Hoge { public function foo($arg): string { if ($arg === 'bar') { return 'bar'; } return 'piyo'; } } Ϟςίʔυ🏄

1ߦ1ߦ͍ͯͶ͍ʹॻ͘🙆 • ΠϯσϯτɺۭߦɺεϖʔεΛஸೡʹ • ͢΂ͯͷߦͱจࣈʹ੹೚Λ࣋ͭ

ඇϞςίʔυᶄ

public function isActiveUser(User $user): bool { if ($user !== null) { if ($user->email_verified_at !== null) { if ($user->last_logined_at > new DateTime('-1 year')) { return true; } else { return false; } } else { return false; } } else { return false; } } ඇϞςίʔυ💩

৚͕݅ଟ͍உ͸Ϟςͳ͍🙅 • elseจ͕ͨ͘͞Μ͋ΔͱಡΈʹ͘͘ͳΔ • ͜Ε΋ݟͨ໨͸ྑ͘ͳ͍

public function isActiveUser(User $user): bool { if ($user !== null) { return false; } if ($user->email_verified_at === null) { return false; } if ($user->last_logined_at <= new DateTime('-1 year')) { return false; } return true; } Ϟςίʔυ🏄

ૣظϦλʔϯΛ࢖͏🙆 • Ψʔυઅͱ΋ݴ͏ • ifจ͸elseΛͳ͘͢ͱಡΈ΍͘͢ͳΔ • ωετΛݮΒͯ͠ɺ೴಺ϝϞϦΛઅ໿

ඇϞςίʔυᶅ

try { $hogeService->handle(); } catch (Exception $e) { } ඇϞςίʔυ💩

ΤϥʔΛӅ͢உ͸Ϟςͳ͍ • ΤϥʔΛແࢹͨ͠ΓӅṭͯ͠͸͍͚ͳ͍ • ίʔυ͕௥͍ʹ͘͘ͳΔ

try { $hogeService->handle(); } catch (Exception $e) { $this->logger->error($e->getMesage()); } Ϟςίʔυ🏄

ྫ֎͸ѲΓͭͿ͞ͳ͍🙆 • ྫ֎͕ى͖ͨΒॲཧΛதࢭ͢Δͷ͕جຊ • ॲཧΛࢭΊͨ͘ͳ͍৔߹͸ඞͣϩάΛ࢒͢ • ϩά͔Β௥͍΍͘͢͢Δ

ඇϞςίʔυᶆ

final class HogeService { public function execute() { $slackNotification = new SlackNotification(); if ($isProduction) { $slackNotification->send('Success!'); } } } ඇϞςίʔυ💩

ਓʹΑͬͯଶ౓Λม͑Δͷ͸ Ϟςͳ͍🙅 • ਓ(؀ڥ)ʹΑͬͯଶ౓Λม͑Δͷ͸Ϟςͳ͍

interface SlackNotificationInterface { public function send(string $message): void; } final class SlackNotification implemetns SlackNotificationInterface { public function send(string $message): void { // Slack通知の実装を書く } } final class MockSlackNotification implemetns SlackNotificationInterface { public function send(string $message): void { // 何もしない } } final class HogeService { public function __construct(private SlackNotificationInterface $slackNotification) { } public function execute() { $this->slackNotification->send('Success!'); } } Ϟςίʔυ🏄

NullΦϒδΣΫτύλʔϯ Λ࢖͏🙆 • Slack௨஌༻ͷΠϯλʔϑΣʔεΛ༻ҙ͢Δ • ςετ࣌͸Կ΋͠ͳ͍Mockʹࠩ͠ସ͑Δ

·ͱΊ

·ͱΊ • Πϯσϯτ͸େࣄ • ૣظϦλʔϯΛ࢖ͬͯifจΛγϯϓϧʹ • ྫ֎ΛѲΓͭͿ͞ͳ͍ • nullΦϒδΣΫτύλʔϯΛ࢖͏

େ੾ͳ͜ͱ

͜ͷLTΛฉ͍ͯ΋ ࣮ࡍʹϞςΔͱ͸ݶΓ·ͤ Μɻ

͍͞͝ʹ

એ఻Ͱ͢

એ఻1 ฐࣾ(ROLO)Ͱ͸PHP/Laravelͷ Ҋ݅Λେืूͯ͠·͢🙏

એ఻2 • https://github.com/ucan-lab/laravel-dacapo • LaravelͷϚΠάϨʔγϣϯੜ੒αϙʔτ • γϯϓϧͳYAMLදهͰ؅ཧͰ͖Δ • https://github.com/ucan-lab/docker-laravel • LaravelͷDocker؀ڥςϯϓϨʔτ

͓͠·͍👏