Slide 76
Slide 76 text
[] ~/projects/discourse $ jrlint
JRuby-Lint version 0.9.0
./Gemfile:: [gems, info] For more on gem compatibility see http://wiki.jruby.org/C-Extension-Alternatives
./Gemfile:80: [gems, warning] Found gem 'oj' which is reported to have some issues:
Try `gson`, `json` or `json_pure` instead.|
gem 'oj'
./Gemfile:81: [gems, warning] Found gem 'pg' which is reported to have some issues:
Use activerecord-jdbcpostgresql-adapter instead or pg_jruby (drop-in replacement).|
gem 'pg'
./Gemfile:187: [gems, warning] Found gem 'mysql2' which is reported to have some issues:
Use activerecord-jdbcmysql-adapter.|
gem 'mysql2'
./Gemfile:188: [gems, warning] Found gem 'redcarpet' which is reported to have some issues:
Same as with **RDiscount** use alternatives such as kramdown, Maruku or markdown_j|
gem 'redcarpet'
./Gemfile:189: [gems, warning] Found gem 'sqlite3' which is reported to have some issues:
Use activerecord-jdbcsqlite3-adapter.|
gem 'sqlite3', '~> 1.3.13'
./app/mailers/user_notifications.rb:152: [nonatomic, warning] Non-local operator assignment (@popular_topics) is not guaranteed to be atomic.
@popular_topics = topics_for_digest[0, SiteSetting.digest_topics]
./app/mailers/user_notifications.rb:630: [nonatomic, warning] Non-local operator assignment (@site_name) is not guaranteed to be atomic.
@site_name = SiteSetting.email_prefix.presence || SiteSetting.title # used by I18n
./app/models/report.rb:21: [nonatomic, warning] Non-local operator assignment (@start_date) is not guaranteed to be atomic.
@start_date ||= Report.default_days.days.ago.utc.beginning_of_day
./app/models/report.rb:22: [nonatomic, warning] Non-local operator assignment (@end_date) is not guaranteed to be atomic.
@end_date ||= Time.now.utc.end_of_day
./app/models/admin_dashboard_next_data.rb:17: [nonatomic, warning] Non-local operator assignment (@json) is not guaranteed to be atomic.
@json ||= get_json
./app/models/topic_posters_summary.rb:31: [nonatomic, warning] Non-local operator assignment (@descriptions_by_id) is not guaranteed to be atomic.
@descriptions_by_id ||= begin
./app/models/topic_posters_summary.rb:33: [nonatomic, warning] Non-local operator assignment (descriptions[id]) is not guaranteed to be atomic.
descriptions[id] ||= []
./app/models/topic_posters_summary.rb:79: [nonatomic, warning] Non-local operator assignment (@avatar_lookup) is not guaranteed to be atomic.
@avatar_lookup ||= options[:avatar_lookup] || AvatarLookup.new(user_ids)
./app/models/topic_posters_summary.rb:83: [nonatomic, warning] Non-local operator assignment (@primary_group_lookup) is not guaranteed to be atomic.
@primary_group_lookup ||= options[:primary_group_lookup] || PrimaryGroupLookup.new(user_ids)
./app/models/directory_item.rb:8: [nonatomic, warning] Non-local operator assignment (@headings) is not guaranteed to be atomic.
@headings ||= [:likes_received,
./app/models/directory_item.rb:18: [nonatomic, warning] Non-local operator assignment (@types) is not guaranteed to be atomic.
@types ||= Enum.new(all: 1,
./app/models/group_history.rb:11: [nonatomic, warning] Non-local operator assignment (@actions) is not guaranteed to be atomic.
@actions ||= Enum.new(
./app/models/locale_site_setting.rb:10: [nonatomic, warning] Non-local operator assignment (@values) is not guaranteed to be atomic.
@values ||= supported_locales.map do |locale|
./app/models/locale_site_setting.rb:25: [nonatomic, warning] Non-local operator assignment (@language_names) is not guaranteed to be atomic.
@language_names ||= begin
./app/models/locale_site_setting.rb:41: [nonatomic, warning] Non-local operator assignment (@supported_locales) is not guaranteed to be atomic.
@supported_locales ||= begin
./app/models/category.rb:98: [nonatomic, warning] Non-local operator assignment (TOPIC_CREATION_PERMISSIONS) is not guaranteed to be atomic.
TOPIC_CREATION_PERMISSIONS ||= [:full]
./app/models/category.rb:99: [nonatomic, warning] Non-local operator assignment (POST_CREATION_PERMISSIONS) is not guaranteed to be atomic.
POST_CREATION_PERMISSIONS ||= [:create_post, :full]
./app/models/category.rb:109: [nonatomic, warning] Non-local operator assignment (@topic_id_cache) is not guaranteed to be atomic.
@topic_id_cache = DistributedCache.new('category_topic_ids')
./app/models/category.rb:228: [nonatomic, warning] Non-local operator assignment (@@cache) is not guaranteed to be atomic.
@@cache ||= LruRedux::ThreadSafeCache.new(1000)
./app/models/category.rb:520: [nonatomic, warning] Non-local operator assignment (@has_children) is not guaranteed to be atomic.
@has_children ||= (id && Category.where(parent_category_id: id).exists?) ? :true : :false