Less Code, Less Problems Pass 1(of 2) April 2, 2014
 Kansas City PHP User Group Slides: http://johnkary.net/talks John Kary Code Slinger, Build Breaker @johnkary 

0 Survey
 the land 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function setBucketIds($bucketIds){...}
 
 public function setBallIds($ballIds){...}
 
 public function setMinBallsPerBucket($count){...}
 
 public function setMinBucketsPerBall($count){...}
 
 public function run(){...}
 
 public function getResults(){...}
 
 public function getResultsByBall(){...}
 
 public function getMinBucketsPerBall(){...}
 
 public function getMinBallsPerBucket(){...}
 
 public function getBallPoolSize(){...}
 
 public function getStatusMessage(){...}
 
 public function createBallIdPool(){...}
 
 public function checkBallIdForBucketId($ballId, $bucketId){...}
 } CLASS 

TEST 

TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $bucketIds;
 private $ballIds;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->bucketIds = array('a');
 $this->ballIds = array('200');
 
 $results = $this->runDistribution();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 
 // ...
 
 private function runDistribution() {
 $this->dist->setBucketIds($this->bucketIds);
 $this->dist->setBallIds($this->ballIds);
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall);
 
 $this->dist->run();
 
 return $this->dist->getResults();
 }
 } TEST 

1 Masking our PAIN 

1 DRY !== Better 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $bucketIds;
 private $ballIds;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->bucketIds = array('a');
 $this->ballIds = array('200');
 
 $results = $this->runDistribution();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 
 // ...
 
 private function runDistribution() {
 $this->dist->setBucketIds($this->bucketIds);
 $this->dist->setBallIds($this->ballIds);
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall);
 
 $this->dist->run();
 
 return $this->dist->getResults();
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $bucketIds;
 private $ballIds;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->bucketIds = array('a');
 $this->ballIds = array('200');
 
 $this->dist->setBucketIds($this->bucketIds);
 $this->dist->setBallIds($this->ballIds);
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $bucketIds;
 private $ballIds;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->bucketIds = array('a');
 $this->ballIds = array('200');
 
 $this->dist->setBucketIds($this->bucketIds);
 $this->dist->setBallIds($this->ballIds);
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $bucketIds;
 private $ballIds;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->bucketIds = array('a');
 $this->ballIds = array('200');
 
 $this->dist->setBucketIds($this->bucketIds);
 $this->dist->setBallIds($this->ballIds);
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $bucketIds;
 private $ballIds;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->bucketIds = array('a');
 $this->ballIds = array('200');
 
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $bucketIds;
 private $ballIds;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->bucketIds = array('a');
 $this->ballIds = array('200');
 
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $bucketIds;
 private $ballIds;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->setMinBallsPerBucket($this->minBallsPerBucket);
 $this->dist->setMinBucketsPerBall($this->minBucketsPerBall); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->setMinBallsPerBucket(0);
 $this->dist->setMinBucketsPerBall(0); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->setMinBallsPerBucket(0);
 $this->dist->setMinBucketsPerBall(0); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0; ! // ... } CLASS 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->setMinBallsPerBucket(0);
 $this->dist->setMinBucketsPerBall(0); ! $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 $this->dist->run();
 
 $results = $this->dist->getResults();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

use KCPHPUG\BucketBallDistribution;
 
 class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /** @var BucketBallDistribution */
 private $dist;
 
 protected function setUp() {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeOneBucketToOneApp() {
 $this->dist->setBucketIds(array('a'));
 $this->dist->setBallIds(array('200'));
 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('200'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

No content

2Single Responsibility Principle 

2 A class should have
 one
 and only one
 reason to change 

2(I added the next part) 

2 and when it does change
 you should try to
 preserve
 its public API 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function setBucketIds($bucketIds){...}
 
 public function setBallIds($ballIds){...}
 
 public function setMinBallsPerBucket($count){...}
 
 public function setMinBucketsPerBall($count){...}
 
 public function run(){...}
 
 public function getResults(){...}
 
 public function getResultsByBall(){...}
 
 public function getMinBucketsPerBall(){...}
 
 public function getMinBallsPerBucket(){...}
 
 public function getBallPoolSize(){...}
 
 public function getStatusMessage(){...}
 
 public function createBallIdPool(){...}
 
 public function checkBallIdForBucketId($ballId, $bucketId){...}
 } CLASS 

Smell! ! Too many public methods make it unclear how a class is supposed to be used 

Public Methods
 communicate how a class can WILL BE used 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function setBucketIds($bucketIds){...}
 
 public function setBallIds($ballIds){...}
 
 public function setMinBallsPerBucket($count){...}
 
 public function setMinBucketsPerBall($count){...}
 
 public function run(){...}
 
 public function getResults(){...}
 
 public function getResultsByBall(){...}
 
 public function getMinBucketsPerBall(){...}
 
 public function getMinBallsPerBucket(){...}
 
 public function getBallPoolSize(){...}
 
 public function getStatusMessage(){...}
 
 public function createBallIdPool(){...}
 
 public function checkBallIdForBucketId($ballId, $bucketId){...}
 } CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Inform runtime about various state
 public function createBallIdPool()
 public function getBallPoolSize()
 public function checkBallIdForBucketId($ballId, $bucketId)
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Inform runtime about various state
 public function createBallIdPool()
 public function getBallPoolSize()
 public function checkBallIdForBucketId($ballId, $bucketId)
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

Find methods only used internally
 and hide them 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Inform runtime about various state
 public function createBallIdPool()
 public function getBallPoolSize()
 public function checkBallIdForBucketId($ballId, $bucketId)
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Inform runtime about various state
 public function createBallIdPool()
 public function getBallPoolSize()
 public function checkBallIdForBucketId($ballId, $bucketId)
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Inform runtime about various state
 private function createBallIdPool()
 private function getBallPoolSize()
 private function checkBallIdForBucketId($ballId, $bucketId)
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

Smell! ! When an object's public methods must be invoked
 in a specific order to properly use it 

Object Instantiation Rules 

An object should be ! ready to use and impossible to misuse! ! after it has been instantiated Object Instantiation Rules 

An object should be ! ready to use and impossible to misuse! ! after it has been instantiated Object Instantiation Rules Enforce required values in the constructor 

class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function setUp()
 {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array('201','202','203','204','205','206','207','208' $this->dist->setMinBallsPerBucket(1);
 $this->dist->setMinBucketsPerBall(3);
 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function setUp()
 {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array('201','202','203','204','205','206','207','208' $this->dist->setMinBallsPerBucket(1);
 $this->dist->setMinBucketsPerBall(3);
 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function setUp()
 {
 $this->dist = new BucketBallDistribution();
 }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array('201','202','203','204','205','206','207','208' $this->dist->setMinBallsPerBucket(1);
 $this->dist->setMinBucketsPerBall(3);
 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } TEST 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array(‘201','202','203','204','205','206','207','208' $this->dist->setMinBallsPerBucket(1);
 $this->dist->setMinBucketsPerBall(3);
 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->build(3, 1);
 
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array(‘201','202','203','204','205','206','207','208' $this->dist->setMinBallsPerBucket(1);
 $this->dist->setMinBucketsPerBall(3);
 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->build(3, 1);
 
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array(‘201','202','203','204','205','206','207','208' $this->dist->setMinBallsPerBucket(1);
 $this->dist->setMinBucketsPerBall(3);
 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->build(3, 1);
 
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array(‘201','202','203','204','205','206','207','208' $this->dist->setMinBallsPerBucket(1);
 $this->dist->setMinBucketsPerBall(3);
 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->build(3, 1);
 
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array(‘201','202','203','204','205','206','207','208' 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 } ! // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 } ! // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 } ! // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 } ! // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 } ! // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 CLASS 

An object’s configuration should not change after instantiation API Design Principles 

An object’s configuration should not change after instantiation If you need a different configuration create another instance API Design Principles 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 } ! // Set Configuration
 public function setMinBucketsPerBall($count)
 public function setMinBallsPerBucket($count)
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 } ! // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall() ! // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

No content

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 } ! // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 } ! // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

Do not expose getters for values you don’t use yset Do not expose getters for configuration API Design Principles 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 }
 
 // Get Configuration (but based on runtime data?)
 public function getMinBallsPerBucket()
 public function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 }
 
 // Get Configuration (but based on runtime data?)
 private function getMinBallsPerBucket()
 private function getMinBucketsPerBall()
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 // Set Configuration
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0) $this->minBucketsPerBall = $minBucketsPerBall; $this->minBallsPerBucket = $minBallsPerBucket;
 }
 
 // Set runtime data
 public function setBucketIds($bucketIds)
 public function setBallIds($ballIds)
 
 // Main runtime algorithm
 public function run()
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage()
 }
 CLASS 

No content

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->build(3, 1);
 
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array(‘201','202','203','204','205','206','207','208' 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->build(3, 1);
 
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array(‘201','202','203','204','205','206','207','208' 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! public function setBucketIds(array $bucketIds) {
 $this->bucketIds = $bucketIds;
 } ! public function setBallIds(array $ballIds) {
 $this->ballIds = $ballIds;
 }
 
 public function run() {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($this->bucketIds, $this->ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! public function setBucketIds(array $bucketIds) {
 $this->bucketIds = $bucketIds;
 } ! public function setBallIds(array $ballIds) {
 $this->ballIds = $ballIds;
 }
 
 public function run() {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($this->bucketIds, $this->ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! public function setBucketIds(array $bucketIds) {
 $this->bucketIds = $bucketIds;
 } ! public function setBallIds(array $ballIds) {
 $this->ballIds = $ballIds;
 }
 
 public function run() {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($this->bucketIds, $this->ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

Class and Methods Principles 

Class and Methods Principles STATELESS Do not store data during execution 

Class and Methods Principles STATELESS Do not store data during execution DETERMINISTIC Given the same input, the return value is identical 

Class and Methods Principles STATELESS Do not store data during execution IDEMPOTENT Given the same input, the state of the system is identical when the method completes DETERMINISTIC Given the same input, the return value is identical 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->build(3, 1);
 
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array(‘201','202','203','204','205','206','207','208' 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3()
 {
 $this->build(3, 1);
 
 $this->dist->setBucketIds(array('a','b','c','d'));
 $this->dist->setBallIds(array(‘201','202','203','204','205','206','207','208' 
 $results = $this->dist->run();
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 }
 } 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3() {
 $this->build(3, 1);
 
 $bucketIds = array('a', 'b', 'c', 'd');
 $ballIds = array('201', '202', '203', '204', '205', '206', '207', '208', '209 
 $results = $this->dist->run($bucketIds, $ballIds);
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 } } 

TEST class BucketBallDistributionTest extends \PHPUnit_Framework_TestCase
 {
 /**
 * @var BucketBallDistribution
 */
 private $dist;
 
 protected function build($minBucketsPerBall = 0, $minBallsPerBucket = 0)
 {
 $this->dist = new BucketBallDistribution($minBucketsPerBall, $minBallsPerBuck }
 
 public function testDistributeManyBucketToManyAppsLimit3() {
 $this->build(3, 1);
 
 $bucketIds = array('a', 'b', 'c', 'd');
 $ballIds = array('201', '202', '203', '204', '205', '206', '207', '208', '209 
 $results = $this->dist->run($bucketIds, $ballIds);
 $expected = array(
 'a' => array('201','205','209','203','207','204','208'),
 'b' => array('202','206','210','204','208','201','205','209'),
 'c' => array('203','207','201','205','209','202','206','210'),
 'd' => array('204','208','202','206','210','203','207'),
 );
 
 $this->assertEquals($expected, $results);
 } } 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! public function setBucketIds(array $bucketIds) {
 $this->bucketIds = $bucketIds;
 } ! public function setBallIds(array $ballIds) {
 $this->ballIds = $ballIds;
 }
 
 public function run() {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($this->bucketIds, $this->ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! public function setBucketIds(array $bucketIds) {
 $this->bucketIds = $bucketIds;
 } ! public function setBallIds(array $ballIds) {
 $this->ballIds = $ballIds;
 }
 
 public function run() {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($this->bucketIds, $this->ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! public function setBucketIds(array $bucketIds) {
 $this->bucketIds = $bucketIds;
 } ! public function setBallIds(array $ballIds) {
 $this->ballIds = $ballIds;
 }
 
 public function run(array $bucketIds, array $ballIds) {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($this->bucketIds, $this->ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! public function setBucketIds(array $bucketIds) {
 $this->bucketIds = $bucketIds;
 } ! public function setBallIds(array $ballIds) {
 $this->ballIds = $ballIds;
 }
 
 public function run(array $bucketIds, array $ballIds) {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($this->bucketIds, $this->ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! public function setBucketIds(array $bucketIds) {
 $this->bucketIds = $bucketIds;
 } ! public function setBallIds(array $ballIds) {
 $this->ballIds = $ballIds;
 }
 
 public function run(array $bucketIds, array $ballIds) {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($bucketIds, $ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! public function setBucketIds(array $bucketIds) {
 $this->bucketIds = $bucketIds;
 } ! public function setBallIds(array $ballIds) {
 $this->ballIds = $ballIds;
 }
 
 public function run(array $bucketIds, array $ballIds) {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($bucketIds, $ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall; private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! ! ! ! ! ! ! 
 
 public function run(array $bucketIds, array $ballIds) {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($bucketIds, $ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $minBallsPerBucket;
 private $minBucketsPerBall; private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! ! ! ! ! ! ! 
 
 public function run(array $bucketIds, array $ballIds) {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($bucketIds, $ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $minBallsPerBucket;
 private $minBucketsPerBall; private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! ! ! ! ! ! ! 
 
 public function run(array $bucketIds, array $ballIds) {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($bucketIds, $ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $minBallsPerBucket;
 private $minBucketsPerBall; private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! ! ! ! ! ! ! 
 
 public function run(array $bucketIds, array $ballIds) {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($bucketIds, $ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){} ! ! ! ! ! ! ! 
 
 public function run(array $bucketIds, array $ballIds) {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($bucketIds, $ballIds); while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

No content

class BucketBallDistribution
 {
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){ 
 // Main runtime algorithm
 public function run(array $bucketIds, array $ballIds)
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage(array $bucketIds, array $ballIds)
 }
 CLASS 

class BucketBallDistribution
 {
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){ 
 // Main runtime algorithm
 public function run(array $bucketIds, array $ballIds)
 
 // Get results after runtime
 public function getResults()
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage(array $bucketIds, array $ballIds)
 }
 CLASS 

class BucketBallDistribution
 {
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 
 public function getResults() {
 return $this->results;
 } ! public function run() {
 $this->results = array();
 $this->resultsByBall = array();
 
 $ballPool = $this->createBallIdPool($this->bucketIds, $this->ballI while ($ballPool ...) {
 // ...
 $this->results[$bucketId][] = $ballId;
 // ...
 }
 
 return $this->results;
 } } CLASS 

class BucketBallDistribution
 {
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall = 0, $minBallsPerBucket = 0){ 
 // Main runtime algorithm
 public function run(array $bucketIds, array $ballIds)
 
 // Get results after runtime
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage(array $bucketIds, array $ballIds)
 }
 CLASS 

No content

ass BucketBallDistribution
 private $bucketIds = array();
 private $ballIds = array();
 private $minBallsPerBucket = 0;
 private $minBucketsPerBall = 0;
 private $ballPool = array();
 private $results = array();
 private $resultsByBall = array();
 public function setBucketIds($bucketIds){...}
 public function setBallIds($ballIds){...}
 public function setMinBallsPerBucket($count){...}
 public function setMinBucketsPerBall($count){...}
 public function run(){...}
 public function getResults(){...}
 public function getResultsByBall(){...}
 public function getMinBucketsPerBall(){...}
 public function getMinBallsPerBucket(){...}
 public function getBallPoolSize(){...}
 public function getStatusMessage(){...}
 public function createBallIdPool(){...}
 public function checkBallIdForBucketId($ballId, $bucketId){...}
 class BucketBallDistribution
 {
 private $minBallsPerBucket;
 private $minBucketsPerBall;
 private $results = array();
 private $resultsByBall = array();
 
 public function __construct($minBucketsPerBall 
 // Main runtime algorithm
 public function run(array $bucketIds, array $ba 
 // Get results after runtime
 public function getResultsByBall()
 
 // Text describing results
 public function getStatusMessage(array $bucketI 
 

Further Learning Refactoring: Improving the Design of Existing Code
 Martin Fowler, 2000 http://refactoring.com Less: The Path to Better Design
 Sandi Metz (GoRuCo 2011) http://vimeo.com/26330100 Therapeutic Refactoring
 Katrina Owen (2012) http://www.youtube.com/watch?v=J4dlF0kcThQ 

Questions John Kary Code Slinger, Build Breaker @johnkary http://johnkary.net/talks