Github Pull Requests for Everyone

Slide 1

Slide 1 text

GitHub Pull GitHub Pull Requests for Requests for Everyone Everyone tiny.cc/cmeade-gpr-repo tiny.cc/cmeade-gpr-repo speakerdeck.com/catheraaine speakerdeck.com/catheraaine 1

Slide 2

Slide 2 text

✨ NEW BONUS FEATURE: ✨ ✨ NEW BONUS FEATURE: ✨ Code Reviews Code Reviews for Everyone for Everyone tiny.cc/cmeade-gpr-repo tiny.cc/cmeade-gpr-repo 2

Slide 3

Slide 3 text

Catherine Meade Catherine Meade DEVELOPER, SPARKBOX DEVELOPER, SPARKBOX she / her she / her @catheraaine @catheraaine 3

Slide 4

Slide 4 text

How Sparkbox Does How Sparkbox Does Code Reviews Code Reviews 4

Slide 5

Slide 5 text

No content

Slide 6

Slide 6 text

Slide 7

Slide 7 text

RULE ONE RULE ONE No one merges their own code. No one merges their own code. 6

Slide 8

Slide 8 text

RULE TWO RULE TWO Never push directly to master. Never push directly to master. 7

Slide 9

Slide 9 text

RULE THREE RULE THREE If you are working with UI, get a If you are working with UI, get a design review. design review. 8

Slide 10

Slide 10 text

RULE FOUR RULE FOUR If you’re working on copy, get a If you’re working on copy, get a copy review. copy review. 9

Slide 11

Slide 11 text

RULE FIVE RULE FIVE Never, ever push directly to Never, ever push directly to master. master. 10

Slide 12

Slide 12 text

RULE SIX RULE SIX Rules are more like… Rules are more like… guidelines. guidelines. github.com/sparkbox/standard github.com/sparkbox/standard 11

Slide 13

Slide 13 text

Challenges of Collaboration Challenges of Collaboration 12

Slide 14

Slide 14 text

Write Good Stories Write Good Stories 13

Slide 15

Slide 15 text

Slide 16

Slide 16 text

Github Issue Templates Github Issue Templates via GitHub via GitHub tiny.cc/github-issue-templates tiny.cc/github-issue-templates 15

Slide 17

Slide 17 text

Slide 18

Slide 18 text

No content

Slide 19

Slide 19 text

Slide 20

Slide 20 text

Slide 21

Slide 21 text

Github Issue Templates Github Issue Templates via GitHub via GitHub tiny.cc/github-issue-templates tiny.cc/github-issue-templates 19

Slide 22

Slide 22 text

Kasey Bonifacio, Sparkbox Developer Kasey Bonifacio, Sparkbox Developer "Writing Better Release Notes" "Writing Better Release Notes" tiny.cc/foundry-bonifacio tiny.cc/foundry-bonifacio 20

Slide 23

Slide 23 text

Get the Basics Right Get the Basics Right 21

Slide 24

Slide 24 text

Slide 25

Slide 25 text

No content

Slide 26

Slide 26 text

Slide 27

Slide 27 text

No content

Slide 28

Slide 28 text

Slide 29

Slide 29 text

We try to include: We try to include: A quick summary of the work being done. A link to any related stories or issues. A link or screenshot of the original design work. Step-by-step testing instructions. 25

Slide 30

Slide 30 text

No content

Slide 31

Slide 31 text

Slide 32

Slide 32 text

Enhance Your Pull Enhance Your Pull Request: with Gif Request: with Gif 27

Slide 33

Slide 33 text

Slide 34

Slide 34 text

Gifs can be useful. Gifs can be useful. 29

Slide 35

Slide 35 text

Recordit Recordit recordit.co recordit.co 30

Slide 36

Slide 36 text

Slide 37

Slide 37 text

Recordit Recordit recordit.co recordit.co 32

Slide 38

Slide 38 text

Gifox Gifox gifox.io gifox.io

Slide 39

Slide 39 text

Slide 40

Slide 40 text

LICEcap LICEcap licecap.en.softonic.com licecap.en.softonic.com 34

Slide 41

Slide 41 text

Enhance Your Pull Enhance Your Pull Request: with Video Request: with Video 35

Slide 42

Slide 42 text

GoVideo by Vidyard GoVideo by Vidyard vidyard.com/govideo vidyard.com/govideo 36

Slide 43

Slide 43 text

Slide 44

Slide 44 text

GoVideo by Vidyard GoVideo by Vidyard vidyard.com/govideo/ vidyard.com/govideo/ 38

Slide 45

Slide 45 text

Give Valuable Give Valuable Feedback: Skitch Feedback: Skitch 39

Slide 46

Slide 46 text

Skitch by Evernote Skitch by Evernote evernote.com/products/skitch evernote.com/products/skitch 40

Slide 47

Slide 47 text

No content

Slide 48

Slide 48 text

Slide 49

Slide 49 text

Slide 50

Slide 50 text

Slide 51

Slide 51 text

Slide 52

Slide 52 text

Slide 53

Slide 53 text

Skitch by Evernote Skitch by Evernote evernote.com/products/skitch evernote.com/products/skitch 46

Slide 54

Slide 54 text

More Feedback Feedback More Feedback Feedback Offer an alternative. Phone a friend. Choose which hills to die on. Keep the tone light. 47

Slide 55

Slide 55 text

Slide 56

Slide 56 text

Give Valuable Give Valuable Feedback: Be Nice Feedback: Be Nice 49

Slide 57

Slide 57 text

BRYAN BRAUN, SPARKBOX DEVELOPER, EAGLE SCOUT BRYAN BRAUN, SPARKBOX DEVELOPER, EAGLE SCOUT "Stop Giving Depressing Code "Stop Giving Depressing Code Reviews" Reviews" tiny.cc/foundry-braun tiny.cc/foundry-braun 50

Slide 58

Slide 58 text

“Giving positive feedback is an easy habit to adopt. You're already reading through the lines of code, looking for issues. It doesn't take much time to throw in a ‘Nice!’ or ‘Looks great!’ If you see something awesome, say it!” - Bryan Braun tiny.cc/foundry-braun 51

Slide 59

Slide 59 text

Be Nice. Be Nice. 52

Slide 60

Slide 60 text

✨ Take the 2019 Sparkbox Design ✨ Take the 2019 Sparkbox Design Systems Survey ✨ Systems Survey ✨ bit.ly/sb-2019-survey 53

Slide 61

Slide 61 text

Thanks! Thanks! Catherine Meade Catherine Meade DEVELOPER, SPARKBOX DEVELOPER, SPARKBOX | cat@heysparkbox.com | cat@heysparkbox.com @catheraaine @catheraaine tiny.cc/cmeade-gpr-repo bit.ly/sb-2019-survey speakerdeck.com/catheraaine 54