Tweet
Tweet

Slide 1

Slide 1 text

Code reviews @hannesvdvreken @afup #phptour

Slide 2

Slide 2 text

Hi, my name is Hannes.

Slide 3

Slide 3 text

!

Slide 4

Slide 4 text

madewithlove.be

Slide 5

Slide 5 text

Code reviews

Slide 6

Slide 6 text

What’s a code review?

Slide 7

Slide 7 text

push commits review commits reply approve

Slide 8

Slide 8 text

push commits review commits reply approve

Slide 9

Slide 9 text

git add -p WHAT MAKES A CODE REVIEW?

Slide 10

Slide 10 text

No content

Slide 11

Slide 11 text

Why spend time on that?

Slide 12

Slide 12 text

WHY SPEND TIME ON THAT? Why spend time on that? as a submitter:

Slide 13

Slide 13 text

WHY SPEND TIME ON THAT? Why spend time on that? as a reviewer:

Slide 14

Slide 14 text

WHY SPEND TIME ON THAT? Why spend time on that? Management:

Slide 15

Slide 15 text

What should a submitter do?

Slide 16

Slide 16 text

No content

Slide 17

Slide 17 text

What should a reviewer do? or NOT do?

Slide 18

Slide 18 text

don’ts ❌ WHAT SHOULD A REVIEWER DO?

Slide 19

Slide 19 text

do ✓ WHAT SHOULD A REVIEWER DO?

Slide 20

Slide 20 text

No content

Slide 21

Slide 21 text

Language

Slide 22

Slide 22 text

OMG I'M A BIG FAN OF UR CODES LANGUAGE

Slide 23

Slide 23 text

LANGUAGE

Slide 24

Slide 24 text

LANGUAGE

Slide 25

Slide 25 text

LANGUAGE

Slide 26

Slide 26 text

No content

Slide 27

Slide 27 text

No content

Slide 28

Slide 28 text

Wrapping up

Slide 29

Slide 29 text

Thank you! @hannesvdvreken @afup #phptour

Slide 30

Slide 30 text

Time for questions. @hannesvdvreken @afup #phptour