Slide 1
Slide 1 text
TDD - EP 4
codurance.com
Testing anti-patterns - The greedy
catcher, The sequencer, Hidden
dependency and The enumerator
Slide 2
Slide 2 text
Matheus Marabesi
Hello there, you can call me Marabesi,
But my name is Matheus Marabesi, I work at Codurance as a
Software Craftsperson.
I enjoy talking about anything related to: testing, patterns and
gamification.
You can find me at @MatheusMarabesi or https://marabesi.com
Codurance
Crafting Code
Slide 3
Slide 3 text
1. Intro - Recap
2. The greedy catcher
3. The sequencer
4. Hidden dependency
5. The enumerator
6. Wrapping up
Crafting code
Agenda
Slide 4
Slide 4 text
1. Recap
Episode 1, Episode 2, Episode 3
Getting started
Slide 5
Slide 5 text
The Liar
The Giant
The Mockery
The Inspector
Generous Leftovers
The Local Hero
The Nitpicker
The Secret Catcher
The Dodger
The Loudmouth
Anti patterns
The Greedy Catcher
Excessive Setup
The Sequencer
Hidden Dependency
The Enumerator
The Stranger
The Operating System Evangelist
Success Against All Odds
The Free Ride
The One
The Peeping Tom
The Slow Poke
James Carr - TDD Anti-Patterns
Slide 6
Slide 6 text
The Liar 4
The Giant 5
The Mockery
The Inspector
Generous Leftovers
The Local Hero
The Nitpicker
The Secret Catcher
The Dodger
The Loudmouth
Anti patterns
The Greedy Catcher
Excessive Setup 3
The Sequencer
Hidden Dependency
The Enumerator
The Stranger
The Operating System Evangelist
Success Against All Odds
The Free Ride
The One
The Peeping Tom
The Slow Poke 6
Slide 7
Slide 7 text
Anti patterns - Survey takeaways
1. Survey notes: Javascript, PHP and Java were the most used programming languages
2. Survey notes: Practitioners usually informally learn TDD
3. The anti patterns covered were related to test last
4. Subjects we touched around testability: SOLID, Object calisthenics, Non-determinism and the
test pyramid
Slide 8
Slide 8 text
2. Anti-patterns - Episode 4
The greedy catcher, The sequencer,
Hidden dependency and The
enumerator
Getting started
Slide 9
Slide 9 text
The Liar
The Giant
The Mockery
The Inspector
Generous Leftovers
The Local Hero
The Nitpicker
The Secret Catcher
The Dodger
The Loudmouth
Anti patterns
The Greedy Catcher
Excessive Setup
The Sequencer
Hidden Dependency
The Enumerator
The Stranger
The Operating System Evangelist
Success Against All Odds
The Free Ride
The One
The Peeping Tom
The Slow Poke
James Carr - TDD Anti-Patterns
Slide 10
Slide 10 text
The Liar
The Giant
The Mockery
The Inspector
Generous Leftovers
The Local Hero
The Nitpicker
The Secret Catcher
The Dodger
The Loudmouth
Anti patterns
The Greedy Catcher 8
Excessive Setup
The Sequencer 8
Hidden Dependency 2
The Enumerator 9
The Stranger
The Operating System Evangelist
Success Against All Odds
The Free Ride
The One
The Peeping Tom
The Slow Poke
James Carr - TDD Anti-Patterns
Slide 11
Slide 11 text
Challenge time
Crafting code
Which one if faster to understand?
Slide 12
Slide 12 text
describe('Request.headers', function () {
it('should work', async () => {
const { page, server, isChrome } = getTestState();
const response = await page.goto(server.EMPTY_PAGE);
if (isChrome)
expect(response.request().headers()['user-agent']).toContain('Chrome');
else
expect(response.request().headers()['user-agent']).toContain('Firefox');
});
});
describe('Request.headers', function () {
itChromeOnly('should define Chrome as user agent header', async () => {
const { page, server } = getTestState();
const response = await page.goto(server.EMPTY_PAGE);
expect(response.request().headers()['user-agent']).toContain('Chrome');
});
itFirefoxOnly('should define Firefox as user agent header', async () => {
const { page, server } = getTestState();
const response = await page.goto(server.EMPTY_PAGE);
expect(response.request().headers()['user-agent']).toContain('Firefox');
});
});
Puppeteer
A
Slide 13
Slide 13 text
describe('Request.headers', function () {
it('should work', async () => {
const { page, server, isChrome } = getTestState();
const response = await page.goto(server.EMPTY_PAGE);
if (isChrome)
expect(response.request().headers()['user-agent']).toContain('Chrome');
else
expect(response.request().headers()['user-agent']).toContain('Firefox');
});
});
describe('Request.headers', function () {
itChromeOnly('should define Chrome as user agent header', async () => {
const { page, server } = getTestState();
const response = await page.goto(server.EMPTY_PAGE);
expect(response.request().headers()['user-agent']).toContain('Chrome');
});
itFirefoxOnly('should define Firefox as user agent header', async () => {
const { page, server } = getTestState();
const response = await page.goto(server.EMPTY_PAGE);
expect(response.request().headers()['user-agent']).toContain('Firefox');
});
});
Puppeteer
B
Slide 14
Slide 14 text
describe('Request.headers', function () {
it('should work', async () => {
const { page, server, isChrome } = getTestState();
const response = await page.goto(server.EMPTY_PAGE);
if (isChrome)
expect(response.request().headers()['user-agent']).toContain('Chrome');
else
expect(response.request().headers()['user-agent']).toContain('Firefox');
});
});
describe('Request.headers', function () {
itChromeOnly('should define Chrome as user agent header', async () => {
const { page, server } = getTestState();
const response = await page.goto(server.EMPTY_PAGE);
expect(response.request().headers()['user-agent']).toContain('Chrome');
});
itFirefoxOnly('should define Firefox as user agent header', async () => {
const { page, server } = getTestState();
const response = await page.goto(server.EMPTY_PAGE);
expect(response.request().headers()['user-agent']).toContain('Firefox');
});
});
Puppeteer
A
B
Slide 15
Slide 15 text
● Could you spot something that seems to be a smell?
Anti-patterns?
Slide 16
Slide 16 text
● Could you spot something that seems to be a smell?
● Were there anti patterns?
Anti-patterns?
Slide 17
Slide 17 text
2. The greedy catcher - 🏆 8
Crafting code
Slide 18
Slide 18 text
2. The greedy catcher - 🏆 8
A unit test which catches exceptions and
swallows the stack trace, sometimes replacing it
with a less informative failure message, but
sometimes even just logging (c.f. Loudmouth)
and letting the test pass.
Crafting code
Slide 19
Slide 19 text
public function test_retrieve_the_latest_payment_for_a_subscription()
{
$user = $this->createCustomer('retrieve_the_latest_payment_for_a_subscription');
try {
$user->newSubscription('main', static::$priceId)->create('pm_card_threeDSecure2Required');
$this->fail('Expected exception '.IncompletePayment::class.' was not thrown.');
} catch (IncompletePayment $e) {
$subscription = $user->refresh()->subscription('main');
$this->assertInstanceOf(Payment::class, $payment = $subscription->latestPayment());
$this->assertTrue($payment->requiresAction());
}
}
PHP - Laravel/Cashier stripe
Slide 20
Slide 20 text
public function test_retrieve_the_latest_payment_for_a_subscription()
{
$user = $this->createCustomer('retrieve_the_latest_payment_for_a_subscription');
try {
$user->newSubscription('main', static::$priceId)->create('pm_card_threeDSecure2Required');
$this->fail('Expected exception '.IncompletePayment::class.' was not thrown.');
} catch (IncompletePayment $e) {
$subscription = $user->refresh()->subscription('main');
$this->assertInstanceOf(Payment::class, $payment = $subscription->latestPayment());
$this->assertTrue($payment->requiresAction());
}
}
PHP - Laravel/Cashier stripe
Slide 21
Slide 21 text
public function test_retrieve_the_latest_payment_for_a_subscription()
{
$user = $this->createCustomer('retrieve_the_latest_payment_for_a_subscription');
try {
$user->newSubscription('main', static::$priceId)->create('pm_card_threeDSecure2Required');
$this->fail('Expected exception '.IncompletePayment::class.' was not thrown.');
} catch (IncompletePayment $e) {
$subscription = $user->refresh()->subscription('main');
$this->assertInstanceOf(Payment::class, $payment = $subscription->latestPayment());
$this->assertTrue($payment->requiresAction());
}
}
PHP - Laravel/Cashier stripe
Slide 22
Slide 22 text
public function test_retrieve_the_latest_payment_for_a_subscription()
{
$user = $this->createCustomer('retrieve_the_latest_payment_for_a_subscription');
try {
$user->newSubscription('main', static::$priceId)->create('pm_card_threeDSecure2Required');
$this->fail('Expected exception '.IncompletePayment::class.' was not thrown.');
} catch (IncompletePayment $e) {
$subscription = $user->refresh()->subscription('main');
$this->assertInstanceOf(Payment::class, $payment = $subscription->latestPayment());
$this->assertTrue($payment->requiresAction());
}
}
PHP - Laravel/Cashier stripe
Slide 23
Slide 23 text
public function test_retrieve_the_latest_payment_for_a_subscription()
{
$user = $this->createCustomer('retrieve_the_latest_payment_for_a_subscription');
try {
$user->newSubscription('main', static::$priceId)->create('pm_card_threeDSecure2Required');
$this->fail('Expected exception '.IncompletePayment::class.' was not thrown.');
} catch (IncompletePayment $e) {
$subscription = $user->refresh()->subscription('main');
$this->assertInstanceOf(Payment::class, $payment = $subscription->latestPayment());
$this->assertTrue($payment->requiresAction());
}
}
PHP - Laravel/Cashier stripe
Slide 24
Slide 24 text
public function test_retrieve_the_latest_payment_for_a_subscription()
{
$user = $this->createCustomer('retrieve_the_latest_payment_for_a_subscription');
try {
$user->newSubscription('main', static::$priceId)->create('pm_card_threeDSecure2Required');
$this->fail('Expected exception '.IncompletePayment::class.' was not thrown.');
} catch (IncompletePayment $e) {
$subscription = $user->refresh()->subscription('main');
$this->assertInstanceOf(Payment::class, $payment = $subscription->latestPayment());
$this->assertTrue($payment->requiresAction());
}
}
PHP - Laravel/Cashier stripe
Slide 25
Slide 25 text
public function test_retrieve_the_latest_payment_for_a_subscription()
{
$user = $this->createCustomer('retrieve_the_latest_payment_for_a_subscription');
try {
$user->newSubscription('main', static::$priceId)->create('pm_card_threeDSecure2Required');
$this->fail('Expected exception '.IncompletePayment::class.' was not thrown.');
} catch (IncompletePayment $e) {
$subscription = $user->refresh()->subscription('main');
$this->assertInstanceOf(Payment::class, $payment = $subscription->latestPayment());
$this->assertTrue($payment->requiresAction());
}
}
PHP - Laravel/Cashier stripe
Slide 26
Slide 26 text
public function test_retrieve_the_latest_payment_for_a_subscription()
{
$user = $this->createCustomer('retrieve_the_latest_payment_for_a_subscription');
try {
$user->newSubscription('main', static::$priceId)->create('pm_card_threeDSecure2Required');
$this->fail('Expected exception '.IncompletePayment::class.' was not thrown.');
} catch (IncompletePayment $e) {
$subscription = $user->refresh()->subscription('main');
$this->assertInstanceOf(Payment::class, $payment = $subscription->latestPayment());
$this->assertTrue($payment->requiresAction());
}
}
PHP - Laravel/Cashier stripe
Slide 27
Slide 27 text
public function test_retrieve_the_latest_payment_for_a_subscription()
{
$user = $this->createCustomer('retrieve_the_latest_payment_for_a_subscription');
try {
$user->newSubscription('main', static::$priceId)->create('pm_card_threeDSecure2Required');
$this->fail('Expected exception '.IncompletePayment::class.' was not thrown.');
} catch (IncompletePayment $e) {
$subscription = $user->refresh()->subscription('main');
$this->assertInstanceOf(Payment::class, $payment = $subscription->latestPayment());
$this->assertTrue($payment->requiresAction());
}
}
PHP - Laravel/Cashier stripe
Slide 28
Slide 28 text
try {
const token = jwt_decode(req?.cookies['token']);
if (token) {
return null;
} else {
return await logout($auth, redirect);
}
} catch (e) {
return await logout($auth, redirect);
}
Jest
Slide 29
Slide 29 text
try {
const token = jwt_decode(req?.cookies['token']);
if (token) {
return null;
} else {
return await logout($auth, redirect);
}
} catch (e) {
return await logout($auth, redirect);
}
Jest
Slide 30
Slide 30 text
try {
const token = jwt_decode(req?.cookies['token']);
if (token) {
return null;
} else {
return await logout($auth, redirect);
}
} catch (e) {
return await logout($auth, redirect);
}
Jest
Slide 31
Slide 31 text
try {
const token = jwt_decode(req?.cookies['token']);
if (token) {
return null;
} else {
return await logout($auth, redirect);
}
} catch (e) {
return await logout($auth, redirect);
}
Jest
Slide 32
Slide 32 text
try {
const token = jwt_decode(req?.cookies['token']);
if (token) {
return null;
} else {
return await logout($auth, redirect);
}
} catch (e) {
return await logout($auth, redirect);
}
Jest
Slide 33
Slide 33 text
try {
const token = jwt_decode(req?.cookies['token']);
if (token) {
return null;
} else {
return await logout($auth, redirect);
}
} catch (e) {
return await logout($auth, redirect);
}
Jest
Slide 34
Slide 34 text
try {
const token = jwt_decode(req?.cookies['token']);
if (token) {
return null;
} else {
return await logout($auth, redirect);
}
} catch (e) {
return await logout($auth, redirect);
}
Jest
Slide 35
Slide 35 text
try {
const token = jwt_decode(req?.cookies['token']);
if (token) {
return null;
} else {
return await logout($auth, redirect);
}
} catch (e) {
return await logout($auth, redirect);
}
Jest
Slide 36
Slide 36 text
try {
const token = jwt_decode(req?.cookies['token']);
if (token) {
return null;
} else {
return await logout($auth, redirect);
}
} catch (e) {
return await logout($auth, redirect);
}
Jest
Slide 37
Slide 37 text
it('should logout when token is invalid', async () => {
const redirect = jest.fn();
const serverParameters: Partial = {
route: currentRoute as Route, $auth, redirect
};
await actions.nuxtServerInit(
actionContext as ActionContext,
serverParameters as IContextCookie
);
expect($auth.logout).toHaveBeenCalled();
});
Jest
Slide 38
Slide 38 text
it('should logout when token is invalid', async () => {
const redirect = jest.fn();
const serverParameters: Partial = {
route: currentRoute as Route, $auth, redirect
};
await actions.nuxtServerInit(
actionContext as ActionContext,
serverParameters as IContextCookie
);
expect($auth.logout).toHaveBeenCalled();
});
Jest
Slide 39
Slide 39 text
it('should logout when token is invalid', async () => {
const redirect = jest.fn();
const serverParameters: Partial = {
route: currentRoute as Route, $auth, redirect
};
await actions.nuxtServerInit(
actionContext as ActionContext,
serverParameters as IContextCookie
);
expect($auth.logout).toHaveBeenCalled();
});
Jest
Slide 40
Slide 40 text
it('should logout when token is invalid', async () => {
const redirect = jest.fn();
const serverParameters: Partial = {
route: currentRoute as Route, $auth, redirect
};
await actions.nuxtServerInit(
actionContext as ActionContext,
serverParameters as IContextCookie
);
expect($auth.logout).toHaveBeenCalled();
});
Jest
Slide 41
Slide 41 text
it('should logout when token is invalid', async () => {
const redirect = jest.fn();
const serverParameters: Partial = {
route: currentRoute as Route, $auth, redirect
};
await actions.nuxtServerInit(
actionContext as ActionContext,
serverParameters as IContextCookie
);
expect($auth.logout).toHaveBeenCalled();
});
Jest
Slide 42
Slide 42 text
No content
Slide 43
Slide 43 text
Secret catcher, silent catcher
Relates to
Slide 44
Slide 44 text
3. The sequencer - 🏆8
Crafting code
Slide 45
Slide 45 text
3. The sequencer - 🏆8
A unit test that depends on items in an unordered
list appearing in the same order during
assertions.
Crafting code
Slide 46
Slide 46 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 47
Slide 47 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 48
Slide 48 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 49
Slide 49 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 50
Slide 50 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 51
Slide 51 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 52
Slide 52 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 53
Slide 53 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 54
Slide 54 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 55
Slide 55 text
test(contains three fruits', () => {
const expectedFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits[0]).toEqual('banana')
expect(expectedFruits[1]).toEqual('mango')
expect(expectedFruits[2]).toEqual('watermelon')
})
test('contains three fruits', () => {
const expectedFruits = ['mango', 'watermelon', 'banana']
const actualFruits = ['banana', 'mango', 'watermelon']
expect(expectedFruits).toEqual(
expect.arrayContaining(actualFruits)
)
})
Jest - arrays / primitives
Slide 56
Slide 56 text
def test_predictions_returns_a_dataframe_with_automatic_predictions(self,form):
# Given
order_id = "51a64e87-a768-41ed-b6a5-bf0633435e20"
order_info = pd.DataFrame({"order_id": [order_id], "form": [form],})
file_path = Path("tests/data/prediction_data.csv")
service = FileRepository(file_path)
# When
result = get_predictions(main_service=service, order_info=order_info)
# Then
assert list(result.columns) == ["id", "quantity", "country", "form", "order_id"]
Python
Slide 57
Slide 57 text
def test_predictions_returns_a_dataframe_with_automatic_predictions(self,form):
# Given
order_id = "51a64e87-a768-41ed-b6a5-bf0633435e20"
order_info = pd.DataFrame({"order_id": [order_id], "form": [form],})
file_path = Path("tests/data/prediction_data.csv")
service = FileRepository(file_path)
# When
result = get_predictions(main_service=service, order_info=order_info)
# Then
assert list(result.columns) == ["id", "quantity", "country", "form", "order_id"]
Python
Slide 58
Slide 58 text
def test_predictions_returns_a_dataframe_with_automatic_predictions(self,form):
# Given
order_id = "51a64e87-a768-41ed-b6a5-bf0633435e20"
order_info = pd.DataFrame({"order_id": [order_id], "form": [form],})
file_path = Path("tests/data/prediction_data.csv")
service = FileRepository(file_path)
# When
result = get_predictions(main_service=service, order_info=order_info)
# Then
assert list(result.columns) == ["id", "quantity", "country", "form", "order_id"]
Python
Slide 59
Slide 59 text
def test_predictions_returns_a_dataframe_with_automatic_predictions(self,form):
# Given
order_id = "51a64e87-a768-41ed-b6a5-bf0633435e20"
order_info = pd.DataFrame({"order_id": [order_id], "form": [form],})
file_path = Path("tests/data/prediction_data.csv")
service = FileRepository(file_path)
# When
result = get_predictions(main_service=service, order_info=order_info)
# Then
assert list(result.columns) == ["id", "quantity", "country", "form", "order_id"]
Python
Slide 60
Slide 60 text
def test_predictions_returns_a_dataframe_with_automatic_predictions(self,form):
# Given
order_id = "51a64e87-a768-41ed-b6a5-bf0633435e20"
order_info = pd.DataFrame({"order_id": [order_id], "form": [form],})
file_path = Path("tests/data/prediction_data.csv")
service = FileRepository(file_path)
# When
result = get_predictions(main_service=service, order_info=order_info)
# Then
assert list(result.columns) == ["id", "quantity", "country", "form", "order_id"]
Python
Slide 61
Slide 61 text
tests/test_predictions.py::TestPredictions::test_predictions_returns_a_dataframe_with_automatic_pr
edictions FAILED [100%]
tests/test_predictions.py:16
(TestPredictions.test_predictions_returns_a_dataframe_with_automatic_predictions)
['id', 'quantity', 'form', 'country', 'order_id'] != ['id', 'quantity', 'country', 'form',
'order_id']
Expected :['id', 'quantity', 'country', 'form', 'order_id']
Actual :['id', 'quantity', 'form', 'country', 'order_id']
Python
Slide 62
Slide 62 text
def test_predictions_returns_a_dataframe_with_automatic_predictions(self,form):
# Given
order_id = "51a64e87-a768-41ed-b6a5-bf0633435e20"
order_info = pd.DataFrame({"order_id": [order_id], "form": [form],})
file_path = Path("tests/data/prediction_data.csv")
service = FileRepository(file_path)
# When
result = get_predictions(main_service=service, order_info=order_info)
# Then
assert list(result.columns) == ["id", "quantity", "country", "form", "order_id"]
Python
Slide 63
Slide 63 text
def test_predictions_returns_a_dataframe_with_automatic_predictions(self,form):
# Given
order_id = "51a64e87-a768-41ed-b6a5-bf0633435e20"
order_info = pd.DataFrame({"order_id": [order_id], "form": [form],})
file_path = Path("tests/data/prediction_data.csv")
service = FileRepository(file_path)
# When
result = get_predictions(main_service=service, order_info=order_info)
# Then
assert ("id" in result.columns and "quantity" in result.columns and "country" in result.columns
and "form" in result.columns and "order_id" in result.columns)
Python
Slide 64
Slide 64 text
def test_predictions_returns_a_dataframe_with_automatic_predictions(self,form):
# Given
order_id = "51a64e87-a768-41ed-b6a5-bf0633435e20"
order_info = pd.DataFrame({"order_id": [order_id], "form": [form],})
file_path = Path("tests/data/prediction_data.csv")
service = FileRepository(file_path)
# When
result = get_predictions(main_service=service, order_info=order_info)
# Then
assert set(result.columns) == {"id", "quantity", "country", "form", "order_id"}
Python
Slide 65
Slide 65 text
Points of attention
● Know your data structures
● Think about the role the order plays in a collection
Slide 66
Slide 66 text
4. Hidden dependency - 🏆2
Crafting code
Slide 67
Slide 67 text
4. Hidden dependency - 🏆2
A unit test that requires some existing data to have
been populated somewhere before the test runs. If
that data wasn’t populated, the test will fail and
leave little indication to the developer what it
wanted, or why… forcing them to dig through acres
of code to find out where the data it was using was
supposed to come from.
Crafting code
Slide 68
Slide 68 text
query: str = """
select
product.id
po.order_id,
po.quantity,
product.country
from product
join purchased as pur on pur.product_id = product.id
join purchased_order as po on po.purchase_id = cur.id
where product.completed is true and
pur.type = 'MANUAL' and
product.is_test is true
;
"""
Python
Slide 69
Slide 69 text
def test_dbdatasource_is_able_to_load_products_related_only_to_manual_purchase(
self, db_resource
):
# Given
config_file_path = Path("./tests/data/configs/docker_config.json")
expected_result = pd.read_csv("./tests/data/manual_product_info.csv")
datasource = DBDataSource(config_file_path=config_file_path)
# When
result = datasource.get_manual_purchases()
# Then
assert result.equals(expected_result)
Python
Slide 70
Slide 70 text
def test_dbdatasource_is_able_to_load_products_related_only_to_manual_purchase(
self, db_resource
):
# Given
config_file_path = Path("./tests/data/configs/docker_config.json")
expected_result = pd.read_csv("./tests/data/manual_product_info.csv")
datasource = DBDataSource(config_file_path=config_file_path)
# When
result = datasource.get_manual_purchases()
# Then
assert result.equals(expected_result)
Python
Slide 71
Slide 71 text
def test_dbdatasource_is_able_to_load_products_related_only_to_manual_purchase(
self, db_resource
):
# Given
config_file_path = Path("./tests/data/configs/docker_config.json")
expected_result = pd.read_csv("./tests/data/manual_product_info.csv")
datasource = DBDataSource(config_file_path=config_file_path)
# When
result = datasource.get_manual_purchases()
# Then
assert result.equals(expected_result)
Python
Slide 72
Slide 72 text
def test_dbdatasource_is_able_to_load_products_related_only_to_manual_purchase(
self, db_resource
):
# Given
config_file_path = Path("./tests/data/configs/docker_config.json")
expected_result = pd.read_csv("./tests/data/manual_product_info.csv")
datasource = DBDataSource(config_file_path=config_file_path)
# When
result = datasource.get_manual_purchases()
# Then
assert result.equals(expected_result)
Python
Slide 73
Slide 73 text
def test_dbdatasource_is_able_to_load_products_related_only_to_manual_purchase(
self, db_resource
):
# Given
config_file_path = Path("./tests/data/configs/docker_config.json")
expected_result = pd.read_csv("./tests/data/manual_product_info.csv")
datasource = DBDataSource(config_file_path=config_file_path)
# When
result = datasource.get_manual_purchases()
# Then
assert result.equals(expected_result)
Python
Slide 74
Slide 74 text
E assert False
E + where False = (
product_id ... country\n0 2893abc0-eab0-7223-a73d-e39060a7eabe ... 652400 099\n1
4760ff15-52af-1638-0c61-0ebecefc3eb0 ... 652400 130\n2 328f6852-9bf1-e1ce-cf44-8f680537adc6 ... 652400
148\n3 851799e1-9b28-4210-5c44-30ddf031ad20 ... 652400 181\n4 00ab74ed-bd99-63af-ca0c-4f10c8c090db ...
652400 249\n5 2893abc0-eab0-7223-a73d-e39060a7eabe ... 652400 099\n6
4760ff15-52af-1638-0c61-0ebecefc3eb0 ... 652400 130\n7 328f6852-9bf1-e1ce-cf44-8f680537adc6 ... 652400
148\n8 851799e1-9b28-4210-5c44-30ddf031ad20 ... 652400 181\n9 00ab74ed-bd99-63af-ca0c-4f10c8c090db ...
652400 249\n\n[10 rows x 5 columns])
E + where =
fragrance_id ... country\n0 851799e1-9b28-4210-5c44-30ddf031ad20 ... 652400 181\n\n[1 rows x 5
columns].equals
Python
Slide 75
Slide 75 text
is_test boolean DEFAULT false NOT NULL
…
and we forgot to fulfill it..
Python
Slide 76
Slide 76 text
it('should list admins in the administrator field to be able to pick one up', async () => {
const store = Store();
const { findByTestId, getByText } = render(AdminPage as any, {
store,
mocks: {
$route: {
query: {},
},
},
});
await fireEvent.click(await findByTestId('admin-list'));
await waitFor(() => {
expect(getByText('Admin')).toBeInTheDocument();
});
});
Jest
Slide 77
Slide 77 text
it('should list admins in the administrator field to be able to pick one up', async () => {
const store = Store();
const { findByTestId, getByText } = render(AdminPage as any, {
store,
mocks: {
$route: {
query: {},
},
},
});
await fireEvent.click(await findByTestId('admin-list'));
await waitFor(() => {
expect(getByText('Admin')).toBeInTheDocument();
});
});
Jest
Slide 78
Slide 78 text
it('should list admins in the administrator field to be able to pick one up', async () => {
const store = Store();
const { findByTestId, getByText } = render(AdminPage as any, {
store,
mocks: {
$route: {
query: {},
},
},
});
await fireEvent.click(await findByTestId('admin-list'));
await waitFor(() => {
expect(getByText('Admin')).toBeInTheDocument();
});
});
Jest
Slide 79
Slide 79 text
it('should list admins in the administrator field to be able to pick one up', async () => {
const store = Store();
const { findByTestId, getByText } = render(AdminPage as any, {
store,
mocks: {
$route: {
query: {},
},
},
});
await fireEvent.click(await findByTestId('admin-list'));
await waitFor(() => {
expect(getByText('Admin')).toBeInTheDocument();
});
});
Jest
Slide 80
Slide 80 text
it('should list admins in the administrator field to be able to pick one up', async () => {
const store = Store();
const { findByTestId, getByText } = render(AdminPage as any, {
store,
mocks: {
$route: {
query: {},
},
},
});
await fireEvent.click(await findByTestId('admin-list'));
await waitFor(() => {
expect(getByText('Admin')).toBeInTheDocument();
});
});
Jest
Slide 81
Slide 81 text
it('should list admins in the administrator field to be able to pick one up', async () => {
const store = Store();
const { findByTestId, getByText } = render(AdminPage as any, {
store,
mocks: {
$route: {
query: {},
},
},
});
await fireEvent.click(await findByTestId('admin-list'));
await waitFor(() => {
expect(getByText('Admin')).toBeInTheDocument();
});
});
Jest
Slide 82
Slide 82 text
it('should list admins in the administrator field to be able to pick one up', async () => {
const store = Store();
const { findByTestId, getByText } = render(AdminPage as any, {
store,
mocks: {
$route: {
query: {},
},
},
});
await fireEvent.click(await findByTestId('admin-list'));
await waitFor(() => {
expect(getByText('Admin')).toBeInTheDocument();
});
});
Jest
Slide 83
Slide 83 text
export const Store = () => ({
modules: {
user: {
namespaced: true,
state: {
currentAdmin: {
email: '[email protected]',
},
},
getters: userGetters,
},
admin: adminStore(adminList).modules.admin,
},
});
Jest
Slide 84
Slide 84 text
export const Store = () => ({
modules: {
user: {
namespaced: true,
state: {
currentAdmin: {
email: '[email protected]',
},
},
getters: userGetters,
},
admin: adminStore(adminList).modules.admin,
},
});
Jest
Slide 85
Slide 85 text
it('should list admins in the administrator field to be able to pick one up', async () => {
const store = Store({ admin: { name: 'Admin' } });
const { findByTestId, getByText } = render(AdminPage as any, {
store,
mocks: {
$route: {
query: {},
},
},
});
await fireEvent.click(await findByTestId('admin-list'));
await waitFor(() => {
expect(getByText('Admin')).toBeInTheDocument();
});
});
Jest
Slide 86
Slide 86 text
● Use some libraries that generates fake data
● Test data adapters as soon as possible
● If possible try to avoid data from external sources
Points of attention
Slide 87
Slide 87 text
5. The enumerator - 🏆9
Crafting code
Slide 88
Slide 88 text
5. The enumerator - 🏆9
A unit test with each test case method name
is only an enumeration, i.e. test1, test2,
test3. As a result, the intention of the test
case is unclear, and the only way to be sure
is to read the test case code and pray for
clarity.
Crafting code
Slide 89
Slide 89 text
from status_processor import StatusProcessor
def test_set_status():
row_with_status_inactive_1 = dict(
row_with__status_inactive_2 = dict(
row_with_status_inactive_3 = dict(
row_with_status_inactive_3b = dict(
row_with_status_inactive_4 = dict(
row_with_status_inactive_5 = dict(
The enumerator - Python
Slide 90
Slide 90 text
from status_processor import StatusProcessor
def test_set_status():
row_with_status_inactive_1 = dict(
row_with__status_inactive_2 = dict(
row_with_status_inactive_3 = dict(
row_with_status_inactive_3b = dict(
row_with_status_inactive_4 = dict(
row_with_status_inactive_5 = dict(
The enumerator - Python
Slide 91
Slide 91 text
from status_processor import StatusProcessor
def test_set_status():
row_with_status_inactive_1 = dict(
row_with__status_inactive_2 = dict(
row_with_status_inactive_3 = dict(
row_with_status_inactive_3b = dict(
row_with_status_inactive_4 = dict(
row_with_status_inactive_5 = dict(
The enumerator - Python
Slide 92
Slide 92 text
from status_processor import StatusProcessor
def test_set_status():
row_with_status_inactive_1 = dict(
row_with__status_inactive_2 = dict(
row_with_status_inactive_3 = dict(
row_with_status_inactive_3b = dict(
row_with_status_inactive_4 = dict(
row_with_status_inactive_5 = dict(
The enumerator - Python
Slide 93
Slide 93 text
from status_processor import StatusProcessor
def test_set_status():
row_with_status_inactive_1 = dict(
row_with__status_inactive_2 = dict(
row_with_status_inactive_3 = dict(
row_with_status_inactive_3b = dict(
row_with_status_inactive_4 = dict(
row_with_status_inactive_5 = dict(
The enumerator - Python
Slide 94
Slide 94 text
from status_processor import StatusProcessor
def test_set_status():
row_with_status_inactive_1 = dict(
row_with__status_inactive_2 = dict(
row_with_status_inactive_3 = dict(
row_with_status_inactive_3b = dict(
row_with_status_inactive_4 = dict(
row_with_status_inactive_5 = dict(
The enumerator - Python
Slide 95
Slide 95 text
from status_processor import StatusProcessor
def test_set_status():
row_with_status_inactive_1 = dict(
row_with__status_inactive_2 = dict(
row_with_status_inactive_3 = dict(
row_with_status_inactive_3b = dict(
row_with_status_inactive_4 = dict(
row_with_status_inactive_5 = dict(
The enumerator - Python
Slide 96
Slide 96 text
from status_processor import StatusProcessor
def test_set_status():
row_with_status_inactive_1 = dict(
row_with__status_inactive_2 = dict(
row_with_status_inactive_3 = dict(
row_with_status_inactive_3b = dict(
row_with_status_inactive_4 = dict(
row_with_status_inactive_5 = dict(
The enumerator - Python
Slide 97
Slide 97 text
from status_processor import StatusProcessor
def test_set_status():
row_with_status_inactive_1 = dict(
row_with__status_inactive_2 = dict(
row_with_status_inactive_3 = dict(
row_with_status_inactive_3b = dict(
row_with_status_inactive_4 = dict(
row_with_status_inactive_5 = dict(
The enumerator - Python
Slide 98
Slide 98 text
The enumerator - typescript + php
Slide 99
Slide 99 text
The enumerator - typescript + php
Slide 100
Slide 100 text
The enumerator - typescript + php
Slide 101
Slide 101 text
The enumerator - typescript + php
Slide 102
Slide 102 text
The enumerator - typescript + php
Slide 103
Slide 103 text
The enumerator - typescript + php
Slide 104
Slide 104 text
The enumerator - typescript + php
Slide 105
Slide 105 text
The enumerator - typescript + php
Slide 106
Slide 106 text
The enumerator - typescript + php
Slide 107
Slide 107 text
The enumerator - typescript + php
Slide 108
Slide 108 text
The enumerator - typescript + php
Slide 109
Slide 109 text
The enumerator - typescript + php
Slide 110
Slide 110 text
● Are we using 1, 2, 3?
● The test that failed was easy to understand why?
Points of attention
Slide 111
Slide 111 text
6. Wrapping up
We are almost done!
Crafting code
Slide 112
Slide 112 text
● The Greedy Catcher
● The Sequencer
● Hidden Dependency
● The Enumerator
● and many more!
What we covered
Slide 113
Slide 113 text
https://www.codurance.com/publications/building-testing-culture
https://www.codurance.com/publications/tdd-anti-patterns-chapter-1
Slide 114
Slide 114 text
https://www.codurance.com/publications/building-testing-culture
https://www.codurance.com/publications/building-testing-culture
Slide 115
Slide 115 text
Matheus Marabesi
Hello there, you can call me Marabesi,
But my name is Matheus Marabesi, I work at Codurance as a
Software craftsperson.
I enjoy talking about anything related to: testing, patterns and
gamification.
You can find me at @MatheusMarabesi or https://marabesi.com
Codurance
Crafting Code