先輩から教えてもらったコードレビュー
by
Yuto Kondo
Link
Embed
Share
Beginning
This slide
Copy link URL
Copy link URL
Copy iframe embed code
Copy iframe embed code
Copy javascript embed code
Copy javascript embed code
Share
Tweet
Share
Tweet
Slide 1
Slide 1 text
ۙ౻༟ే(.01FQBCP *OD ʲࣾ߹ಉ-5େձʳ(.0ϖύϘɾ+BQBO5BYJɾΦΠγοΫε ઌഐ͔Βڭ͑ͯΒͬͨ ίʔυϨϏϡʔ ۙ౻༟ే(.01FQBCP *OD ʲࣾ߹ಉ-5େձʳ(.0ϖύϘɾ+BQBO5BYJɾΦΠγοΫε
Slide 2
Slide 2 text
磦堄嫵㞷
Slide 3
Slide 3 text
No content
Slide 4
Slide 4 text
υϯͱݟ͍ͤͨςΩετΛೖΕΔ
Slide 5
Slide 5 text
ܦҢ
Slide 6
Slide 6 text
ZVUPLZPLVUZPIBUFOBCMPHDPNFOUSZ
Slide 7
Slide 7 text
IUUQTXXXTMJEFTIBSFOFUUBLBGVNJPOBLBTT
Slide 8
Slide 8 text
͡·Γ
Slide 9
Slide 9 text
ొਓհ ߶ഠƑ༵Ḻ
Slide 10
Slide 10 text
No content
Slide 11
Slide 11 text
ίʔυϨϏϡʔͬͯΈͳ͍ʁ ˞։ൃνʔϜϝϯόʔ
Slide 12
Slide 12 text
ίʔυϨϏϡʔ ͳΜͯͰ͖Δͣͳ͍Α
Slide 13
Slide 13 text
ͩͬͯ ίʔυϦʔσΟϯά ͢ΒͰ͖ͳ͍ΜͩΑʁ
Slide 14
Slide 14 text
ίʔυϨϏϡʔ αʔϏεͷίʔυΛख़ ͍ͯ͠Δਓ͡Όͳ͍ͱ Ͱ͖ͳ͍Μ͡Όͳ͍͔ͳʁ
Slide 15
Slide 15 text
ࢲୡ͕αϙʔτ͠·͢ʂ ˞։ൃνʔϜϝϯόʔ
Slide 16
Slide 16 text
ͬͯΈΔ͔ɻ
Slide 17
Slide 17 text
͜ͷΑ͏ʹͯ͠ ͷίʔυϨϏϡʔਓੜ͕ ελʔτ͠·ͨ͠ɻ
Slide 18
Slide 18 text
ͱ͍͑ϨϏϡʔॳ৺ऀΛ ์ஔ͓ͯ͘͠Θ͚ʹ͍͖·ͤΜɻ
Slide 19
Slide 19 text
์͓ͬͯ͘ͱ
Slide 20
Slide 20 text
େৎ͡Όͳ͍͔ͳɻ ଟେৎͩΖ͏ʂ ϙνοͱͳ
Slide 21
Slide 21 text
େৎ͡Όͳ͍͔ͳɻ ଟେৎͩΖ͏ʂ ා͗͢Δ
Slide 22
Slide 22 text
Ͳ͏͔ͬͨʁ
Slide 23
Slide 23 text
Ȃǩǻƺ✣ Ȃǩǻȅ✣
Slide 24
Slide 24 text
Ȃǩǻƺ✣ Ȃǩǻȅ✣ ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 25
Slide 25 text
Ȃǩǻƺ✣ Ȃǩǻȅ✣ ϨϏϡʔ ͓Ͷ͠Ό͢ -(5.
Slide 26
Slide 26 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ
Slide 27
Slide 27 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ઌഐ͕ ࣍ड͚
Slide 28
Slide 28 text
ύλʔϯ̍
Slide 29
Slide 29 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 30
Slide 30 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 31
Slide 31 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. -(5. ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 32
Slide 32 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ NBTUFSʹ Ϛʔδ͠·͢ -(5. -(5.
Slide 33
Slide 33 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ NBTUFSʹ Ϛʔδ͠·͢ -(5. -(5. ϨϏϡΠʔ͕҆৺ ҆৺ αʔϏε҆શ
Slide 34
Slide 34 text
ύλʔϯ̎
Slide 35
Slide 35 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ
Slide 36
Slide 36 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 37
Slide 37 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ Μʁͪ͜͜ΐͬͱ ͓͔͍͔͠ ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 38
Slide 38 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ Μʁͪ͜͜ΐͬͱ ͓͔͍͔͠ ͔֬ʹͶʂ ͬͱ͍͍ॻ͖ํ Ͱ͖ͦ͏ʂ
Slide 39
Slide 39 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ͷߟ͑ ਖ਼͔ͬͨ͠Μͩʂ ͔֬ʹͶʂ ͬͱ͍͍ॻ͖ํ Ͱ͖ͦ͏ʂ
Slide 40
Slide 40 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ Μʁͪ͜͜ΐͬͱ ͓͔͍͔͠ ͔֬ʹͶʂ ͬͱ͍͍ॻ͖ํ Ͱ͖ͦ͏ʂ ͕ࣗҧײΛ࣋ͬͨ Օॴ͕ਖ਼͍͠ͱ ೝࣝͰ͖Δ
Slide 41
Slide 41 text
ύλʔϯ̏
Slide 42
Slide 42 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ
Slide 43
Slide 43 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 44
Slide 44 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 45
Slide 45 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢ ͍͍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ
Slide 46
Slide 46 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ͳΔ΄Ͳɻ ͦ͏͍͏ߟ͑ํ͕ ͋ͬͨͷ͔ ͍͍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ
Slide 47
Slide 47 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ͍͍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ ͳΔ΄Ͳɻ ͦ͏͍ͬͨߟ͑ํ͕ ͋ͬͨͷ͔ ࣗͷதʹଘࡏ͢Δ όουύλʔϯʹؾ͘ ͜ͱ͕Ͱ͖Δ
Slide 48
Slide 48 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ͳΔ΄Ͳɻ ͦ͏͍͏ߟ͑ํ͕ ͋ͬͨͷ͔ ͍͍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ ࣗʹͳ͍ࢹߟ͑ ํΛֶͿ͜ͱ͕Ͱ͖Δ
Slide 49
Slide 49 text
ύλʔϯ̐
Slide 50
Slide 50 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ
Slide 51
Slide 51 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 52
Slide 52 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢
Slide 53
Slide 53 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢ ཱʹ ͳͬͨͳ͊☺
Slide 54
Slide 54 text
Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ͍͍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ ͳΔ΄Ͳɻ ͦ͏͍ͬͨߟ͑ํ͕ ͋ͬͨͷ͔ ׳Ε͍ͯ͘ʹͭΕͯ ҰਓͰϨϏϡʔͰ͖Δ ྔ͕૿͍͑ͯ͘
Slide 55
Slide 55 text
ϲ݄ޙ
Slide 56
Slide 56 text
ʹͿͪͨΓ·ͨ͠ɻ
Slide 57
Slide 57 text
ҰਓͰίʔυϨϏϡʔΛ ͢Δͱ͖ʹࣗ৴͕࣋ͯͳ͍
Slide 58
Slide 58 text
ઌഐୡͷΑ͏ʹత֬ͳ ίʔυϨϏϡʔ͕Ͱ͖ͳ͍
Slide 59
Slide 59 text
ͳ͔ͳ͔ಠΓཱͪͰ͖ͳ͍যΓ
Slide 60
Slide 60 text
νʔϜϝϯόʔͱ;Γ͔͑Γ ˞։ൃνʔϜϝϯόʔ
Slide 61
Slide 61 text
˞։ൃνʔϜϝϯόʔ ·ͣୈҰʹযΒͳͯ͘େৎɻ Ͱ͖Δ͜ͱ͔Β͍ͬͯ͜͏ɻ
Slide 62
Slide 62 text
˞։ൃνʔϜϝϯόʔ ҧײΛ͖࣋ͭՕॴඞͣͰͯ͘Δɻ ͦͷՕॴʹ͍ͭͯʮͳͥ͜ͷΑ͏ʹॻ͍ͨͷ Ͱ͔͢ʁʯͱ࣭͢Δ͚ͩͰྑ͍ΜͩΑɻ
Slide 63
Slide 63 text
˞։ൃνʔϜϝϯόʔ Կ͔ٙΛ࣋ͬͨͱ͍͏͜ͱΓ͍ͨ͜ͱ ͕ͦͷίʔυ͔ΒಡΈऔΕͳ͔͔ͬͨΒʂ ͦΕ͖ͬͱͲ͔͜ʹٞվળͷ༨͕͋ Δͬͯ͜ͱͳΜ͡Όͳ͍͔ͳʁ
Slide 64
Slide 64 text
˞։ൃνʔϜϝϯόʔ ҧײΛ࣋ͬͯఏى͚ͨͩ͠ͷίϝϯτ͚ͩ ͰɺϨϏϡΠʔʹ࠶ߟͤ͞Δ͜ͱͰ৽ͨͳ ൃݟ͕ੜ·ΕͨΓ͢Δ͜ͱ͋ΔΜͩɻ
Slide 65
Slide 65 text
˞։ൃνʔϜϝϯόʔ (JU)VC্ͰͷΓͱΓ4MBDLʹ௨͞Ε ΔΑͶʁͦΕΛݟͨνʔϜϝϯόʔ͔Β·ͨ ৽ͨͳίϝϯτΛ͑Δ͜ͱͩͬͯ͋Δɻ
Slide 66
Slide 66 text
˞։ൃνʔϜϝϯόʔ ͔ͩΒͦͷҰาઈରʹແବʹͳΒͳ͍ɻ ༐ؾΛ࣋ͬͯൃݴ͍ͯ͜͠͏ʂ
Slide 67
Slide 67 text
͜ΜͳࣗͰͰ͖Δ ͔͠Εͳ͍ɻ
Slide 68
Slide 68 text
ޙ
Slide 69
Slide 69 text
ؾ͕͍ͭͨΒඦ݅ʹٴͿ ίʔυϨϏϡʔΛ͜ͳ͍ͯ͠·ͨ͠ɻ
Slide 70
Slide 70 text
ؒΛ;Γ͔͑ͬͯΈͨ
Slide 71
Slide 71 text
ϨϏϡΞʔͷࢹΛ ࣋ͭΑ͏ʹͳͬͨ
Slide 72
Slide 72 text
ϨϏϡΞʔͷࢹΛ࣋ͭΑ͏ʹͳͬͨ wҙਤ͕͖ͬΓ໌ࣔ͞Ε͍ͯΔ͖ wίϛοτͷཻ͕దͰྲྀΕͷ͋Δͷͱͳ͍ͬͯΔ͖ wಈ࡞ݕূ݁Ռςετ݁Ռ͕໌ࣔ͞Ε͍ͯΔ͖ wؔ࿈͢ΔJTTVF13ͷϦϯΫ͕షΒΕ͍ͯΔ͖
Slide 73
Slide 73 text
Πϯσϯτमਖ਼ ਓ͕ؒΔ͖Ͱͳ͍
Slide 74
Slide 74 text
Πϯσϯτमਖ਼ਓ͕ؒΔ͖Ͱͳ͍ wਓ͕ؒΔ͖͜ͱͱػց͕Δ͖͜ͱ۠ผ͢Δ͖ wػց͕Ͱ͖Δ͜ͱʹ͍ͭͯਓ͕ؒΔΑΓػցʹͤͨํ͕ඦ ഒޮ͕ྑ͘ਖ਼֬ͳͷͰੵۃతʹΒͤΔ͖ wςετͷ࣮ߦ$*ʹɺΠϯσϯτͷमਖ਼ࢦఠʹ͍ͭͯݴޠຖʹ ͋ΔϦϯτπʔϧΛ͏͜ͱ wਓؒػցʹͰ͖ͳ͍ൃߟ͑Δ͜ͱʹ࣌ؒΛඅ͢Α͏ʹ͢Δ ͖
Slide 75
Slide 75 text
ϨϏϡʔऔΓࠐΉͷ
Slide 76
Slide 76 text
ϨϏϡʔऔΓࠐΉͷ wຊདྷίʔυϨϏϡʔจԽͷ͋Δ͖ਖ਼͖࢟͠νʔϜؒͰٞΛͯ͠ αʔϏεʹͱͬͯ࠷ऴతʹྑ͍ͱஅͨ͜͠ͱΛऔΓࠐΉ͜ͱͰ͋Γɺ ͠मਖ਼͢Δͱ͍͏༰ͳͷͰ͋ΕͦΕϨϏϡΞʔͷҙݟΛऔ ΓࠐΉ͜ͱɻ wमਖ਼ͱ͍͏ݴ༿ΘͣʹϨϏϡʔΛऔΓࠐΉͱ͍͏දݱΛ͏ Α͏ʹ͍ͯ͠·͢ɻ
Slide 77
Slide 77 text
ϨϏϡʔऔΓࠐΉͷ wຊདྷίʔυϨϏϡʔจԽͷ͋Δ͖ਖ਼͖࢟͠νʔϜؒͰٞΛͯ͠ αʔϏεʹͱͬͯ࠷ऴతʹྑ͍ͱஅͨ͜͠ͱΛऔΓࠐΉ͜ͱͰ͋Γɺ ͠मਖ਼͢Δͱ͍͏༰ͳͷͰ͋ΕͦΕϨϏϡΞʔͷҙݟΛऔ ΓࠐΉ͜ͱɻ wमਖ਼ͱ͍͏ݴ༿ΘͣʹϨϏϡʔΛऔΓࠐΉͱ͍͏දݱΛ͏ Α͏ʹ͍ͯ͠·͢ɻ
Slide 78
Slide 78 text
ίʔυϨϏϡʔͱʁ WTࢲୡ
Slide 79
Slide 79 text
ίʔυϨϏϡʔͱʁ wʮWTࢲୡʯͱ͍͏ߏਤΛৗʹΕͣɺ࠷ྑͷίʔυΛνʔϜͰߟ ͑ಋ͖ग़͢͜͠ͱɻ wνʔϜͰ࠷ྑͷίʔυΛ͢ͱ͍͏తΛΕͳ͚ΕɺͲΜͳϨ Ϗϡʔίϝϯτʮ࠷ྑͷίʔυΛͨ͢ΊʹԕྀͤͣʹҙݟΛड़ ͯ͘Ε͍ͯΔʯͱߟ͑Δ͜ͱͰ͖Δɻ wϨϏϡΠʔͱϨϏϡΞʔͷํ͕ޓ͍ʹతΛҰகͤ͞ԕྀͤͣʹา ΈدΔ͜ͱͰ࠷ߴͷίʔυϨϏϡʔ͕Ͱ͖Δɻ
Slide 80
Slide 80 text
ֆจࣈɾإจࣈɾײ୰ූ ΛదࡐదॴͰ͏
Slide 81
Slide 81 text
ྑͦ͞͏ͳྫ w߹ཧతނʹগ͠ݫ͠Ίͳίϝϯτͱͳͬͯ͠·͍ͬͯͯɺඌʹস إͷإจࣈײ୰ූ͕͋Δ͚ͩͰ҆৺ΛಘΔ͜ͱ͕Ͱ͖Δͱ৴ͯ͡· ͢ɻ
Slide 82
Slide 82 text
ѱ͍ྫ wจ຺ͱશؔ͘ͷͳ͍ֆจࣈͷ༻Φεεϝ͠·ͤΜɻ wͳͥͳΒɺ૬खʹҙຯෆ໌ͳֆจࣈΛͬͨཧ༝Λߟ͑ͤͯ͞͠·͏ ͨΊͰ͢ɻ
Slide 83
Slide 83 text
ཧºײ༏উ
Slide 84
Slide 84 text
࠷ޙʹ
Slide 85
Slide 85 text
εΩϧ ढจ ίʔυϨϏϡʔ ϝϥκʔϚ ίʔυϥΠςΟϯά ϝϥϛ ίʔυϦʔσΟϯά ϝϥ शಘ қ
Slide 86
Slide 86 text
εΩϧ ढจ ίʔυϨϏϡʔ ϝϥκʔϚ ίʔυϥΠςΟϯά ϝϥϛ ίʔυϦʔσΟϯά ϝϥ शಘ қ
Slide 87
Slide 87 text
ίʔυϨϏϡʔ ίʔυϦʔσΟϯά ֶशͷஈ֊͚͕ॎʹͳ͍ͬͯͳ͍
Slide 88
Slide 88 text
ΤϯδχΞͱͯ͠ͷࢹ
Slide 89
Slide 89 text
ΤϯδχΞͱͯ͠ͷࢹ
Slide 90
Slide 90 text
ΤϯδχΞͱͯ͠ͷࢹ
Slide 91
Slide 91 text
ΤϯδχΞͱͯ͠ͷࢹ ઌഐୡ͕ॻ͘៉ྷͰચ࿅͞Εͨ ͓खຊͱͳΔίʔυΛ ϨϏϡΞʔͱͯ͠ԿݟΔ͜ͱ͕Ͱ͖ͨ
Slide 92
Slide 92 text
ΤϯδχΞͱͯ͠ͷࢹ ίʔυϨϏϡʔΛ͢Δ͜ͱͰ ϘτϧωοΫͱͳ͍ͬͯͨ ϦʔσΟϯάɾϥΠςΟϯάɾઃܭྗɾςετ ͷجૅతͳྗ͕ߴͰʹ͍ͭͨ
Slide 93
Slide 93 text
ΤϯδχΞͱͯ͠ͷࢹ ίʔυϨϏϡʔΛ௨ͯ͠νʔϜͷΤϯδχΞͱ ڞʹϓϩμΫτΛΓ্͛ͳ͕Β࣮ઓͰಘΒΕ Δݟ͕͍͑ͨͷ͕͋Δ
Slide 94
Slide 94 text
͔ͭͯͷͷΑ͏ʹ ίʔυϨϏϡʔͷҰาΛ ౿Έग़ͤͣʹ͍Δ͋ͳͨʂ
Slide 95
Slide 95 text
νʔϜͷதʹίʔυϨϏϡʔΛ ͍ͯ͠ͳ͍ະख़ͷΤϯδχΞ ͞Μ͕͍Δ͋ͳͨʂ
Slide 96
Slide 96 text
ੋඇ͜ͷػձʹίʔυϨϏϡʔΛ ࢝ΊΔɾ༠ͬͯ͋͛Δ ͷ͍͔͕Ͱ͠ΐ͏͔ʂ✨
Slide 97
Slide 97 text
ΦϑΟεͷݟֶʹདྷ·ͤΜ͔ʁ ڵຯ͋Δํ͓͕͚͍ͩ͘͞☺ ࠷৽ͷ࠾༻ใΛνΣοΫˠ !QC@SFDSVJU