先輩から教えてもらったコードレビュー

Slide 1

Slide 1 text

ۙ౻༟ే(.01FQBCP *OD ʲࣾ߹ಉ-5େձʳ(.0ϖύϘɾ+BQBO5BYJɾΦΠγοΫε ઌഐ͔Βڭ͑ͯ΋Βͬͨ ίʔυϨϏϡʔ ۙ౻༟ే(.01FQBCP *OD ʲࣾ߹ಉ-5େձʳ(.0ϖύϘɾ+BQBO5BYJɾΦΠγοΫε

Slide 2

Slide 2 text

磦堄嫵㞷

Slide 3

Slide 3 text

No content

Slide 4

Slide 4 text

υϯͱݟ͍ͤͨςΩετΛೖΕΔ

Slide 5

Slide 5 text

ܦҢ

Slide 6

Slide 6 text

ZVUPLZPLVUZPIBUFOBCMPHDPNFOUSZ

Slide 7

Slide 7 text

IUUQTXXXTMJEFTIBSFOFUUBLBGVNJPOBLBTT

Slide 8

Slide 8 text

͸͡·Γ

Slide 9

Slide 9 text

ొ৔ਓ෺঺հ ⃂ ߶ഠƑ༵Ḻ

Slide 10

Slide 10 text

No content

Slide 11

Slide 11 text

ίʔυϨϏϡʔ΍ͬͯΈͳ͍ʁ ˞։ൃνʔϜϝϯόʔ

Slide 12

Slide 12 text

ίʔυϨϏϡʔ ͳΜͯͰ͖Δ͸ͣͳ͍Α

Slide 13

Slide 13 text

ͩͬͯ ίʔυϦʔσΟϯά ͢ΒͰ͖ͳ͍ΜͩΑʁ

Slide 14

Slide 14 text

ίʔυϨϏϡʔ͸ αʔϏεͷίʔυΛख़஌ ͍ͯ͠Δਓ͡Όͳ͍ͱ Ͱ͖ͳ͍Μ͡Όͳ͍͔ͳʁ

Slide 15

Slide 15 text

ࢲୡ͕αϙʔτ͠·͢ʂ ˞։ൃνʔϜϝϯόʔ

Slide 16

Slide 16 text

΍ͬͯΈΔ͔ɻ

Slide 17

Slide 17 text

͜ͷΑ͏ʹͯ͠ ๻ͷίʔυϨϏϡʔਓੜ͕ ελʔτ͠·ͨ͠ɻ

Slide 18

Slide 18 text

ͱ͸͍͑ϨϏϡʔॳ৺ऀΛ ์ஔ͓ͯ͘͠Θ͚ʹ͸͍͖·ͤΜɻ

Slide 19

Slide 19 text

์͓ͬͯ͘ͱ

Slide 20

Slide 20 text

େৎ෉͡Όͳ͍͔ͳɻ ଟ෼େৎ෉ͩΖ͏ʂ ϙνοͱͳ

Slide 21

Slide 21 text

େৎ෉͡Όͳ͍͔ͳɻ ଟ෼େৎ෉ͩΖ͏ʂ ා͗͢Δ

Slide 22

Slide 22 text

Ͳ͏΍͔ͬͨʁ

Slide 23

Slide 23 text

Ȃǩǻƺ✣ Ȃǩǻȅ✣

Slide 24

Slide 24 text

Ȃǩǻƺ✣ Ȃǩǻȅ✣ ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 25

Slide 25 text

Ȃǩǻƺ✣ Ȃǩǻȅ✣ ϨϏϡʔ ͓Ͷ͠Ό͢ -(5.

Slide 26

Slide 26 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ

Slide 27

Slide 27 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ઌഐ͕ ࣍ड͚

Slide 28

Slide 28 text

ύλʔϯ̍

Slide 29

Slide 29 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 30

Slide 30 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 31

Slide 31 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. -(5. ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 32

Slide 32 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ NBTUFSʹ Ϛʔδ͠·͢ -(5. -(5.

Slide 33

Slide 33 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ NBTUFSʹ Ϛʔδ͠·͢ -(5. -(5. ϨϏϡΠʔ͕҆৺ ๻΋҆৺ αʔϏε΋҆શ

Slide 34

Slide 34 text

ύλʔϯ̎

Slide 35

Slide 35 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ

Slide 36

Slide 36 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 37

Slide 37 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ Μʁͪ͜͜ΐͬͱ ͓͔͍͔͠΋ ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 38

Slide 38 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ Μʁͪ͜͜ΐͬͱ ͓͔͍͔͠΋ ͔֬ʹͶʂ ΋ͬͱ͍͍ॻ͖ํ Ͱ͖ͦ͏ʂ

Slide 39

Slide 39 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ๻ͷߟ͑͸ ਖ਼͔ͬͨ͠Μͩʂ ͔֬ʹͶʂ ΋ͬͱ͍͍ॻ͖ํ Ͱ͖ͦ͏ʂ

Slide 40

Slide 40 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ Μʁͪ͜͜ΐͬͱ ͓͔͍͔͠΋ ͔֬ʹͶʂ ΋ͬͱ͍͍ॻ͖ํ Ͱ͖ͦ͏ʂ ࣗ෼͕ҧ࿨ײΛ࣋ͬͨ Օॴ͕ਖ਼͍͠ͱ ೝࣝͰ͖Δ

Slide 41

Slide 41 text

ύλʔϯ̏

Slide 42

Slide 42 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ

Slide 43

Slide 43 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 44

Slide 44 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 45

Slide 45 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢ ͍΍͍΍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ

Slide 46

Slide 46 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ͳΔ΄Ͳɻ ͦ͏͍͏ߟ͑ํ͕ ͋ͬͨͷ͔ ͍΍͍΍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ

Slide 47

Slide 47 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ͍΍͍΍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ ͳΔ΄Ͳɻ ͦ͏͍ͬͨߟ͑ํ͕ ͋ͬͨͷ͔ ࣗ෼ͷதʹଘࡏ͢Δ όουύλʔϯʹؾ෇͘ ͜ͱ͕Ͱ͖Δ

Slide 48

Slide 48 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ͳΔ΄Ͳɻ ͦ͏͍͏ߟ͑ํ͕ ͋ͬͨͷ͔ ͍΍͍΍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ ࣗ෼ʹ͸ͳ͍ࢹ఺΍ߟ͑ ํΛֶͿ͜ͱ͕Ͱ͖Δ

Slide 49

Slide 49 text

ύλʔϯ̐

Slide 50

Slide 50 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ

Slide 51

Slide 51 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 52

Slide 52 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢

Slide 53

Slide 53 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ -(5. ϨϏϡʔ ͓Ͷ͠Ό͢ ཱ೿ʹ ͳͬͨͳ͊☺

Slide 54

Slide 54 text

Ȃǩǻ✣၇内 Ց൳Ŵ Ց൳Ŵ ϨϏϡʔ ͓Ͷ͠Ό͢ ͍΍͍΍ʂ ͕͓͔͍͜͜͠ͱ ࢥ͏ͧ͒ʂ ͳΔ΄Ͳɻ ͦ͏͍ͬͨߟ͑ํ͕ ͋ͬͨͷ͔ ׳Ε͍ͯ͘ʹͭΕͯ ҰਓͰϨϏϡʔͰ͖Δ ྔ͕૿͍͑ͯ͘

Slide 55

Slide 55 text

ϲ݄ޙ

Slide 56

Slide 56 text

໰୊ʹͿͪ౰ͨΓ·ͨ͠ɻ

Slide 57

Slide 57 text

ҰਓͰίʔυϨϏϡʔΛ ͢Δͱ͖ʹࣗ৴͕࣋ͯͳ͍

Slide 58

Slide 58 text

ઌഐୡͷΑ͏ʹత֬ͳ ίʔυϨϏϡʔ͕Ͱ͖ͳ͍

Slide 59

Slide 59 text

ͳ͔ͳ͔ಠΓཱͪͰ͖ͳ͍যΓ

Slide 60

Slide 60 text

νʔϜϝϯόʔͱ;Γ͔͑Γ ˞։ൃνʔϜϝϯόʔ

Slide 61

Slide 61 text

˞։ൃνʔϜϝϯόʔ ·ͣୈҰʹযΒͳͯ͘େৎ෉ɻ Ͱ͖Δ͜ͱ͔Β΍͍ͬͯ͜͏ɻ

Slide 62

Slide 62 text

˞։ൃνʔϜϝϯόʔ ҧ࿨ײΛ࣋ͭ΂͖Օॴ͸ඞͣͰͯ͘Δɻ ͦͷՕॴʹ͍ͭͯʮͳͥ͜ͷΑ͏ʹॻ͍ͨͷ Ͱ͔͢ʁʯͱ࣭໰͢Δ͚ͩͰ΋ྑ͍ΜͩΑɻ

Slide 63

Slide 63 text

˞։ൃνʔϜϝϯόʔ Կ͔ٙ໰Λ࣋ͬͨͱ͍͏͜ͱ͸΍Γ͍ͨ͜ͱ ͕ͦͷίʔυ͔ΒಡΈऔΕͳ͔͔ͬͨΒʂ ͦΕ͸͖ͬͱͲ͔͜ʹٞ࿦΍վળͷ༨஍͕͋ Δͬͯ͜ͱͳΜ͡Όͳ͍͔ͳʁ

Slide 64

Slide 64 text

˞։ൃνʔϜϝϯόʔ ҧ࿨ײΛ࣋ͬͯఏى͚ͨͩ͠ͷίϝϯτ͚ͩ Ͱ΋ɺϨϏϡΠʔʹ࠶ߟͤ͞Δ͜ͱͰ৽ͨͳ ൃݟ͕ੜ·ΕͨΓ͢Δ͜ͱ΋͋ΔΜͩɻ

Slide 65

Slide 65 text

˞։ൃνʔϜϝϯόʔ (JU)VC্Ͱͷ΍ΓͱΓ͸4MBDLʹ௨஌͞Ε ΔΑͶʁͦΕΛݟͨνʔϜϝϯόʔ͔Β·ͨ ৽ͨͳίϝϯτΛ໯͑Δ͜ͱͩͬͯ͋Δɻ

Slide 66

Slide 66 text

˞։ൃνʔϜϝϯόʔ ͔ͩΒͦͷҰา͸ઈରʹແବʹͳΒͳ͍ɻ ༐ؾΛ࣋ͬͯൃݴ͍ͯ͜͠͏ʂ

Slide 67

Slide 67 text

͜Μͳࣗ෼Ͱ΋Ͱ͖Δ ͔΋͠Εͳ͍ɻ

Slide 68

Slide 68 text

൒೥ޙ

Slide 69

Slide 69 text

ؾ͕͍ͭͨΒ਺ඦ݅ʹٴͿ ίʔυϨϏϡʔΛ͜ͳ͍ͯ͠·ͨ͠ɻ

Slide 70

Slide 70 text

൒೥ؒΛ;Γ͔͑ͬͯΈͨ

Slide 71

Slide 71 text

ϨϏϡΞʔͷࢹ఺Λ ࣋ͭΑ͏ʹͳͬͨ

Slide 72

Slide 72 text

ϨϏϡΞʔͷࢹ఺Λ࣋ͭΑ͏ʹͳͬͨ wҙਤ͕͸͖ͬΓ໌ࣔ͞Ε͍ͯΔ΂͖ wίϛοτͷཻ౓͕ద੾ͰྲྀΕͷ͋Δ΋ͷͱͳ͍ͬͯΔ΂͖ wಈ࡞ݕূ݁Ռ΍ςετ݁Ռ͕໌ࣔ͞Ε͍ͯΔ΂͖ wؔ࿈͢ΔJTTVF΍13ͷϦϯΫ͕షΒΕ͍ͯΔ΂͖

Slide 73

Slide 73 text

Πϯσϯτमਖ਼͸ ਓ͕ؒ΍Δ΂͖Ͱ͸ͳ͍

Slide 74

Slide 74 text

Πϯσϯτमਖ਼͸ਓ͕ؒ΍Δ΂͖Ͱ͸ͳ͍ wਓ͕ؒ΍Δ΂͖͜ͱͱػց͕΍Δ΂͖͜ͱ͸۠ผ͢Δ΂͖ wػց͕Ͱ͖Δ͜ͱʹ͍ͭͯ͸ਓ͕ؒ΍ΔΑΓ΋ػցʹ೚ͤͨํ͕਺ඦ ഒޮ཰͕ྑ͘ਖ਼֬ͳͷͰੵۃతʹ΍ΒͤΔ΂͖ wςετͷ࣮ߦ͸$*ʹɺΠϯσϯτͷमਖ਼΍ࢦఠʹ͍ͭͯ͸ݴޠຖʹ ͋ΔϦϯτπʔϧΛ࢖͏͜ͱ wਓؒ͸ػցʹ͸Ͱ͖ͳ͍ൃ૝΍ߟ͑Δ͜ͱʹ࣌ؒΛඅ΍͢Α͏ʹ͢Δ ΂͖

Slide 75

Slide 75 text

ϨϏϡʔ͸औΓࠐΉ΋ͷ

Slide 76

Slide 76 text

ϨϏϡʔ͸औΓࠐΉ΋ͷ wຊདྷίʔυϨϏϡʔจԽͷ͋Δ΂͖ਖ਼͖࢟͠͸νʔϜؒͰٞ࿦Λͯ͠ αʔϏεʹͱͬͯ࠷ऴతʹྑ͍ͱ൑அͨ͜͠ͱΛऔΓࠐΉ͜ͱͰ͋Γɺ ΋͠΋मਖ਼͢Δͱ͍͏಺༰ͳͷͰ͋Ε͹ͦΕ͸ϨϏϡΞʔͷҙݟΛऔ ΓࠐΉ͜ͱɻ wमਖ਼ͱ͍͏ݴ༿͸࢖ΘͣʹϨϏϡʔΛऔΓࠐΉͱ͍͏දݱΛ࢖͏ Α͏ʹ͍ͯ͠·͢ɻ

Slide 77

Slide 77 text

Slide 78

Slide 78 text

ίʔυϨϏϡʔͱ͸ʁ ໰୊WTࢲୡ

Slide 79

Slide 79 text

ίʔυϨϏϡʔͱ͸ʁ wʮ໰୊WTࢲୡʯͱ͍͏ߏਤΛৗʹ๨Εͣɺ࠷ྑͷίʔυΛνʔϜͰߟ ͑ಋ͖ग़͠࢒͢͜ͱɻ wνʔϜͰ࠷ྑͷίʔυΛ࢒͢ͱ͍͏໨తΛ๨Εͳ͚Ε͹ɺͲΜͳϨ Ϗϡʔίϝϯτ΋ʮ࠷ྑͷίʔυΛ࢒ͨ͢ΊʹԕྀͤͣʹҙݟΛड़΂ ͯ͘Ε͍ͯΔʯͱߟ͑Δ͜ͱͰ͖Δɻ wϨϏϡΠʔͱϨϏϡΞʔͷ૒ํ͕ޓ͍ʹ໨తΛҰகͤ͞ԕྀͤͣʹา ΈدΔ͜ͱͰ࠷ߴͷίʔυϨϏϡʔ͕Ͱ͖Δɻ

Slide 80

Slide 80 text

ֆจࣈɾإจࣈɾײ୰ූ ΛదࡐదॴͰ࢖͏

Slide 81

Slide 81 text

ྑͦ͞͏ͳྫ w߹ཧతނʹগ͠ݫ͠Ίͳίϝϯτͱͳͬͯ͠·͍ͬͯͯ΋ɺ຤ඌʹস إͷإจࣈ΍ײ୰ූ͕͋Δ͚ͩͰ҆৺ΛಘΔ͜ͱ͕Ͱ͖Δͱ৴ͯ͡· ͢ɻ

Slide 82

Slide 82 text

ѱ͍ྫ wจ຺ͱશؔ͘܎ͷͳ͍ֆจࣈͷ࢖༻͸Φεεϝ͠·ͤΜɻ wͳͥͳΒɺ૬खʹҙຯෆ໌ͳֆจࣈΛ࢖ͬͨཧ༝Λߟ͑ͤͯ͞͠·͏ ͨΊͰ͢ɻ

Slide 83

Slide 83 text

࿦ཧºײ৘༏উ

Slide 84

Slide 84 text

࠷ޙʹ

Slide 85

Slide 85 text

εΩϧ ढจ ίʔυϨϏϡʔ ϝϥκʔϚ ίʔυϥΠςΟϯά ϝϥϛ ίʔυϦʔσΟϯά ϝϥ शಘ ೉қ౓

Slide 86

Slide 86 text

εΩϧ ढจ ίʔυϨϏϡʔ ϝϥκʔϚ ίʔυϥΠςΟϯά ϝϥϛ ίʔυϦʔσΟϯά ϝϥ शಘ ೉қ౓

Slide 87

Slide 87 text

ίʔυϨϏϡʔ΍ ίʔυϦʔσΟϯά͸ ֶशͷஈ֊෇͚͕ॎʹͳ͍ͬͯͳ͍

Slide 88

Slide 88 text

ΤϯδχΞͱͯ͠ͷࢹ໺

Slide 89

Slide 89 text

ΤϯδχΞͱͯ͠ͷࢹ໺

Slide 90

Slide 90 text

ΤϯδχΞͱͯ͠ͷࢹ໺

Slide 91

Slide 91 text

ΤϯδχΞͱͯ͠ͷࢹ໺ ઌഐୡ͕ॻ͘៉ྷͰચ࿅͞Εͨ ͓खຊͱͳΔίʔυΛ ϨϏϡΞʔͱͯ͠Կ౓΋ݟΔ͜ͱ͕Ͱ͖ͨ

Slide 92

Slide 92 text

ΤϯδχΞͱͯ͠ͷࢹ໺ ίʔυϨϏϡʔΛ͢Δ͜ͱͰ ϘτϧωοΫͱͳ͍ͬͯͨ ϦʔσΟϯάɾϥΠςΟϯάɾઃܭྗɾςετ ͷجૅతͳྗ͕ߴ଎Ͱ਎ʹ͍ͭͨ

Slide 93

Slide 93 text

ΤϯδχΞͱͯ͠ͷࢹ໺ ίʔυϨϏϡʔΛ௨ͯ͠νʔϜͷΤϯδχΞͱ ڞʹϓϩμΫτΛ଄Γ্͛ͳ͕Β࣮ઓͰಘΒΕ Δ஌ݟ͸୅͕͍͑ͨ΋ͷ͕͋Δ

Slide 94

Slide 94 text

͔ͭͯͷ๻ͷΑ͏ʹ ίʔυϨϏϡʔͷҰาΛ ౿Έग़ͤͣʹ͍Δ͋ͳͨʂ

Slide 95

Slide 95 text

νʔϜͷதʹίʔυϨϏϡʔΛ ͍ͯ͠ͳ͍ະ੒ख़ͷΤϯδχΞ ͞Μ͕͍Δ͋ͳͨʂ

Slide 96

Slide 96 text

ੋඇ͜ͷػձʹίʔυϨϏϡʔΛ ࢝ΊΔɾ༠ͬͯ͋͛Δ ͷ͸͍͔͕Ͱ͠ΐ͏͔ʂ✨

Slide 97

Slide 97 text

ΦϑΟεͷݟֶʹདྷ·ͤΜ͔ʁ ڵຯ͋Δํ͓੠͕͚͍ͩ͘͞☺ ࠷৽ͷ࠾༻৘ใΛνΣοΫˠ !QC@SFDSVJU