Tweet
Tweet

Slide 1

Slide 1 text

The dream that turned into nightmare ! Radoslav Stankov

Slide 2

Slide 2 text

No content

Slide 3

Slide 3 text

"

Slide 4

Slide 4 text

Radoslav Stankov @rstankov rstankov.com

Slide 5

Slide 5 text

https://tips.rstankov.com

Slide 6

Slide 6 text

No content

Slide 7

Slide 7 text

... in a start up

Slide 8

Slide 8 text

... far far way

Slide 9

Slide 9 text

... in Silicon Valley

Slide 10

Slide 10 text

No content

Slide 11

Slide 11 text

No content

Slide 12

Slide 12 text

No content

Slide 13

Slide 13 text

"Dream" is short for "the dream to not write custom CSS". Let's hope v2 is not named "Nightmare" # Goals - Have consistent UI on the website - Make it easier to build new pages - Implement Product Hunt v6 design - Fully type safe What - Foundational utilities - Core UI components

Slide 14

Slide 14 text

"Dream" is short for "the dream to not write custom CSS". Let's hope v2 is not named "Nightmare" # Goals - Have consistent UI on the website - Make it easier to build new pages - Implement Product Hunt v6 design - Fully type safe What - Foundational utilities - Core UI components $

Slide 15

Slide 15 text

Core Design System - 4px grid - font size - font weights - color tokens - layouts

Slide 16

Slide 16 text

No content

Slide 17

Slide 17 text

No content

Slide 18

Slide 18 text

No content

Slide 19

Slide 19 text

No content

Slide 20

Slide 20 text

The core components part

Slide 21

Slide 21 text

No content

Slide 22

Slide 22 text

No content

Slide 23

Slide 23 text

No content

Slide 24

Slide 24 text

No content

Slide 25

Slide 25 text

No content

Slide 26

Slide 26 text

import { Text } from '~/components/dream' Title Subtile Bold

Slide 27

Slide 27 text

import { Button } from 'ph/components/dream'

Slide 28

Slide 28 text

import { Button } from 'ph/components/dream'

Slide 29

Slide 29 text

import { Flex } from 'ph/components/dream'

Slide 30

Slide 30 text

import { Layout } from 'ph/components/dream'

Slide 31

Slide 31 text

No content

Slide 32

Slide 32 text

import { Form } from 'ph/components/dream'

Slide 33

Slide 33 text

{content} {content} {content} {content} {content}
{content}
{content}
{content}

Slide 34

Slide 34 text

{content} {content} {content} {content} {content}
{content}
{content}
{content}

Slide 35

Slide 35 text

{content} {content} {content} {content} {content}
{content}
{content}
{content}

Slide 36

Slide 36 text

{content} {content} {content} {content} {content}
{content}
{content}
{content}

Slide 37

Slide 37 text

{content} {content} {content} {content} {content}
{content}
{content}
{content}

Slide 38

Slide 38 text

{content} {content} {content} {content} {content}
{content}
{content}
{content}

Slide 39

Slide 39 text

{content} {content} {content} {content} {content}
{content}
{content}
{content}

Slide 40

Slide 40 text

{content} {content} {content} {content} {content}
{content}
{content}
{content}

Slide 41

Slide 41 text

interface IProps extends ITextCSSProps { children: React.ReactNode; className?: string; as?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6' | 'span' | 'strong' | 'p' | 'div' | 'i' | 'legend' | 'details' | 'footer' | 'summary'; id?: string; onClick?: React.MouseEventHandler; format?: boolean; noOfLines?: INoOfLines; center?: boolean; target?: '_blank' | '_self'; 'data-test'?: string; 'aria-label'?: string; ellipsis?: boolean; } export default function Text({ children, className, as, id, color = 'darker-grey', fontSize = 16, fontWeight = 400, format = false, center = false, noOfLines, 'data-test': dataTest, onClick, ellipsis, ...otherProps }: IProps) { const finalClassName = classNames( dreamCSSClasses({ ...otherProps, color, fontSize, fontWeight, noOfLines }), className, format && styles.format, center && styles.center, ellipsis && styles.ellipsis, ); const Component = as ?? 'div'; return ( {children} ); }

Slide 42

Slide 42 text

No content

Slide 43

Slide 43 text

No content

Slide 44

Slide 44 text

dreamCSSClasses(props)

Slide 45

Slide 45 text

export function deprecatedDreamCSSClasses(props: IDreamCSS) { let classes: string = ''; const propNames = Object.keys(props); for (const propName of propNames) { const propValue = props[propName]; if (!ALLOWED_PROPS[propName]) { continue; } if (typeof propValue === 'object') { classes = classesForObject(classes, propName, propValue); } else { classes = classesForProps(classes, propName, propValue); } } return classes.trim(); } function classesForObject(classes: string, prop: string, props: any) { if (isNotSet(props.widescreen) && props.desktop) { props.widescreen = props.desktop; }

Slide 46

Slide 46 text

function classesForObject(classes: string, prop: string, props: any) { if (isNotSet(props.widescreen) && props.desktop) { props.widescreen = props.desktop; } if (isNotSet(props.tablet) && props.mobile) { props.tablet = props.mobile; } const modifiers = Object.keys(props); for (const modifier of modifiers) { const propValue = props[modifier]; if (modifier === 'l') { classes = classesForProps(classes, prop, propValue); } else { classes = classesForProps(classes, `${prop}-${modifier}`, propValue); } } return classes; } function classesForProps(classes: string, propName: string, propValue: any) { if (typeof propValue === 'boolean' && propValue) { classes += `${propName}-default `; } else {

Slide 47

Slide 47 text

const modifiers = Object.keys(props); for (const modifier of modifiers) { const propValue = props[modifier]; if (modifier === 'l') { classes = classesForProps(classes, prop, propValue); } else { classes = classesForProps(classes, `${prop}-${modifier}`, propValue); } } return classes; } function classesForProps(classes: string, propName: string, propValue: any) { if (typeof propValue === 'boolean' && propValue) { classes += `${propName}-default `; } else { classes += `${propName}-${propValue} `; } return classes; } function isNotSet(value) { return typeof value === 'undefined' || value === null; }

Slide 48

Slide 48 text

No content

Slide 49

Slide 49 text

No content

Slide 50

Slide 50 text

' Problem #1 - CSS bundle size All possible class names must be pre-generated and included in the CSS bundle because they are generated dynamically.

Slide 51

Slide 51 text

' Problem #1 - CSS bundle size gap: 14 sizes * 5 variants = 46 margin: 7 props * 14 sizes * 5 variants = 350 padding: 7 props * 14 sizes * 5 variants = 350 colors: 2 props * 12 colors * 5 variants = 120 ... ... total: ~2000 class names (

Slide 52

Slide 52 text

) Problem #2 - too many loops dreamCSSClasses was called for many components to build their class names. This results in loops and variable generation, resulting in many GCs and slowing rendering. Especially the initial rendering.

Slide 53

Slide 53 text

) Problem #2 - too many loops dreamCSSClasses was called for many components to build their class names. This results in loops and variable generation, resulting in many GCs and slowing rendering. Especially the initial rendering.

Slide 54

Slide 54 text

) Problem #2 - too many loops

Slide 55

Slide 55 text

) Problem #2 - too many loops 2000+ calls to dreamCSSClasses for single render

Slide 56

Slide 56 text

* Problem #3 - too many props Core components like Text and Flex, accepted subsets of dreamCSSClasses props, leading to overcomplicated code.

Slide 57

Slide 57 text

interface IProps extends ITextCSSProps { children: React.ReactNode; className?: string; as?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6' | 'span' | 'strong' | 'p' | 'div' | 'i' | 'legend' | 'details' | 'footer' | 'summary'; id?: string; onClick?: React.MouseEventHandler; format?: boolean; noOfLines?: INoOfLines; center?: boolean; target?: '_blank' | '_self'; 'data-test'?: string; 'aria-label'?: string; ellipsis?: boolean; } export default function Text({ children, className, as, id, color = 'darker-grey', fontSize = 16, fontWeight = 400, format = false, center = false, noOfLines, 'data-test': dataTest, onClick, ellipsis, ...otherProps }: IProps) { const finalClassName = classNames( dreamCSSClasses({ ...otherProps, color, fontSize, fontWeight, noOfLines }), className, format && styles.format, center && styles.center, ellipsis && styles.ellipsis, ); const Component = as ?? 'div'; return ( {children} ); }

Slide 58

Slide 58 text

No content

Slide 59

Slide 59 text

No content

Slide 60

Slide 60 text

No content

Slide 61

Slide 61 text

No content

Slide 62

Slide 62 text

No content

Slide 63

Slide 63 text

No content

Slide 64

Slide 64 text

No content