ී௨ͷ CSVΞοϓϩʔυ ϑΥʔϜΛ࡞Γ͍ͨ վ

✓ Kazunari Takahashi ✓ Yokohama.rb ✓ 2012 Ruby kaja award winner ✓ MinatoRubyKaigi01 organizer ✓ TDDBC Yokohama TA @1syo

νΣοΫ ✓ Anvil͸ىಈ͍ͯ͠Δ͔ ✓ http://bad.dev/admin/usersͷλϒ͸͋Δ͔ ✓ http://good.dev/admin/usersͷλϒ͸͋Δ͔ ✓ gist(bad/good)͸tweet͔ͨ͠ ✓ ֤؀ڥͰdb:setup͸࣮ߦ͔ͨ͠ʁ

formͷઃܭΛͲ͏͢Ε͹͍͍͔ʁ ✓ ೖ໳ॻʹࡌͬͯͳ͍ ✓ ೖ໳ॻͷ͕࣍গͳ͍ ✓ Rails Cast͘Β͍? ✓ ྑ͍։ൃݱ৔Ͱڞ༗͞Ε͍ͯΔ

ྑ͍։ൃݱ৔Ͱ ڞ༗͞Ε͍ͯΔϊ΢ϋ΢Λ ίϛϡχςΟʔͰڞ༗͍ͨ͠

γφϦΦ ✓ ؅ཧऀ͕Ϣʔβʔ৘ใҰׅొ࿥͢Δ ✓ ෳ਺ͷϢʔβʔ৘ใ͕CSVϑΝΠϧʹ͋Δ ✓ CSVϑΝΠϧͷத਎͸ࢯ໊ͱemail

No content

class CreateUsers < ActiveRecord::Migration! def change! create_table :users do |t|! t.string :first_name, null:false! t.string :last_name, null:false! t.string :email, null:false! t.timestamps! end! ! add_index :users, :email, unique: true! end! end Users

͋ΔγεςϜͷ࣮૷

class Admin::UsersController < ApplicationController! def index! end! ! def upload! f = params[:data_file]! flash[:notice] = 'Upload successful'! CSV.open(f.path, 'rb', encoding: 'UTF-8').each do |row|! User.create(! ! ! ! email: row[0], ! ! ! ! first_name: row[1], ! ! ! ! last_name: row[2]! ! ! )! end! redirect_to action: :index! end! end Admin:UsersController

! <% end %>! index.html.erb

ϦϦʔεͯ͠ΈͨΒ ✓ ϑΝΠϧࢦఆ͠ͳ͍ͱΤϥʔʹͳΓ·͢ ✓ ը૾͕Ξοϓϩʔυ͢ΔͱΤϥʔʹͳΓ·͢ ✓ ○○͞ΜͷemailΞυϨε͕͓͔͍͠Ͱ͢ ✓ ΤΫηϧ͔Β࡞ͬͨCSV͕औΓࠐΊ·ͤΜ ✓ ࡢ೔ొ࿥ͨ͠ϑΝΠϧΛΞοϓϩʔυͪ͠Ό͍·ͨ͠

demo

ཁ͕݅଍Γͳ͍ ✓ ̎࣠ͷόϦσʔγϣϯ ✓ ϑΝΠϧϑΥʔϚοτ ✓ Ϩίʔυݸผ ✓ Ξϥʔτը໘ ✓ ςετ..

def upload! f = params[:data_file]! if f.blank?! flash[:notice] = 'File not found'! redirect_to action: :index! return! end! ! flash[:notice] = 'Upload successful'! CSV.open(f.path, 'rb', encoding: 'UTF-8').each do |row|! unless row[0] =~ /\A[a-z.-_]+@[a-z.-_]+\z/! next! end! ! User.create(! email: row[0], first_name: row[1], last_name: row[2])! end! redirect_to action: :index! end Admin:UsersController Added!

f = params[:data_file]! if f.blank?! ! flash[:notice] = 'File not found'! ! redirect_to action: :index! return! end Admin:UsersController

CSV.open(f.path, 'rb', encoding: 'UTF-8').each do |row|! unless row[0] =~ /\A[a-z.-_]+@[a-z.-_]+\z/! next! end! end Admin:UsersController

✓ Controllerʹ࣮૷͕௥Ճ͞ΕΔ ✓ Validationʹແཧ͕͋Δ

Ͳ͏͢Ε͹ྑ͍ͷ͔ʁ

Ϟσϧʹ͢Δ https://gist.github.com/1syo/319f237637cf522c8c9f

[email protected] ۭ৚ ঝଠ࿠ [email protected] ՖژӃ య໌ CSVϑΝΠϧશମ͸UserImportϞσϧ Ϟσϧ͸ͭ ֤ߦ͸UserϞσϧ

class Admin::UsersController < ApplicationController! def index! @user_import = UserImport.new! end! ! def import! @user_import = UserImport.new(params[:user_import])! if @user_import.save! redirect_to url_for(action: :index), ! ! ! ! ! notice: 'Upload successful'! else! render :index! end! end! end admin/users_controller.rb

ScaffoldͬΆ͍Controller

<%= form_for(@user_import, url: import_admin_users_path,! html: {method: :post, multipart: true}) do |f| %>! <% if @user_import.errors.any? %>! ! <% end %>! <% end %>! … index.html.erb

form_forΛ࢖͏

ΤοϥʔϝοηʔδΛ දࣔ͢Δ

class UserImport! CSV_OPTIONS = {encoding: 'UTF-8'}.freeze! include ActiveModel::Model! ! attr_accessor :file! ! validates :file, presence: true! validate :csv_format, ! ! ! ! if: Proc.new { |m| m.file.present? }! ! def save; end! ! private! def csv_format;end! def path; end! end user_import.rb

class User < ActiveRecord::Base! validates :first_name, ! ! ! length: { maximum: 100 }, presence: true! validates :last_name, ! ! ! length: { maximum: 100 }, presence: true! validates :email, ! ! ! length: { maximum: 100 }, presence: true, uniqueness: true! end user.rb

ActiveModel::ModelΛ࢖͏

Custom ValidationΛ࡞Δ

def save! return false unless valid?! ! User.transaction do! CSV.read(path, "r", CSV_OPTIONS).each_with_index do |row, index|! user = User.new(! ! ! ! email: row[0], ! ! ! ! first_name: row[1], ! ! ! ! last_name: row[2]! ! ! )! unless user.save! errors.add(! ! ! ! ! "line #{index+1} : ", ! ! ! ! ! user.errors.full_messages.join(" , “)! ! ! ! )! end! end! ! if errors.any?! raise ActiveRecord::Rollback! end! end! ! !errors.any?! end user_import.rb

UserϞσϧͷerrorsΛ UserImportϞσϧͷerrorsʹ add͢Δ

private! def csv_format! CSV.open(path, "r", CSV_OPTIONS) { |csv| }! rescue! errors.add(:file, "is invalid csv format")! end! ! def path! if file.respond_to? :path! file.path! else! file! end! end user_import.rb

demo

ςετΛͲ͏ॻ͘ʁ

describe "#save" do! subject { UserImport.new(file: file) }! context "༗ޮͳϑΥʔϚοτͷ࣌" do! let(:file) do! ! ! Rails.root.join(“spec/fixtures/valid.csv")! ! ! end! let(:error_count) { CSV.read(file).count }! it { expect(subject.save).to be_truthy }! it do! ! ! expect { subject.save }.to! ! ! ! ! change(User, :count).by(error_count)! ! ! end! end! end user_import_spec.rb

RSpec.describe UserImport do! describe "#save" do! subject { UserImport.new(file: file) }! context "UserϞσϧͰΤϥʔͰ͕͋Δ࣌" do! let(:file) do! ! ! Rails.root.join(“spec/fixtures/valid.csv")! ! ! end! let(:errors) { double(add: nil, clear: nil, empty?: nil) }! before do! allow_any_instance_of(User).to receive(:save) { false }! expect(subject).to receive(:errors) { errors }.twice! end! it { expect(subject.save).to be_falsey }! it do! ! ! expect { subject.save }.not_to ! ! ! ! change(User, :count)! ! ! end! end! end! end user_import_spec.rb

RSpec.describe Admin::UsersController do! describe "POST import" do! let(:attributes) { { file: Rack::Test::UploadedFile.new(file, "text/plan") } }! ! describe "with valid params" do! let(:file) { Rails.root.join("spec/fixtures/valid.csv") }! let(:record_count) { CSV.read(file).count }! ! it "creates new Users" do! expect {! post :import, {user_import: attributes}! }.to change(User, :count).by(record_count)! end! ! it "redirects to the created user" do! post :import, {user_import: attributes}! expect(response).to redirect_to(action: :index)! end! end! end! end admin/users_controller_spec.rb

·ͱΊ ✓ form_forͰݕ౼ͯ͠ΈΔ ✓ ScaffoldͰͰ͖ͨControllerͷઃܭΛ·ͶΔ ✓ ActiveModel::ModelΛ࢖͏ ✓ Custom ValidationΛ࢖͏

͋ͳͨͳΒͲ͏࣮૷͢Δ͔ ڭ͍͑ͯͩ͘͞