*%&͕ੜ͢Δ
ίϝϯτΛফ͢
✘ Bad
!
1 package jp.pxv.android;
2
3 /**
4 * Created by Chobi on 2014/05/26.
5 */
6
7 public class CreatedByComment {
IUUQTUBDLPWFSqPXDPNRVFTUJPOT
Slide 42
Slide 42 text
*%&͕ੜ͢Δ
ίϝϯτΛফ͢
✔ Good
!
1 package jp.pxv.android;
2
3 public class CreatedByComment {
IUUQTUBDLPWFSqPXDPNRVFTUJPOT
Slide 43
Slide 43 text
ఆTUBUJDpOBMͰ
1 public class Constants {
2 // ✘ Bad
3 private final String BAD_FOO = "foo";
4 private final String BAD_BAR = "bar";
5
6 // ✔ Good
7 private static final String GOOD_FOO = "foo";
8 private static final String GOOD_BAR = "bar";
9 }
Slide 44
Slide 44 text
ม໊
✘ Bad
1 @Override
2 public void onProgressChanged(float progressRate) {
3 final float _progressRate = progressRate;
4 uiThreadHandler.post(new Runnable() {
5 @Override
6 public void run() {
7 if (_progressRate == 1) {
8 progressBar.setVisibility(View.GONE);
9 }
10 }
11 });
12 }
Slide 45
Slide 45 text
ม໊
✔ Good
1 @Override
2 public void onProgressChanged(final float progressRate) {
3 uiThreadHandler.post(new Runnable() {
4 @Override
5 public void run() {
6 if (progressRate == 1) {
7 progressBar.setVisibility(View.GONE);
8 }
9 }
10 });
11 }
Slide 46
Slide 46 text
ଞʹ
w ্ྲྀϒϥϯνͰ͢Ͱʹมߋ͞Ε͍ͯΔ
ͷ͕1VMM3FRVFTUͷϒϥϯνͰಉ
͡มߋͷผͷDPNNJUΛ͍ͯ͠Δ
w ˠఆظతʹ্ྲྀϒϥϯνΛ
git merge --no-ffͰऔΓࠐΊ
Α͍
Slide 47
Slide 47 text
·ͱΊ
w มߋ͕ଟ͗͢ΔͱϨϏϡʔ͠ʹ͍͘
w ϨϏϡʔΛසൟʹߦ͏ͳͲ͢Δඞཁ͕͋Δ
ˠ1VMM3FRVFTUͷ୯ҐΛࡉ͔͘͢Δ
w ͏͔͝ͳ͍ίʔυΑΓ͏͘͝ίʔυͷ΄
͏͕͍͍
w ίʔυஅવ͖Ε͍ͳ΄͏͕͍͍