Slide 1

Slide 1 text

Code review in JavaScript

Slide 2

Slide 2 text

Who made this cool slide deck??? ● Director @ indigo (hiring JS devs) ● @theadamconrad on Twitter ● Contributor to deno ● Boston JS co-organizer ● Writer for SEDaily and host for Software Engineering Radio ● ??? ● P r o f i t

Slide 3

Slide 3 text

Do u know how to code review?

Slide 4

Slide 4 text

Do u know how to code review? ● It’s not

Slide 5

Slide 5 text

Do u know how to code review? ● It’s not → ✅ looks good

Slide 6

Slide 6 text

Do u know how to code review? ● It’s not → ✅ looks good ● It’s probably more like

Slide 7

Slide 7 text

Do u know how to code review? ● It’s not → ✅ looks good ● It’s probably more like → ⁉ could we split this code up and test it

Slide 8

Slide 8 text

An example is probably best https://github.com/indigo-ag/api-interview/pull/1