Tweet
Tweet

Slide 1

Slide 1 text

Code Reviews @hannesvdvreken @phpantwerp

Slide 2

Slide 2 text

Hi, my name is Hannes.

Slide 3

Slide 3 text

!

Slide 4

Slide 4 text

No content

Slide 5

Slide 5 text

No content

Slide 6

Slide 6 text

Code reviews

Slide 7

Slide 7 text

PSR-2 Laravel code style Symfony code style

Slide 8

Slide 8 text

No content

Slide 9

Slide 9 text

No content

Slide 10

Slide 10 text

No content

Slide 11

Slide 11 text

No content

Slide 12

Slide 12 text

No content

Slide 13

Slide 13 text

No content

Slide 14

Slide 14 text

What’s a code review?

Slide 15

Slide 15 text

git

Slide 16

Slide 16 text

push commits review commits reply approve writer reviewer ↻

Slide 17

Slide 17 text

push commits review commits reply approve ↻ writer reviewer

Slide 18

Slide 18 text

git add -p git checkout -p WHAT MAKES A CODE REVIEW?

Slide 19

Slide 19 text

$ git add -p diff --git a/composer.json b/composer.json index 55f40d7..c2cdaa7 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "name": "get-stream/stream", "description": "A PHP client for Stream (https://getstream.io)", - "keywords": ["stream", "newsfeed", "feedly"], + "keywords": ["stream", "newsfeed", "feedly", "activity", "feed"], "homepage": “https://getstream.io", Stage this hunk [y,n,q,a,d,/,e,?]? WHAT MAKES A CODE REVIEW?

Slide 20

Slide 20 text

No content

Slide 21

Slide 21 text

Why spend time on that?

Slide 22

Slide 22 text

Submitter WHY SPEND TIME ON THAT?

Slide 23

Slide 23 text

Reviewer WHY SPEND TIME ON THAT?

Slide 24

Slide 24 text

Management WHY SPEND TIME ON THAT?

Slide 25

Slide 25 text

No content

Slide 26

Slide 26 text

What should a writer do?

Slide 27

Slide 27 text

No content

Slide 28

Slide 28 text

No content

Slide 29

Slide 29 text

No content

Slide 30

Slide 30 text

No content

Slide 31

Slide 31 text

What should a reviewer do?

Slide 32

Slide 32 text

don’ts ❌ WHAT SHOULD A REVIEWER DO?

Slide 33

Slide 33 text

No content

Slide 34

Slide 34 text

No content

Slide 35

Slide 35 text

No content

Slide 36

Slide 36 text

do ✓ WHAT SHOULD A REVIEWER DO?

Slide 37

Slide 37 text

No content

Slide 38

Slide 38 text

No content

Slide 39

Slide 39 text

No content

Slide 40

Slide 40 text

No content

Slide 41

Slide 41 text

No content

Slide 42

Slide 42 text

No content

Slide 43

Slide 43 text

Language

Slide 44

Slide 44 text

OMG IM A BIG FAN OF UR CODEZ LANGUAGE

Slide 45

Slide 45 text

BRO, what iz up with dis? Ma mom cud v written bettr code LANGUAGE

Slide 46

Slide 46 text

No politics LANGUAGE

Slide 47

Slide 47 text

Can’t stand the person giving you feedback? LANGUAGE

Slide 48

Slide 48 text

LANGUAGE

Slide 49

Slide 49 text

LANGUAGE

Slide 50

Slide 50 text

LANGUAGE

Slide 51

Slide 51 text

No content

Slide 52

Slide 52 text

No content

Slide 53

Slide 53 text

No content

Slide 54

Slide 54 text

Wrapping up

Slide 55

Slide 55 text

https://youtu.be/3Fn68v7JWKI

Slide 56

Slide 56 text

Thank you! @hannesvdvreken @phpantwerp

Slide 57

Slide 57 text

Time for questions. @hannesvdvreken @phpantwerp