Tweet
Tweet

Slide 1

Slide 1 text

@KULKARNIANKITA9 THE ART OF HUMANIZING PULL REQUESTS ANKITA KULKARNI, RANGLE.IO

Slide 2

Slide 2 text

@KULKARNIANKITA9 HI I’M ANKITA

Slide 3

Slide 3 text

AGENDA @KULKARNIANKITA9 HOW TO CREATE A PR? 
 HOW TO REVIEW A PR? HOW TO RESPOND TO FEEDBACK? WHAT IS A PR?

Slide 4

Slide 4 text

@KULKARNIANKITA9 WHAT IS A PULL REQUEST (PR)?

Slide 5

Slide 5 text

@KULKARNIANKITA9 HOW TO CREATE A PULL REQUEST?

Slide 6

Slide 6 text

@KULKARNIANKITA9 BREAKDOWN YOUR STORY/FEATURE AS A USER, I CAN ADD/DELETE ITEMS FROM A LIST PR #1: ADD A TEXT BOX & AN ADD BUTTON ON THE PAGE PR #2: CLICKING ON ADD BUTTON ADDS THE ITEM TO THE LIST PR #3: CLICKING ON DELETE, DELETES ITEM FROM THE LIST

Slide 7

Slide 7 text

@KULKARNIANKITA9 IN-LINE WITH THE PROGRAMMER’S OATH I WILL MAKE FREQUENT, SMALL, RELEASES SO THAT I DO NOT IMPEDE THE PROGRESS OF OTHERS. by Robert C. Martin “ “

Slide 8

Slide 8 text

@KULKARNIANKITA9 YOU WILL GET REVIEWER BLESSINGS FOR DOING SO
 #BLESSINGS

Slide 9

Slide 9 text

@KULKARNIANKITA9 ADD COMMENTS ON YOUR PR

Slide 10

Slide 10 text

@KULKARNIANKITA9 ➕SCREENSHOTS/GIFS AS A USER, I WOULD LIKE TO VIEW EVERY SCREEN USING THE TAB BAR

Slide 11

Slide 11 text

@KULKARNIANKITA9 TESTS ARE DOCUMENTATION 
 OF YOUR CODE

Slide 12

Slide 12 text

@KULKARNIANKITA9 Can I split this code into smaller functions? Should I rename this function to something more obvious? How can I simplify my code further so it’s less complex? WHILE WRITING TESTS

Slide 13

Slide 13 text

@KULKARNIANKITA9 REGARDLESS, YOU SHOULD 
 WRITE A TEST.

Slide 14

Slide 14 text

@KULKARNIANKITA9

Slide 15

Slide 15 text

@KULKARNIANKITA9 HOW TO REVIEW A PULL REQUEST?

Slide 16

Slide 16 text

@KULKARNIANKITA9 BE EMPATHETIC

Slide 17

Slide 17 text

@KULKARNIANKITA9 FEELINGS CAN GET HURT EASILY

Slide 18

Slide 18 text

@KULKARNIANKITA9 DON’T BE TOO SERIOUS

Slide 19

Slide 19 text

@KULKARNIANKITA9 FAMILIARIZE YOURSELF WITH THE CODE *

Slide 20

Slide 20 text

@KULKARNIANKITA9 ALWAYS PROVIDE 
 CODE SUGGESTIONS

Slide 21

Slide 21 text

@KULKARNIANKITA9 THIS WILL CRASH WHEN IT’S NULL SO YOU SHOULD NULL 
 CHECK THIS. WHAT WILL HAPPEN IF THIS VALUE IS NULL? WHAT ARE SOME CASES WHERE THIS VALUE MIGHT BE NULL? REWORDING FEEDBACK…

Slide 22

Slide 22 text

@KULKARNIANKITA9 DON’T FORCE IT, KEEP IT REAL USE EMOJIS

Slide 23

Slide 23 text

@KULKARNIANKITA9 TAKE IT OFFLINE OR .

Slide 24

Slide 24 text

@KULKARNIANKITA9 NITPICK

Slide 25

Slide 25 text

@KULKARNIANKITA9 MAKE IT AN ES/TS LINT RULE

Slide 26

Slide 26 text

@KULKARNIANKITA9 DON’T LITTER CODE 
 WITH NITPICKS

Slide 27

Slide 27 text

@KULKARNIANKITA9 HOW TO RESPOND TO FEEDBACK?

Slide 28

Slide 28 text

@KULKARNIANKITA9 IF YOU THINK FEEDBACK IS VALID, IMPLEMENT IT

Slide 29

Slide 29 text

@KULKARNIANKITA9 I WASN’T AWARE OF THIS API. THAT’S REALLY USEFUL! THAT’S AN EXCELLENT POINT, CHANGE COMING RIGHT AWAY! BREAKING UP THIS FUNCTION WAS A GREAT IDEA. SO MUCH SIMPLER NOW. THIS IS AN ELEGANT SOLUTION. I NEVER WOULD HAVE THOUGHT OF THAT. EXAMPLES…

Slide 30

Slide 30 text

@KULKARNIANKITA9 IF YOU DISAGREE

Slide 31

Slide 31 text

@KULKARNIANKITA9 MAKE YOUR COMMIT MESSAGES OBVIOUS USE GITMOJI

Slide 32

Slide 32 text

@KULKARNIANKITA9 ✨ INTRODUCING A NEW FEATURE FIXING A BUG ✅ ADDING TESTS! PR COMMENTS RELATED WRITING DOCS!

Slide 33

Slide 33 text

@KULKARNIANKITA9 ONCE YOU FIX A DEFECT, ADD A TEST

Slide 34

Slide 34 text

@KULKARNIANKITA9 WHAT IF THEY ARE REMOTE?

Slide 35

Slide 35 text

@KULKARNIANKITA9 PAIR PROGRAMMING

Slide 36

Slide 36 text

@KULKARNIANKITA9

Slide 37

Slide 37 text

@KULKARNIANKITA9 SMALL THINGS CAN HAVE A BIG IMPACT

Slide 38

Slide 38 text

@KULKARNIANKITA9 THANK YOU @KULKARNIANKITA9