Tweet
Tweet

Slide 1

Slide 1 text

Code Reviews How to get an instant +1 and make reviewers love you David Majda (@dmajda) Feb 20, 2015

Slide 2

Slide 2 text

Intro

Slide 3

Slide 3 text

No content

Slide 4

Slide 4 text

Preparing PRs Reviewing PRs Code smells

Slide 5

Slide 5 text

Preparing PRs

Slide 6

Slide 6 text

Make PRs small

Slide 7

Slide 7 text

Easy to review Don’t rot so quickly Less conflicts Less breakage

Slide 8

Slide 8 text

Atomic Incremental Features / Refactoring / Formatting Controversial / Non-controversial

Slide 9

Slide 9 text

No content

Slide 10

Slide 10 text

No content

Slide 11

Slide 11 text

Advise reviewers

Slide 12

Slide 12 text

State Assumptions Focus areas

Slide 13

Slide 13 text

No content

Slide 14

Slide 14 text

No content

Slide 15

Slide 15 text

Use commit messages

Slide 16

Slide 16 text

http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

Slide 17

Slide 17 text

Reviewing PRs

Slide 18

Slide 18 text

Do I get it?

Slide 19

Slide 19 text

Checklist

Slide 20

Slide 20 text

High-level

Slide 21

Slide 21 text

Best approach & design? Proper level of abstraction? Change isolated?

Slide 22

Slide 22 text

Mid-level

Slide 23

Slide 23 text

Already seen this? Easy to maintain? Easy to extend? Not overengineered? Boy scout rule?

Slide 24

Slide 24 text

Low-level

Slide 25

Slide 25 text

Are errors handled? Covered by tests? Follows coding style? Bugs: other occurrences?

Slide 26

Slide 26 text

Code smells

Slide 27

Slide 27 text

Long functions

Slide 28

Slide 28 text

No content

Slide 29

Slide 29 text

No modularity

Slide 30

Slide 30 text

No interfaces

Slide 31

Slide 31 text

That’s it!