Tweet
Tweet

Slide 1

Slide 1 text

Zen Code Reviews The (fast) way towards painless code reviews CodeMobile UK 2017 - Chester

Slide 2

Slide 2 text

Why ◎ Find defects early ◎ Harmonize code base ◎ Generate discussion ◎ Share knowledge ◎ Team Building @xgouchet

Slide 3

Slide 3 text

◎ Pre vs Post Commit ◎ Mandatory vs Optional ◎ Remote vs Pair Review ◎ Static Analysis Workflows @xgouchet

Slide 4

Slide 4 text

Reviewable Code ◎ Keep the commits short ◎ git add --patch ◎ Use a proper commit message ○ CR Brief ◎ Review your own code @xgouchet

Slide 5

Slide 5 text

Commenting on issues ◎ Be precise ○ “This uses too much memory…” ◎ Argument ○ “… because this object is not retained when …” ◎ Help fix it ○ “You could instead use …” ◎ Define criticity ○ “Itʼs not critical and can be done in a later commit” @xgouchet This is bad This is bad

Slide 6

Slide 6 text

Best behavior ◎ Stay open minded ◎ Make it about the code ◎ Share knowledge ◎ Give as much as you receive @xgouchet