How to perform a code
review well
• Read the issue before
reviewing code
• Asking questions
encourages discussion
• Be supportive and
helpful.
Slide 5
Slide 5 text
What to look for
• Test coverage
• Duplicate code
• Security
• Anything else!
Slide 6
Slide 6 text
How can the author make
code reviews better?
• Each set of changes should be one coherent
thought
• Good version control comments
• Self-documenting code
• Be a “team lead” in your own task
Slide 7
Slide 7 text
Coding Standards
• Developers know what to expect
• Keeps code reviews efficient
• Improved development speed
Slide 8
Slide 8 text
How teams perform
code reviews
Slide 9
Slide 9 text
Volunteer-basis/Pull Requests
Slide 10
Slide 10 text
No content
Slide 11
Slide 11 text
Volunteer-basis/Pull
Requests
• Efficient, does not interrupt developer
• Everyone can participate
• Fits neatly into existing workflows
Slide 12
Slide 12 text
Group Code Reviews
Slide 13
Slide 13 text
Group Code Reviews
• Require meetings
• Can take up a lot of time
Slide 14
Slide 14 text
No content
Slide 15
Slide 15 text
No content
Slide 16
Slide 16 text
No content
Slide 17
Slide 17 text
Group Code Reviews
• Requires meetings
• Can take up a lot of time
• Can drift into problem-solving
• Not necessarily more effective than
previous method
Slide 18
Slide 18 text
Pair Reviews
• Allows interaction
• Can be used for
mentoring new
developers
• Author can skip a
change
• Review is driven by
the developer