Tweet
Tweet

Slide 1

Slide 1 text

Code reviews @hannesvdvreken @phpgent

Slide 2

Slide 2 text

Hi, my name is Hannes.

Slide 3

Slide 3 text

!

Slide 4

Slide 4 text

madewithlove.be

Slide 5

Slide 5 text

Code reviews

Slide 6

Slide 6 text

What makes a code review?

Slide 7

Slide 7 text

push commits review commits reply approve

Slide 8

Slide 8 text

git add -p WHAT MAKES A CODE REVIEW?

Slide 9

Slide 9 text

Why spend time on that?

Slide 10

Slide 10 text

Submitter WHY SPEND TIME ON THAT?

Slide 11

Slide 11 text

Reviewer WHY SPEND TIME ON THAT?

Slide 12

Slide 12 text

Management WHY SPEND TIME ON THAT?

Slide 13

Slide 13 text

@PHP_CEO YOU THINK DEPLOYING HUNDREDS OF TIMES A DAY IS COOL? WE DEPLOY *INFINITY* TIMES A DAY BY CUTTING OUT THE MIDDLEMAN AND EDITING LIVE CODE

Slide 14

Slide 14 text

Management WHY SPEND TIME ON THAT?

Slide 15

Slide 15 text

What should a submitter do?

Slide 16

Slide 16 text

Intermezzo: code style

Slide 17

Slide 17 text

PSR-2 (soon PSR-12) Symfony code style

Slide 18

Slide 18 text

No content

Slide 19

Slide 19 text

multiline_array_trailing_comma

Slide 20

Slide 20 text

No content

Slide 21

Slide 21 text

phpdoc_params align_double_arrow align_equals

Slide 22

Slide 22 text

Braces

Slide 23

Slide 23 text

No content

Slide 24

Slide 24 text

No content

Slide 25

Slide 25 text

new_with_braces

Slide 26

Slide 26 text

No content

Slide 27

Slide 27 text

What should a reviewer do?

Slide 28

Slide 28 text

don’ts ❌ WHAT SHOULD A REVIEWER DO?

Slide 29

Slide 29 text

do ✓ WHAT SHOULD A REVIEWER DO?

Slide 30

Slide 30 text

Language

Slide 31

Slide 31 text

LANGUAGE

Slide 32

Slide 32 text

No content

Slide 33

Slide 33 text

No content

Slide 34

Slide 34 text

No content

Slide 35

Slide 35 text

No content

Slide 36

Slide 36 text

OMG I'M A BIG FAN OF UR CODES LANGUAGE

Slide 37

Slide 37 text

LANGUAGE

Slide 38

Slide 38 text

No content

Slide 39

Slide 39 text

Thank you! @hannesvdvreken @phpgent

Slide 40

Slide 40 text

Time for questions. @hannesvdvreken @phpgent