Slide 1

Slide 1 text

foolab.ca | @foolabca Rewriting
 15-Year-Old Code Bulgaria PHP, Sofia - October 8, 2016

Slide 2

Slide 2 text

#bgphp16

Slide 3

Slide 3 text

Anna Filina • Developer • Problem solver • Teacher • Advisor • FooLab + ConFoo 3

Slide 4

Slide 4 text

You Inherited a
 15-Year-Old Codebase Code Doesn't Age Like Wine

Slide 5

Slide 5 text

The Web Was 600px Wide 5

Slide 6

Slide 6 text

Feeling Old Yet? • Y2K bug. • Internet Explorer 5. • ICQ was starting to be cool. • Rounded corners = status symbol. 6

Slide 7

Slide 7 text

Code Smells

Slide 8

Slide 8 text

Mixed Concerns

Total:

8

Slide 9

Slide 9 text

Global Functions & Constants include("functions.php"); MyClass::myMethod(); // namespaced function? anotherMethod(DEV_MODE); 9

Slide 10

Slide 10 text

False Security $clean = htmlentities($_GET['password']); // use filter functions or a framework // use prepared statements 10

Slide 11

Slide 11 text

Inexplicable Conditions if ($order_id > 20117) { // use this sql } else { // use that sql } // weakness = time to refactor 11

Slide 12

Slide 12 text

Long Methods public function importCsv($path, $googleApiKey, $databaseDsn, $databaseUser, $databasePassword) { // Convert CSV to array of conferences $lines = file($path); $csv = array_map('str_getcsv', $lines); $conferences = []; foreach ($csv as $line) { $conference = new Conference(); $conference->name = $line[0]; $conference->location = $line[1]; $conferences[] = $conference; // Get coordinates for location $location = urlencode($conference->location); $url = 'https://maps.googleapis.com/maps/api/geocode/json?address='.$location.'&key='.$googleApiKey; $curl = curl_init(); curl_setopt($curl, CURLOPT_URL, $url); curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1); $response = curl_exec($curl); curl_close($curl); $json = json_decode($response); if (count($json->results) == 0) { continue; } $latitude = $json->results[0]->geometry->location->lat; $longitude = $json->results[0]->geometry->location->lng; $coordinates = $latitude.','.$longitude; $conference->coordinates = $coordinates; // Save conference to database $pdo = new PDO($databaseDsn, $databaseUser, $databasePassword); $statement = $pdo->prepare('REPLACE INTO conference (name, location, coordinates) VALUES (?, ?, ?)'); $statement->execute([ $conference->name, $conference->location, $conference->coordinates, ]); 12

Slide 13

Slide 13 text

Average Legacy Code File • 3000-6000 lines of code. • Half of it is commented "in case we need it later". • Method length of 800 lines. • Abuse of helper classes. • Sometimes no classes at all. 13

Slide 14

Slide 14 text

Codebase • 5,000 classes. • 20,000 methods. • 1,500,000 lines of code. 14

Slide 15

Slide 15 text

Before You Code

Slide 16

Slide 16 text

Strategy • Make a strategy based on constraints. • Full rewrite vs progressive: ◦ By class. ◦ By module. ◦ By HTTP call. • How to run code side-by-side: ◦ Session sharing. ◦ mod_rewrite. 16

Slide 17

Slide 17 text

Data Can Be Lost, Stuff Can Break • Backup: test restore. • Staging env: package versions, configs. • Simulate deployments/ upgrades. • Automate tests before code changes. • Make a risk assessment: ◦ Don't be too optimistic. ◦ Account for side-effects. 17

Slide 18

Slide 18 text

Rewrite Example

Slide 19

Slide 19 text

PHP 3 to PHP 5.6 • HTML + PHP + SQL in same file. • Includes all over the place. • IFs that concatenate SQL. • Previous rewrite attempt: ◦ Failed, made things worse. ◦ Folders of dead code. ◦ Classes with static functions (no instances). 19

Slide 20

Slide 20 text

Solution • Rewrite complex forms in Symfony: ◦ mod_rewrite for concerned pages. • Rewrite biggest module as OOP: ◦ Design extraction. ◦ Automated tests. ◦ Flexible architecture. 20

Slide 21

Slide 21 text

Design Extraction

Slide 22

Slide 22 text

Avoid Code Bias • Old code → design docs. • Validate design docs: ◦ Clarify business rules. • Improve design: ◦ Reduce technical debt. ◦ More flexible. • Design docs → new code. 22

Slide 23

Slide 23 text

Code-Level Advice

Slide 24

Slide 24 text

Code Duplication • Sometimes, the bug is repeated 80+ times. • Remove duplications ASAP. 24

Slide 25

Slide 25 text

Fix Long Methods • Extract broken part into its own method. • Write unit tests for it. • Fix it. • Call it from the mega-method. 25

Slide 26

Slide 26 text

Spot Logical Groups 26 Code block Comment Code block Comment Code block Comment Convert CSV to array of conferences. Get coordinates for conference location. Save conference to database.

Slide 27

Slide 27 text

Extract 27 Code block Comment Code block Method Code block Comment Call method

Slide 28

Slide 28 text

Repeat 28 Code block Method Code block Method Call method Call method Code block Method Call method getConferencesFromCsv getLocationCoordinates saveConference

Slide 29

Slide 29 text

Rewrite Example #2

Slide 30

Slide 30 text

ASP Classic to PHP 5.6 • 15+ spaghetti and hacks. • Language no longer supported. • Huge ERP with lots of code. 30

Slide 31

Slide 31 text

Solution • Rewrite page by page to framework. • mod_rewrite for concerned pages. • DB session adapter in both apps. • Page in any language = HTTP request. ◦ Guzzle tests FTW! 31

Slide 32

Slide 32 text

Guzzle Tests 32

Slide 33

Slide 33 text

Stuck?

Slide 34

Slide 34 text

Try Something New • Bounce ideas. ◦ New people to avoid tunnel vision. • Has this been done before? • Can I try another approach? 34

Slide 35

Slide 35 text

Takeaways • Make a strategy. • Use known tools & methodologies. • Get inspiration from others. • Refactoring gets easier. • Every problem has a solution. 35

Slide 36

Slide 36 text

Anna Filina • Fix bugs & performance issues. • Workshops on testing, Symfony & API. • Advisor on testing strategy, legacy code. • Stickers! 36

Slide 37

Slide 37 text

@afilina afilina.com joind.in