Teaching Through Code Review

Slide 1

Slide 1 text

@DerekB_WI Teaching Through Code Review

Slide 2

Slide 2 text

@DerekB_WI Why Code Review? Prevent Bugs Ensure Consistency

Slide 3

Slide 3 text

@DerekB_WI Importance of Consistency

Slide 4

Slide 4 text

@DerekB_WI Reduce Friction Automate Tedious Checks Consistency

Slide 5

Slide 5 text

@DerekB_WI Make Time for Review Add Code Review to Estimates

Slide 6

Slide 6 text

@DerekB_WI Teaching through Review

Slide 7

Slide 7 text

@DerekB_WI Code Review is Not a Final Exam for a user story

Slide 8

Slide 8 text

@DerekB_WI Knowledge Sharing This is probably one of the most valuable reasons to do code review.” – Trisha Gee of JetBrains

Slide 9

Slide 9 text

@DerekB_WI Reviews by Juniors Yes, with solid procedure

Slide 10

Slide 10 text

@DerekB_WI Readable Code

Slide 11

Slide 11 text

@DerekB_WI Unreadable code

Slide 12

Slide 12 text

@DerekB_WI Readable Code

Slide 13

Slide 13 text

@DerekB_WI Negative Feedback Code Review should not be like grading a final exam.

Slide 14

Slide 14 text

@DerekB_WI Turn it around

Slide 15

Slide 15 text

@DerekB_WI Excellent Coaching Opportunity Insightful feedback accelerates learning and growth. Quality code strengthens readability and system understanding. This is a force multiplier for the team’s long term feature velocity. Curtis Einsmann – AWS Engineer

Slide 16

Slide 16 text

@DerekB_WI

Slide 17

Slide 17 text

@DerekB_WI I comment with kindness I comment on the code, not the person. I avoid using “you” or “your.” I prefix nitpicks with ”nit.” I phrase most comments as questions or suggestions. I leave at least one positive comment. Curtis Einsmann – AWS Engineer

Slide 18

Slide 18 text

@DerekB_WI

Slide 19

Slide 19 text

@DerekB_WI

Slide 20

Slide 20 text

@DerekB_WI learning from others. Remember that code reviews are not just for looking at what’s wrong, but for Camila Lenis – Truora, Inc.

Slide 21

Slide 21 text

@DerekB_WI The Accidental Code Review

Slide 22

Slide 22 text

@DerekB_WI

Slide 23

Slide 23 text

@DerekB_WI Ask for Help Managers should create an environment where collaboration is encouraged.

Slide 24

Slide 24 text

@DerekB_WI Resources ● How to Review Someone Else’s Code - https://youtu.be/TlXy_i27N3w ● Code Review Best Practice - https://youtu.be/a9_0UUUNt-Y ● What to Look For in a Code Review - https://leanpub.com/whattolookforinacodereview\ ● Blackillustrations.com ● https://twitter.com/curtiseinsmann ● https://dev.to/camilaleniss/the-code-review-guide-4gfo ● https://hbr.org/2018/01/negative-feedback-rarely-leads-to-improvement

Slide 25

Slide 25 text

@DerekB_WI Thanks Keep in touch: [email protected]