„(…) when you program,
you have to think about
how someone will read
your code, not just how a
computer will interpret it.“
Kent Beck
Slide 5
Slide 5 text
Not about
Architecture
Slide 6
Slide 6 text
Methods & Code
Slide 7
Slide 7 text
Extra effort
Slide 8
Slide 8 text
Save time
Slide 9
Slide 9 text
Your code base?
Slide 10
Slide 10 text
No content
Slide 11
Slide 11 text
It's about joy!
Slide 12
Slide 12 text
Code is read many more times
than written
Tobias Pfeiffer
@PragTob
pragtob.info
Slide 13
Slide 13 text
Sources
Slide 14
Slide 14 text
Crazy?
Slide 15
Slide 15 text
Are comments a smell?
Slide 16
Slide 16 text
Outdated comments are the
worst
Slide 17
Slide 17 text
The why not the what
Slide 18
Slide 18 text
Comments are an excuse of
the code that it could not be
clearer.
Slide 19
Slide 19 text
# do one thing
…
…
…
# do another thing
…
…
…
# do something more
…
…
Slide 20
Slide 20 text
Extract Methods
Slide 21
Slide 21 text
do_one_thing
do_another_thing
do_something_more
Slide 22
Slide 22 text
# context, outlet, times, time per
step, state, data
def pattern(c, o, t, l, s, d)
# …
end
Slide 23
Slide 23 text
Explanatory and meaningful
names
Slide 24
Slide 24 text
def pattern(context, outlet, time,
time_per_step, state, data)
# …
end
Slide 25
Slide 25 text
Try to keep it to 2 parameters
Slide 26
Slide 26 text
Short Methods (<= 8 LOC)
Slide 27
Slide 27 text
# allowed to drink?
if customer.age > 18
say 'Okay'
prepare_drink requested_drink
say 'here you go'
hand_drink_over drink, customer
else
say 'I am sorry you are not legally
allowed rather to drink here'
say "Would you rather have a
#{NON_ALCOHOLIC_DRINKS.sample}?"
end
Slide 28
Slide 28 text
if customer.age > 18
say 'Okay'
prepare_drink requested_drink
say 'here you go'
hand_drink_over drink, customer
else
say 'I am sorry you are not legally
allowed rather to drink here'
say "Would you rather have a
#{NON_ALCOHOLIC_DRINKS.sample}?"
end
Slide 29
Slide 29 text
if customer.age > 18
say 'Okay'
prepare_drink requested_drink
say 'here you go'
hand_drink_over drink, customer
else
say 'I am sorry you are not legally
allowed rather to drink here'
say "Would you rather have a
#{NON_ALCOHOLIC_DRINKS.sample}?"
end
Slide 30
Slide 30 text
if customer.age > 18
say 'Okay'
prepare_drink requested_drink
say 'here you go'
hand_drink_over drink, customer
else
say 'I am sorry you are not legally
allowed rather to drink here'
say "Would you rather have a
#{NON_ALCOHOLIC_DRINKS.sample}?"
end
Slide 31
Slide 31 text
if allowed_to_drink_alcohol?(customer)
serve_drink requested_drink,
customer
else
propose_non_alcoholic_drink
end