コードレビューをカイゼンする基本の考え方 / How to kaizen code reviewing

Slide 1

Slide 1 text

ίʔυϨϏϡʔΛΧΠθϯ͢Δ جຊͷߟ͑ํ 2021-12-01ɹίʔυϨϏϡʔ LTձɹ#codereviewltɹ ٶ㟒ষଠ @mazamachiʢגࣜձࣾHERPʣ

Slide 2

Slide 2 text

͖ΐ͏ݴ͍͍ͨ͜ͱ

Slide 3

Slide 3 text

ίʔυϨϏϡʔͰ͸  ʓʓͷʓʓʓʓʓͱʓʓʓͰ ϨϏϡʔ͢Δ͜ͱΛݮΒͦ͏

Slide 4

Slide 4 text

ίʔυϨϏϡʔͰ͸  ʓʓͷʓʓʓʓʓͱʓʓʓͰ ϨϏϡʔ͢Δ͜ͱΛݮΒͦ͏

Slide 5

Slide 5 text

͜͜ͰCMͰ͢ • ٶ㟒ষଠ @mazamachi

Slide 6

Slide 6 text

͜͜ͰCMͰ͢ • ٶ㟒ষଠ @mazamachi • גࣜձࣾHERP

Slide 7

Slide 7 text

͜͜ͰCMͰ͢ • ٶ㟒ষଠ @mazamachi • גࣜձࣾHERPιϑτ΢ΣΞΤϯδχΞ • όοΫΤϯυ։ൃɺϑϩϯτΤϯυ։ൃɺཁ݅ఆٛɺϓϩϚωɺ  UXϦαʔνɺ࠾༻׆ಈɺΧελϚʔαΫηεɺͳͲͳΜͰ΋԰

Slide 8

Slide 8 text

͜͜ͰCMͰ͢ • ٶ㟒ষଠ @mazamachi • גࣜձࣾHERPιϑτ΢ΣΞΤϯδχΞ • όοΫΤϯυ։ൃɺϑϩϯτΤϯυ։ൃɺཁ݅ఆٛɺϓϩϚωɺ  UXϦαʔνɺ࠾༻׆ಈɺΧελϚʔαΫηεɺͳͲͳΜͰ΋԰ • ΧΠθϯதಟ

Slide 9

Slide 9 text

ίʔυϨϏϡʔͰ͸  ʓʓͷʓʓʓʓʓͱʓʓʓͰ ϨϏϡʔ͢Δ͜ͱΛݮΒͦ͏

Slide 10

Slide 10 text

ͨ·ʹى͖ͯͨϛε ৽نϝϯόʔ ϨϏϡϫʔ ίʔυॻ͍ͯΈͨʂϨϏϡʔ͓ئ͍͠·͢ let ͡Όͳͯ͘ const ࢖ͬͯͶ ม਺໊͸খจࣈͰ͓ئ͍͠·͢ Ͳ͏͍͏ಈ࡞֬ೝ͔ͨ͠ڭ͍͑ͯͩ͘͞ ௚ͯ͠Έ·ͨ͠ʂ ͋Γ͕ͱ͏ʂ approve Ͱ͢

Slide 11

Slide 11 text

ͨ·ʹى͖ͯͨϛε ৽نϝϯόʔ ϨϏϡϫʔ ίʔυॻ͍ͯΈͨʂϨϏϡʔ͓ئ͍͠·͢ let ͡Όͳͯ͘ const ࢖ͬͯͶ ม਺໊͸খจࣈͰ͓ئ͍͠·͢ Ͳ͏͍͏ಈ࡞֬ೝ͔ͨ͠ڭ͍͑ͯͩ͘͞ ௚ͯ͠Έ·ͨ͠ʂ ͋Γ͕ͱ͏ʂ approve Ͱ͢ ޙʹ΋ͬͱେ͖ͳ໰୊ʢόά΍ઃܭϛεʣ͕ൃ֮

Slide 12

Slide 12 text

ͨ·ʹى͖ͯͨϛε ৽نϝϯόʔ ϨϏϡϫʔ ίʔυॻ͍ͯΈͨʂϨϏϡʔ͓ئ͍͠·͢ let ͡Όͳͯ͘ const ࢖ͬͯͶ ม਺໊͸খจࣈͰ͓ئ͍͠·͢ Ͳ͏͍͏ಈ࡞֬ೝ͔ͨ͠ڭ͍͑ͯͩ͘͞ ௚ͯ͠Έ·ͨ͠ʂ ͋Γ͕ͱ͏ʂ approve Ͱ͢ ޙʹ΋ͬͱେ͖ͳ໰୊ʢόά΍ઃܭϛεʣ͕ൃ֮ ύοͱ໨ʹͭ͘໰୊͹͔Γ ϨϏϡʔͯ͠͠·͏

Slide 13

Slide 13 text

ϨϏϡʔʹ·ͭΘΔೝ஌όΠΞε • Մ༻ੑώϡʔϦεςΟοΫɿೝࣝɺཧղɺܾఆͷࡍʹɺࢥ͍ग़͠΍͢ ͍৘ใ͚ͩʹج͍ͮͯ൑அ͢Δ܏޲ • ϑΥʔΧεޮՌɿ࠷ॳʹ઀ͨ͠৘ใʹҾ͖ͣΒΕɺ෺ࣄͷશମ૾Ͱ͸ ͳ͘Ұ෦෼ͷଆ໘͔͠ݟΑ͏ͱ͠ͳ͍܏޲ • ϢχοτόΠΞεɿ՝୊Λऴྃ͢Δࣄʹ஫ҙΛूத͢Δ܏޲ɻԿͰ͋ Εɺ΍Γऴ͑Δࣄʹਓؒ͸ຬ଍Λײ͡Δ ٱᜌঘ΄͔ɽʮ࡞੒ऀͷೝ஌όΠΞεʹண໨ͨ͠ϨϏϡʔख๏ͷఏҊʯ42J1ݚڀձɽΑΓҾ༻

Slide 14

Slide 14 text

େ͖͍໰୊ʹϑΥʔΧε͢ΔͨΊʹ

Slide 15

Slide 15 text

ίʔυϨϏϡʔͰ͸  ʓʓͷʓʓʓʓʓͱʓʓʓͰ ϨϏϡʔ͢Δ͜ͱΛݮΒͦ͏

Slide 16

Slide 16 text

ίʔυϨϏϡʔͰ͸  ࣄલͷ͢Γ߹ΘͤͱࣗಈԽͰ ϨϏϡʔ͢Δ͜ͱΛݮΒͦ͏

Slide 17

Slide 17 text

Happy Story ৽نϝϯόʔ ϨϏϡϫʔ ͳΔ΄Ͳɺ͜ͷ repository Ͱ͸͜͏ॻ͘ͷ͔ let ͡Όͳͯ͘ const ࢖ͬͯͶ ม਺໊͸খจࣈͰ͓ئ͍͠·͢ ͜͜ͷίʔυɺ͜͏ॻ͍ͨ΄͏͕ྑ͍ͱࢥ͏ ͜͜ςετέʔε଍ͨ͠΄͏͕ྑ͍Α ͜͏͍͏࣌ʹόάΓͦ͏ ࣄલઆ໌จॻ CI

Slide 18

Slide 18 text

Happy Story ৽نϝϯόʔ ϨϏϡϫʔ ͳΔ΄Ͳɺ͜ͷ repository Ͱ͸͜͏ॻ͘ͷ͔ let ͡Όͳͯ͘ const ࢖ͬͯͶ ม਺໊͸খจࣈͰ͓ئ͍͠·͢ ͜͜ͷίʔυɺ͜͏ॻ͍ͨ΄͏͕ྑ͍ͱࢥ͏ ͜͜ςετέʔε଍ͨ͠΄͏͕ྑ͍Α ͜͏͍͏࣌ʹόάΓͦ͏ ࣄલઆ໌จॻ CI ೉͍͚͠Ͳେࣄͳ෦෼ʹूதͯ͠ϨϏϡʔͰ͖Δ

Slide 19

Slide 19 text

Ͳ͏΍ͬͯΧΠθϯ͢Δʁ

Slide 20

Slide 20 text

ίʔυϨϏϡʔͰݟΔ͜ͱ • ίʔσΟϯάن໿ʹԊ͍ͬͯΔ͔ • ςετ͸ॻ͍ͯ͋Δ͔ • ςετ͸௨Δͷ͔ • ςετέʔε͸ద੾͔ • ୭ͷϨϏϡʔ͕ඞཁ͔ • ࣮ࡍʹಈ͘ͷ͔ • อकੑͷߴ͍ίʔυʹͳ͍ͬͯΔ͔ • σϓϩΠ͢ΔࡍʹͲΜͳ४උ͕ඞཁ͔ • GIt ͷίϛοτϩά͸ݟ΍͘͢ͳ͍ͬͯΔ͔ • Θ͔Γ΍͍͢ίϝϯτ͸ॻ͍ͯ͋Δ͔ • ΑΓྑ͍ॻ͖ํ͸ͳ͍͔ • ར༻ϥΠϒϥϦͷόʔδϣϯ͸ద੾͔ • etc…

Slide 21

Slide 21 text

ࣗಈԽ  ͠΍͍͢ ඞཁͳ஌͕ࣝଟ͍ ඞཁͳ஌͕ࣝগͳ͍ ࣗಈԽ  ͮ͠Β͍

Slide 22

Slide 22 text

ίʔσΟϯάن໿ʹ  Ԋ͍ͬͯΔ͔ GIt ͷίϛοτϩά͸ ݟ΍͘͢ͳ͍ͬͯΔ͔ ςετέʔε͸ద੾͔ ࣮ࡍʹಈ͘ͷ͔ ΑΓྑ͍ॻ͖ํ͸ͳ͍͔ Θ͔Γ΍͍͢ίϝϯτ͸ ॻ͍ͯ͋Δ͔ อकੑͷߴ͍ίʔυʹ ͳ͍ͬͯΔ͔ σϓϩΠ͢Δࡍʹ ͲΜͳ४උ͕ඞཁ͔ ࣗಈςετ͸௨Δͷ͔ ୭ͷϨϏϡʔ͕ ඞཁ͔ ར༻ϥΠϒϥϦͷ όʔδϣϯ͸ద੾͔ ࣗಈԽ  ͠΍͍͢ ඞཁͳ஌͕ࣝଟ͍ ඞཁͳ஌͕ࣝগͳ͍ ࣗಈԽ  ͮ͠Β͍

Slide 23

Slide 23 text

ίʔσΟϯάن໿ʹ  Ԋ͍ͬͯΔ͔ GIt ͷίϛοτϩά͸ ݟ΍͘͢ͳ͍ͬͯΔ͔ ςετέʔε͸ద੾͔ ࣮ࡍʹಈ͘ͷ͔ ΑΓྑ͍ॻ͖ํ͸ͳ͍͔ Θ͔Γ΍͍͢ίϝϯτ͸ ॻ͍ͯ͋Δ͔ อकੑͷߴ͍ίʔυʹ ͳ͍ͬͯΔ͔ σϓϩΠ͢Δࡍʹ ͲΜͳ४උ͕ඞཁ͔ ࣗಈςετ͸௨Δͷ͔ ୭ͷϨϏϡʔ͕ ඞཁ͔ ᶃ ࣗಈԽͰ Ͳ͏ʹ͔ͳΔ ྖҬ ᶄ ࣄલʹ͢Γ߹Θͤ Δ΂͖ྖҬ ίʔυϨϏϡʔ ͢Δ΂͖ྖҬ ࣗಈԽ  ͠΍͍͢ ඞཁͳ஌͕ࣝଟ͍ ඞཁͳ஌͕ࣝগͳ͍ ࣗಈԽ  ͮ͠Β͍

Slide 24

Slide 24 text

Slide 25

Slide 25 text

ᶃࣗಈԽͷྫ • CI্ͰϏϧυ΍ςετΛ૸ΒͤΔ • CIͰࣗಈϑΥʔϚολʢe.g. Prettierʣ΍ Linter (e.g. eslint) ΋૸ΒͤΔ • GitHub ͷػೳͷ Problem Matchers Λ࢖͏ͱɺ  ίʔυϨϏϡʔͬΆ͍ίϝϯτΛࣗಈͰ͚ͭͯ͘Εͯศར • CODEOWNERSϑΝΠϧΛ׆༻ͯ͠ɺࣗಈͰ review request ग़དྷΔΑ͏ʹ͢Δ • CI ্ͰϥΠϒϥϦΠϯετʔϧͯ͠ lock ϑΝΠϧͱࠩ෼͕ͳ͍͔νΣοΫ͢Δ

Slide 26

Slide 26 text

Slide 27

Slide 27 text

ᶄࣄલ͢Γ߹Θͤͷྫ • pull_request_template.md Λ׆༻ͯ͠ɺPR description ʹॻ͘΂͖಺༰Λ ຖճΘ͔Γ΍͘͢͢Δ • ࣾ಺ wiki ʢScrapboxʣʹ README ΍ CONTRIBUTING.md తͳ಺༰Λ༻ ҙ͢Δ • GitHub ্Ͱϝϯς͢ΔͱɺPRग़͢ඞཁ͕͋ͬͯ໘౗ɻߋ৽͠΍͍͢৔ ॴʹ͋ͬͨ΄͏͕ྑ͍ͱߟ͍͑ͯΔɻ • Θ͔Γ΍͔ͬͨ͢/ϨϏϡʔͰྑ͘ͳͬͨPRΛެͷ৔Ͱশ͑Δ

Slide 28

Slide 28 text

ᶄࣄલ͢Γ߹Θͤͷྫ

Slide 29

Slide 29 text

ίʔυϨϏϡʔͰ͸  ࣄલͷ͢Γ߹ΘͤͱࣗಈԽͰ ϨϏϡʔ͢Δ͜ͱΛݮΒͦ͏

Slide 30

Slide 30 text

ίʔυϨϏϡʔͰ͸  ࣄલͷ͢Γ߹ΘͤͱࣗಈԽͰ ϨϏϡʔ͢Δ͜ͱΛݮΒͦ͏ ΧΠθϯ஌ݟ͋ͬͨΒ ڭ͑߹͍·͠ΐ͏ʂ

Slide 31

Slide 31 text

ࢀߟจݙ • ٱᜌ ঘ΄͔ɽʮ࡞੒ऀͷೝ஌όΠΞεʹண໨ͨ͠ϨϏϡʔख๏ͷఏ ҊʯSQiPݚڀձɽ2017

Slide 32

Slide 32 text

࠷ޙʹCMͰ͢ɿ ࠾༻ͯ͠·͢ʂ • HERP Culture Deck: https://culture.herp.co.jp/ • ΤϯδχΞ޲͚࠾༻ࢿྉ: https://github.com/herp-inc/engineering-careers • ΤϯδχΞܥ৬छ࠾༻ϖʔδ: https://herp.careers/v1/herpinc/requisition- groups/84aec4e1-19c7-4268-b62a-027470d1ebd9