Tweet
Tweet

Slide 1

Slide 1 text

Nuna | Confidential @maltzj Code Reviewing Like A Champion Jonathan Maltz @maltzj 5-10-19 AUTHOR DATE

Slide 2

Slide 2 text

Nuna | Confidential @maltzj Why do code review?

Slide 3

Slide 3 text

Nuna | Confidential @maltzj 3 Ensure Correctness

Slide 4

Slide 4 text

Nuna | Confidential @maltzj 4 Improve Design

Slide 5

Slide 5 text

Nuna | Confidential @maltzj 5 Share Knowledge

Slide 6

Slide 6 text

Nuna | Confidential @maltzj How to do that?

Slide 7

Slide 7 text

Nuna | Confidential @maltzj 7 Psychological Safety

Slide 8

Slide 8 text

Nuna | Confidential @maltzj 8 Psychological safety is a shared belief that the team is safe for interpersonal risk taking. It can be defined as "being able to show and employ one's self without fear of negative consequences of self-image, status or career" (Kahn 1990, p. 708). In psychologically safe teams, team members feel accepted and respected.

Slide 9

Slide 9 text

Nuna | Confidential @maltzj 9 Make People Feel Worse

Slide 10

Slide 10 text

Nuna | Confidential @maltzj ● "Your code style here is inconsistent. Bring your code in line with our style guidelines." ● "This Dockerfile will take forever to build. Re-order it to make it faster" ● "Why did you do this refactor? The code was better in its previous form" How does that Manifest? 10

Slide 11

Slide 11 text

Nuna | Confidential @maltzj 11

Slide 12

Slide 12 text

Nuna | Confidential @maltzj 12 "This code is good, let's make it even better"

Slide 13

Slide 13 text

Nuna | Confidential @maltzj 3 Step Process

Slide 14

Slide 14 text

Nuna | Confidential @maltzj 14 1. Start with Neutral Facts

Slide 15

Slide 15 text

Nuna | Confidential @maltzj 15 This change uses Jenkins' scripted syntax rather than it's declarative syntax, which is being more widely adopted. Change it to use the declarative syntax.

Slide 16

Slide 16 text

Nuna | Confidential @maltzj 16 Link to External Resources

Slide 17

Slide 17 text

Nuna | Confidential @maltzj 17

Slide 18

Slide 18 text

Nuna | Confidential @maltzj 18 Opinions == Facts

Slide 19

Slide 19 text

Nuna | Confidential @maltzj 19 ✅ You can do blue-green deploys using Docker containers and an ELB.

Slide 20

Slide 20 text

Nuna | Confidential @maltzj 20 Docker containers and an ELB are the best way to do blue-green deploys.

Slide 21

Slide 21 text

Nuna | Confidential @maltzj 21 2. Invite a Discussion

Slide 22

Slide 22 text

Nuna | Confidential @maltzj 22 This change uses Jenkins' scripted syntax rather than it's declarative syntax, which is being more widely adopted. Can you change it to use the declarative syntax?

Slide 23

Slide 23 text

Nuna | Confidential @maltzj 23 3. Replace "you" with "we" or "us"

Slide 24

Slide 24 text

Nuna | Confidential @maltzj 24 This change uses Jenkins' scripted syntax rather than it's declarative syntax, which is being more widely adopted. Can we change it to use the declarative syntax?

Slide 25

Slide 25 text

Nuna | Confidential @maltzj 25

Slide 26

Slide 26 text

Nuna | Confidential @maltzj 26

Slide 27

Slide 27 text

Nuna | Confidential @maltzj 27 Rule of 3

Slide 28

Slide 28 text

Nuna | Confidential @maltzj ● Start with neutral facts ● Invite a discussion ● Replace "You" with "We" or "Us" ● Rule of 3 Summary 28

Slide 29

Slide 29 text

Nuna | Confidential @maltzj ● Yelp's Code Review Guidelines ● How to Use Code Review To Execute Someone's Soul ● Creating a Strong Code Review Culture ● Honesty, Kindness, Inspiration: Pick Three ● Bettercode.reviews ● Giving and Getting Technical Help ● Crucial Conversations External Links 29

Slide 30

Slide 30 text

@maltzj @maltzj https://boards.greenhouse.io/nuna/ https://boards.greenhouse.io/nuna/