Slide 1

Slide 1 text

Cleaner unit testing with the Arrange Act Assert pattern James Cooke Licensed under the Creative Commons Attribution-ShareAlike 3.0 Unported License.

Slide 2

Slide 2 text

Outline ● Background ● Problem ● AAA pattern ● Smells and solutions ● Questions in the break

Slide 3

Slide 3 text

Background ● Python developer ● TDD with AAA ● github.com/txels

Slide 4

Slide 4 text

Givens ● PEP008 is beneficial ● PEP020 is our mantra ● We all TDD ● Every test is a function, uncoupled ● Simplicity trumps performance ● Eliminate duplication

Slide 5

Slide 5 text

Problem ● Pythonic code in project, carnage in tests ● Tests of OSS projects are often hard to understand ● Tests are non-uniform

Slide 6

Slide 6 text

Example Member Account Membership 1 1 m m

Slide 7

Slide 7 text

The Pattern def test_x(*args, **kwargs): """__docstring__ """ # Arrange # Act # Assert AKA ‘AAA’ or ‘3A’

Slide 8

Slide 8 text

def test_x(*args, **kwargs): """__docstring__ """ # Arrange # Act # Assert

Slide 9

Slide 9 text

def test_printable_name(): """__docstring__ """ # Arrange # Act # Assert

Slide 10

Slide 10 text

Docstring ● Follow existing style of your project ● First line positive statement of tested action ● Extra info about test, conditions

Slide 11

Slide 11 text

def test_printable_name(): """__docstring__ """ # Arrange # Act # Assert

Slide 12

Slide 12 text

def test_printable_name(): """New members have printable names """ # Arrange # Act # Assert

Slide 13

Slide 13 text

Arrange ● Single block of code ● No assertions ● Only prepare non-deterministic results not available after Act ● Should not require comments

Slide 14

Slide 14 text

def test_printable_name(): """New members have printable names """ # Arrange # Act # Assert

Slide 15

Slide 15 text

def test_printable_name(): """New members have printable names """ person = Member() person.first_name = 'René' person.last_name = ' 北京 ' # Act # Assert

Slide 16

Slide 16 text

Act ● `result = ` format ● One line only ● Can be wrapped in `with raises` for expected exceptions

Slide 17

Slide 17 text

def test_printable_name(): """New members have printable names """ person = Member() person.first_name = 'René' person.last_name = ' 北京 ' # Act # Assert

Slide 18

Slide 18 text

def test_printable_name(): """New members have printable names """ person = Member() person.first_name = 'René' person.last_name = ' 北京 ' result = person.printable_name() # Assert

Slide 19

Slide 19 text

Assert ● Single block of code ● No actions should happen ● Test result first, then side effects ● Use simple blocks of assertions

Slide 20

Slide 20 text

def test_printable_name(): """New members have printable names """ person = Member() person.first_name = 'René' person.last_name = ' 北京 ' result = person.printable_name() # Assert

Slide 21

Slide 21 text

def test_printable_name(): """New members have printable names """ person = Member() person.first_name = 'René' person.last_name = ' 北京 ' result = person.printable_name() assert result == ' 北京 , René'

Slide 22

Slide 22 text

Smell: Assertions in Arrange

Slide 23

Slide 23 text

def test_account_list(): """Member can list their accounts """ person = Member() account = Account() person.join(account) assert person in account.members result = person.account_list() assert len(result) == 1 assert account in result

Slide 24

Slide 24 text

person = Member() account = Account() person.join(account) assert person in account.members

Slide 25

Slide 25 text

person = Member() account = Account() person.join(account) result = account.members assert person in account.members

Slide 26

Slide 26 text

person = Member() account = Account() person.join(account) result = account.members assert person in result

Slide 27

Slide 27 text

def test_account_member(): """Member can join account """ person = Member() account = Account() person.join(account) result = account.members assert person in result

Slide 28

Slide 28 text

def test_account_member(): """Member can join account """ person = Member() account = Account() person.join(account) result = account.members assert person in result def test_account_list(): """Member can list their accounts """ person = Member() account = Account() person.join(account) assert person in account.members result = person.account_list() assert len(result) == 1 assert account in result

Slide 29

Slide 29 text

def test_account_member(): """Member can join account """ person = Member() account = Account() person.join(account) result = account.members assert person in result def test_account_list(): """Member can list their accounts """ person = Member() account = Account() person.join(account) result = person.account_list() assert len(result) == 1 assert account in result ● Eliminate duplication

Slide 30

Slide 30 text

def test_account_member(): """Member can join account """ person = Member() account = Account() person.join(account) result = account.members assert person in result def test_account_list(): """Member can list their accounts """ person = Member() account = Account() person.join(account) result = person.account_list() assert len(result) == 1 assert account in result person = Member() account = Account() person.join(account) return person, account

Slide 31

Slide 31 text

def test_account_member(): """Member can join account """ person = Member() account = Account() person.join(account) result = account.members assert person in result def test_account_list(): """Member can list their accounts """ person = Member() account = Account() person.join(account) result = person.account_list() assert len(result) == 1 assert account in result def account_member_factory(): """Create Member and Account pair """ person = Member() account = Account() person.join(account) return person, account

Slide 32

Slide 32 text

def account_member_factory(): """Create Member and Account pair """ person = Member() account = Account() person.join(account) return person, account def test_account_member(): """Member can join account """ person = Member() account = Account() person.join(account) result = account.members assert person in result def test_account_list(): """Member can list their accounts """ person = Member() account = Account() person.join(account) result = person.account_list() assert len(result) == 1 assert account in result

Slide 33

Slide 33 text

def account_member_factory(): """Create Member and Account pair """ person = Member() account = Account() person.join(account) return person, account def test_account_list(): """Member can list their accounts """ person = Member() account = Account() person.join(account) result = person.account_list() assert len(result) == 1 assert account in result def test_account_member(): """Member can join account """ person, account = account_member_factory() result = account.members assert person in result

Slide 34

Slide 34 text

def account_member_factory(): """Create Member and Account pair """ person = Member() account = Account() person.join(account) return person, account def test_account_member(): """Member can join account """ person, account = account_member_factory() result = account.members assert person in result def test_account_list(): """Member can list their accounts """ person, account = account_member_factory() result = person.account_list() assert len(result) == 1 assert account in result

Slide 35

Slide 35 text

def account_member_factory(): """Create Member and Account pair """ person = Member() account = Account() person.join(account) return person, account def test_account_member_factory(): """Member can join account """ person, account = account_member_factory() result = account.members assert person in result def test_account_list(): """Member can list their accounts """ person, account = account_member_factory() result = person.account_list() assert len(result) == 1 assert account in result

Slide 36

Slide 36 text

def account_member_factory(): """Create Member and Account pair """ person = Member() account = Account() person.join(account) return person, account def test_account_member_factory(): """account_member_factory creates joined Member Account pair """ person, account = account_member_factory() result = account.members assert person in result def test_account_list(): """Member can list their accounts """ person, account = account_member_factory() result = person.account_list() assert len(result) == 1 assert account in result

Slide 37

Slide 37 text

Smell: Duplication between tests

Slide 38

Slide 38 text

Example Member A Account 1 Member B Member C Account 2 Account 3

Slide 39

Slide 39 text

def test_a_transfer_b(): """Member A in Account 1 can transfer to B """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory() user_b.join(account_one) user_c, account_three = account_member_factory() # Act # Assert def test_a_not_transfer_c(): """Member A in Account 1 can not tranfer to C """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory() user_b.join(account_one) user_c, account_three = account_member_factory() # Act # Assert def test_c_not_transfer_a(): """Member C in Account 3 can not tranfer to A """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory() ● Eliminate duplication

Slide 40

Slide 40 text

class TestTranfers(unittest.TestCase): def test_a_transfer_b(): """Member A in Account 1 can transfer to B """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory() user_b.join(account_one) user_c, account_three = account_member_factory() # Act # Assert def test_a_not_transfer_c(): """Member A in Account 1 can not tranfer to C """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory() user_b.join(account_one) user_c, account_three = account_member_factory() # Act # Assert def test_c_not_transfer_a(): """Member C in Account 3 can not tranfer to A """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory()

Slide 41

Slide 41 text

class TestTranfers(unittest.TestCase): def test_a_transfer_b(self): """Member A in Account 1 can transfer to B """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory() user_b.join(account_one) user_c, account_three = account_member_factory() # Act # Assert def test_a_not_transfer_c(self): """Member A in Account 1 can not tranfer to C """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory() user_b.join(account_one) user_c, account_three = account_member_factory() # Act # Assert def test_c_not_transfer_a(self): """Member C in Account 3 can not tranfer to A """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory()

Slide 42

Slide 42 text

class TestTranfers(unittest.TestCase): def setUp(self): """ """ def test_a_transfer_b(self): """Member A in Account 1 can transfer to B """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory() user_b.join(account_one) user_c, account_three = account_member_factory() # Act # Assert

Slide 43

Slide 43 text

Addendum: TestCase.setUp ● A pure Arrange block ● Docstring if required ● Assert valid with a special test called test_set_up

Slide 44

Slide 44 text

class TestTranfers(unittest.TestCase): def setUp(self): """Create three Accounts and three members --------+--------------------------- Member | Accounts --------+--------------------------- user_a | account_one user_b | account_one, account_two user_c | account_three --------+--------------------------- """ super().setUp() self.user_a, self.account_one = account_member_factory() self.user_b, self.account_two = account_member_factory() self.user_b.join(self.account_one) self.user_c, self.account_three = account_member_factory() def test_a_transfer_b(self): """Member A in Account 1 can transfer to B """ user_a, account_one = account_member_factory() user_b, account_two = account_member_factory() user_b.join(account_one) user_c, account_three = account_member_factory() # Act # Assert

Slide 45

Slide 45 text

class TestTranfers(unittest.TestCase): def setUp(self): """Create three Accounts and three members --------+--------------------------- Member | Accounts --------+--------------------------- user_a | account_one user_b | account_one, account_two user_c | account_three --------+--------------------------- """ super().setUp() self.user_a, self.account_one = account_member_factory() self.user_b, self.account_two = account_member_factory() self.user_b.join(self.account_one) self.user_c, self.account_three = account_member_factory() def test_a_transfer_b(self): """Member A in Account 1 can transfer to B """ # Act # Assert def test_a_not_transfer_c(self): """Member A in Account 1 can not tranfer to C """ # Act

Slide 46

Slide 46 text

class TestTranfers(unittest.TestCase): def setUp(self): """Create three Accounts and three members --------+--------------------------- Member | Accounts --------+--------------------------- user_a | account_one user_b | account_one, account_two user_c | account_three --------+--------------------------- """ super().setUp() self.user_a, self.account_one = account_member_factory() self.user_b, self.account_two = account_member_factory() self.user_b.join(self.account_one) self.user_c, self.account_three = account_member_factory() def test_set_up(self): def test_a_transfer_b(self): """Member A in Account 1 can transfer to B """ # Act # Assert

Slide 47

Slide 47 text

Addendum: test_set_up ● A pure Assert block ● Docstring if required

Slide 48

Slide 48 text

class TestTranfers(unittest.TestCase): def setUp(self): """Create three Accounts and three members --------+--------------------------- Member | Accounts --------+--------------------------- user_a | account_one user_b | account_one, account_two user_c | account_three --------+--------------------------- """ super().setUp() self.user_a, self.account_one = account_member_factory() self.user_b, self.account_two = account_member_factory() self.user_b.join(self.account_one) self.user_c, self.account_three = account_member_factory() def test_set_up(self): assert self.user_a.account_list() == [self.account_one] assert self.user_b.account_list() == [self.account_one, self.account_two assert self.user_c.account_list() == [self.account_three] def test_a_transfer_b(self): """Member A in Account 1 can transfer to B """ # Act # Assert

Slide 49

Slide 49 text

class TestTranfers(unittest.TestCase): def setUp(self): """Create three Accounts and three members --------+--------------------------- Member | Accounts --------+--------------------------- user_a | account_one user_b | account_one, account_two user_c | account_three --------+--------------------------- """ super().setUp() self.user_a, self.account_one = account_member_factory() self.user_b, self.account_two = account_member_factory() self.user_b.join(self.account_one) self.user_c, self.account_three = account_member_factory() def test_set_up(self): assert self.user_a.account_list() == [self.account_one] assert self.user_b.account_list() == [self.account_one, self.account_two] assert self.user_c.account_list() == [self.account_three] def test_a_transfer_b(self): """Member A in Account 1 can transfer to B """ # Act # Assert def test_a_not_transfer_c(self): """Member A in Account 1 can not tranfer to C """ # Act # Assert def test_c_not_transfer_a(self): """Member C in Account 3 can not tranfer to A """ # Act # Assert

Slide 50

Slide 50 text

Summary ● Demonstrated AAA ● Small and simple tests ● Opens the door to DRY and clarity

Slide 51

Slide 51 text

Thanks! ● Resources: http://jamescooke.info/cleaner... ● @jamesfublo ● Come ask questions ● Let’s talk more about testing ● Thanks for listening! Licensed under the Creative Commons Attribution-ShareAlike 3.0 Unported License.