Tweet
Tweet

Slide 1

Slide 1 text

Code reviews @hannesvdvreken @webcampzg

Slide 2

Slide 2 text

Hi, my name is Hannes.

Slide 3

Slide 3 text

!

Slide 4

Slide 4 text

madewithlove.be

Slide 5

Slide 5 text

Code reviews

Slide 6

Slide 6 text

What makes a code review?

Slide 7

Slide 7 text

git add -p WHAT MAKES A CODE REVIEW?

Slide 8

Slide 8 text

Why spend time on that?

Slide 9

Slide 9 text

Submitter WHY SPEND TIME ON THAT?

Slide 10

Slide 10 text

Reviewer WHY SPEND TIME ON THAT?

Slide 11

Slide 11 text

Management WHY SPEND TIME ON THAT?

Slide 12

Slide 12 text

What should a submitter do?

Slide 13

Slide 13 text

What should a reviewer do?

Slide 14

Slide 14 text

don’ts ❌ WHAT SHOULD A REVIEWER DO?

Slide 15

Slide 15 text

do ✓ WHAT SHOULD A REVIEWER DO?

Slide 16

Slide 16 text

Language WHAT SHOULD A REVIEWER DO?

Slide 17

Slide 17 text

WHAT SHOULD A REVIEWER DO - LANGUAGE

Slide 18

Slide 18 text

OMG I'M A BIG FAN OF UR CODES WHAT SHOULD A REVIEWER DO - LANGUAGE

Slide 19

Slide 19 text

WHAT SHOULD A REVIEWER DO - LANGUAGE

Slide 20

Slide 20 text

Thank you! @hannesvdvreken @webcampzg

Slide 21

Slide 21 text

Time for questions. @hannesvdvreken @webcampzg