Link
Embed
Share
Beginning
This slide
Copy link URL
Copy link URL
Copy iframe embed code
Copy iframe embed code
Copy javascript embed code
Copy javascript embed code
Share
Tweet
Share
Tweet
Slide 1
Slide 1 text
Prague, 21st September 2013 David Majda @dmajda Code Reviews FTW!
Slide 2
Slide 2 text
#1 Ugly Code?
Slide 3
Slide 3 text
#2 Hard to Start?
Slide 4
Slide 4 text
#3 Nobody Understands?
Slide 5
Slide 5 text
What? 1
Slide 6
Slide 6 text
Code review = code checked by other person
Slide 7
Slide 7 text
Why? 2
Slide 8
Slide 8 text
Code Quality
Slide 9
Slide 9 text
Encourage Learning
Slide 10
Slide 10 text
Bus Factor
Slide 11
Slide 11 text
SUSE Way 3
Slide 12
Slide 12 text
No content
Slide 13
Slide 13 text
Code Change Pull Request Review Merge Accept Reject
Slide 14
Slide 14 text
My Way 4
Slide 15
Slide 15 text
Do I Understand It?
Slide 16
Slide 16 text
David's Personal Code Review Checklist
Slide 17
Slide 17 text
High-level Checklist
Slide 18
Slide 18 text
High-level Checklist ☑ Best approach & design?
Slide 19
Slide 19 text
High-level Checklist ☑ Best approach & design? ☑ Proper level of abstraction?
Slide 20
Slide 20 text
High-level Checklist ☑ Best approach & design? ☑ Proper level of abstraction? ☑ Change isolated?
Slide 21
Slide 21 text
Mid-level Checklist
Slide 22
Slide 22 text
Mid-level Checklist ☑ Already seen this?
Slide 23
Slide 23 text
Mid-level Checklist ☑ Already seen this? ☑ Easy to maintain?
Slide 24
Slide 24 text
Mid-level Checklist ☑ Already seen this? ☑ Easy to maintain? ☑ Easy to extend?
Slide 25
Slide 25 text
Mid-level Checklist ☑ Already seen this? ☑ Easy to maintain? ☑ Easy to extend? ☑ Not overengineered?
Slide 26
Slide 26 text
Mid-level Checklist ☑ Already seen this? ☑ Easy to maintain? ☑ Easy to extend? ☑ Not overengineered? ☑ Boy scout rule?
Slide 27
Slide 27 text
Low-level Checklist
Slide 28
Slide 28 text
Low-level Checklist ☑ Are erros handled?
Slide 29
Slide 29 text
Low-level Checklist ☑ Are erros handled? ☑ Covered by tests?
Slide 30
Slide 30 text
Low-level Checklist ☑ Are erros handled? ☑ Covered by tests? ☑ Follows coding style?
Slide 31
Slide 31 text
Low-level Checklist ☑ Are erros handled? ☑ Covered by tests? ☑ Follows coding style? ☑ Bugs: other occurrences?
Slide 32
Slide 32 text
Social Aspects 5
Slide 33
Slide 33 text
No content
Slide 34
Slide 34 text
No content
Slide 35
Slide 35 text
No content
Slide 36
Slide 36 text
No content
Slide 37
Slide 37 text
David Majda @dmajda