Tweet
Tweet

Slide 1

Slide 1 text

DANNY KOPPING Code-reviews: a team tool Teams & People

Slide 2

Slide 2 text

Who’s the loudmouth? Danny Kopping - Lead Developer @ Zando @dannykopping http://lanyrd.com/cfydfp

Slide 3

Slide 3 text

Main Challenges in producing software

Slide 4

Slide 4 text

• defects in production • adherence to style-guides • technical debt • silos • inconsistency • inefficiency • incomprehensibility • duplication • lack of tests • inability to test • rigidity • tight coupling • best-practice violations • anti-patterns • …etc

Slide 5

Slide 5 text

Who cares? When we break something, we’ll fix it #YOLO

Slide 6

Slide 6 text

http://bit.ly/1RuSIBr Bugs cost money

Slide 7

Slide 7 text

“Sunlight is the
 best disinfectant” * * better options now available - yay science - Louis D. Brandeis

Slide 8

Slide 8 text

Code-review should be a collaborative, cumulative & critical process

Slide 9

Slide 9 text

Code-review Culture the how-to guide

Slide 10

Slide 10 text

Purpose it’s not just for finding bugs

Slide 11

Slide 11 text

Outcome better developers with a broader understanding

Slide 12

Slide 12 text

Everything as a PR every line of code is just as important

Slide 13

Slide 13 text

Reduce the noise small, digestible changes

Slide 14

Slide 14 text

No content

Slide 15

Slide 15 text

No content

Slide 16

Slide 16 text

Discussion not dictation

Slide 17

Slide 17 text

Reinforce good work highlight and improve bad work

Slide 18

Slide 18 text

All of us are better than one of us

Slide 19

Slide 19 text

Feedback. Fast. dedicate time to code-reviews

Slide 20

Slide 20 text

Horizontal interrogation challenge, learn, share

Slide 21

Slide 21 text

Vertical guidance direct, mentor, question

Slide 22

Slide 22 text

Quorum for large PRs

Slide 23

Slide 23 text

Agree on a baseline Style-guides, clean code, avoid smells

Slide 24

Slide 24 text

Don’t just tell Provide links to bolster argument, increase learning

Slide 25

Slide 25 text

Code is all there is and all there should be

Slide 26

Slide 26 text

The Bus Factor aim for 3+

Slide 27

Slide 27 text

Logical fallacies to avoid when reviewing code

Slide 28

Slide 28 text

No content

Slide 29

Slide 29 text

No content

Slide 30

Slide 30 text

No content

Slide 31

Slide 31 text

No content

Slide 32

Slide 32 text

No content

Slide 33

Slide 33 text

No content

Slide 34

Slide 34 text

No content

Slide 35

Slide 35 text

No content

Slide 36

Slide 36 text

Get off your tuchus

Slide 37

Slide 37 text

Soft stuff • Diplomacy • Professional, but light • Questions, not statements • Humility • Politeness • Consistency • Sweat the small stuff! • Have fun

Slide 38

Slide 38 text

Brown-fields 
 vs 
 green-fields the consistency vs. correctness challenge

Slide 39

Slide 39 text

Tools

Slide 40

Slide 40 text

No content

Slide 41

Slide 41 text

Why we use Upsource • integration with Git/GitHub • self-hosted, easy setup • fast! • incremental reviews • multiple reviewers / watchers • direct integration into PHPStorm • discussion threads (with resolve, @mentions)

Slide 42

Slide 42 text

Reviews

Slide 43

Slide 43 text

Analytics

Slide 44

Slide 44 text

Questions? http://www.devconf.co.za/rate

Slide 45

Slide 45 text

Questions? /* THANK YOU*/ DANNY KOPPING www.zando.co.za [email protected] @dannykopping http://lanyrd.com/cfydfp