×
Copy
Open
Link
Embed
Share
Beginning
This slide
Copy link URL
Copy link URL
Copy iframe embed code
Copy iframe embed code
Copy javascript embed code
Copy javascript embed code
Share
Tweet
Share
Tweet
Slide 1
Slide 1 text
Teaching RSpec to play nice with Rails @samphippen
Slide 2
Slide 2 text
Friends, it’s good to be back
Slide 3
Slide 3 text
Last year I had a life threatening illness
Slide 4
Slide 4 text
No content
Slide 5
Slide 5 text
A precious bag of ceftriaxone, saving my life
Slide 6
Slide 6 text
No content
Slide 7
Slide 7 text
Thanks @searls
Slide 8
Slide 8 text
Thanks @searls #samphippenisjustin searlsconfirmed
Slide 9
Slide 9 text
5.1
Slide 10
Slide 10 text
Yes*
Slide 11
Slide 11 text
ActionChatbox::TestCase
Slide 12
Slide 12 text
ActionDispatch ::BeliefSystemTestCase
Slide 13
Slide 13 text
Have some faith in us
Slide 14
Slide 14 text
5.1 has not been released yet
Slide 15
Slide 15 text
No changes required by you
Slide 16
Slide 16 text
Released soon in 3.6.0
Slide 17
Slide 17 text
No system test integration
Slide 18
Slide 18 text
but I would welcome a PR
Slide 19
Slide 19 text
RSpec + Rails
Slide 20
Slide 20 text
RSpec
Slide 21
Slide 21 text
RSpec isn’t a monolith
Slide 22
Slide 22 text
gem “rspec”, “~> 3.5”
Slide 23
Slide 23 text
Does nothing on it’s own
Slide 24
Slide 24 text
No content
Slide 25
Slide 25 text
No content
Slide 26
Slide 26 text
No content
Slide 27
Slide 27 text
No content
Slide 28
Slide 28 text
Internal shared code
Slide 29
Slide 29 text
rspec-rails
Slide 30
Slide 30 text
No content
Slide 31
Slide 31 text
No content
Slide 32
Slide 32 text
RSpec Rails
Slide 33
Slide 33 text
RSpec Rails our code Your rails version
Slide 34
Slide 34 text
gem “rspec”, “~> 3.5” gem “rspec-rails”, “~> 3.5”
Slide 35
Slide 35 text
gem “rspec-rails”, “~> 3.5”
Slide 36
Slide 36 text
Rails
Slide 37
Slide 37 text
Rails is a big complicated library
Slide 38
Slide 38 text
RSpec is extremely permissive about rails versions
Slide 39
Slide 39 text
>= 3.0
Slide 40
Slide 40 text
No content
Slide 41
Slide 41 text
No content
Slide 42
Slide 42 text
No content
Slide 43
Slide 43 text
Don’t ask
Slide 44
Slide 44 text
5
Slide 45
Slide 45 text
RSpec’s rails 5 compatability was not a smooth ride
Slide 46
Slide 46 text
Lesson 1: 5.0 means they break things
Slide 47
Slide 47 text
No content
Slide 48
Slide 48 text
No content
Slide 49
Slide 49 text
No content
Slide 50
Slide 50 text
No content
Slide 51
Slide 51 text
No content
Slide 52
Slide 52 text
Let’s just make sure this works with RSpec
Slide 53
Slide 53 text
No content
Slide 54
Slide 54 text
View specs don’t work
Slide 55
Slide 55 text
Specifically path helpers
Slide 56
Slide 56 text
No content
Slide 57
Slide 57 text
No content
Slide 58
Slide 58 text
Switch back to working version of rails
Slide 59
Slide 59 text
No content
Slide 60
Slide 60 text
Work out what changed
Slide 61
Slide 61 text
controller .singleton_class .ancestors
Slide 62
Slide 62 text
No content
Slide 63
Slide 63 text
No content
Slide 64
Slide 64 text
So we lost 3 random anonymous modules
Slide 65
Slide 65 text
WTF even are they?
Slide 66
Slide 66 text
actionpack-5.0.0.beta2/ lib/action_dispatch/ routing/route_set.rb:283
Slide 67
Slide 67 text
At this point we call in an emergency rails maintainer
Slide 68
Slide 68 text
No content
Slide 69
Slide 69 text
No content
Slide 70
Slide 70 text
No content
Slide 71
Slide 71 text
This is a huge win for collaboration
Slide 72
Slide 72 text
Lesson 2: Some bugs are in Rails
Slide 73
Slide 73 text
No content
Slide 74
Slide 74 text
What the hell is a signed cookie?
Slide 75
Slide 75 text
No content
Slide 76
Slide 76 text
No content
Slide 77
Slide 77 text
No content
Slide 78
Slide 78 text
No content
Slide 79
Slide 79 text
No content
Slide 80
Slide 80 text
So now the fun begins
Slide 81
Slide 81 text
git clone rails/rails
Slide 82
Slide 82 text
Point the app at that rails clone
Slide 83
Slide 83 text
git bisect bad
Slide 84
Slide 84 text
git checkout v4.2.0.beta4
Slide 85
Slide 85 text
git bisect good
Slide 86
Slide 86 text
No content
Slide 87
Slide 87 text
No content
Slide 88
Slide 88 text
No content
Slide 89
Slide 89 text
and then I left it for a while
Slide 90
Slide 90 text
and went to Rubyconf
Slide 91
Slide 91 text
“You have a breaking commit sha? Show me”
Slide 92
Slide 92 text
No content
Slide 93
Slide 93 text
No content
Slide 94
Slide 94 text
No content
Slide 95
Slide 95 text
“can be replicated purely with Rails using public API”
Slide 96
Slide 96 text
There exists a twisty turny maze of dependencies
Slide 97
Slide 97 text
Before filling an issue on a gem, check it’s not in a dep
Slide 98
Slide 98 text
Lesson 3: Sometimes you can’t call in @sgrif
Slide 99
Slide 99 text
No content
Slide 100
Slide 100 text
No content
Slide 101
Slide 101 text
No content
Slide 102
Slide 102 text
No content
Slide 103
Slide 103 text
“I made a short screencast”
Slide 104
Slide 104 text
No content
Slide 105
Slide 105 text
No content
Slide 106
Slide 106 text
Do the bisect shimmy and shake
Slide 107
Slide 107 text
No content
Slide 108
Slide 108 text
No content
Slide 109
Slide 109 text
No content
Slide 110
Slide 110 text
No content
Slide 111
Slide 111 text
Explaining a lot of context in a PR message is super useful
Slide 112
Slide 112 text
No content
Slide 113
Slide 113 text
Gets merged!
Slide 114
Slide 114 text
No content
Slide 115
Slide 115 text
It is fine to poke a maintainer to close an issue once they’ve fixed it
Slide 116
Slide 116 text
Summary
Slide 117
Slide 117 text
A lot of bugs that appear in RSpec can be because of rails
Slide 118
Slide 118 text
Literally every fix we saw today was in a rails gem
Slide 119
Slide 119 text
A Rails reproduction script is a great place to start
Slide 120
Slide 120 text
No content
Slide 121
Slide 121 text
I will almost always ask you for a reproduction sample app
Slide 122
Slide 122 text
Just calling @sgrif is a great way to get rails bugs fixed
Slide 123
Slide 123 text
No content
Slide 124
Slide 124 text
Working on open source is really hard
Slide 125
Slide 125 text
No content
Slide 126
Slide 126 text
This work represented 40+ hours of donated maintainer time
Slide 127
Slide 127 text
Hug a maintainer
Slide 128
Slide 128 text
Find some time to work on open source
Slide 129
Slide 129 text
Pay a maintainer?
Slide 130
Slide 130 text
No content
Slide 131
Slide 131 text
No content
Slide 132
Slide 132 text
Thanks @samphippen
[email protected]
Let’s have some questions