Engineer's Work/Pull Request Review

I have talked about what pull request review is about, how engineers review others' source codes, and why it is important for us to review others' pull requests and read others' source codes, which is a very ordinal and common ideology for most engineers I suppose.

Transcript

1. View Slide

2. ΤϯδχΞͷγΰτͷ1ͭ
   

   View Slide

3. ࢓༷ܾΊ
   ࣮૷
   ϨϏϡʔ ςετ ϦϦʔε
   ͜ΓΜ͞Μൃදࢿྉ
   ʮϚδςοΫτʔΫ - 20180509ʯ ΑΓ
   

   View Slide

4. ࢓༷ܾΊ
   ࣮૷
   ϨϏϡʔ ςετ ϦϦʔε
   ͜ΓΜ͞Μൃදࢿྉ
   ʮϚδςοΫτʔΫ - 20180509ʯ ΑΓ
   

   View Slide

5. ʰϨϏϡʔʱ
   

   View Slide

6. ʰϨϏϡʔʱͬͯʁ
   

   View Slide

7. ଞͷਓ͕ॻ͍ͨίʔυΛಡΜͰɺ
   ʮςετɾϦϦʔεͰ͖ΔΑʂʯ
   ͱ͍͏֬ೝΛ͢Δ͜ͱ
   

   View Slide

8. ϨϏϡʔ͢Δͱྑ͍͜ͱ͕
   ͨ͘͞Μʂʂ
   

   View Slide

9. ࡞ۀʹΑͬͯ”ࠩ෼”͸େ͖͔ͬͨΓখ͔͞
   ͔ͬͨΓ͠·͢
   

   View Slide

10. ϨϏϡʔΛ௨ͯ͠ίϛϡχέʔγϣϯ
    

    View Slide

11. ʰϨϏϡʔʱ
    

    View Slide

12. ΘΓͱूத͢Δඞཁ͕͋Δ
    

    View Slide

13. ଟ͘ͳΔͱ͠ΜͲ͍
    

    View Slide

14. Ͱ͖Δ͚ͩཷΊͳ͍Α͏ʹʂ
    

    View Slide

15. ϨϏϡʔ͢Δཧ༝ᶃ
    

    View Slide

16. όάɾೝࣝͷҧ͍Λࣄલʹݟ͚ͭΔ

    ʢ֬཰Λ͋͛Δʣ
    

    View Slide

17. Ͳ͔͜Βͱ΋ͳ͘ݱΕΔ
    ༧ظͤͣݱΕΔ
    

    View Slide

18. ͳΔૣͰݟ͚͍ͭͨ
    

    View Slide

19. ϨϏϡʔ͸ଟ͚Ε͹ଟ͍΄Ͳ͍͍
    

    View Slide

20. ·ͣ͸ϨϏϡʔ͢ΔྔΛ૿΍͢
    ؾʹͳΔͱ͜
    Ζ͸ॏ఺తʹ
    ΏΔΊʹશମ
    ΛݟͯΔ
    શମΛ͔ͬ͠Γ
    ϨϕϧϚοΫε
    (·ͣ͸ແཧͷͳ͍ൣғͰ)
    

    View Slide

21. ϨϏϡʔ͢Δཧ༝ᶄ
    

    View Slide

22. ୭͕ͲΜͳ࡞ۀ͍ͯ͠Δͷ͔ཧղͰ͖Δ
    

    View Slide

23. ● ։ൃ͸ڞಉ࡞ۀ
    ● ࡞ۀͷόοςΟϯά͕ى͜Βͳ͍Α͏ʹ͢Δ
    ● ͷʹࣗ෼͕ಉ͡ͱ͜ΖΛվम͢Δࡍʹ૬ஊ͠΍͍͢
    

    View Slide

24. ҰਓδΣϯΨ͸ऐ͍͠(´ɾωɾʆ)
    

    View Slide

25. ϨϏϡʔ͢Δཧ༝ᶅ
    

    View Slide

26. ଞͷਓͷίʔυ͔ΒֶͿ͜ͱ͕Ͱ͖Δ
    (ϓϥϯφʔɾϓϩσϡʔαʔ͕ଞͷਓͷ࢓༷ॻ͔ΒֶͿͱ͔΋͋Δʁ)
    (σβΠφʔ͕ଞͷਓͷσβΠϯϨϏϡʔ͔ΒֶͿͱ͔΋͋Δʁ)
    

    View Slide

27. ϨϏϡʔ͢Δͱྑ͍͜ͱ͕
    ͨ͘͞Μʂʂ
    

    View Slide

28. ·ͱΊ
    ● ϨϏϡʔ͸ΤϯδχΞͷେࣄͳγΰτͷͭ
    ● ϨϏϡʔ͸ཷ·Δલʹ͢Δͷ͕ྑͦ͞͏ɻܾ࣌ؒΊ
    ͯ΍Δͱ͔ɻ
    ੵۃతʹϨϏϡʔΛͯ͠ɺ
    ྑ͍ΞϓϦΛ࡞͍͖ͬͯ·͠ΐ͏ʂ
    

    View Slide