Slide 1
Slide 1 text
։ԋ·Ͱͷؒ
ژͷࣸਅΛ
ָ͓͠Έ͍ͩ͘͞
IUUQQIPUPTBOPHSBQIJYOFU
148݄30༵
Slide 2
Slide 2 text
IUUQQIPUPTBOPHSBQIJYOFU
։ԋ·Ͱͷؒ
ژͷࣸਅΛ
ָ͓͠Έ͍ͩ͘͞
148݄30༵
Slide 3
Slide 3 text
IUUQQIPUPTBOPHSBQIJYOFU
։ԋ·Ͱͷؒ
ژͷࣸਅΛ
ָ͓͠Έ͍ͩ͘͞
148݄30༵
Slide 4
Slide 4 text
IUUQQIPUPTBOPHSBQIJYOFU
։ԋ·Ͱͷؒ
ژͷࣸਅΛ
ָ͓͠Έ͍ͩ͘͞
148݄30༵
Slide 5
Slide 5 text
IUUQQIPUPTBOPHSBQIJYOFU
։ԋ·Ͱͷؒ
ژͷࣸਅΛ
ָ͓͠Έ͍ͩ͘͞
148݄30༵
Slide 6
Slide 6 text
IUUQQIPUPTBOPHSBQIJYOFU
։ԋ·Ͱͷؒ
ژͷࣸਅΛ
ָ͓͠Έ͍ͩ͘͞
148݄30༵
Slide 7
Slide 7 text
1FSMͷ੩తղੳ
ೖͱ1FSM
ϦϑΝΫλϦϯά
πʔϧ
"QQ135
ͷ͝հ
IJUPEF
148݄30༵
Slide 8
Slide 8 text
IJUPEF
झຯϚϦϯεϙʔπͰ͢
148݄30༵
Slide 9
Slide 9 text
148݄30༵
Slide 10
Slide 10 text
148݄30༵
Slide 11
Slide 11 text
͘͡
148݄30༵
Slide 12
Slide 12 text
͘͡
ϦϑΝΫλϦϯάʹ͍ͭͯ
1FSMͷϦϑΝΫλϦϯά
੩తղੳೖ
੩తղੳ࿅श
ϦϑΝΫλϦϯάπʔϧͷհ
ϦϑΝΫλϦϯά࿅श
ࣄྫհ
148݄30༵
Slide 13
Slide 13 text
4&&"-40
148݄30༵
Slide 14
Slide 14 text
Perl::Lint - Yet
Another Perl
Source Code
Linter
148݄30༵
Slide 15
Slide 15 text
͘͡
ϦϑΝΫλϦϯάʹ͍ͭͯ
1FSMͷϦϑΝΫλϦϯά
੩తղੳೖ
੩తղੳ࿅श
ϦϑΝΫλϦϯάπʔϧͷհ
ϦϑΝΫλϦϯά࿅श
ࣄྫհ
148݄30༵
Slide 16
Slide 16 text
148݄30༵
Slide 17
Slide 17 text
͘͡
ϦϑΝΫλϦϯάʹ͍ͭͯ
1FSMͷϦϑΝΫλϦϯά
੩తղੳೖ
੩తղੳ࿅श
ϦϑΝΫλϦϯάπʔϧͷհ
ϦϑΝΫλϦϯά࿅श
ࣄྫհ
148݄30༵
Slide 18
Slide 18 text
ϦϑΝΫλϦϯά
148݄30༵
Slide 19
Slide 19 text
148݄30༵
Slide 20
Slide 20 text
ϦϑΝΫλϦϯάͱɺι
ϑτΣΞͷ֎෦తৼΔక
͍Λอͬͨ··Ͱɺ෦ͷ
ߏΛվળ͍ͯ͘͠࡞ۀΛ
ࢦ͠·͢ɻ
148݄30༵
Slide 21
Slide 21 text
ৼ͍Λม͑ͣʹ
ίʔυΛ͖Ε͍ʹ
148݄30༵
Slide 22
Slide 22 text
ѱ໊͍લΛม͑Δ
148݄30༵
Slide 23
Slide 23 text
࣮Λྑ͍ॴʹҠ͢
148݄30༵
Slide 24
Slide 24 text
࡞ઓߟ͑Δͷ͍͠
࡞ۀࣗମ؆୯
148݄30༵
Slide 25
Slide 25 text
ϦϑΝΫλϦϯάࣗମͷ
͠·ͤΜ
148݄30༵
Slide 26
Slide 26 text
148݄30༵
Slide 27
Slide 27 text
δϟό
148݄30༵
Slide 28
Slide 28 text
IUUQTUBDLPWFSqPXDPNRVFTUJPOTDIBOHFOBNFPGBQBDLBHFBGUFSJGJUJTDSFBUFEBOEIBWFDMBTTFTJOFDMJQTFQPT
148݄30༵
Slide 29
Slide 29 text
1FSMͷ߹
148݄30༵
Slide 30
Slide 30 text
1FSMͷ߹
͕ΜΔ
148݄30༵
Slide 31
Slide 31 text
ιʔείʔυΛΤσΟλͰ
ॻ͖͑Δ
ݺͼग़͠ݩॻ͖͑Δ
ςετ͋Ε࣮ߦ
ಈ͚ϥοΩʔ
148݄30༵
Slide 32
Slide 32 text
ͳΜ͔ͳͷ͍ͷ͔
148݄30༵
Slide 33
Slide 33 text
1BESF
UIF1FSM*%&
1FSM༻ͷ*%&
ม໊มߋͰ͖Δ
͏·͘ಈ͔ͳ͔ͬͨ
͙͢Ϋϥογϡ͢Δ
148݄30༵
Slide 34
Slide 34 text
%FWFM3FGBDUPS
my $refactory = Devel::Refactor->new;
$refactory->rename_subroutine(
'./path/to/dir',
'oldSubName','newSubName'
);
ͷϞδϡʔϧ
αϒϧʔνϯͷϦωʔϜ
148݄30༵
Slide 35
Slide 35 text
%FWFM3FGBDUPS
my $regex1 = '(\W)(' . $old_name . ')(\W)';
my $regex2 = "^$old_name(" . '\W)';
while (<$fh>) {
$line_number++;
if (/$regex1/o or /$regex2/o) {
my $new_line = $_;
$new_line =~ s/$regex1/$1$new_name$3/g;
$new_line =~ s/$regex2/$new_name$1/;
ਖ਼نදݱͰஔ
148݄30༵
Slide 36
Slide 36 text
%FWFM3FGBDUPS
sub _syntax_check{
my $self = shift;
my $tmp;
my $eval_stmt = "my (". join ', ', @{$self->{parms}};
$eval_stmt .= ");\n";
$eval_stmt .= $self->get_sub_call();
$eval_stmt .= $self->get_new_code();
$self->{eval_code} = $eval_stmt;
eval " $eval_stmt ";
if ($@) {
$self->{eval_err} = $@;
FWBMͯ͠ޭ͔ͨ͠ݟΔ
ͱʹ͔͘ϫΠϧυ
148݄30༵
Slide 37
Slide 37 text
"QQ&EJUPS5PPMT
&NBDT7JN༻ϓϥάΠϯ ίϚϯυ
ϑΝΠϧ໊͔ΒQBDLBHF໊ਪଌͯ͠ೖྗ
ม໊มߋ
બൣғΛมʹ͘͘Γग़͠
ͳ͔ͳ͔Α͍͚Ͳ͏ͪΐͬͱ
148݄30༵
Slide 38
Slide 38 text
5SZJOHUPSFGBDUPS
1FSMDPEF
148݄30༵
Slide 39
Slide 39 text
ͦͦ
ϦϑΝΫλϦϯά
͢Δʹ
148݄30༵
Slide 40
Slide 40 text
TFE
148݄30༵
Slide 41
Slide 41 text
148݄30༵
Slide 42
Slide 42 text
จࣈྻૢ࡞Ͱਫ਼ѱ͍
148݄30༵
Slide 43
Slide 43 text
148݄30༵
Slide 44
Slide 44 text
TFEਫ਼͍
my $blog = shift;
print $blog->{id};
print $blog->{user_id};
my $blog = shift;
print $blog->{article_id};
print $blog->{user_article_id};
sed -e “s/id/article_id/”
148݄30༵
Slide 45
Slide 45 text
ͦ͜Ͱ੩తղੳ
148݄30༵
Slide 46
Slide 46 text
੩తղੳ
ϓϩάϥϜΛ࣮ߦͤͣʹௐΔ
࣮ߦ͢ΔͱಈతղੳʹͳΔ
148݄30༵
Slide 47
Slide 47 text
͍ͭ੩తղੳ͢Δͷ
γϯλοΫεϋΠϥΠτ
ߏจνΣοΫ
ίʔσΟϯάنʹԊͬͯΔ͔
੬ऑੑΛ୳͢
ϦϑΝΫλϦϯά
148݄30༵
Slide 48
Slide 48 text
ࡶͳ੩తղੳ
ϓϩάϥϜΛ࣮ߦͤͣʹ
ϓϩάϥϜͷੑ࣭Λௐ͍ͯΔ
DBUMJC1MBDLQNcXDM
148݄30༵
Slide 49
Slide 49 text
؆୯Ͱ͠ΐ
ߦ͡Όͳ໋ͯ͘ྩΓ͍ͨ
148݄30༵
Slide 50
Slide 50 text
;ͭ͏ͷ੩తղੳ
148݄30༵
Slide 51
Slide 51 text
;ͭ͏ͷ੩తղੳ
ߏจΛ࡞ͬͯௐΔ
148݄30༵
Slide 52
Slide 52 text
print (1 * 2) + 3;
ߏจ
148݄30༵
Slide 53
Slide 53 text
‘;’
ߏจ
‘print’ ‘ ‘ List ‘ ‘ ‘ ‘
‘1’ ‘ ‘ ‘*’ ‘ ‘ ‘2’
‘+’ ‘3’
Statement
Document
print (1 * 2) + 3;
148݄30༵
Slide 54
Slide 54 text
ߏจ
print "(1 * 2) + 3";
148݄30༵
Slide 55
Slide 55 text
‘;’
ߏจ
‘print’ ‘ ‘
Statement
Document
print "(1 * 2) + 3";
‘"(1 * 2) + 3"’
148݄30༵
Slide 56
Slide 56 text
͜ΕͳΒ҆৺
148݄30༵
Slide 57
Slide 57 text
ߏจͲ͏ͬͯ࡞Δͷ
148݄30༵
Slide 58
Slide 58 text
11*
148݄30༵
Slide 59
Slide 59 text
11*
1FSMղੳͯ͘͠ΕΔϞδϡʔϧ
1FSM%PDVNFOU0CKFDU.PEFM
1FSMύʔε͢Δͷ͍͠ͷͰ͍͢͝
148݄30༵
Slide 60
Slide 60 text
ࡶஊ
$PNQJMFS-FYFS͍ͬͯ͏
͍ͷ͋Δ͚Ͳͦͷ͠·ͤΜ
ࡢͷNP[OJPOͷൃදݟͯ
148݄30༵
Slide 61
Slide 61 text
11*Ͱ༡΅͏
148݄30༵
Slide 62
Slide 62 text
11*Ͱߏจݟ͍ͨ
print (1 * 2) + 3;
11*%PDVNFOU
11*4UBUFNFOU
11*5PLFO8PSEQSJOU
11*5PLFO8IJUFTQBDF
11*4USVDUVSF-JTU
11*4UBUFNFOU&YQSFTTJPO
11*5PLFO/VNCFS
11*5PLFO8IJUFTQBDF
11*5PLFO0QFSBUPS
11*5PLFO8IJUFTQBDF
11*5PLFO/VNCFS
11*5PLFO8IJUFTQBDF
11*5PLFO0QFSBUPS
11*5PLFO8IJUFTQBDF
11*5PLFO/VNCFS
11*5PLFO4USVDUVSF
11*5PLFO8IJUFTQBDFaO
use PPI;
use PPI::Dumper;
my $document = PPI::Document->new($ARGV[0]);
my $dumper = PPI::Dumper->new($document);
$dumper->print;
148݄30༵
Slide 63
Slide 63 text
‘;’
Ͱ͖ͨ
‘print’ ‘ ‘ List ‘ ‘ ‘ ‘
‘1’ ‘ ‘ ‘*’ ‘ ‘ ‘2’
‘+’ ‘3’
Statement
Document
print (1 * 2) + 3;
148݄30༵
Slide 64
Slide 64 text
11*Ͱ໋ྩݟ͍ͨ
my $document = PPI::Document->new($ARGV[0]);
my $statements = $document->find('PPI::Statement');
my $statement_count = @$statements;
say "count: $statement_count";
148݄30༵
Slide 65
Slide 65 text
11*Ͱ'J[[#V[[Λഁյ͍ͨ͠
use PPI;
my $path = $ARGV[0];
my $document = PPI::Document->new($path);
my $tokens = $document->find('PPI::Token');
for my $token (@$tokens) {
if (ref $token eq 'PPI::Token::Number') {
$token->set_content($token->content * 2);
}
}
$document->save("broken-$path");
148݄30༵
Slide 66
Slide 66 text
11*Ͱ'J[[#V[[Λഁյ͍ͨ͠
use PPI;
my $path = $ARGV[0];
my $document = PPI::Document->new($path);
my $tokens = $document->find('PPI::Token');
for my $token (@$tokens) {
if (ref $token eq 'PPI::Token::Number') {
$token->set_content($token->content * 2);
}
}
$document->save("broken-$path");
ࣈΛݟ͚ͭͨΒ
ͱΓ͋͑ͣഒʹ͢Δ
148݄30༵
Slide 67
Slide 67 text
͜Ε͕
use strict;
use warnings;
for my $i (1..20) {
my $message = "";
$message .= "Fizz" unless $i % 3;
$message .= "Buzz" unless $i % 5;
$message = $i unless $message;
print "$message\n";
}
148݄30༵
Slide 68
Slide 68 text
͜͏
use strict;
use warnings;
for my $i (2..40) {
my $message = "";
$message .= "Fizz" unless $i % 6;
$message .= "Buzz" unless $i % 10;
$message = $i unless $message;
print "$message\n";
}
148݄30༵
Slide 69
Slide 69 text
-(5.
'J[[
#V[[
'J[[
'J[[
#V[[
'J[[
'J[[#V[[
'J[[
148݄30༵
Slide 70
Slide 70 text
'J[[#V[[ʹݶΒͣ
ഁյͰ͖Δ
148݄30༵
Slide 71
Slide 71 text
ΣϒΞϓϦέʔγϣϯΛഁյ
148݄30༵
Slide 72
Slide 72 text
my $app = sub {
return [
200,
[ 'Content-Type' => 'text/plain' ],
[ 'Hello World' ] ];
};
148݄30༵
Slide 73
Slide 73 text
my $app = sub {
return [
400,
[ 'Content-Type' => 'text/plain' ],
[ 'Hello World' ] ];
};
148݄30༵
Slide 74
Slide 74 text
my $app = sub {
return [
400,
[ 'Content-Type' => 'text/plain' ],
[ 'Hello World' ] ];
};
ഒ
148݄30༵
Slide 75
Slide 75 text
ϙΠϯτ
148݄30༵
Slide 76
Slide 76 text
ϙΠϯτ
ߏจΛॻ͖͑ͯอଘ
148݄30༵
Slide 77
Slide 77 text
ศརͳྫ
148݄30༵
Slide 78
Slide 78 text
HJUHSFQͷ͍͍ͭ
148݄30༵
Slide 79
Slide 79 text
HJUHSFQͷ͍͍ͭ
"QQ(JU(SFQ1FSM4UBUFNFOU
git grep-perl-statement finalize t/
τʔΫϯ୯ҐͰݕࡧ
εςʔτϝϯτ୯ҐͰදࣔ
148݄30༵
Slide 80
Slide 80 text
HJUHSFQͷ͍͍ͭ
HJUHSFQͰϑΝΠϧ୳͢
Ϛονͨ͠ϑΝΠϧͷߏจ࡞Δ
TUBUFNFOUΛݸͣͭݟΔ
TUBUFNFOU͕୳ͯ͠ΔUPLFOΛؚΊදࣔ
148݄30༵
Slide 81
Slide 81 text
งғؾ
my $doc = PPI::Document->new($file);
my $statements = $doc->find('PPI::Statement');
grep {
my $tokens = [ $_->children ];
any {
$_ eq $self->word;
} @$tokens;
} @$statements;
148݄30༵
Slide 82
Slide 82 text
ίʔσΟϯάελΠϧ
ௐΔͭ
148݄30༵
Slide 83
Slide 83 text
1FSM$SJUJD
ίʔσΟϯάελΠϧௐͯ͘ΕΔ
νʔϜͰελΠϧ౷Ұ͢Δͷʹศར
148݄30༵
Slide 84
Slide 84 text
Ұൠతͳ1FSMϞδϡʔϧ
ͷελΠϧΛνΣοΫͯ͠
Έ·͠ΐ͏
148݄30༵
Slide 85
Slide 85 text
package Antipop;
use strict;
use warnings;
our $VERSION = '0.01';
sub talk {
return q{ҿΈʹߦͧ͘!!1};
}
!!1;
__END__
148݄30༵
Slide 86
Slide 86 text
QFSMDSJUJD"OUJQPQQN
148݄30༵
Slide 87
Slide 87 text
QFSMDSJUJD"OUJQPQQN
.PEVMFEPFTOPUFOEXJUI BUMJOF
DPMVNO
.VTUFOEXJUIBSFDPHOJ[BCMFUSVFWBMVF
4FWFSJUZ
148݄30༵
Slide 88
Slide 88 text
QFSMDSJUJD"OUJQPQQN
.PEVMFEPFTOPUFOEXJUI BUMJOF
DPMVNO
.VTUFOEXJUIBSFDPHOJ[BCMFUSVFWBMVF
4FWFSJUZ
!!1;
148݄30༵
Slide 89
Slide 89 text
1FSM$SJUJD1PMJDZ.PEVMFT3FRVJSF&OE8JUI0OF
sub violates {
my ( $self, $elem, $doc ) = @_;
# Last statement should be just "1;"
my @significant = grep { _is_code($_) }
$doc->schildren();
my $match = $significant[-1];
return if !$match;
return if ((ref $match) eq 'PPI::Statement' &&
$match =~ m{\A 1 \s* ; \z}xms );
# Must be a violation...
return $self->violation( $DESC, $EXPL, $match );
}
148݄30༵
Slide 90
Slide 90 text
੩తղੳͰ
͠ΐ΅͍͔Β
ෳࡶͳ·Ͱ
148݄30༵
Slide 91
Slide 91 text
੩తղੳͷ͓ΘΓ
148݄30༵
Slide 92
Slide 92 text
ϦϑΝΫλϦϯάπʔϧͷ
148݄30༵
Slide 93
Slide 93 text
"QQ135
148݄30༵
Slide 94
Slide 94 text
"QQ135
1FSM
3FGBDUPSJOH
5PPM
148݄30༵
Slide 95
Slide 95 text
"QQ135
1FSM
3FGBDUPSJOH
5PPM
࡞ͬͯ·͢
148݄30༵
Slide 96
Slide 96 text
ϦϑΝΫλϦϯά͍ͨ͠ͱ
͖ʹ͋ΔΑ͋͘Δૢ࡞Λ·
ͱΊͨπʔϧ
148݄30༵
Slide 97
Slide 97 text
ίϚϯυϥΠϯ͔Β࣮ߦ
ιʔείʔυॻ͖͑ͯอଘ
148݄30༵
Slide 98
Slide 98 text
Ͱ͖Δ͜ͱ
148݄30༵
Slide 99
Slide 99 text
Ͱ͖Δ͜ͱ
τʔΫϯͷஔ
ΫϥεͷϦωʔϜ
ωʔϜεϖʔεͷϦωʔϜ
ϝιουͷআ
ΫϥεϝιουͷҠಈ
148݄30༵
Slide 100
Slide 100 text
࿅श
148݄30༵
Slide 101
Slide 101 text
࿅श༻ʹ༻ҙͨ͠
ΫιίʔυΛ
ϦϑΝΫλϦϯά
ͯ͠Έ·͠ΐ͏
148݄30༵
Slide 102
Slide 102 text
͓Έ͘͡ΞϓϦέʔγϣϯ
ͷϦϑΝΫλϦϯά
IUUQTHJUIVCDPNIJUPEFPNJLVKJ
148݄30༵
Slide 103
Slide 103 text
QFSMPNJLVKJQM
த٢
QFSMPNJLVKJQM
த٢
QFSMPNJLVKJQM
େ٢
QFSMEPVCVUV@PNJLVKJQM
ޕ
QFSMEPVCVUV@PNJLVKJQM
ਃ
148݄30༵
Slide 104
Slide 104 text
0NJLVKJ
VSBOBV
VSBOBXBOBJ
0NJLVKJ%PVCVUV
VSBOBV
0NJLVKJ6UJM
DIPJTF
MVDLZ
˚
ܧঝ
ར༻
148݄30༵
Slide 105
Slide 105 text
VSBOBVϝιουΛ
ϦωʔϜͯ͠ΈΔ
prt replace_token
uranau tell
148݄30༵
Slide 106
Slide 106 text
prt replace_token uranau tell
ίϚϯυ
αϒίϚϯυ
Ҿ
148݄30༵
Slide 107
Slide 107 text
0NJLVKJ
UFMM
VSBOBXBOBJ
0NJLVKJ%PVCVUV
UFMM
0NJLVKJ6UJM
DIPJTF
MVDLZ
˚
ܧঝ
ར༻
148݄30༵
Slide 108
Slide 108 text
0NJLVKJ6UJM MVDLZϝιουΛ
-VDLZΫϥεʹҠಈͯ͠ΈΔ
prt move_class_method
‘Omikuji::Util#lucky’
‘Omikuji::Lucky#get_lucky’
148݄30༵
Slide 109
Slide 109 text
0NJLVKJ
UFMM
VSBOBXBOBJ
0NJLVKJ%PVCVUV
UFMM
0NJLVKJ6UJM
DIPJTF
˚
ܧঝ
ར༻
0NJLVKJ-VDLZ
HFU@MVDLZ
148݄30༵
Slide 110
Slide 110 text
0NJLVKJ6UJMΫϥεΛ
0NJLVKJ-JTUΫϥεʹ
ϦωʔϜ
prt rename_class
Omikuji::Util
Omikuji::List
148݄30༵
Slide 111
Slide 111 text
0NJLVKJ
UFMM
VSBOBXBOBJ
0NJLVKJ%PVCVUV
UFMM
0NJLVKJ-JTU
DIPJTF
˚
ܧঝ
ར༻
0NJLVKJ-VDLZ
HFU@MVDLZ
148݄30༵
Slide 112
Slide 112 text
0NJLVKJΫϥεΛ
-PUΫϥεʹϦωʔϜ
prt rename_class
Omikuji
Lot
148݄30༵
Slide 113
Slide 113 text
-PU
UFMM
VSBOBXBOBJ
0NJLVKJ%PVCVUV
UFMM
0NJLVKJ-JTU
DIPJTF
˚
ܧঝ
ར༻
0NJLVKJ-VDLZ
HFU@MVDLZ
148݄30༵
Slide 114
Slide 114 text
0NJLVKJҎԼΛશͯ
-PUʹϦωʔϜ
prt rename_name_space
Omikuji
Lot
148݄30༵
Slide 115
Slide 115 text
-PU
UFMM
VSBOBXBOBJ
-PU%PVCVUV
UFMM
-PU-JTU
DIPJTF
˚
ܧঝ
ར༻
-PU-VDLZ
HFU@MVDLZ
148݄30༵
Slide 116
Slide 116 text
ϦϑΝΫλϦϯάޭ
148݄30༵
Slide 117
Slide 117 text
͏ͪΐͬͱ
େ͖͍ΞϓϦέʔγϣϯͰ
࿅श
148݄30༵
Slide 118
Slide 118 text
1MBDL3FRVFTUΛ
1MBDL,VEBTBJʹ
148݄30༵
Slide 119
Slide 119 text
prt rename_class Plack::Request Plack::Kudasai
148݄30༵
Slide 120
Slide 120 text
ϦϑΝΫλϦϯάޭ
148݄30༵
Slide 121
Slide 121 text
໊લΛؾܰʹ
͋ͱ͔Βม͑ΒΕΔͷ
ศར
148݄30༵
Slide 122
Slide 122 text
ϦϥοΫεͰ͖Δ
148݄30༵
Slide 123
Slide 123 text
͏·͘͏ίπ
148݄30༵
Slide 124
Slide 124 text
ରϑΝΠϧΛߜΔ
prt rename_token foo bar $(git grep --name-only foo)
ରϑΝΠϧ͕ݮΔͱ͍ͧ
148݄30༵
Slide 125
Slide 125 text
ςετ௨͔ͯ͠Βίϛοτ
ςετ௨͔ͬͯΒ
ίϛοτ͢Δͱ҆৺Ͱ͖Δͧ
148݄30༵
Slide 126
Slide 126 text
ϦϑΝΫλϦϯά͘͢͠อͭ
ϝλϓϩάϥϛϯάΛආ͚Δ
จࣈྻ࿈݁ͰQBDLBHF໊࡞Δͱ͍͠
KPJObz
b0NJLVKJ`
b6UJM`
148݄30༵
Slide 127
Slide 127 text
ࣄྫհ
148݄30༵
Slide 128
Slide 128 text
ࣄྫհ
ͯͳϒϩάશࣗಈϦϑΝΫλϦϯά
148݄30༵
Slide 129
Slide 129 text
എܠ
4FSWJDFΫϥεʹ
DPOUFYUΦϒδΣΫτΛͯͨ͠
Service::User->find_user_by_name($r, $name);
148݄30༵
Slide 130
Slide 130 text
എܠ
4FSWJDFΫϥεʹ
DPOUFYUΦϒδΣΫτΛͯͨ͠
EC͚ͩ͢ͱ͜Ζ
Service::User->find_user_by_name($r, $name);
Service::Blog->find_blog_by_uri($r->db, $uri);
148݄30༵
Slide 131
Slide 131 text
എܠ
4FSWJDFΫϥεʹ
DPOUFYUΦϒδΣΫτΛͯͨ͠
EC͚ͩ͢ͱ͜Ζ
౷Ұ͞Εͯͳͯ͘ΧΦε
ΫϥεɼݸҎ্ͷϝιου
Service::User->find_user_by_name($c, $name);
Service::Blog->find_blog_by_uri($c->db, $uri);
148݄30༵
Slide 132
Slide 132 text
എܠ
4FSWJDFΫϥεʹ
DPOUFYUΦϒδΣΫτΛͯͨ͠
EC͚ͩ͢ͱ͜Ζ
౷Ұ͞Εͯͳͯ͘ΧΦε
ΫϥεɼݸҎ্ͷϝιου
खͰͪ·ͪ·ͦ͏ͱ͢Δ࠳ં
Service::User->find_user_by_name($c, $name);
Service::Blog->find_blog_by_uri($c->db, $uri);
148݄30༵
Slide 133
Slide 133 text
શࣗಈνϟϯε
148݄30༵
Slide 134
Slide 134 text
Γ͍ͨ͜ͱ
148݄30༵
Slide 135
Slide 135 text
Service::User->find_user_by_name($r, $name);
sub find_user_by_name {
my ($class, $r, $name) = @_;
$r->db->select(..., $name);
}
CFGPSF
148݄30༵
Slide 136
Slide 136 text
Service::User->find_user_by_name($r->db, $name);
sub find_user_by_name {
my ($class, $db, $name) = @_;
$db->select(..., $name);
}
BGUFS
148݄30༵
Slide 137
Slide 137 text
࡞ઓ
148݄30༵
Slide 138
Slide 138 text
Service::User->find_user_by_name($r->db, $name);
sub find_user_by_name {
my ($class, $db, $name) = @_;
$db->select(..., $name);
}
ݺͼग़͠ݩͰ $r → $r->db
ݺͼग़͠ઌͰ $r → $db
$r->db → $db
148݄30༵
Slide 139
Slide 139 text
ॻ͖͍͚͑ͯͳ͍߹
148݄30༵
Slide 140
Slide 140 text
sub aaa {
my ($class, $r = @_;
AnotherService->bbb($r);
$r->db->select(..., $user->name);
}
΄͔ͷϝιουʹSͯ͠Δ
148݄30༵
Slide 141
Slide 141 text
sub aaa {
my ($class, $r) = @_;
AnotherService->bbb($r->db);
$r->db->select(..., $user->name);
}
΄͔ͷϝιουʹSͯ͠Δ
ઌʹ"OPUIFS4FSWJDFΛ
ϦϑΝΫλϦϯά
148݄30༵
Slide 142
Slide 142 text
sub aaa {
my ($class, $db) = @_;
AnotherService->bbb($db);
$db->select(..., $user->name);
}
΄͔ͷϝιουʹSͯ͠Δ
ઌʹ"OPUIFS4FSWJDFΛ
ϦϑΝΫλϦϯά
ϝιου͕શͯS ECͳΒॻ͖͑ΒΕΔ
148݄30༵
Slide 143
Slide 143 text
sub aaa {
my ($class, $r) = @_;
my $user = $r->user;
$r->db->select(..., $user->name);
}
ECҎ֎ͬͯΔ
148݄30༵
Slide 144
Slide 144 text
sub aaa {
my ($class, $r, $user) = @_;
$r->db->select(..., $user->name);
}
ECҎ֎ͬͯΔ
VTFSड͚औΔ
͜ΕػցతʹͰ͖ͳ͍ͷͰख࡞ۀ
148݄30༵
Slide 145
Slide 145 text
࡞ઓ
wιʔείʔυશϑΝΠϧॱ൪ʹݟΔ
wSΛड͚औͬͯΔϝιουΛ୳͢
w҆શʹॻ͖͑ΒΕΔ
wϝιουఆٛΛॻ͖͑ˠݺͼग़͠ݩॻ͖͑
wมߋՕॴͷςετ࣮ߦ
w௨ͬͨΒDPNNJUQVTIͯ͠࠷ॳʹΔ
wམͪͨΒεΫϦϓτऴྃͯ͠ਓؒΛݺͿ
w҆શ͡Όͳ͔ͬͨΒ࣍ͷϝιουʹߦ͘
wԿॻ͖͑ͣશϑΝΠϧݟऴΘͬͨΒਓؒΛݺͿ
148݄30༵
Slide 146
Slide 146 text
ݟͲ͜Ζ
148݄30༵
Slide 147
Slide 147 text
ࢦఆ͞ΕͨϑΝΠϧ
ॱ൪ʹݟΔ
sub replace_all {
for my $file (@ARGV) {
my $document = PPI::Document->new($file);
my $package = $document->find_first(
'PPI::Statement::Package'
);
my $package_name = $package->namespace;
my $methods = $document->find(
'PPI::Statement::Sub'
);
for my $method (@$methods) {
my $document = PPI::Document->new($file);
...;
}
}
}
148݄30༵
Slide 148
Slide 148 text
S ECΛECʹஔ
sub r_db_to_db {
my ($statement) = @_;
my $tokens = [$statement->children];
for my $token (@$tokens) {
if ($token eq '$r') {
if ($token->next_token eq '->') {
if ($token->next_token->next_token eq 'db') {
$token->set_content('$db');
$token->next_token->set_content('');
$token->next_token->next_token->set_content('');
} else {
die "->@{[ $token->next_token->next_token ]}";
}
} else {
die "@{[ $token->next_token ]}";
}
}
}
}
148݄30༵
Slide 149
Slide 149 text
ݺͼग़͠ݩͷมߋ
$command = 'prt replace_token \'' .
$package_name . '->' . $method_name .
'($r\' \'' . $package_name . '->' .
$method_name . '($r->db\' --in-
statement ' . $method_name . ' $(git
grep --name-only ' . $method_name .
')';
system $command;
148݄30༵
Slide 150
Slide 150 text
ΫϥεͰͷݺͼग़͠มߋ
$command = 'prt replace_token
\'$class' . '->' .
$method_name . '($r\'
\'$class' . '->' .
$method_name . '($r->db\' --in-
statement ' . $method_name . '
' . $file;
system $command;
148݄30༵
Slide 151
Slide 151 text
มߋՕॴΛςετͯ͠ίϛοτ
if (`git diff --name-only t/**.t`) {
system('carton exec -- prove $(git diff --
name-only t/**.t)') and die "test failed";
} else {
warn 'skip test';
}
system "git commit -am '$package_name\ͷ
$method_name\Λ\$db Λड͚औΔΑ͏ʹมߋ'";
system "git push";
148݄30༵
Slide 152
Slide 152 text
ॻ͖͑ଓ͚Δ
my $success = 1;
while($success) {
$success = replace_all();
}
148݄30༵
Slide 153
Slide 153 text
ޙ
148݄30༵
Slide 154
Slide 154 text
250+ Commits
281 Files changed
+2,004 −1,927
148݄30༵
Slide 155
Slide 155 text
ϦϑΝΫλϦϯάޭ
148݄30༵
Slide 156
Slide 156 text
ݟ
148݄30༵
Slide 157
Slide 157 text
ݟ
ҙ֎ͱͳΜͱ͔ͳΔ
148݄30༵
Slide 158
Slide 158 text
ݟ
ҙ֎ͱͳΜͱ͔ͳΔ
ϨϏϡϫʔ͔Θ͍ͦ͏
148݄30༵
Slide 159
Slide 159 text
ݟ
ҙ֎ͱͳΜͱ͔ͳΔ
ϨϏϡϫʔ͔Θ͍ͦ͏
ͷٕज़తෛ࠴Λٕज़Ͱղܾͨ͠
148݄30༵
Slide 160
Slide 160 text
Ҏ্
148݄30༵
Slide 161
Slide 161 text
·ͱΊ
ϦϑΝΫλϦϯάʹ͍ͭͯ
1FSMͷϦϑΝΫλϦϯά
੩తղੳೖ
੩తղੳ࿅श
ϦϑΝΫλϦϯάπʔϧͷհ
ϦϑΝΫλϦϯά࿅श
ࣄྫհ
148݄30༵
Slide 162
Slide 162 text
148݄30༵
Slide 163
Slide 163 text
ҰॹʹϦϑΝΫλϦϯά͠·͠ΐ͏
ʲॕʳTPOHNV͞Μೖࣾ
148݄30༵