Share
Embed
Slide 1
Slide 1 text
©2019 Wantedly, Inc.
Introduce RuboCop
In 8-year-old project
May 30, 2019 - Yuta Kamezaki
Meguro.rb #27
Slide 2
Slide 2 text
©2019 Wantedly, Inc.
Yuta Kamezaki @ykamez
About me
Twitter: @ykamez_
2
Wantedly. Inc. / Engineer
2019ೖࣾɻ
Wantedly VisitͷάϩʔενʔϜॴଐ
ੳ͔ΒࢪࡦఏҊɺ࣮(αʔόʔ)·ͰΛ୲ɻ
Slide 3
Slide 3 text
©2019 Wantedly, Inc.
3VCP$PQΛೖΕ͍ͨਓ
ಛʹɺطଘͷϓϩδΣΫτʹೖΕΔέʔε
ର
Slide 4
Slide 4 text
©2019 Wantedly, Inc.
େมͩͬͨ͜ͱ
ͨ͜͠ͱ
ࠓ͢͜ͱ ࡀͷϓϩδΣΫτʹ3VCP$PQΛಋೖ͢Δ·Ͱ
Slide 5
Slide 5 text
©2019 Wantedly, Inc.
w ͲͷϧʔϧΛ࠾༻͢Δ͔
w ͲͷΑ͏ʹͬͯΒ͏͔
w Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠
େมͩͬͨ͜ͱ Ұൠతͳ
Slide 6
Slide 6 text
©2019 Wantedly, Inc.
ྺ࢙͕ͯ͘ڊେ ੜ·Ε
ߦ: 166,566
େมͩͬͨ͜ͱ 8BOUFEMZͳΒͰͷ
Slide 7
Slide 7 text
©2019 Wantedly, Inc.
w ؒΈΜͳࣗ༝ͳελΠϧͰॻ͍͖ͯͨ
w طଘίʔυͷमਖ਼͕େม
w ؔऀ͕ଟ͍ˠίϯηϯαε͕औΓͮΒ͍
w ࠓߋײ ৺ཧతϋʔυϧ
େมͩͬͨ͜ͱ 8BOUFEMZͳΒͰͷ
ྺ࢙͕ͯ͘ڊେ
Slide 8
Slide 8 text
©2019 Wantedly, Inc.
σϑΥϧτͰΒͤͯΈͨ
ͲͷϧʔϧΛ࠾༻͢Δ͔
Slide 9
Slide 9 text
©2019 Wantedly, Inc.
ͲͷϧʔϧΛ࠾༻͢Δ͔
Inspecting 4062 files
4062 files inspected, 126547 offenses detected
σϑΥϧτͷϧʔϧͷ߹
126,547 offenses
Slide 10
Slide 10 text
©2019 Wantedly, Inc.
σϑΥϧτͷϧʔϧݫͦ͠͏
ͲͷϧʔϧΛ࠾༻͢Δ͔
ϧʔϧͱݱঢ়ʹେ͖ͳဃ͕͋Δ
Slide 11
Slide 11 text
©2019 Wantedly, Inc.
NFPXDPQͷϧʔϧ͕ྑ͍Β͍͠
ͲͷϧʔϧΛ࠾༻͢Δ͔
ผνʔϜͰಋೖ͓ͯ͠Γɺධ͕ྑ͔ͬͨ
Slide 12
Slide 12 text
©2019 Wantedly, Inc.
3VCP$PQͷDPOpHͷHFN
https://github.com/sider/meowcop
ελΠϧͷࢦఠ͠ͳ͍
w ϓϩδΣΫτݻ༗ͷϧʔϧΛແޮԽ
https://blog-ja.sideci.com/entry/2016/10/03/171816
NFPXDPQͱ
→طଘProjectʹಋೖ͍͢͠
Slide 13
Slide 13 text
©2019 Wantedly, Inc.
4062 files inspected, 12080 offenses detecte
ͲͷϧʔϧΛ࠾༻͢Δ͔ NFPXDPQͷϧʔϧͷ߹
Slide 14
Slide 14 text
©2019 Wantedly, Inc.
4062 files inspected, 12080 offenses detecte
ͲͷϧʔϧΛ࠾༻͢Δ͔ NFPXDPQͷϧʔϧͷ߹
12,080 offenses
Slide 15
Slide 15 text
©2019 Wantedly, Inc.
4062 files inspected, 12080 offenses detecte
126,547→12,080
ͲͷϧʔϧΛ࠾༻͢Δ͔ NFPXDPQͷϧʔϧͷ߹
ݱ࣮తͳဃ
Slide 16
Slide 16 text
©2019 Wantedly, Inc.
ͲͷϧʔϧΛ࠾༻͢Δ͔
w ͲͷΑ͏ʹͬͯΒ͏͔
w Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠
େมͩͬͨ͜ͱ
✅
Slide 17
Slide 17 text
©2019 Wantedly, Inc.
୭Θͳ͔ͬͨΒҙຯ͕ͳ͍
ͲͷΑ͏ʹͬͯΒ͏͔
ڧ੍ྗ͕ͳ͍ͷܗ֚Խ͕ͪ͠
Slide 18
Slide 18 text
©2019 Wantedly, Inc.
ͲͷΑ͏ʹͬͯΒ͏͔
+
Slide 19
Slide 19 text
©2019 Wantedly, Inc.
1. reviewdog
3VCP$PQͷ݁ՌΛ13ʹίϝϯτͯ͘͠ΕΔ
IUUQTHJUIVCDPNSFWJFXEPHSFWJFXEPH
2. Travis CI
$*αʔϏεͰࣗಈνΣοΫ
ͲͷΑ͏ʹͬͯΒ͏͔
ˠΏΔΊͷӡ༻ࣗಈԽ $*མͱ͞ͳ͍
Slide 20
Slide 20 text
©2019 Wantedly, Inc.
ͲͷϧʔϧΛ࠾༻͢Δ͔
✅ͲͷΑ͏ʹͬͯΒ͏͔
w Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠
େมͩͬͨ͜ͱ
✅
Slide 21
Slide 21 text
©2019 Wantedly, Inc.
w طଘͷίʔυͷѻ͍
w ϧʔϧऔࣺબͷϓϩηε
Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠
Slide 22
Slide 22 text
©2019 Wantedly, Inc.
طଘͷίʔυͷѻ͍
Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠
ϧʔϧΛద༻ͨ͠Βɺطଘͷ$PEFमਖ਼ɻ
ϧʔϧͱ$PEFͷဃΛ͙ɻ
Slide 23
Slide 23 text
©2019 Wantedly, Inc.
ϧʔϧऔࣺબͷϓϩηε
Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠
JTTVFͰٞˠϧʔϧ֬ఆˠө
JTTVFͰΦʔϓϯʹٞ͠ɺೲಘײΛ࣋ͨͤΔɻ
Slide 24
Slide 24 text
©2019 Wantedly, Inc.
ϧʔϧऔࣺબͷϓϩηε
Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠
Slide 25
Slide 25 text
©2019 Wantedly, Inc.
JTTVFͰΦʔϓϯʹٞ͠ɺೲಘײΛ࣋ͨͤΔɻ
ϧʔϧऔࣺબͷϓϩηε
Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠
JTTVFͰٞˠϧʔϧ֬ఆˠө
Slide 26
Slide 26 text
©2019 Wantedly, Inc.
ͲͷϧʔϧΛ࠾༻͢Δ͔
✅ͲͷΑ͏ʹͬͯΒ͏͔
✅Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠FUD
େมͩͬͨ͜ͱ
✅
Slide 27
Slide 27 text
©2019 Wantedly, Inc.
՝
େมͩͬͨ͜ͱͨ͜͠ͱ
ํ๏
•ؔऀͷଟ͞
•ڊେ͞
•8ͷྺ࢙
•ΏΔ͍ϧʔϧͰελʔτ
•CIͰࣗಈԽ(ڧ੍͠ͳ͍)
•Φʔϓϯͳٞ
•ӡ༻ํͷ໌֬Խ
• ͲͷϧʔϧΛ࠾༻͢Δ͔
• ͲͷΑ͏ʹͬͯΒ͏͔
• Ͳ͏͍͏ํͰӡ༻͍͔ͯ͘͠
Ұൠతͳ
Wantedlyݻ༗ͷ
Slide 28
Slide 28 text
©2019 Wantedly, Inc.
ແࣄ3VCP$PQಋೖ
ӽ͠ͷಋೖ
Slide 29
Slide 29 text
©2019 Wantedly, Inc.
ྑ͍
• ϨϏϡʔલʹϛεʹؾ͕͚ͭͨɻ
՝
• ϧʔϧͷऔࣺબ͕͍͠ɻ
• ϧʔϧΛܾΊΔϓϩηε͕ᐆດɻ
Ԡ
Slide 30
Slide 30 text
©2019 Wantedly, Inc.
ϧʔϧऔࣺબͷϓϩηεޮԽ
• ೲಘײͷ͋ΔϧʔϧΛͲ͏ૉૣܾ͘Ί͍͔ͯ͘
ͲΕ͘Β͍ݫ͍͠ӡ༻ʹ͢Δ͔
• CIམͱ͢ͷ͔
ࣾͷϧʔϧڞ௨Խ ϚΠΫϩαʔϏε
Δ՝
ˠ·ͩ·ͩࢼߦࡨޡத
Slide 31
Slide 31 text
©2019 Wantedly, Inc.
ͷϓϩδΣΫτͰಋೖͰ͖Δ
• ઍཬͷಓҰา͔Β
ΏΔ࢝͘ΊͯΈΑ͏
·ͱΊ
Slide 32
Slide 32 text
©2019 Wantedly, Inc.
Thank you