コードレビューなんてしてられるかッ!!

by Yusuke Hirao

Slide 1

Slide 1 text

2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ ͳΜͯͯ͠ΒΕΔ͔ο Զͷ࿩Λฉ͚-5େձ גࣜձࣾσΟʔθϩ ϑϩϯτΤϯυΤϯδχΞ ฏඌ༏య

Slide 2

Slide 2 text

2018 Yusuke Hirao, CC BY-ND. ݁࿦͔Β

Slide 3

Slide 3 text

2018 Yusuke Hirao, CC BY-ND. )5.-ͷ-JOUFS࡞ͬͨ

Slide 4

Slide 4 text

2018 Yusuke Hirao, CC BY-ND. ࣗݾ঺հ ฏඌ༏యʢͻΒ͓Ώ͏ͯΜʣ גࣜձࣾσΟʔθϩ ϑϩϯτΤϯυΤϯδχΞ ίϛϡχςΟ׆ಈ ෱ԬϑϩϯτΤϯυ༑ͷձ'VLVPLB'SPOUFOE'SPHT ෱ԬϚʔΫΞοϓษڧձ CBTFS$.4Ϣʔβʔձ Yusuke Hirao @cloud10designs

Slide 5

Slide 5 text

2018 Yusuke Hirao, CC BY-ND. ࣾ಺ͷ ίʔσΟϯάΨΠυϥΠϯΛ ॻ͍ͨΜͰ͢

Slide 6

Slide 6 text

2018 Yusuke Hirao, CC BY-ND.

Slide 7

Slide 7 text

2018 Yusuke Hirao, CC BY-ND. ίʔσΟϯάελΠϧ͔Β ΞΫηγϒϧϚʔΫΞοϓɺ $44ઃܭɺ+4ͷςΫχοΫ͔Β ίʔσΟϯάࢥ૝ͳͲ ΤϞ͍ײ͡Ͱςϯί੝Γ

Slide 8

Slide 8 text

2018 Yusuke Hirao, CC BY-ND. Ͱɺ ࡞͔ͬͨΒʹ͸ɺ ͪΌΜͱΨΠυϥΠϯʹ Ԋ͍ͬͯΔ͔֬ೝ͍ͨ͠

Slide 9

Slide 9 text

2018 Yusuke Hirao, CC BY-ND. Α͠ɺ

Slide 10

Slide 10 text

2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ͠Α͏

Slide 11

Slide 11 text

2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏

Slide 12

Slide 12 text

2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏

Slide 13

Slide 13 text

2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔

Slide 14

Slide 14 text

2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏

Slide 15

Slide 15 text

2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͢

Slide 16

Slide 16 text

2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͓͢΍ɺBMU͕ͳ͍Ͱ͢Ͷ

Slide 17

Slide 17 text

Slide 18

Slide 18 text

2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͓͢΍ɺBMU͕ͳ͍Ͱ͢Ͷ ͓΍ɺෆਖ਼ͳωετؔ܎ʹͳͬ ͯ·͋͢ɺλά໊͸খจࣈʹ ͍ͯͩ͘͠͞Ͷ

Slide 19

Slide 19 text

Slide 20

Slide 20 text

Slide 21

Slide 21 text

Slide 22

Slide 22 text

2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ͠Α͏

Slide 23

Slide 23 text

2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ͠Α͏ ͯ͠ΒΕΔ͔ο

Slide 24

Slide 24 text

2018 Yusuke Hirao, CC BY-ND. ϨϏϡʔ͸ࠔ೉ΛۃΊͨ ϨϏϡʔͷຊདྷͷ໨త ίϯςΩετͱηϚϯςΟοΫͷ֬ೝ ΞΫηγϏϦςΟνΣοΫ ࣮ࡍʹؾΛऔΒΕͯ͠·ͬͨ͜ͱ )5.-7BMJEBUJPO Ϋϥε໋໊نଇͳͲίʔσΟϯάΨΠυϥΠϯ४ڌͷ֬ೝ ඼্࣭໰୊ͳ͍͚ͲϝϯςͷͨΊͷΨΠυϥΠϯϧʔϧ͕ Πϯσϯτ͸ϨϏϡʔͷಡΈ΍͢͞ͷͨΊͳͷʹͦΕΛࢦఠ ෛͷϧʔϓ

Slide 25

Slide 25 text

2018 Yusuke Hirao, CC BY-ND. -JOUFSΛಋೖ͠Α͏✅

Slide 26

Slide 26 text

2018 Yusuke Hirao, CC BY-ND. -JOUFSͷԸܙ +BWB4DSJQU͸&4-JOUͰɺ$44͸4UZMFMJOUͰಋೖࡁΈ ࣍ͷ͜ͱ͸͍͍ͩͨࣗಈԽͰ͖Δ γϯλοΫενΣοΫ ίʔυελΠϧͷνΣοΫ ໋໊نଇͷνΣοΫ ΞϯνύλʔϯͷνΣοΫ ࢦఠ͢Δͷ͸ػցͳͷͰਓ֨൱ఆʹड͚औΒΕʹ͍͘ ʮΤϥʔ͕ग़ͳ͍Α͏ʹίʔσΟϯά͍ͯͩ͘͠͞ʯͰย෇͘

Slide 27

Slide 27 text

2018 Yusuke Hirao, CC BY-ND. )5.-)JOUΛ࢖ͬͯΈ͕ͨʜ جຊͷνΣοΫ͸΋ͪΖΜαϙʔτ ϓϥάΠϯ"1*Λ͍࣋ͬͯͨͷͰ࠷ॳ͸ͦΕͰؤுͬͨ ͔͠͠΍͍ͬͯ͘͏ͪʹ໰୊͕ϙϩϙϩ "1*͸͋ͬͯ΋HVMQ΍ΤσΟλ͕ϓϥάΠϯʹରԠͯ͠ͳ͍ &4-JOUΈ͍ͨʹϑΥϧμ͝ͱͷϧʔϧઃఆ͕Ͱ͖ͳ͍ 47(ͳͲͷ֎དྷཁૉʹରԠ͍ͯ͠ͳ͍ ։ൃࢭ·ͬͯΔ͠

Slide 28

Slide 28 text

2018 Yusuke Hirao, CC BY-ND. ͭʔΘ͚Ͱ

Slide 29

Slide 29 text

2018 Yusuke Hirao, CC BY-ND. )5.--JOUFS࡞Γ·ͨ͠

Slide 30

Slide 30 text

2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU /PEFKTͰಈ͘)5.--JOUFS ͦͷ͏ͪϒϥ΢β൛΋ ϓϥάΠϯ"1*Λ͍࣋ͬͯΔ ਖ਼֬ͳϩέʔγϣϯΛ΋ͭ"45%0.ϥΠΫͳπϦʔߏ଄͕ѻ͑Δ ཁૉ͝ͱʹϧʔϧΛ࠶ઃఆͰ͖Δ ର৅ͷཁૉ͸ηϨΫλͰߜΓ͜ΊΔ ϑΥϧμ͝ͱʹϧʔϧΛઃఆͰ͖Δ ϧʔϧઃఆ͸ܧঝ͕Ͱ͖Δ )5.--JWJOHTUBOEBSEͷίϯςϯπϞσϧ৘ใΛ΋ͭ ֎དྷཁૉɾΧελϜཁૉɾ7JFXϥΠϒϥϦͷରԠΛݟਾ͑ͨઃܭ Τϥʔ͕೔ຊޠ ϩέʔϧͰ൑ఆ ·੍ͩ࡞த͚ͩͲ

Slide 31

Slide 31 text

2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU ͦͦ͜͜͸ಈ͖·͢

Slide 32

Slide 32 text

2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU 74$PEF֦ுެ։ࡁΈ

Slide 33

Slide 33 text

2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU ॗʑϧʔϧͱ௥Ճத

Slide 34

Slide 34 text

2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU ͕Μ͹ͬͯυΩϡϝϯτॻ͍ͯ·͢

Slide 35

Slide 35 text

2018 Yusuke Hirao, CC BY-ND. Ͱɺ࡞ͬͯΈͯͷײ૝

Slide 36

Slide 36 text

2018 Yusuke Hirao, CC BY-ND. ௒ָ͍͠

Slide 37

Slide 37 text

2018 Yusuke Hirao, CC BY-ND. ͳΜ΍͜Ε։ൃ௒ָ͍͠΍Μ ඞཁʹۦΒΕͯ࡞Γ࢝Ίͨʹͯ͠͸༧૝֎ʹָ͍͠ ΰϦΰϦ)5.-ΛѻͬͯΔͷʹϑϩϯτΤϯυ͡Όͳ͍ෆࢥٞײ ͍ΖΜͳֶͼ͕͋ͬͨ ͱʹ͔͘)5.--JWJOHTUBOEBSEಡΈ·ͬͨ͘ )5.-ͷߏจ΍ύʔεʹ΍ͨΒৄ͘͠ͳͬͨ $-*ͷԞਂ͞ ඪ४ೖྗग़ྗͱ͔ϑϩϯτΤϯυͰ͸ະ஌ ࠶ؼॲཧͱ͔΋ਅ໘໨ʹऔΓ૊ΜͩͷॳΊ͔ͯ΋͠Εͳ͍ ϒϥ΢βޓ׵Λؾʹ͠ͳ͍ίʔσΟϯάͷշײ ͋ͱɺۙʑ਺ઍϖʔδͷ໾ʹཱͯΔ͜ͱ͕ ͸͖ͬΓ͍ͯ͠Δ఺͸೩͑Δಈػʹͳ͍ͬͯͨ

Slide 38

Slide 38 text

2018 Yusuke Hirao, CC BY-ND. ໨తͱָཱ͍͕྆͠Ͱ͖ͦ͏Ͱ͋Δ ϨϏϡʔͷຊདྷͷ໨త ίϯςΩετͱηϚϯςΟοΫͷ֬ೝ ΞΫηγϏϦςΟνΣοΫ ࣮ࡍʹؾΛऔΒΕͯ͠·ͬͨ͜ͱ )5.-7BMJEBUJPO Ϋϥε໋໊نଇͳͲίʔσΟϯάΨΠυϥΠϯ४ڌͷ֬ೝ ඼্࣭໰୊ͳ͍͚ͲϝϯςͷͨΊͷΨΠυϥΠϯϧʔϧ͕ Πϯσϯτ͸ϨϏϡʔͷಡΈ΍͢͞ʹͨΊͳͷʹͦΕΛࢦఠ ෛͷϧʔϓ

Slide 39

Slide 39 text

Slide 40

Slide 40 text

Slide 41

Slide 41 text

2018 Yusuke Hirao, CC BY-ND. ͋͞ɺ

Slide 42

Slide 42 text

2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ͠Α͏

Slide 43

Slide 43 text

2018 Yusuke Hirao, CC BY-ND. 5IBOLZPV

Slide 44

Slide 44 text

2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU IUUQTHJUIVCDPN:VTVLF)JSBPNBSLVQMJOU NBSLVQMJOUQMVHJOUFYUMJOU IUUQTXXXOQNKTDPNQBDLBHFNBSLVQMJOUQMVHJOUFYUMJOU NBSLVQMJOUGPS74$PEF IUUQTNBSLFUQMBDFWJTVBMTUVEJPDPNJUFNT JUFN/BNFZVTVLFIJSBPWTDPEFNBSLVQMJOU