コードレビュー なんてしてられるかッ!!

1adcc39bcb4268334437c9c12b84d7a4?s=47 Yusuke Hirao
January 19, 2018
Technology
23
10k

コードレビュー なんてしてられるかッ!!

俺の話を聞け!! LT大会#7
結論markuplintというHTMLのLinter作った

1adcc39bcb4268334437c9c12b84d7a4?s=128

Yusuke Hirao

January 19, 2018
Tweet

More Decks by Yusuke Hirao

See All by Yusuke Hirao
1adcc39bcb4268334437c9c12b84d7a4?s=48 yusukehirao
1
250
1adcc39bcb4268334437c9c12b84d7a4?s=48 yusukehirao
4
110
1adcc39bcb4268334437c9c12b84d7a4?s=48 yusukehirao
1
180
1adcc39bcb4268334437c9c12b84d7a4?s=48 yusukehirao
2
320
1adcc39bcb4268334437c9c12b84d7a4?s=48 yusukehirao
2
600
1adcc39bcb4268334437c9c12b84d7a4?s=48 yusukehirao
0
390
1adcc39bcb4268334437c9c12b84d7a4?s=48 yusukehirao
1
500
1adcc39bcb4268334437c9c12b84d7a4?s=48 yusukehirao
0
500
1adcc39bcb4268334437c9c12b84d7a4?s=48 yusukehirao
1
2.3k

Other Decks in Technology

See All in Technology
5919537a0ecfa5d4dea704cf878ae90e?s=48 toshimaru
31
11k
9c42c4bc1d91c409d754da88c91cb2ef?s=48 kur0cky
1
240
1dfa2bb34977b1db41d0d46d4505183f?s=48 osuke
2
2.2k
835671ae91e49b2637313b91dacda1db?s=48 tdys13
2
2k
B1cc148711c6a37a5c922b6e72a4ad52?s=48 upura
1
970
9e7a653ed313b3da4b263a772bfc5026?s=48 clustervr
0
450
Ce2ffa10331de7d89e06eabe1d231aef?s=48 hornets79
1
120
53850955f15249a1a9dc49df6113e400?s=48 line_developers
1
170
C918bcbfa8df32567636c2d125a34fa1?s=48 sonnylazuardi
0
140
A64ac825509279a770c13c6fc517f11a?s=48 kawaguti
0
130
66fabad28b40a99387ab582cd0e94a2d?s=48 hiromaaa03
1
110
0251532f4fb413ea1a026efe6eb16b87?s=48 stajima
0
260

Featured

See All Featured
C51b39fa3c79ccb99dcb8a076bc98287?s=48 brianwarren
83
4.5k
Dafc4723e9a1c067796c0fec6f509774?s=48 lemiorhan
620
40k
25c7c18223fb42a4c6ae1c8db6f50f9b?s=48 mojombo
353
62k
Ded01cdab114abe4ec13511e4c25b9bb?s=48 andyhume
60
2.4k
465724d73fe3a92c0879fdfb43a3a6f3?s=48 philhawksworth
190
8.6k
F383c6a4dc55e331bbe2987b622cee6b?s=48 stephaniewalter
256
10k
719435d98d452de7ac367c828266cf01?s=48 erikaheidi
5
3.6k
282d599b414022eba5096510f675b6e2?s=48 chrislema
169
14k
D47656e20ff5e42f125fc5ea0fd636c6?s=48 tmm1
61
7.4k
95d9f37115fbb0d13135d0f77132f856?s=48 morganepeng
86
11k
1519587b1a0febb658c36c94f6272b0d?s=48 roundedbygravity
84
7.6k
D67fff74178013024d833b3eec6cf27f?s=48 lynnandtonic
265
16k

Transcript

  1. 2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ ͳΜͯͯ͠ΒΕΔ͔ο Զͷ࿩Λฉ͚-5େձ גࣜձࣾσΟʔθϩ ϑϩϯτΤϯυΤϯδχΞ

    ฏඌ༏య

  2. 2018 Yusuke Hirao, CC BY-ND. ݁࿦͔Β

  3. 2018 Yusuke Hirao, CC BY-ND. )5.-ͷ-JOUFS࡞ͬͨ

  4. 2018 Yusuke Hirao, CC BY-ND. ࣗݾ঺հ ฏඌ༏యʢͻΒ͓Ώ͏ͯΜʣ גࣜձࣾσΟʔθϩ ϑϩϯτΤϯυΤϯδχΞ ίϛϡχςΟ׆ಈ

    ෱ԬϑϩϯτΤϯυ༑ͷձ'VLVPLB'SPOUFOE'SPHT ෱ԬϚʔΫΞοϓษڧձ CBTFS$.4Ϣʔβʔձ Yusuke Hirao @cloud10designs

  5. 2018 Yusuke Hirao, CC BY-ND. ࣾ಺ͷ ίʔσΟϯάΨΠυϥΠϯΛ ॻ͍ͨΜͰ͢

  6. 2018 Yusuke Hirao, CC BY-ND.

  7. 2018 Yusuke Hirao, CC BY-ND. ίʔσΟϯάελΠϧ͔Β ΞΫηγϒϧϚʔΫΞοϓɺ $44ઃܭɺ+4ͷςΫχοΫ͔Β ίʔσΟϯάࢥ૝ͳͲ ΤϞ͍ײ͡Ͱςϯί੝Γ

  8. 2018 Yusuke Hirao, CC BY-ND. Ͱɺ ࡞͔ͬͨΒʹ͸ɺ ͪΌΜͱΨΠυϥΠϯʹ Ԋ͍ͬͯΔ͔֬ೝ͍ͨ͠

  9. 2018 Yusuke Hirao, CC BY-ND. Α͠ɺ

  10. 2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ͠Α͏

  11. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏

  12. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏

  13. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔

  14. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ

    ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏

  15. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ

    ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͢

  16. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ

    ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͓͢΍ɺBMU͕ͳ͍Ͱ͢Ͷ

  17. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ

    ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͓͢΍ɺBMU͕ͳ͍Ͱ͢Ͷ ͓΍ɺෆਖ਼ͳωετؔ܎ʹͳͬ ͯ·͢

  18. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ

    ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͓͢΍ɺBMU͕ͳ͍Ͱ͢Ͷ ͓΍ɺෆਖ਼ͳωετؔ܎ʹͳͬ ͯ·͋͢ɺλά໊͸খจࣈʹ ͍ͯͩ͘͠͞Ͷ

  19. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ

    ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͓͢΍ɺBMU͕ͳ͍Ͱ͢Ͷ ͓΍ɺෆਖ਼ͳωετؔ܎ʹͳͬ ͯ·͋͢ɺλά໊͸খจࣈʹ ͍ͯͩ͘͠͞ͶͱΓ͋͑ͣΠ ϯσϯτ͚ͭͯ΋Β͑·͔͢ʁ

  20. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ

    ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͓͢΍ɺBMU͕ͳ͍Ͱ͢Ͷ ͓΍ɺෆਖ਼ͳωετؔ܎ʹͳͬ ͯ·͋͢ɺλά໊͸খจࣈʹ ͍ͯͩ͘͠͞ͶͱΓ͋͑ͣΠ ϯσϯτ͚ͭͯ΋Β͑·͢ ͔ʁΨΠυϥΠϯಡΈ·͠ ͨʁ

  21. 2018 Yusuke Hirao, CC BY-ND. ͜͜͸+4ͷτϦΨʔʹͳΔ ͷͰBλάΑΓCVUUPOλάͭ ͔͍·͠ΐ͏͜͜͸VMMJͰՕ ৚ॻ͖ʹ͠·͠ΐ͏OBWʹ͸ BSJBMBCFMೖΕ·͠ΐ͏͔ϥ

    ϯυϚʔΫϩʔϧ͚ͭ·͠ΐ ͏͓΍ɺด͡λά͕ൈ͚͍ͯ ·͓͢΍ɺBMU͕ͳ͍Ͱ͢Ͷ ͓΍ɺෆਖ਼ͳωετؔ܎ʹͳͬ ͯ·͋͢ɺλά໊͸খจࣈʹ ͍ͯͩ͘͠͞ͶͱΓ͋͑ͣΠ ϯσϯτ͚ͭͯ΋Β͑·͢ ͔ʁΨΠυϥΠϯಡΈ·͠ ͨʁ ͔͠΋ ਺ઍϖʔδ

  22. 2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ͠Α͏

  23. 2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ͠Α͏ ͯ͠ΒΕΔ͔ο

  24. 2018 Yusuke Hirao, CC BY-ND. ϨϏϡʔ͸ࠔ೉ΛۃΊͨ ϨϏϡʔͷຊདྷͷ໨త ίϯςΩετͱηϚϯςΟοΫͷ֬ೝ ΞΫηγϏϦςΟνΣοΫ ࣮ࡍʹؾΛऔΒΕͯ͠·ͬͨ͜ͱ

    )5.-7BMJEBUJPO Ϋϥε໋໊نଇͳͲίʔσΟϯάΨΠυϥΠϯ४ڌͷ֬ೝ ඼্࣭໰୊ͳ͍͚ͲϝϯςͷͨΊͷΨΠυϥΠϯϧʔϧ͕ Πϯσϯτ͸ϨϏϡʔͷಡΈ΍͢͞ͷͨΊͳͷʹͦΕΛࢦఠ ෛͷϧʔϓ

  25. 2018 Yusuke Hirao, CC BY-ND. -JOUFSΛಋೖ͠Α͏✅

  26. 2018 Yusuke Hirao, CC BY-ND. -JOUFSͷԸܙ +BWB4DSJQU͸&4-JOUͰɺ$44͸4UZMFMJOUͰಋೖࡁΈ ࣍ͷ͜ͱ͸͍͍ͩͨࣗಈԽͰ͖Δ γϯλοΫενΣοΫ ίʔυελΠϧͷνΣοΫ

    ໋໊نଇͷνΣοΫ ΞϯνύλʔϯͷνΣοΫ ࢦఠ͢Δͷ͸ػցͳͷͰਓ֨൱ఆʹड͚औΒΕʹ͍͘ ʮΤϥʔ͕ग़ͳ͍Α͏ʹίʔσΟϯά͍ͯͩ͘͠͞ʯͰย෇͘

  27. 2018 Yusuke Hirao, CC BY-ND. )5.-)JOUΛ࢖ͬͯΈ͕ͨʜ جຊͷνΣοΫ͸΋ͪΖΜαϙʔτ ϓϥάΠϯ"1*Λ͍࣋ͬͯͨͷͰ࠷ॳ͸ͦΕͰؤுͬͨ ͔͠͠΍͍ͬͯ͘͏ͪʹ໰୊͕ϙϩϙϩ "1*͸͋ͬͯ΋HVMQ΍ΤσΟλ͕ϓϥάΠϯʹରԠͯ͠ͳ͍

    &4-JOUΈ͍ͨʹϑΥϧμ͝ͱͷϧʔϧઃఆ͕Ͱ͖ͳ͍ 47(ͳͲͷ֎དྷཁૉʹରԠ͍ͯ͠ͳ͍ ։ൃࢭ·ͬͯΔ͠

  28. 2018 Yusuke Hirao, CC BY-ND. ͭʔΘ͚Ͱ

  29. 2018 Yusuke Hirao, CC BY-ND. )5.--JOUFS࡞Γ·ͨ͠

  30. 2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU /PEFKTͰಈ͘)5.--JOUFS ͦͷ͏ͪϒϥ΢β൛΋  ϓϥάΠϯ"1*Λ͍࣋ͬͯΔ

    ਖ਼֬ͳϩέʔγϣϯΛ΋ͭ"45 %0.ϥΠΫͳπϦʔߏ଄͕ѻ͑Δ ཁૉ͝ͱʹϧʔϧΛ࠶ઃఆͰ͖Δ ର৅ͷཁૉ͸ηϨΫλͰߜΓ͜ΊΔ ϑΥϧμ͝ͱʹϧʔϧΛઃఆͰ͖Δ ϧʔϧઃఆ͸ܧঝ͕Ͱ͖Δ )5.--JWJOHTUBOEBSEͷίϯςϯπϞσϧ৘ใΛ΋ͭ ֎དྷཁૉɾΧελϜཁૉɾ7JFXϥΠϒϥϦͷରԠΛݟਾ͑ͨઃܭ Τϥʔ͕೔ຊޠ ϩέʔϧͰ൑ఆ ·੍ͩ࡞த͚ͩͲ

  31. 2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU ͦͦ͜͜͸ಈ͖·͢

  32. 2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU 74$PEF֦ுެ։ࡁΈ

  33. 2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU ॗʑϧʔϧͱ௥Ճத

  34. 2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU ͕Μ͹ͬͯυΩϡϝϯτॻ͍ͯ·͢

  35. 2018 Yusuke Hirao, CC BY-ND. Ͱɺ࡞ͬͯΈͯͷײ૝

  36. 2018 Yusuke Hirao, CC BY-ND. ௒ָ͍͠

  37. 2018 Yusuke Hirao, CC BY-ND. ͳΜ΍͜Ε։ൃ௒ָ͍͠΍Μ ඞཁʹۦΒΕͯ࡞Γ࢝Ίͨʹͯ͠͸༧૝֎ʹָ͍͠ ΰϦΰϦ)5.-ΛѻͬͯΔͷʹϑϩϯτΤϯυ͡Όͳ͍ෆࢥٞײ ͍ΖΜͳֶͼ͕͋ͬͨ ͱʹ͔͘)5.--JWJOHTUBOEBSEಡΈ·ͬͨ͘

    )5.-ͷߏจ΍ύʔεʹ΍ͨΒৄ͘͠ͳͬͨ $-*ͷԞਂ͞ ඪ४ೖྗग़ྗͱ͔ϑϩϯτΤϯυͰ͸ະ஌ ࠶ؼॲཧͱ͔΋ਅ໘໨ʹऔΓ૊ΜͩͷॳΊ͔ͯ΋͠Εͳ͍ ϒϥ΢βޓ׵Λؾʹ͠ͳ͍ίʔσΟϯάͷշײ ͋ͱɺۙʑ਺ઍϖʔδͷ໾ʹཱͯΔ͜ͱ͕ ͸͖ͬΓ͍ͯ͠Δ఺͸೩͑Δಈػʹͳ͍ͬͯͨ

  38. 2018 Yusuke Hirao, CC BY-ND. ໨తͱָཱ͍͕྆͠Ͱ͖ͦ͏Ͱ͋Δ ϨϏϡʔͷຊདྷͷ໨త ίϯςΩετͱηϚϯςΟοΫͷ֬ೝ ΞΫηγϏϦςΟνΣοΫ ࣮ࡍʹؾΛऔΒΕͯ͠·ͬͨ͜ͱ

    )5.-7BMJEBUJPO Ϋϥε໋໊نଇͳͲίʔσΟϯάΨΠυϥΠϯ४ڌͷ֬ೝ ඼্࣭໰୊ͳ͍͚ͲϝϯςͷͨΊͷΨΠυϥΠϯϧʔϧ͕ Πϯσϯτ͸ϨϏϡʔͷಡΈ΍͢͞ʹͨΊͳͷʹͦΕΛࢦఠ ෛͷϧʔϓ

  39. 2018 Yusuke Hirao, CC BY-ND. ໨తͱָཱ͍͕྆͠Ͱ͖ͦ͏Ͱ͋Δ ϨϏϡʔͷຊདྷͷ໨త ίϯςΩετͱηϚϯςΟοΫͷ֬ೝ ΞΫηγϏϦςΟνΣοΫ ࣮ࡍʹؾΛऔΒΕͯ͠·ͬͨ͜ͱ

    )5.-7BMJEBUJPO Ϋϥε໋໊نଇͳͲίʔσΟϯάΨΠυϥΠϯ४ڌͷ֬ೝ ඼্࣭໰୊ͳ͍͚ͲϝϯςͷͨΊͷΨΠυϥΠϯϧʔϧ͕ Πϯσϯτ͸ϨϏϡʔͷಡΈ΍͢͞ʹͨΊͳͷʹͦΕΛࢦఠ ෛͷϧʔϓ ໨త

  40. 2018 Yusuke Hirao, CC BY-ND. ໨తͱָཱ͍͕྆͠Ͱ͖ͦ͏Ͱ͋Δ ϨϏϡʔͷຊདྷͷ໨త ίϯςΩετͱηϚϯςΟοΫͷ֬ೝ ΞΫηγϏϦςΟνΣοΫ ࣮ࡍʹؾΛऔΒΕͯ͠·ͬͨ͜ͱ

    )5.-7BMJEBUJPO Ϋϥε໋໊نଇͳͲίʔσΟϯάΨΠυϥΠϯ४ڌͷ֬ೝ ඼্࣭໰୊ͳ͍͚ͲϝϯςͷͨΊͷΨΠυϥΠϯϧʔϧ͕ Πϯσϯτ͸ϨϏϡʔͷಡΈ΍͢͞ʹͨΊͳͷʹͦΕΛࢦఠ ෛͷϧʔϓ ໨త ָ͍͠

  41. 2018 Yusuke Hirao, CC BY-ND. ͋͞ɺ

  42. 2018 Yusuke Hirao, CC BY-ND. ίʔυϨϏϡʔ͠Α͏

  43. 2018 Yusuke Hirao, CC BY-ND. 5IBOLZPV

  44. 2018 Yusuke Hirao, CC BY-ND. NBSLVQMJOU IUUQTHJUIVCDPN:VTVLF)JSBPNBSLVQMJOU NBSLVQMJOUQMVHJOUFYUMJOU IUUQTXXXOQNKTDPNQBDLBHFNBSLVQMJOUQMVHJOUFYUMJOU NBSLVQMJOUGPS74$PEF

    IUUQTNBSLFUQMBDFWJTVBMTUVEJPDPNJUFNT JUFN/BNFZVTVLFIJSBPWTDPEFNBSLVQMJOU