Contributing to fastlane

by giginet

Slide 1

Slide 1 text

Contributing to fastlane @giginet

Slide 2

Slide 2 text

@giginet • iOS Engineer @ Cookpad • ։ൃج൫΍ͬͯ·͢ • fastlane maintainerʹͳͬͨ • झຯɿήʔϜ։ൃ • &⌚ͷਓ

Slide 3

Slide 3 text

https://speakerdeck.com/giginet/automatic- release-in-cookpad

Slide 4

Slide 4 text

No content

Slide 5

Slide 5 text

No content

Slide 6

Slide 6 text

ࠓ೔࿩͢͜ͱ • fastlaneʹPRΛૹͬͯϚʔδ͞ΕΔ·Ͱ • @giginetͷ։ൃख๏

Slide 7

Slide 7 text

Ϛʔδݖ΋Βͬͨ

Slide 8

Slide 8 text

՝୊ͷ୳͠ํ • ͱ͸͍͑ԿΛ΍ͬͨΒྑ͍͔Θ͔Βͳ͍ • ͕͜͜Ұ൪Ή͍ͣ • Ϛʔδݖ౉͞Ε͚ͨͩ

Slide 9

Slide 9 text

No content

Slide 10

Slide 10 text

ʊਓਓਓਓਓʊ ʼɹNothingɹʻ ʉY^Y^Y^Yʉ

Slide 11

Slide 11 text

1. όάΛ௵͢ • fastlaneେମόάͬͯΔ͔Βωλ͸͍͘ΒͰ΋ མ͍ͪͯΔ

Slide 12

Slide 12 text

2. ৽ػೳΛ૿΍͢ • উखʹߟ͑ͯྑ͍ • Action͸ෆՄ • ϓϥάΠϯͰ࡞ͬͯΈ·͠ΐ͏

Slide 13

Slide 13 text

3. ϚΠφʔͳॴΛΈͯΈΔ • ϝϯς͞Εͯͳ͍ͱ͜Ζ͕ૂ͍໨ • MacରԠ • AndroidରԠ • ςετΛ૿΍͢ • ϚΠφʔͳΞΫγϣϯ

Slide 14

Slide 14 text

4. issueΛݟͯΈΔ • You can do thisλά

Slide 15

Slide 15 text

✨Φεεϝ✨ • Fix typo

Slide 16

Slide 16 text

ಈ࡞֬ೝ؀ڥΛ࡞Δ • RubyΛΠϯετʔϧ͢Δ • System Ruby͸࢖Θͳ͍ํ͕ແ೉ • rbenvͰCIͱಉ͡όʔδϣϯʢݱࡏ͸2.3.1ʣ • System Ruby(2.0.0-p648)ͱͷޓ׵Λߟྀ͠ ࣮ͯ૷

Slide 17

Slide 17 text

ಈ࡞֬ೝ؀ڥΛ࡞Δ • ςετ༻ͷϓϩδΣΫτΛ࡞Δ • Gemﬁle͔ΒϩʔΧϧͷfastlaneΛಡΉ gem 'fastlane', path: ‘/path/to/fastlane'

Slide 18

Slide 18 text

ಈ࡞֬ೝ؀ڥΛ࡞Δ • ݕূ؀ڥΛ࡞͓ͬͯ͘ͱศར • Fastfile, Appfile, Deliverfile • iTunes ConnectͷApplication • matchͷcertificates

Slide 19

Slide 19 text

࣮૷͢Δ • ͕Μ͹Δ • ίʔυϕʔε͕ڊେ͔ͩΒ୳͢ͷ͕େม • vim, RubyMine

Slide 20

Slide 20 text

ϋϚΓ͕ͪ • pry͕ಈ͔ͳ͍໰୊ • DEBUGΛ༗ޮʹ͢Δ • ToolsAndDebugging.mdʹॻ͍ͯ͋Δ DEBUG= bundle exec fastlane your_lane

Slide 21

Slide 21 text

ςετͷॻ͖ํ • ࣮૷͕ऴΘͬͨΒςετΛॻ͘ • ΧόϨοδ௿͍ • ඞͣࠓΑΓԼ͕Βͳ͍Α͏ʹग़͢ • ֎෦ґଘ͕ଟ͗͢ͰϞοΫςετ͕૿͕͑ͪ (deliverͱ͔)

Slide 22

Slide 22 text

No content

Slide 23

Slide 23 text

ࢀߟ • Better Specs • http://betterspecs.org/

Slide 24

Slide 24 text

PRͷૹΓํ • CONTRIBUTING.mdಡΉ • ςϯϓϨʔτ͕͋Δ͔ΒΑ͘ಡΉ • rspec/rubocopΛ௨͢ • Description/Motivation, ContextΛॻ͘

Slide 25

Slide 25 text

bundle exec rspec bundle exec rubocop -a

Slide 26

Slide 26 text

No content

Slide 27

Slide 27 text

ϨϏϡʔΛड͚Δ • ΍ͨΒͱ͕෇͘͠ڪ͘ͳ͍

Slide 28

Slide 28 text

No content

Slide 29

Slide 29 text

΍͍ͬͯ͘ • ํ਑͕ఆ·ͬͯͳ͍ • ςετ΋ബ͍ • issue΋ཷ·Γ͕ͪ • ΍͍ͬͯ͘ؾ࣋ͪ

Slide 30

Slide 30 text

PRٻΉ • ༏͍͠ੈքͩ͠ڪ͘ͳ͍ • ͦͷؾʹͳͬͨΒΨϯΨϯૹͬͯཉ͍͠ • ςετॻ͍ͯŋŋŋŋŋŋ

Slide 31

Slide 31 text

͝ਗ਼ௌ ͋Γ͕ͱ͏͍͟͝·ͨ͠