Share
Embed
Slide 1
Slide 1 text
danger-swift
2017.08.28 potatotips #43 / #potatotips
Satoshi Hachiya / @jpmartha_jp
Slide 2
Slide 2 text
Satoshi Hachiya
• iOS ΞϓϦ Player!
• http:/
/www.playerapp.tokyo
• ϋφίϨ
• https:/
/hana-collection.com
Slide 3
Slide 3 text
No content
Slide 4
Slide 4 text
No content
Slide 5
Slide 5 text
Danger (Ruby)
Slide 6
Slide 6 text
Danger ͱ
• Danger (Ruby)
• http:/
/danger.systems/ruby/
• Danger JS
• http:/
/danger.systems/js/
• ✨ danger-swift ✨
• ✨ https:/
/github.com/danger/danger-swift ✨
Slide 7
Slide 7 text
[WIP] danger-swift
• Dangerfile Λ Swift Ͱॻ͘
• Danger JS ! JSON
• Swift Package Manager Ͱ࡞ΔίϚϯυϥΠϯπʔϧ
• Xcode 9 (beta) / Swift 4.0
Slide 8
Slide 8 text
Danger JS
http:/
/danger.systems/js/
Slide 9
Slide 9 text
Danger (Ruby) Ͱઆ໌
http:/
/danger.systems/ruby/
Slide 10
Slide 10 text
λʔϛφϧ্Ͱ
Danger Λ͏
Slide 11
Slide 11 text
Dangerfile
# Test
warn("ͱ͜ΖͰ͏ҿΜͰΔΖ!ʁ @#{github.pr_author}")
Slide 12
Slide 12 text
ίϚϯυ࣮ߦʢOSS ͷ߹ʣ
$ bundle exec danger pr https://github.com/jpmartha/LicensePlist/pull/1
Result
Warnings:
- [ ] ͱ͜ΖͰ͏ҿΜͰΔΖ!ʁ @jpmartha
Slide 13
Slide 13 text
CI ্Ͱ
Danger Λ͏
Slide 14
Slide 14 text
GitHubʢOSS ͷ߹ʣ
• Danger ༻ͷ ΞΧϯτ࡞
• Personal access tokens Λઃఆ
Slide 15
Slide 15 text
Travis CIʢ·ͨ CircleCI ͳͲʣ
• ڥม DANGER_GITHUB_API_TOKEN Λઃఆ
Slide 16
Slide 16 text
Travis CI
• .travis.yml Λ࡞
...
include:
- os: osx
language: swift
osx_image: xcode8.3
script:
- bundle exec danger
...
Slide 17
Slide 17 text
bundle exec danger Λ
࣮ߦ͢ΔʢOSS ͷ߹ʣ
# Test
ͱ͜ΖͰ͏ҿΜͰΔΖ!ʁ @#{github.pr_author}")
Slide 18
Slide 18 text
GitHub ͔ΒऔಘͰ͖Δ༰ͷҰྫ
• github.pr_author
• github.pr_title
• github.pr_body
• github.pr_labels
• github.pr_json["milestone"]
• github.pr_json["assignee"]
• etc.
Slide 19
Slide 19 text
αϯϓϧը૾
Slide 20
Slide 20 text
! Stop saying "you forgot to ..." in
code review by
(https:/
/github.com/danger/danger/ ͔ΒҾ༻)
Slide 21
Slide 21 text
͍͞͝ʹ
Slide 22
Slide 22 text
try! Swift
• try! Swift NYC 2017
• try! Swift India
• try! Swift Tokyo 2018ʢ࣮ݱʹ͚४උதʣ
Slide 23
Slide 23 text
Thanks!