danger-swift

potatotips #43
https://potatotips.connpass.com/event/63472/

danger-swift
https://github.com/danger/danger-swift

Transcript

1. danger-swift
   2017.08.28 potatotips #43 / #potatotips
   Satoshi Hachiya / @jpmartha_jp
   

   View Slide

2. Satoshi Hachiya
   • iOS ΞϓϦ Player!
   • http:/
   /www.playerapp.tokyo
   • ϋφίϨ
   • https:/
   /hana-collection.com
   

   View Slide

3. View Slide

4. View Slide

5. Danger (Ruby)
   

   View Slide

6. Danger ͱ͸
   • Danger (Ruby)
   • http:/
   /danger.systems/ruby/
   • Danger JS
   • http:/
   /danger.systems/js/
   • ✨ danger-swift ✨
   • ✨ https:/
   /github.com/danger/danger-swift ✨
   

   View Slide

7. [WIP] danger-swift
   • Dangerfile Λ Swift Ͱॻ͘
   • Danger JS ! JSON
   • Swift Package Manager Ͱ࡞ΔίϚϯυϥΠϯπʔϧ
   • Xcode 9 (beta) / Swift 4.0
   

   View Slide

8. Danger JS
   http:/
   /danger.systems/js/
   

   View Slide

9. Danger (Ruby) Ͱઆ໌
   http:/
   /danger.systems/ruby/
   

   View Slide

10. λʔϛφϧ্Ͱ
    Danger Λ࢖͏
    

    View Slide

11. Dangerfile
    # Test
    warn("ͱ͜ΖͰ΋͏ҿΜͰΔ΍Ζ!ʁ @#{github.pr_author}")
    

    View Slide

12. ίϚϯυ࣮ߦʢOSS ͷ৔߹ʣ
    $ bundle exec danger pr https://github.com/jpmartha/LicensePlist/pull/1
    Result
    Warnings:
    - [ ] ͱ͜ΖͰ΋͏ҿΜͰΔ΍Ζ!ʁ @jpmartha
    

    View Slide

13. CI ্Ͱ
    Danger Λ࢖͏
    

    View Slide

14. GitHubʢOSS ͷ৔߹ʣ
    • Danger ༻ͷ ΞΧ΢ϯτ࡞੒
    • Personal access tokens Λઃఆ
    

    View Slide

15. Travis CIʢ·ͨ͸ CircleCI ͳͲʣ
    • ؀ڥม਺ DANGER_GITHUB_API_TOKEN Λઃఆ
    

    View Slide

16. Travis CI
    • .travis.yml Λ࡞੒
    ...
    include:
    - os: osx
    language: swift
    osx_image: xcode8.3
    script:
    - bundle exec danger
    ...
    

    View Slide

17. bundle exec danger Λ
    ࣮ߦ͢ΔʢOSS ͷ৔߹ʣ
    # Test
    ͱ͜ΖͰ΋͏ҿΜͰΔ΍Ζ!ʁ @#{github.pr_author}")
    

    View Slide

18. GitHub ͔ΒऔಘͰ͖Δ಺༰ͷҰྫ
    • github.pr_author
    • github.pr_title
    • github.pr_body
    • github.pr_labels
    • github.pr_json["milestone"]
    • github.pr_json["assignee"]
    • etc.
    

    View Slide

19. αϯϓϧը૾
    

    View Slide

20. ! Stop saying "you forgot to ..." in
    code review by
    (https:/
    /github.com/danger/danger/ ͔ΒҾ༻)
    

    View Slide

21. ͍͞͝ʹ
    

    View Slide

22. try! Swift
    • try! Swift NYC 2017
    • try! Swift India
    • try! Swift Tokyo 2018ʢ࣮ݱʹ޲͚४උதʣ
    

    View Slide

23. Thanks!
    

    View Slide