danger-swift

 danger-swift

5eee847529e8f5ec2f634a85075fd5aa?s=128

Satoshi Hachiya

August 28, 2017
Tweet

Transcript

  1. danger-swift 2017.08.28 potatotips #43 / #potatotips Satoshi Hachiya / @jpmartha_jp

  2. Satoshi Hachiya • iOS ΞϓϦ Player! • http:/ /www.playerapp.tokyo •

    ϋφίϨ • https:/ /hana-collection.com
  3. None
  4. None
  5. Danger (Ruby)

  6. Danger ͱ͸ • Danger (Ruby) • http:/ /danger.systems/ruby/ • Danger

    JS • http:/ /danger.systems/js/ • ✨ danger-swift ✨ • ✨ https:/ /github.com/danger/danger-swift ✨
  7. [WIP] danger-swift • Dangerfile Λ Swift Ͱॻ͘ • Danger JS

    ! JSON • Swift Package Manager Ͱ࡞ΔίϚϯυϥΠϯπʔϧ • Xcode 9 (beta) / Swift 4.0
  8. Danger JS http:/ /danger.systems/js/

  9. Danger (Ruby) Ͱઆ໌ http:/ /danger.systems/ruby/

  10. λʔϛφϧ্Ͱ Danger Λ࢖͏

  11. Dangerfile # Test warn("ͱ͜ΖͰ΋͏ҿΜͰΔ΍Ζ!ʁ @#{github.pr_author}")

  12. ίϚϯυ࣮ߦʢOSS ͷ৔߹ʣ $ bundle exec danger pr https://github.com/jpmartha/LicensePlist/pull/1 Result Warnings:

    - [ ] ͱ͜ΖͰ΋͏ҿΜͰΔ΍Ζ!ʁ @jpmartha
  13. CI ্Ͱ Danger Λ࢖͏

  14. GitHubʢOSS ͷ৔߹ʣ • Danger ༻ͷ ΞΧ΢ϯτ࡞੒ • Personal access tokens

    Λઃఆ
  15. Travis CIʢ·ͨ͸ CircleCI ͳͲʣ • ؀ڥม਺ DANGER_GITHUB_API_TOKEN Λઃఆ

  16. Travis CI • .travis.yml Λ࡞੒ ... include: - os: osx

    language: swift osx_image: xcode8.3 script: - bundle exec danger ...
  17. bundle exec danger Λ ࣮ߦ͢ΔʢOSS ͷ৔߹ʣ # Test ͱ͜ΖͰ΋͏ҿΜͰΔ΍Ζ!ʁ @#{github.pr_author}")

  18. GitHub ͔ΒऔಘͰ͖Δ಺༰ͷҰྫ • github.pr_author • github.pr_title • github.pr_body • github.pr_labels

    • github.pr_json["milestone"] • github.pr_json["assignee"] • etc.
  19. αϯϓϧը૾

  20. ! Stop saying "you forgot to ..." in code review

    by (https:/ /github.com/danger/danger/ ͔ΒҾ༻)
  21. ͍͞͝ʹ

  22. try! Swift • try! Swift NYC 2017 • try! Swift

    India • try! Swift Tokyo 2018ʢ࣮ݱʹ޲͚४උதʣ
  23. Thanks!