つらくないコードレビューの運用

by Kazuhiro Serizawa

Embed

Start on current slide

Slide 1

Slide 1 text

ͭΒ͘ͳ͍ ίʔυϨϏϡʔͷӡ༻ ίʔυվળ meetup #1 2016.5.26

Slide 2

Slide 2 text

About me • Kazuhiro Serizawa • github: serihiro • work at • serverside engineer • like %i(ruby erlang elixir)

Slide 3

Slide 3 text

ࠓ೔࿩͞ͳ͍͜ͱ • ίʔυϨϏϡʔͷ۩ମతͳํ๏࿦ • ޮՌతͳίʔυϨϏϡʔͷ࢓ํ http://www.slideshare.net/rootmoon/7-37892729 ͓͢͢Ίʂ

Slide 4

Slide 4 text

ࠓ೔࿩͢͜ͱ ίʔυϨϏϡʔ ΈΜͳͰ΍Ε͹ ͭΒ͘ͳ͍

Slide 5

Slide 5 text

ίʔυϨϏϡʔ͋Δ͋Δ • ϨϏϡʔ͓͡͞Μ͕͍Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ࠓ೔΋ϨϏϡʔͰ̍೔͕ऴΘ͓ͬͨʜ

Slide 6

Slide 6 text

ίʔυϨϏϡʔ͋Δ͋Δ • ࢓༷ʹৄ͍͠ਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ͜͜෼͔Βͳ͍ΜͰ  "͞ΜʹϨϏϡʔ͓ئ͍ͯ͠ ࠓ೔΋ϨϏϡʔָ͕͍͓͠ʜ ͡Ό͋"͞Μ͓ئ͍͠·͢ʂ

Slide 7

Slide 7 text

ίʔυϨϏϡʔ͋Δ͋Δ • ͰɺproductionͰόά͕ݟ͔ͭΔͱ "͞Μ͕ϨϏϡʔ  ͯ͘͠Εͨͷʹʜ ͪΐ͏ͪΐʜͪΐ͏ͪΐʜ "͞Μʜ

Slide 8

Slide 8 text

ʮϨϏϡʔ͓͡͞Μʯ໰୊ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͢Δͱ • ಛఆͷਓͷෛ୲͕େ͖ͯͭ͘Β͍ࢥ͍Λ͢Δ • νʔϜ಺Ͱίʔυͷ஌ݟ͕ڞ༗͞Εͳ͍ • νʔϜϝϯόʔͷϨϏϡʔྗ͕ҭͨͳ͍ • ͍ͭ·Ͱ΋͋ΒΏΔ͜ͱ͕ଐਓతͰεέʔϧ͠ͳ͍૊৫ʹ…

Slide 9

Slide 9 text

ͳͥʮϨϏϡʔ͓͡͞Μʯ͕  ੜ·Εͯ͠·͏ͷ͔ • ৭ʑཧ༝͸͋Δͱࢥ͍·͢ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘  ̋̋͞Μ͕΍Βͳ͍ͱμϝͳؾ͕͢Δ or  ࠷ॳʹ࡞ͬͨਓ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ or  ͓ͬ͞Μ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ

Slide 10

Slide 10 text

Ͱ΋͜Εͬͯ  ͜͏͢Ε͹ղܾ͢ΔͷͰ͸ʁ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍ ͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘ →ֶ΂ʂ →஁͑Ζʂ →ཧ༝͕ͳ͍ͳΒࢭΊΑ͏ʂ

Slide 11

Slide 11 text

͜ΕΛղܾ͢ΔͨΊͷఏҊ νʔϜશһͰ  ϨϏϡʔ͠Α͏

Slide 12

Slide 12 text

΋͠νʔϜશһͰϨϏϡʔ͢Δ Α͏ʹͳΔͱ • ୭΋͕ޓ͍ͷίʔυΛϨϏϡʔ͢Δ • ϓϩμΫτͷ੹೚͕ڞ༗͞ΕΔ • ίʔυͷ࢓༷Λ޿͘ڞ༗͢Δ • ݁Ռͱͯ͠ϨϏϡʔ͓͡͞Μ͕͍ͳ͘ͳΓɺ୭͔ ͕ͭΒ͍ࢥ͍Λ͢Δ։ൃ͸ͳ͘ͳΔʂ  …ͷ͔ʁ

Slide 13

Slide 13 text

Α͋͘Δݱ࣮ ࣗ෼ͷλεΫͰखҰഋͩ ͔ΒϨϏϡʔ͢Δͷେม ࢓ࣄͰͦΜͳʹ ษڧͨ͘͠ͳ͍ ΍ͬͺΓԶ͕ϨϏϡʔ͠ͳ͍ͱෆ҆ ͪΌΜͱϨϏϡʔ  Ͱ͖Δࣗ৴͕ͳ͍

Slide 14

Slide 14 text

Ͱ΋ϨϏϡʔ͸΍Βͳ͍ͱ  Ͱ͖ΔΑ͏ʹͳΔͷ͸೉͍͠ʢܦݧ্ʣ • ͷͰ΍ͬͺΓνʔϜͰϨϏϡʔΛճͤΔΑ͏ ʹͳͬͯཉ͍͠ͱݸਓతʹ͸ࢥ͏ • ͳͷͰνʔϜͰϨϏϡʔΛճ͠΍͘͢͢Δͨ Ίʹ࣮ࡍʹࢲ͕΍͍ͬͯΔtipsΛ͍͔ͭ͘঺հ

Slide 15

Slide 15 text

ϨϏϡʔͯ͠΄͍͠಺༰ͷઆ໌Λ ৄࡉʹॻ͘Α͏ʹ࢓૊ΈԽ͢Δ • PullRequestͷDescriptionΛςϯϓϨԽ

Slide 16

Slide 16 text

ϨϏϡΞʔ͸hubotͰ  ެฏʹׂΓৼΔ • hubot pluginʰhubot-reviewer-lottoʱΛ࢖͏ https://github.com/sakatam/hubot-reviewer-lotto

Slide 17

Slide 17 text

ϨϏϡΞʔΛؾݣ͏ • ʮ͜Ε΋͔ͨ͠͠Β೉͍͔͠΋ͳʙʯ  ͱࢥͬͨΒϨϏϡΞʔʹ੠Λ͔͚ͯΈΔ • ͓ޓ͍ʹෆ໌ͳ఺Λฉ͖΍͘͢͢Δ  งғؾͮ͘Γ͕ॏཁ

Slide 18

Slide 18 text

ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࢓༷ͰΘ͔Βͳ͍ॴ͕͋ͬͨ Βੵۃతʹ࣭໰͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࣭໰͢Δ͚ͩͰ΋ϨϏϡΞʔɾ ϨϏϡʔΠ૒ํͷؾ͖ͮʹͭͳ͕Δࣄ͸ଟ͍ • ʮԿ͔ࢦఠ͠ͳ͍ͱ͍͚ͳ͍ʯͱ͍͏ϓϨογϟʔ͕ ͋ΔͱϨϏϡʔͨ͘͠ͳ͘ͳΔɻੵۃతʹΈΜͳͰ࣭ ໰͋ͬͯͦ͠͏͍͏ϓϨογϟʔΛͳ͘͢͜ͱ͕ॏཁ

Slide 19

Slide 19 text

ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ซͤͯಡΈ͍ͨ http://qiita.com/kkoide1332/items/c6ee6f007617114c8f0b

Slide 20

Slide 20 text

·ͱΊ • ίʔυϨϏϡʔ͓͡͞Μ͸ੜ·Ε΍͍͢ • ίʔυϨϏϡʔ͓͡͞Μ͕͍ΔνʔϜ͸͍Ζ ͍ΖͭΒ͍ • ΈΜͳͰίʔυϨϏϡʔΛճ͢͜ͱͰɺͭΒ ͍ίʔυϨϏϡʔ͔ΒϝϯόʔʹϝϦοτ͕ ͋ͬͯͭΒ͘ͳ͍ίʔυϨϏϡʔ΁